Re: [pve-devel] [PATCHv2] Add support for multipath-backed direct attached storage

2016-07-11 Thread Dmitry Petuhov
Okay, there's problem: Linux is little ugly when it comes to delete external LUN. So we have to unlink (rescan-scsi-bus.sh -r or echo 1 > /sys/block/sdX/device/delete) all paths to this LUN from all nodes, and only then we may safely delete it. BTW, iSCSI (not direct) storage is also affected (

Re: [pve-devel] [PATCHv2] Add support for multipath-backed direct attached storage

2016-07-11 Thread Alexandre DERUMIER
>>Okay, there's problem: Linux is little ugly when it comes to delete >>external LUN. >>So we have to unlink (rescan-scsi-bus.sh -r or echo 1 > >>/sys/block/sdX/device/delete) all paths to this LUN from all nodes, and >>only then we may safely delete it. BTW, iSCSI (not direct) storage is >>al

Re: [pve-devel] [PATCHv2] Add support for multipath-backed direct attached storage

2016-07-11 Thread Dmitry Petuhov
Yes, deleting multipath dev itself is just another command ``multipath -f $dev'' after (or better before) scsi devices deletion. iSCSI is cool, but I don't want to be bound to it because I have also SAS and FC storages, so multipath is the only option. So question about way to run code on all

[pve-devel] [PATCH v2 container 3/3] collect errors from all local volumes

2016-07-11 Thread Fabian Grünbichler
and then die with more meaningful/complete output, instead of on the first encountered error. --- src/PVE/LXC/Migrate.pm | 64 -- 1 file changed, 41 insertions(+), 23 deletions(-) diff --git a/src/PVE/LXC/Migrate.pm b/src/PVE/LXC/Migrate.pm index 83

[pve-devel] [PATCH v2 container 1/3] collect and log origin of found local volumes

2016-07-11 Thread Fabian Grünbichler
just knowing that local disks prevent a migration is not very helpful, so be a bit more verbose here. --- src/PVE/LXC/Migrate.pm | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/src/PVE/LXC/Migrate.pm b/src/PVE/LXC/Migrate.pm index fbcb8c7..185be07 100644

[pve-devel] [PATCH v2 container 2/3] switch order of disk checks

2016-07-11 Thread Fabian Grünbichler
to make log message more meaningful. 'storage' < 'snapshot' < 'config' --- src/PVE/LXC/Migrate.pm | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/src/PVE/LXC/Migrate.pm b/src/PVE/LXC/Migrate.pm index 185be07..83d2cb9 100644 --- a/src/PVE/LXC/Migrat

[pve-devel] [PATCH v2 container 0/3] handling of local volumes when migrating

2016-07-11 Thread Fabian Grünbichler
this patch series introduces similar handling for local volumes like in QemuMigrate.pm changes to v1 (only in patch #3): - remove unused variable - cleanup indentation Fabian Grünbichler (3): collect and log origin of found local volumes switch order of disk checks collect errors from all l

[pve-devel] [PATCH v2 container 0/2] mount: deal with failing realpath

2016-07-11 Thread Wolfgang Bumiller
Changes: * Split this into two separate patches as they're unrelated issues. * do the KRBD check earlier Wolfgang Bumiller (2): provide a better error message for rbd without krbd fix a possible undefined value error src/PVE/LXC.pm | 10 +- 1 file changed, 9 insertions(+), 1 deleti

[pve-devel] [PATCH v2 container 2/2] fix a possible undefined value error

2016-07-11 Thread Wolfgang Bumiller
--- src/PVE/LXC.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index 6cd4c71..84f13f9 100644 --- a/src/PVE/LXC.pm +++ b/src/PVE/LXC.pm @@ -1215,7 +1215,9 @@ sub mountpoint_mount { # device-mapper devices is special-cased to use

[pve-devel] [PATCH v2 container 1/2] provide a better error message for rbd without krbd

2016-07-11 Thread Wolfgang Bumiller
--- src/PVE/LXC.pm | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index caadce1..6cd4c71 100644 --- a/src/PVE/LXC.pm +++ b/src/PVE/LXC.pm @@ -1175,6 +1175,12 @@ sub mountpoint_mount { if ($storage) { my $scfg = PVE::Storage::storage_config(

Re: [pve-devel] [PATCH v2 container 0/3] handling of local volumes when migrating

2016-07-11 Thread Wolfgang Bumiller
applied whole series On Mon, Jul 11, 2016 at 12:03:33PM +0200, Fabian Grünbichler wrote: > this patch series introduces similar handling for local volumes > like in QemuMigrate.pm > > changes to v1 (only in patch #3): > - remove unused variable > - cleanup indentation > > Fabian Grünbichler (3):

Re: [pve-devel] [PATCH v2 container 0/2] mount: deal with failing realpath

2016-07-11 Thread Fabian Grünbichler
applied both patches On Mon, Jul 11, 2016 at 12:19:13PM +0200, Wolfgang Bumiller wrote: > Changes: > * Split this into two separate patches as they're unrelated issues. > * do the KRBD check earlier > > Wolfgang Bumiller (2): > provide a better error message for rbd without krbd > fix a pos

Re: [pve-devel] [PATCHv2] Add support for multipath-backed direct attached storage

2016-07-11 Thread Alexandre DERUMIER
>>So question about way to run code on all nodes is still open. Maybe get >>node list from PVE and just run what we need over ssh? Or there's some >>special API? They are not api for that currently. I think ssh should be better, as maybe sometime api could be unresponsive (hanging daemon for

[pve-devel] [PATCH v3 storage 2/3] rbd: use pve-storage-portal-dns-list for monhost

2016-07-11 Thread Wolfgang Bumiller
This way we get parameter verification on monitor addresses as well as the ability to pass multiple `--monhost` arguments to `pvesm add`. Since our '-list' schemas default to using commas we now need to properly support these, so all uses of the monhost property now replace all of semicolon, space

[pve-devel] [PATCH v3 storage 3/3] Remove unused pve-storage-monhost format

2016-07-11 Thread Wolfgang Bumiller
--- No changes to v2 PVE/Storage/RBDPlugin.pm | 12 1 file changed, 12 deletions(-) diff --git a/PVE/Storage/RBDPlugin.pm b/PVE/Storage/RBDPlugin.pm index 2788a34..7a08ff5 100644 --- a/PVE/Storage/RBDPlugin.pm +++ b/PVE/Storage/RBDPlugin.pm @@ -232,18 +232,6 @@ sub rbd_volume_info {

[pve-devel] [PATCH v3 storage 1/3] rbd: path: don't build the entire path if we don't use it

2016-07-11 Thread Wolfgang Bumiller
--- No changes to v2 PVE/Storage/RBDPlugin.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/PVE/Storage/RBDPlugin.pm b/PVE/Storage/RBDPlugin.pm index 2ef7573..ced9af0 100644 --- a/PVE/Storage/RBDPlugin.pm +++ b/PVE/Storage/RBDPlugin.pm @@ -299,10 +299,12 @@ sub path {

Re: [pve-devel] [PATCH v3 storage 1/3] rbd: path: don't build the entire path if we don't use it

2016-07-11 Thread Fabian Grünbichler
applied whole series On Mon, Jul 11, 2016 at 01:55:47PM +0200, Wolfgang Bumiller wrote: > --- > No changes to v2 > PVE/Storage/RBDPlugin.pm | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/PVE/Storage/RBDPlugin.pm b/PVE/Storage/RBDPlugin.pm > index 2ef7573..ced9af0

[pve-devel] [PATCH manager] give comment in bridgeselector more space

2016-07-11 Thread Dominik Csapak
change the default column widths, to give more space to the comment column Signed-off-by: Dominik Csapak --- www/manager6/form/BridgeSelector.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/www/manager6/form/BridgeSelector.js b/www/manager6/form/BridgeSelector.js ind

[pve-devel] [PATCH kernel 1/2] Fix CVE-2016-6187: AppArmor oops in apparmor_setprocattr

2016-07-11 Thread Wolfgang Bumiller
--- ...x-oops-validate-buffer-size-in-apparmor_s.patch | 120 + Makefile | 1 + 2 files changed, 121 insertions(+) create mode 100644 CVE-2016-6187-apparmor-fix-oops-validate-buffer-size-in-apparmor_s.patch diff --git a/CVE-2016-6

[pve-devel] [PATCH kernel 2/2] modinfo is not in a user's PATH

2016-07-11 Thread Wolfgang Bumiller
--- find-firmware.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/find-firmware.pl b/find-firmware.pl index 0e1b3ea..18e8962 100755 --- a/find-firmware.pl +++ b/find-firmware.pl @@ -18,7 +18,7 @@ while (defined(my $fn = )) { my $relfn = $fn; $relfn =~ s|^$dir/*||;

[pve-devel] [PATCH qemu-server] Fix #1051: typo: vpcus -> vcpus

2016-07-11 Thread Wolfgang Bumiller
Otherwise only root can change this setting. --- Note: already applied PVE/API2/Qemu.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 4b64312..7337887 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -184,7 +184,7 @@ my $cpuop

[pve-devel] [PATCH manager 2/7] add new StatusView component

2016-07-11 Thread Dominik Csapak
this adds a component StatusView which is intended to replace the old statusview panels of qemu/lxc/nodes (later maybe also pools and storages) it extends Ext.panel.Panel and expects an rstore and title it is not intended to be used directly but to be subclassed it works like this: on instantia

[pve-devel] [PATCH manager 1/7] add new infoWidget component

2016-07-11 Thread Dominik Csapak
this adds a new component, which is 2 labels (left the title and right the text) with a small progressbar it has a method updateValue, where it takes a string and a value from 0 to 1 and updates the right label and the progressbar the progressbar gets a different css class at over 60% and over 90

[pve-devel] [PATCH manager 0/7] new StatusView

2016-07-11 Thread Dominik Csapak
this patch series changes the StatusView Panel this version has multiple advantages: uses space more efficiently (two columns on node statusview) makes information more readable (grouping, spacing, progressbar with colors) displays more information (% of memory, disk, etc; node of qemu/lxc guests

[pve-devel] [PATCH manager 4/7] include new statusview classes in makefile

2016-07-11 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- www/manager6/Makefile | 4 1 file changed, 4 insertions(+) diff --git a/www/manager6/Makefile b/www/manager6/Makefile index 92969b3..868bf2b 100644 --- a/www/manager6/Makefile +++ b/www/manager6/Makefile @@ -70,8 +70,12 @@ JSSRC=

[pve-devel] [PATCH manager 3/7] add GuestStatusView and TemplateStatusView

2016-07-11 Thread Dominik Csapak
this implements the new StatusView class for guests and templates using the new pveStatusView, we do not split the status panels per lxc/qemu, but for Template/Guest this makes more sense, since the information which lxc and qemu guests have are more similar than what you want to display for temp

[pve-devel] [PATCH manager 5/7] make node StatusView use new version

2016-07-11 Thread Dominik Csapak
this implements the new StatusView for nodes and uses it declarative instead of with Ext.Create Signed-off-by: Dominik Csapak --- www/manager6/node/StatusView.js | 167 ++-- www/manager6/node/Summary.js| 14 ++-- 2 files changed, 115 insertions(+), 66 del

[pve-devel] [PATCH manager 6/7] make lxc/qemu use new statusview

2016-07-11 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- www/manager6/lxc/Summary.js | 36 ++-- www/manager6/qemu/Summary.js | 26 +- 2 files changed, 39 insertions(+), 23 deletions(-) diff --git a/www/manager6/lxc/Summary.js b/www/manager6/lxc/Summary.js index

[pve-devel] [PATCH manager 7/7] delete old lxc/qemu statusview classes

2016-07-11 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- www/manager6/Makefile | 2 - www/manager6/lxc/StatusView.js | 105 www/manager6/qemu/StatusView.js | 75 3 files changed, 182 deletions(-) delete mode 100644 www/manager6/lxc/Sta

[pve-devel] Qemu Guest IOPS Graphing

2016-07-11 Thread Darryl Dixon
Hi, I have been working through the logistics of providing a patch for this functionality with data stored in a separate file, as requested here: http://pve.proxmox.com/pipermail/pve-devel/2015-November/018096.html However, the real difficulty lies not in getting the data stored into a separate f

Re: [pve-devel] Qemu Guest IOPS Graphing

2016-07-11 Thread Andreas Steinel
I'd be great if we could have ZFS (L2)ARC stats aswell as IOPS for the pool. Maybe if this integration problem is solved properly, we have a simple pipeline to add new things. On Mon, Jul 11, 2016 at 11:47 PM, Darryl Dixon wrote: > Hi, > > I have been working through the logistics of providing a