Re: [pve-devel] pve-manager and disk IO monitoring

2016-09-30 Thread Alexandre DERUMIER
>>To summe it all up. I think scsi-generic should be reserved for the >>situations were you make pass-through of a HBA/RAID controller to a VM >>or if device is either scsi-CD, scsi-tape, or scsi-backplane. maybe could we add an option on scsihw ? scsihw:virtio-scsi,type=generic|block ? - M

[pve-devel] [PATCH RFC storage 0/4] more SMART improvements

2016-09-30 Thread Fabian Grünbichler
this patch series reduces the number of calls to smartctl, and tries to support more smartctl output formats. I am not really sure about the label-value thing from patch #3 - it might be better to just get the whole output instead, since we don't really know much about the content/structure anyway

[pve-devel] [PATCH RFC storage 2/4] fix #1120: SCSI SMART health parsing

2016-09-30 Thread Fabian Grünbichler
SCSI disks report their health as "SMART Health Status: OK" --- PVE/Diskmanage.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/Diskmanage.pm b/PVE/Diskmanage.pm index 54ede16..1c9ebd0 100644 --- a/PVE/Diskmanage.pm +++ b/PVE/Diskmanage.pm @@ -96,7 +96,7 @@ sub get_smart_

[pve-devel] [PATCH RFC storage 1/4] disks: allow get_disks without smart checks

2016-09-30 Thread Fabian Grünbichler
the smart checks are only needed for the API call(s) that list all disks and their status, but get_disks is also used in disk usage checks and in the Ceph code, where the smart status is completely irrelevant. --- PVE/Diskmanage.pm | 49 ++--- 1 file cha

[pve-devel] [PATCH RFC storage 4/4] fix #1123: modify NVME device path for SMART support

2016-09-30 Thread Fabian Grünbichler
seems like we need to drop the namespace part before calling smartctl. note that NVME devices require smartmontools >= 6.5 --- PVE/Diskmanage.pm | 6 ++ 1 file changed, 6 insertions(+) diff --git a/PVE/Diskmanage.pm b/PVE/Diskmanage.pm index 29e07d1..12c742c 100644 --- a/PVE/Diskmanage.pm ++

[pve-devel] [PATCH RFC storage 3/4] fix #1120: non-ATA disks with label-value smart data

2016-09-30 Thread Fabian Grünbichler
simple parser as fallback for non-ATA disks. note that this does not collect all the data output, but just those lines which match the following schema: some label: some value and also the special case of: "manufactured in" some value --- Note: see cover letter for possible alternative PVE/Dis