Re: [pve-devel] [PATCH firewall 2/2] don't try to apply ports to rules which don't support them

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH firewall 1/2] remove redundant checks

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager 0/3] ceph disk fixes

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH kvm] various fixes

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH pve-manager] Sort all lists in the storage what we load dynamically.

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager v2 1/2] Add global regexp to match bus entry in a VM config

> On October 6, 2016 at 8:00 AM Dietmar Maurer wrote: > > > > > > On October 5, 2016 at 2:24 PM Emmanuel Kasper wrote: > > > > > > --- > > www/manager6/Utils.js | 2 ++ > > www/manager6/qemu/BootOrderEdit.js | 3 ++- > > 2 files changed, 4 insertions(+), 1 deletion(-) > > >

Re: [pve-devel] [PATCH manager v2 1/2] Add global regexp to match bus entry in a VM config

> On October 5, 2016 at 2:24 PM Emmanuel Kasper wrote: > > > --- > www/manager6/Utils.js | 2 ++ > www/manager6/qemu/BootOrderEdit.js | 3 ++- > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js > index 3c15135..3bf518

Re: [pve-devel] [PATCH storage 2/2] fix #1135: refactor wear level parsing

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH storage] correctly parse cciss devices in get_disks

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH storage 1/2] merge get_smart_data/health

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH storage 1/2] merge get_smart_data/health

> On October 5, 2016 at 10:57 AM Dominik Csapak wrote: > > > instead of parsing the output of smart in two places, > give get_smart_data a flag if we only want health > > this fixes a bug (not on the bugtracker), where > an ssd with disabled smart had an empty string as health > in the gui >

Re: [pve-devel] [PATCH manager v2 0/2] When adding a new hard disk, use the most used controller as suggested value

looks good to me ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH pve-manager] Sort all lists in the storage what we load dynamically.

looks good On 10/05/2016 02:27 PM, Wolfgang Link wrote: It locks better if the lists are sorted. Also if you have long list it makes working easier. --- www/manager6/storage/GlusterFsEdit.js | 2 ++ www/manager6/storage/IScsiEdit.js | 2 ++ www/manager6/storage/LVMEdit.js | 4 ww

Re: [pve-devel] [RFC pve-storage 1/2] add CIFSPlugin

On Wed, Oct 05, 2016 at 02:48:05PM +0200, Wolfgang Link wrote: > --- > PVE/API2/Storage/Config.pm | 75 - > PVE/Storage.pm | 2 + > PVE/Storage/CIFSPlugin.pm | 198 > + > PVE/Storage/Makefile | 2 +- > PVE/Storage

[pve-devel] [PATCH firewall 2/2] don't try to apply ports to rules which don't support them

--- The list of protocols was assembled by reading the iptables and nftable sources, so this should in theory not break any rules which weren't broken before already anyway. src/PVE/Firewall.pm | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/src/PVE/Fi

[pve-devel] [PATCH firewall 1/2] remove redundant checks

--- src/PVE/Firewall.pm | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm index 9aa9be1..d4e2469 100644 --- a/src/PVE/Firewall.pm +++ b/src/PVE/Firewall.pm @@ -1831,8 +1831,8 @@ sub ruleset_generate_cmdstr { } } -

[pve-devel] [PATCH manager 3/3] use correct info on disks in destroyosd and skip smart

instead of using '/dev/${real_dev}' we use the devpath property directly also we skip the smart check in the cleanup Signed-off-by: Dominik Csapak --- PVE/API2/Ceph.pm | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/PVE/API2/Ceph.pm b/PVE/API2/Ceph.pm index 030664a

[pve-devel] [PATCH manager 0/3] ceph disk fixes

this series drops the use of smartctl in the ceph related api calls, and uses the devname property instead of manually building it Dominik Csapak (3): do not get smart data for ceph disk list fix #1099: get correct info on disks in createosd use correct info on disks in destroyosd and skip s

[pve-devel] [PATCH manager 2/3] fix #1099: get correct info on disks in createosd

instead of getting all disks, only get the info from the one we get as parameter and use the 'devname' value for the ceph commands instead of the parameter itself (this fixes the cciss!cXdY cciss/cXdY mismatch) Signed-off-by: Dominik Csapak --- PVE/API2/Ceph.pm | 13 +++-- 1 file changed

[pve-devel] [PATCH manager 1/3] do not get smart data for ceph disk list

on the ceph disks call, we do not need the smart data, so set the nosmart flag Signed-off-by: Dominik Csapak --- PVE/API2/Ceph.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/API2/Ceph.pm b/PVE/API2/Ceph.pm index 5845174..7a19810 100644 --- a/PVE/API2/Ceph.pm +++ b/PVE

[pve-devel] [RFC pve-storage 2/2] add cifs_scan

--- PVE/API2/Storage/Scan.pm | 41 + PVE/Storage.pm | 24 2 files changed, 65 insertions(+) diff --git a/PVE/API2/Storage/Scan.pm b/PVE/API2/Storage/Scan.pm index 11d139f..14e6a3c 100644 --- a/PVE/API2/Storage/Scan.pm +++

[pve-devel] [RFC pve-manager] add_cifs

--- www/manager6/Makefile| 1 + www/manager6/Utils.js| 2 + www/manager6/dc/StorageView.js | 11 ++ www/manager6/storage/CIFSEdit.js | 234 +++ 4 files changed, 248 insertions(+) create mode 100644 www/manager6/storage/CIFSEdit.js

[pve-devel] [RFC pve-storage 1/2] add CIFSPlugin

--- PVE/API2/Storage/Config.pm | 75 - PVE/Storage.pm | 2 + PVE/Storage/CIFSPlugin.pm | 198 + PVE/Storage/Makefile | 2 +- PVE/Storage/Plugin.pm | 2 +- control.in | 2 +- 6 files changed

[pve-devel] [PATCH kvm] various fixes

CVE-2016-7161: hw/net: Fix a heap overflow in xlnx.xps-ethernetlite CVE-2016-7422: virtio: add check for descriptor's mapped address CVE-2016-7907: net: imx: limit buffer descriptor count CVE-2016-7908: net: mcf: limit buffer descriptor count CVE-2016-7909: net: pcnet: check rx/tx descriptor ring l

[pve-devel] [PATCH pve-manager] Sort all lists in the storage what we load dynamically.

It locks better if the lists are sorted. Also if you have long list it makes working easier. --- www/manager6/storage/GlusterFsEdit.js | 2 ++ www/manager6/storage/IScsiEdit.js | 2 ++ www/manager6/storage/LVMEdit.js | 4 www/manager6/storage/LvmThinEdit.js | 2 ++ www/manager6/st

[pve-devel] [PATCH manager v2 0/2] When adding a new hard disk, use the most used controller as suggested value

* create a regexp object to match all bus properties entry and use this regexp in ControllerSelector and BootSelector * rename 'value' property to 'count' to fix jslint type mismatch warning Emmanuel Kasper (2): Add global regexp to match bus entry in a VM config When adding a new hard disk,

[pve-devel] [PATCH manager v2 2/2] When adding a new hard disk, use the most used controller as suggested value

This is a complementary fix for #1105 (Create Linux VM Wizard: use scsi as default bus/device) and add some logic to the list of controllers presented in the ControllerSelector combo box Since we can have IDE, SCSI, Virtio(blk) as a controller during installation, based on OS detection and persona

[pve-devel] [PATCH manager v2 1/2] Add global regexp to match bus entry in a VM config

--- www/manager6/Utils.js | 2 ++ www/manager6/qemu/BootOrderEdit.js | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js index 3c15135..3bf5188 100644 --- a/www/manager6/Utils.js +++ b/www/manager6/Utils.js @@ -63,6 +63,

[pve-devel] [PATCH docs] Update the list of supported web browsers

Also move the list of supported browsers from Installing Proxmox VE to the System Requirements chapter --- pve-installation.adoc| 3 +-- pve-system-requirements.adoc | 15 +++ 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/pve-installation.adoc b/pve-installat

[pve-devel] [PATCH docs] Stress the recommandation use CD-ROM for installation and put information abou on-top-of-Debian information into special paragraph

From: fritz Signed-off-by: fritz --- pve-installation.adoc | 47 ++- 1 file changed, 26 insertions(+), 21 deletions(-) diff --git a/pve-installation.adoc b/pve-installation.adoc index 27f2d72..486f916 100644 --- a/pve-installation.adoc +++ b/pve-inst

[pve-devel] [PATCH 1/2] Separate cluster node: remove strange sentence

It should be clear that the VMs you have now on the node should be those you want there after the separation. The sentence is not quite correct and more confusing remove it. Signed-off-by: Thomas Lamprecht --- As I always try to use a 80 character limit to make it a bit easier to read the .adoc

[pve-devel] [PATCH 2/2] add block separators to bash commands

else a new line is seen as blockend and can break formating Signed-off-by: Thomas Lamprecht --- pvecm.adoc | 42 ++ 1 file changed, 42 insertions(+) diff --git a/pvecm.adoc b/pvecm.adoc index 2b7f5d2..9b11b0a 100644 --- a/pvecm.adoc +++ b/pvecm.adoc @@ -1

[pve-devel] [PATCH storage] correctly parse cciss devices in get_disks

cciss maps the devices to /sys/block/cciss!cXdY and not to /sys/block/cXdY Signed-off-by: Dominik Csapak --- PVE/Diskmanage.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/Diskmanage.pm b/PVE/Diskmanage.pm index 1befd9e..97c6f7b 100644 --- a/PVE/Diskmanage.pm +++

[pve-devel] [PATCH docs] Add warning about using qcow2 images on a ZFS filesystem

--- local-zfs.adoc | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/local-zfs.adoc b/local-zfs.adoc index 9b682b9..1b9f682 100644 --- a/local-zfs.adoc +++ b/local-zfs.adoc @@ -254,6 +254,22 @@ can be used as cache. zpool replace -f +Using a directory s

[pve-devel] [PATCH v2 docs 10/12] clarify that privileges are always part of roles

--- pveum.adoc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pveum.adoc b/pveum.adoc index f1abd94..36426cf 100644 --- a/pveum.adoc +++ b/pveum.adoc @@ -244,7 +244,8 @@ Privileges A privilege is the right to perform a specific action. To simplify management, lists of pr

[pve-devel] [PATCH v2 docs 05/12] document permission syntax

--- pveum.adoc | 69 +- 1 file changed, 59 insertions(+), 10 deletions(-) diff --git a/pveum.adoc b/pveum.adoc index 78c514a..c31383c 100644 --- a/pveum.adoc +++ b/pveum.adoc @@ -292,16 +292,9 @@ As mentioned earlier, object paths form a

[pve-devel] [PATCH v2 docs 09/12] reorder the roles section

As they provide an overview of predefined roles and give an idea of what kind of permissions are available, they fit better right after the new general permission introduction. --- pveum.adoc | 61 +++-- 1 file changed, 31 insertions(+), 30 d

[pve-devel] [PATCH v2 docs 11/12] move and expand the Objects and Paths section

It now gets more technical to finish the documentation of the permission checks found in the API documentation, and is the final section about the various parts making up the access control lists. --- pveum.adoc | 39 +-- 1 file changed, 29 insertions(+), 10 del

[pve-devel] [PATCH v2 docs 12/12] move inheritance section / remove redundant general text

As inheritance is a property of paths, so it makes sense to make them a subsection of them. The permissions paragraph in what used to be a 'terms and definitions' section now doesn't fit in and is redundant now that there's a general introduction paragraph. --- pveum.adoc | 14 -- 1 f

[pve-devel] [PATCH v2 docs 08/12] replace Terms and Definitions with a general introduction

--- pveum.adoc | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/pveum.adoc b/pveum.adoc index 294de43..e11a2ed 100644 --- a/pveum.adoc +++ b/pveum.adoc @@ -183,9 +183,20 @@ https://developers.yubico.com/Software_Projects/YubiKey_OTP/YubiCloud_Validation host your

[pve-devel] [PATCH v2 docs 07/12] Reorder users and groups section above realms section.

You now first read about users, learning the fact that they're part of groups and realms, which are described afterwards. This seems more natural then starting with realms and then describing users in a "Terms and Definitions" section. --- pveum.adoc | 72 ++

[pve-devel] [PATCH v2 docs 06/12] reordering

--- pveum.adoc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pveum.adoc b/pveum.adoc index c31383c..8c187c0 100644 --- a/pveum.adoc +++ b/pveum.adoc @@ -27,9 +27,9 @@ endif::manvolnum[] // Copied from pve wiki: Revision as of 16:10, 27 October 2015 -Proxmox VE supp

[pve-devel] [PATCH v2 docs 04/12] describe two factor authentication

--- pveum.adoc | 38 ++ 1 file changed, 38 insertions(+) diff --git a/pveum.adoc b/pveum.adoc index 8a8a6ae..78c514a 100644 --- a/pveum.adoc +++ b/pveum.adoc @@ -106,6 +106,44 @@ ldap an optional fallback server, optional port, and SSL encryption can be config

[pve-devel] [PATCH v2 docs 03/12] expand the authentication realm descriptions

--- pveum.adoc | 70 -- 1 file changed, 54 insertions(+), 16 deletions(-) diff --git a/pveum.adoc b/pveum.adoc index 522da4d..8a8a6ae 100644 --- a/pveum.adoc +++ b/pveum.adoc @@ -35,24 +35,19 @@ By using the role based user- and permissi

[pve-devel] [PATCH v2 docs 02/12] remove first person reference

--- pveum.adoc | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/pveum.adoc b/pveum.adoc index 2cb1b4e..522da4d 100644 --- a/pveum.adoc +++ b/pveum.adoc @@ -241,10 +241,9 @@ Command Line Tool Most users will simply use the GUI to manage users. But there is also a full

[pve-devel] [PATCH v2 docs 01/12] remove obsolete note on link local addresses

--- pve-firewall.adoc | 63 --- 1 file changed, 63 deletions(-) diff --git a/pve-firewall.adoc b/pve-firewall.adoc index ec0db30..a7c9d24 100644 --- a/pve-firewall.adoc +++ b/pve-firewall.adoc @@ -458,69 +458,6 @@ NFQUEUE=0 -Avoiding `

[pve-devel] [RFC manager] BackupEdit, cleanup: remove insideUpdate construct

insideUpdate protects for a endless loop which gets caused if the sm selection change callback updates vmidField which then triggers the vmidField change callback which updates the selection model again, and the circle starts again. As this construct is rather confusing when looking first at the c

[pve-devel] [PATCH manager v2 1/2] add getNodes function to PVEResource store

Add the getNodes function to the periodically asynchronous updated PVEResource store. This allows a component to get the node data directly, without making an API call and waiting that it's finished, the data is also up to date. A usage example would be: var data = PVE.data.ResourceStore.getNodes

[pve-devel] [PATCH manager v2 2/2] ha/groups: allow editing node priorities through UI

This allows the setting and editing node priorities in HA groups. Also fixes the bug where the priorities of an existing group (e.g. set through the CLI) where deleted when editing said group through the GUI. Signed-off-by: Thomas Lamprecht --- changes since v1: * use getWidgetRecord() instead

[pve-devel] [PATCH storage 2/2] fix #1135: refactor wear level parsing

refactored the wear level parsing into its own function, where we can now define a vendor <-> attribute id mapping Signed-off-by: Dominik Csapak --- PVE/Diskmanage.pm | 53 + 1 file changed, 41 insertions(+), 12 deletions(-) diff --git a/PVE/D

[pve-devel] [PATCH storage 1/2] merge get_smart_data/health

instead of parsing the output of smart in two places, give get_smart_data a flag if we only want health this fixes a bug (not on the bugtracker), where an ssd with disabled smart had an empty string as health in the gui Signed-off-by: Dominik Csapak --- PVE/API2/Disks.pm | 7 ++- PVE/Diskm

Re: [pve-devel] [PATCH v2 pve-docs] How to create an USB install stick

added a modified version (following our style guide) added to chapter Installation ... ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel