Am 17.11.2016 um 08:42 schrieb Fabian Grünbichler:
> On Thu, Nov 17, 2016 at 07:01:24AM +0100, Dietmar Maurer wrote:
>>> It is really hard to review patches without descriptions. Please
>>> can you add minimal information?
>>
>> Oh, just saw you sent that in a separate mail - please ignore me!
>
On Thu, Nov 17, 2016 at 07:01:24AM +0100, Dietmar Maurer wrote:
> > It is really hard to review patches without descriptions. Please
> > can you add minimal information?
>
> Oh, just saw you sent that in a separate mail - please ignore me!
Just as a side note - it makes a lot of sense to include
On Thu, Nov 17, 2016 at 08:21:33AM +0100, Stefan Priebe - Profihost AG wrote:
> Am 17.11.2016 um 07:33 schrieb Dietmar Maurer:
> > AFAIK we only protect base volumes, and we 'unprotect' that in the code.
> > So what is the purpose of this patch?
> >
>
> good question ;-) I just remember that i ha
Am 17.11.2016 um 07:33 schrieb Dietmar Maurer:
> AFAIK we only protect base volumes, and we 'unprotect' that in the code.
> So what is the purpose of this patch?
>
good question ;-) I just remember that i had this situation where i did
clones from snapshots which results in protected snapshots.
Am 17.11.2016 um 07:20 schrieb Dietmar Maurer:
>> While blessing it is good practise to provide the class. This makes it also
>> possible to use
>> QemuServer as a base / parent class.
>
> Why do you want another class (QemuServer) as base?
We've a custom class PHQemuServer which has VZDump/QemuS
Am 17.11.2016 um 06:44 schrieb Dietmar Maurer:
> This is dangerous and can destroy data. So is there a real reason
> to allow that?
Yes it can. That's the reason i've not exported this to the GUI. But it
is a real use case today. More and more FS supports shrinking.
f.e. Windows ntfs, ext4, btrfs
some comments inline:
> diff --git a/PVE/HTTPServer.pm b/PVE/HTTPServer.pm
> index 1c7d033..5ddbd07 100755
> --- a/PVE/HTTPServer.pm
> +++ b/PVE/HTTPServer.pm
> @@ -105,6 +105,53 @@ sub get_login_formatter {
> return $info->{func};
> }
>
> +my $cert_cache_nodes = {};
> +my $cert_cache_fing
AFAIK we only protect base volumes, and we 'unprotect' that in the code.
So what is the purpose of this patch?
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>>maybe this fix is related
>>virtio: update balloon size in balloon "probe"
>>https://github.com/torvalds/linux/commit/8424af5336b34043a705d66bdf2c1428048ef085
>>fix a bug introduced in kernel 4.6
>>I'll do test tomorrow
Ok, I confirm you that it's fixing the bug.
So maybe warn user that b
> While blessing it is good practise to provide the class. This makes it also
> possible to use
> QemuServer as a base / parent class.
Why do you want another class (QemuServer) as base?
Isn't it better to remove that whole $class parameter?
sub new {
my ($vzdump) = @_;
applied, thanks.
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> It is really hard to review patches without descriptions. Please
> can you add minimal information?
Oh, just saw you sent that in a separate mail - please ignore me!
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/m
It is really hard to review patches without descriptions. Please
can you add minimal information?
- What is the purpose?
- Does it solve a bug?
I simply cannot see the reason for this patch?
> On November 16, 2016 at 8:08 PM Stefan Priebe wrote:
>
>
> Signed-off-by: Stefan Priebe
> ---
> PV
This is dangerous and can destroy data. So is there a real reason
to allow that?
> On November 16, 2016 at 8:13 PM Stefan Priebe wrote:
>
>
> Signed-off-by: Stefan Priebe
> ---
> PVE/Storage/RBDPlugin.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/PVE/Storage/RBD
Am 16.11.2016 um 21:41 schrieb Alexandre DERUMIER:
> It is usefull if we growing the volume ?
no - but the function is called resize not grow ;-) So i use it also for
shrinking volumes.
> I'm seeing a refused tracker/pr here to disallow --alow-shrink on extend
>
> http://tracker.ceph.com/issues/
It is usefull if we growing the volume ?
I'm seeing a refused tracker/pr here to disallow --alow-shrink on extend
http://tracker.ceph.com/issues/15991
https://github.com/ceph/ceph/pull/9408
- Mail original -
De: "Stefan Priebe, Profihost AG"
À: "pve-devel"
Envoyé: Mercredi 16 Novembre
I have done some light testing of this and it doesn't seem to work quite
right yet.
Things I have done.
- dist-upgrade on both machines and reboot.
- able to ssh to and from both machines on alternate network without a
password
- Migration works when VM is off or one does not set 'type=secure|
This took me some time that a custom modification was preventing a whole plugin
to fail loading.
The warn also hides in the systemctl status -l / journal log. I think dying is
better if a plugin
contains an error.
[PATCH] VZDump: die with error if plugin loading fails
__
Signed-off-by: Stefan Priebe
---
PVE/VZDump.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm
index a4b40ce..42e34d1 100644
--- a/PVE/VZDump.pm
+++ b/PVE/VZDump.pm
@@ -191,7 +191,7 @@ foreach my $plug (@pve_vzdump_classes) {
$plug->im
Signed-off-by: Stefan Priebe
---
PVE/Storage/RBDPlugin.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/Storage/RBDPlugin.pm b/PVE/Storage/RBDPlugin.pm
index 09562fe..eb0c256 100644
--- a/PVE/Storage/RBDPlugin.pm
+++ b/PVE/Storage/RBDPlugin.pm
@@ -602,7 +602,7 @@ sub vol
Signed-off-by: Stefan Priebe
---
PVE/Storage/RBDPlugin.pm | 36 +---
1 file changed, 25 insertions(+), 11 deletions(-)
diff --git a/PVE/Storage/RBDPlugin.pm b/PVE/Storage/RBDPlugin.pm
index c1f88e4..09562fe 100644
--- a/PVE/Storage/RBDPlugin.pm
+++ b/PVE/Storage/R
While blessing it is good practise to provide the class. This makes it also
possible to use
QemuServer as a base / parent class.
[PATCH] VZDump/QemuServer: set bless clas correctly
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.
Signed-off-by: Stefan Priebe
---
PVE/VZDump/QemuServer.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/VZDump/QemuServer.pm b/PVE/VZDump/QemuServer.pm
index 5322b37..6a58a79 100644
--- a/PVE/VZDump/QemuServer.pm
+++ b/PVE/VZDump/QemuServer.pm
@@ -22,7 +22,7 @@ sub new {
maybe this fix is related
virtio: update balloon size in balloon "probe"
https://github.com/torvalds/linux/commit/8424af5336b34043a705d66bdf2c1428048ef085
fix a bug introduced in kernel 4.6
I'll do test tomorrow
- Mail original -
De: "aderumier"
À: "pve-devel"
Envoyé: Mercredi 16 N
adding a sleep seem to fix it. (execute the balloon command when guest driver
is already loaded)
if (!$statefile && (!defined($conf->{balloon}) ||
$conf->{balloon})) {
+sleep 30;
vm_mon_cmd_nocheck($vmid, "balloon", value =>
$conf->{balloon}*1024*102
Hi,
I have detected something strange with ballooning and qemu 2.7 and 2.6.2 (not
sure about old version).
maybe it's a recent proxmox update ?
vmid.conf
-
memory: 16384
shares: 0
balloon: 4096
at start, qmp command seem to be sent the qmp command
{
'arguments' => {
comments inline:
> +sub check_cert_fp {
> +my ($fp) = @_;
> +
> +my $check = sub {
> + for my $expected (keys %$cert_cache_fingerprints) {
> + return 1 if $fp eq $expected;
> + }
> + return 0;
> +};
> +
> +return 1 if &$check();
> +
> +# refresh cache and re
when forwarding an API request to the responsible node,
only accept the certificate that this node should have
according to the contents of the cluster file system.
to limit performance issues, cache certificate fingerprint
on first request for each node, and only regenerate cache
(once) if the ac
in addition to proxied to IP
---
note just needed for patch #2
PVE/HTTPServer.pm | 6 +++---
PVE/REST.pm | 5 +++--
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/PVE/HTTPServer.pm b/PVE/HTTPServer.pm
index 1712c10..1c7d033 100755
--- a/PVE/HTTPServer.pm
+++ b/PVE/HTTPServer
Wolfgang, any comment ?
- Mail original -
De: "aderumier"
À: "Wolfgang Bumiller"
Cc: "pve-devel"
Envoyé: Jeudi 10 Novembre 2016 15:47:47
Objet: Re: [pve-devel] [PATCH 2/6] qemu_drive_mirror : handle multiple jobs
>>Well, yes, but what happens when the connection fails or gets interrupt
sorry - just applied it.
> On November 16, 2016 at 9:44 AM Thomas Lamprecht
> wrote:
>
>
> On 11/15/2016 04:37 PM, Dietmar Maurer wrote:
> > applied
>
> I just saw that the regression test patch was not applied yet, was this
> on purpose? :)
___
pv
On 11/15/2016 04:37 PM, Dietmar Maurer wrote:
applied
I just saw that the regression test patch was not applied yet, was this
on purpose? :)
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-de
32 matches
Mail list logo
