Re: [pve-devel] Question: open virtual appliance

2017-01-18 Thread Alexandre DERUMIER
The parser code is here https://github.com/virt-manager/virt-manager/blob/561f5cd3e68fa3f1fb6745463a5c1a486171d8c9/virtconv/ovf.py - Mail original - De: "aderumier" À: "pve-devel" Envoyé: Jeudi 19 Janvier 2017 07:53:35 Objet: Re:

Re: [pve-devel] Question: open virtual appliance

2017-01-18 Thread Alexandre DERUMIER
>>Does somebody known where are the specifications of config format ? does it >>have revisions ? seem than virt-manager have a virt-convert tool which is able to read ovf https://github.com/virt-manager/virt-manager/blob/master/virt-convert they are a lot of ovf sample configs in the

Re: [pve-devel] Question: open virtual appliance

2017-01-18 Thread Alexandre DERUMIER
Hi, as a first step, I have send patch to import external disk image. now for ova import, I think we need a method to extract files from ova (it's a simple tar file), then an xml parser to parse OVF descriptor Does somebody known where are the specifications of config format ? does it have

[pve-devel] qemu-server : add new qm import_disk feature

2017-01-18 Thread Alexandre Derumier
We had discuted last year about a method to import external image (vmware,xen,hyperv) to a proxmox vm http://pve.proxmox.com/pipermail/pve-devel/2016-January/018757.html This mostly the feature that all my training students wants each time. (because they don't known how to create target volume

[pve-devel] [PATCH 1/2] add qm import_disk

2017-01-18 Thread Alexandre Derumier
This add a new method to import external disk image in a vm (as ununsed). It very usefull to import vmware,xen,hyperv disk images in a vm (any destination storage, can be zfs,lvm,rbd...) Signed-off-by: Alexandre Derumier --- PVE/API2/Qemu.pm | 120

[pve-devel] [PATCH 2/2] qemu_img_convert: allow $path as src image

2017-01-18 Thread Alexandre Derumier
This allow to use a path as src image directly, without storeid. We don't try to detect the src format ourself (vmware can export raw file with vmdk extension for example) Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 67

Re: [pve-devel] Question: open virtual appliance

2017-01-18 Thread Andreas Steinel
Only some experience: I was not able easily interchange simple OVA generated from VMware with OVA generated from VirtualBox without manual intervention. If you build something that works, that should be fine. I also tried to import OVA exported from VMware into Xen and it also did not work, not

Re: [pve-devel] [PATCH manager] Reduce the number of translations needed

2017-01-18 Thread Dietmar Maurer
> Can we simple use: > > gettext('Enable Firewall') => gettext('Enable') > > gettext('Enable DHCP') => 'DHCP' > > gettext('Enable XXYYYZZZ') => 'XXYYYZZZ' > > > unless there is a real reason to use 'blah blah XXYYYZZZ blah' ... We could even display the actual value as 'enabled/disabled'

Re: [pve-devel] [PATCH manager] Reduce the number of translations needed

2017-01-18 Thread Dietmar Maurer
> > if (me.fwtype === 'node') { > > - add_boolean_row('enable', gettext('Enable Firewall'), 1); > > + add_boolean_row('enable', gettext('Enable') + ': ' + > > gettext('Firewall'), 1); > > I do not think this is good, because "Enable" and "Enable something" is > not the same, e.g.

[pve-devel] [PATCH manager v2 1/2] Remove technical terms from content to be translated

2017-01-18 Thread Emmanuel Kasper
--- www/manager6/ceph/Status.js | 4 ++-- www/manager6/dc/Health.js | 2 +- www/manager6/dc/Summary.js | 2 +- www/manager6/ha/ResourceEdit.js | 3 ++- 4 files changed, 6 insertions(+), 5 deletions(-) diff --git a/www/manager6/ceph/Status.js b/www/manager6/ceph/Status.js index

[pve-devel] [PATCH manager v2 2/2] Split the Enable + name construct in two separate gettext strings

2017-01-18 Thread Emmanuel Kasper
This reduce the number of strings to translate. --- www/manager6/grid/FirewallOptions.js | 10 +- www/manager6/lxc/Options.js | 6 +++--- www/manager6/lxc/ResourceEdit.js | 2 +- www/manager6/qemu/ProcessorEdit.js | 2 +- 4 files changed, 10 insertions(+), 10

[pve-devel] [PATCH manager] Reduce the number of translations needed

2017-01-18 Thread Emmanuel Kasper
Mostly split out technical term who don't need to be translated outside of the gettext function paramater. --- www/manager6/ceph/Status.js | 4 ++-- www/manager6/dc/Health.js| 2 +- www/manager6/dc/Summary.js | 2 +- www/manager6/grid/FirewallOptions.js | 10

Re: [pve-devel] Question: open virtual appliance

2017-01-18 Thread Emmanuel Kasper
On 01/16/2017 10:14 PM, Gustaf Ankarloo wrote: > Are there any plans of making a import function for OVA/OVF ? > I know it's doable with a lot of manual tinkering I have this somewhere in my todo list although it is not high priority at the momment. I would like to try to following approach: *

Re: [pve-devel] Custom storage plugins API

2017-01-18 Thread Fabian Grünbichler
On Wed, Jan 18, 2017 at 10:34:05AM +0100, Alexander Schmid wrote: > Hello Dietmar, > has someone found time to have a look at this ? could you send changes as patch or patch series for the respective git repository - qemu-server in this case I think? see [1] for a short howto. this makes it easy

Re: [pve-devel] [PATCH ha-manager 2/7] sim: use HA envs after_fork to close all inherited FDs

2017-01-18 Thread Dietmar Maurer
I do not really like this one, especially because we have an open pipe ... > Close all file descriptors bigger than 2, that are all open files > from the parent except std{in,out,err}. ___ pve-devel mailing list pve-devel@pve.proxmox.com

[pve-devel] applied: [PATCH container] fix #1253: display SSH fingerprints on CT setup

2017-01-18 Thread Wolfgang Bumiller
applied On Tue, Jan 17, 2017 at 02:12:34PM +0100, Fabian Grünbichler wrote: > Signed-off-by: Fabian Grünbichler > --- > Since we are using the host's ssh-keygen, this output should be very stable. > > src/PVE/LXC/Setup.pm | 15 +++ > 1 file changed, 11

[pve-devel] [PATCH common] fix #1232: cleanup bridges on veth_delete

2017-01-18 Thread Wolfgang Bumiller
When a container stops or hotplug changes are applied we do a veth_delete() which does not cleanup the firewall bridges or OVS ports. This is problematic at the next startup. When creating a network device we usually want to copy the MTU of the bridge we intend to put it on, however, with OVS

Re: [pve-devel] Custom storage plugins API

2017-01-18 Thread Alexander Schmid
Hello Dietmar, has someone found time to have a look at this ? For finishing my SCST-Plugin it would be good to know if there will be a way to catch qemu-img convert from a custom implementation. Also, as my plugin activates snaps temporary via a clone of the snap and exposes this as an

[pve-devel] applied: [PATCH manager 0/3] Reduce the number of required translations

2017-01-18 Thread Dietmar Maurer
applied, and updated po files ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH manager 0/3] Reduce the number of required translations

2017-01-18 Thread Emmanuel Kasper
A side note: if you use an english technical term in your own language (DHCP, DNS) it probably does not need a translation. Emmanuel Kasper (3): Remove duplicate strings Do not try to translate domain specific terms Remove redundant helper for login window www/manager6/Utils.js

[pve-devel] [PATCH manager 3/3] Remove redundant helper for login window

2017-01-18 Thread Emmanuel Kasper
the information is already provided by the label, the helper does not add meaningfull information here. --- www/manager6/ceph/Config.js| 2 +- www/manager6/window/LoginWindow.js | 6 ++ 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/www/manager6/ceph/Config.js

[pve-devel] [PATCH manager 1/3] Remove duplicate strings

2017-01-18 Thread Emmanuel Kasper
--- www/manager6/Utils.js| 2 +- www/manager6/node/Config.js | 2 +- www/manager6/qemu/Options.js | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js index 180b283..40d2fe1 100644 --- a/www/manager6/Utils.js +++

[pve-devel] [PATCH manager 2/3] Do not try to translate domain specific terms

2017-01-18 Thread Emmanuel Kasper
No one is translating DHCP in his/her own language. --- www/manager6/ceph/Config.js | 2 +- www/manager6/ceph/Pool.js | 2 +- www/manager6/ceph/Status.js | 2 +- www/manager6/dc/Health.js | 2 +- www/manager6/lxc/Network.js | 18 +- 5 files changed, 13 insertions(+), 13