[pve-devel] [RFC cluster] update SSH Ciphers for Debian Stretch

2017-05-31 Thread Fabian Grünbichler
blowfish, 3des and arcfour are not enabled by default on the server side anyway. on most hardware, AES is about 3 times faster than Chacha20 because of hardware accelerated AES, hence the changed order of preference compared to the default. Signed-off-by: Fabian Grünbichler --- Alternatively, we

Re: [pve-devel] [PATCH v3 pve-manager 16/23] PVE::Replication::replicate - implement replicate

2017-05-31 Thread Wolfgang Link
Comment inline On 05/30/2017 03:20 PM, Dietmar Maurer wrote: diff --git a/PVE/Replication.pm b/PVE/Replication.pm index ee0b841b..d235b49d 100644 --- a/PVE/Replication.pm +++ b/PVE/Replication.pm @@ -219,12 +219,138 @@ sub prepare { return $last_snapshots; } -sub replicate { -my ($job

Re: [pve-devel] [PATCH v3 pve-manager 01/23] pvesr: add pve storage replication tool

2017-05-31 Thread Wolfgang Link
On 05/30/2017 03:19 PM, Dietmar Maurer wrote: Just added code to configure jobs. Replication itself is not implemented. Signed-off-by: Dietmar Maurer --- PVE/API2/Cluster.pm | 7 ++ PVE/API2/Makefile | 2 + PVE/API2/Nodes.pm | 7 ++ PVE/API2/Replicatio

[pve-devel] applied: [PATCH qemu-server] check also pending changes when reverting/deleting

2017-05-31 Thread Fabian Grünbichler
to master and cherry-picked onto stable-4 ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH v3 pve-manager 01/23] pvesr: add pve storage replication tool

2017-05-31 Thread Dietmar Maurer
> > +my $read_state = sub { > > + > > +return {} if ! -e $state_path; > > + > > +my $raw = PVE::Tools::file_get_contents($state_path); > > + > > +return {} if $raw eq ''; > > + > > +return decode_json($raw); > JSON::decode will not untaint the raw text, so we get problems with the

[pve-devel] [PATCH pve-manager] Untaint the content of pve-replication-state.json.

2017-05-31 Thread Wolfgang Link
JSON::decode will not untaint the raw text, so we get problems with the last_sync, which we use many times in the code with open3. --- PVE/Replication.pm | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/PVE/Replication.pm b/PVE/Replication.pm index 0787..ce0c863f 100644

[pve-devel] [PATCH pve-manager] replication - allow removal of jobs with target on local node

2017-05-31 Thread Dietmar Maurer
Signed-off-by: Dietmar Maurer --- PVE/Replication.pm | 10 --- bin/test/replication_test6.log | 8 ++ bin/test/replication_test6.pl | 65 ++ 3 files changed, 79 insertions(+), 4 deletions(-) create mode 100644 bin/test/replication_tes

[pve-devel] applied: [PATCH pve-manager] Untaint the content of pve-replication-state.json.

2017-05-31 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH pve-manager] replication - allow removal of jobs with target on local node

2017-05-31 Thread Dietmar Maurer
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] Building from Source - Dependency Sequencing Issue?

2017-05-31 Thread Michael Aldridge
I have confirmed I am able to build by removing all makefile targets related to the documentation. It does indeed seem that the code to conditionally ignore the missing packages is, as was mentioned, not in the stable-4 branch. I may try and build from the 5 series once I get the stable-4 series