Re: [pve-devel] applied: [RFC cluster 1/2] add simple corosync config parser self check

On 06/27/2017 07:52 AM, Dietmar Maurer wrote: applied, comments inline diff --git a/data/Makefile.am b/data/Makefile.am index ca180ca..51b1cd4 100644 --- a/data/Makefile.am +++ b/data/Makefile.am @@ -1,4 +1,4 @@ -SUBDIRS = src PVE +SUBDIRS = src PVE test CLEANFILES = *~ diff --git

[pve-devel] applied: [RFC cluster 1/2] add simple corosync config parser self check

applied, comments inline > diff --git a/data/Makefile.am b/data/Makefile.am > index ca180ca..51b1cd4 100644 > --- a/data/Makefile.am > +++ b/data/Makefile.am > @@ -1,4 +1,4 @@ > > -SUBDIRS = src PVE > +SUBDIRS = src PVE test > > CLEANFILES = *~ > diff --git a/data/test/Makefile

[pve-devel] applied: [PATCH manager] refuse to create replication jobs for unreplicatable VMs

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH qemu-server] config: has_feature() take default for backup into account

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH container] refuse to add non-replicatable disks to replicating VMs

> Unfortunately for new disks we can only do this after it has > been created due to the volume_has_feature() interface > requiring a volume name. Same here. Please try to use PVE::Storage::storage_can_replicate() ___ pve-devel mailing list

Re: [pve-devel] [PATCH qemu-server] refuse to add non-replicatable disks to replicating VMs

> Unfortunately for new disks we can only do this after it has > been created due to the volume_has_feature() interface > requiring a volume name. I added a new helper PVE::Storage::storage_can_replicate() Please can you try to use that? ___

[pve-devel] [PATCH manager] refuse to create replication jobs for unreplicatable VMs

--- Otherwise they'll notice it only once the job has been triggered... PVE/API2/Replication.pm | 2 +- PVE/API2/ReplicationConfig.pm | 7 ++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Replication.pm b/PVE/API2/Replication.pm index 117fe57d..ddfc2d0e

[pve-devel] [PATCH pve-docs] Documentation for Storage Replication.

--- pvesr.adoc | 160 - 1 file changed, 158 insertions(+), 2 deletions(-) diff --git a/pvesr.adoc b/pvesr.adoc index e307d0d..9acb8ae 100644 --- a/pvesr.adoc +++ b/pvesr.adoc @@ -6,7 +6,7 @@ pvesr(1) NAME -pvesr - Proxmox VE

[pve-devel] [PATCH qemu-server] config: has_feature() take default for backup into account

--- PVE/QemuConfig.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/QemuConfig.pm b/PVE/QemuConfig.pm index 251fe7e..e327482 100644 --- a/PVE/QemuConfig.pm +++ b/PVE/QemuConfig.pm @@ -55,7 +55,7 @@ sub has_feature { my ($ds, $drive) = @_; return if

[pve-devel] [PATCH container] refuse to add non-replicatable disks to replicating VMs

Unless replication is explicitly disabled for them. Unfortunately for new disks we can only do this after it has been created due to the volume_has_feature() interface requiring a volume name. --- src/PVE/LXC.pm | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/PVE/LXC.pm

[pve-devel] [PATCH qemu-server] refuse to add non-replicatable disks to replicating VMs

Unless replication is explicitly disabled for them. Unfortunately for new disks we can only do this after it has been created due to the volume_has_feature() interface requiring a volume name. --- PVE/API2/Qemu.pm | 12 1 file changed, 12 insertions(+) diff --git a/PVE/API2/Qemu.pm

[pve-devel] [PATCH manager] Use emptyText to inform the user of the value that will set be when the field is empty

emptyText is not submitted, because it does not count as value when getSubmitValue() is called on it in PVE.panel.InputPanel.getValues() --- www/manager6/lxc/DNS.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/www/manager6/lxc/DNS.js b/www/manager6/lxc/DNS.js index

[pve-devel] [RFC cluster 1/2] add simple corosync config parser self check

Each test reads and parses a config "writes" it again and then re-parses it. Then both the parsed hash structures and the raw config get compared This is cheap and should catch simple regressions in either the parser or writer, as currently we have no safety net that modifications on either one

[pve-devel] [RFC cluster 2/2] corosync config parser: move to hash format

The old parser itself was simple and easy but resulted in quite a bit of headache when changing corosync config sections, especially if multiple section levels should be touched. Move to a more practical internal format which represents the corosync configuration in hash format where subsections

[pve-devel] applied: [PATCH v2 container 2/2] use COMMON_TAR_FLAGS from pve-storage

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH v2 container 1/2] create: open templates as real root

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH v2 container 1/2] create: open templates as real root

When creating an unprivileged container previously couldn't open template files the unprivileged namespace did not have access to. This fixes that. Note that we cannot pass the file via stdin since tar will then refuse to extract compressed archives automatically. --- Changes to v1: * Removed

[pve-devel] [PATCH v2 container 2/2] use COMMON_TAR_FLAGS from pve-storage

--- No changes to v1 (just resending since it's based on the other patch). src/PVE/LXC.pm| 6 -- src/PVE/LXC/Create.pm | 2 +- src/PVE/VZDump/LXC.pm | 2 +- 3 files changed, 2 insertions(+), 8 deletions(-) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index 32b0318..8d91b22 100644

Re: [pve-devel] [PATCH manager] fix lxc hostname input window

On 06/23/2017 11:36 AM, Dominik Csapak wrote: > we used a static emptytext at creation, which is wrong after editing > now copied from qemu/Options.js (the name), but instead of deleting the > hostname on the backend on an empty field, we set it to CT > (this is also the default in the wizard) >

[pve-devel] Clean up state file

This patches cleanup the unused stateobj in the state file. ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH pve-guest-common 2/2] Delete unused states.

Delete all state object, which has no config entry and not updated in the last 24 hours. --- PVE/ReplicationState.pm | 36 +++- 1 file changed, 35 insertions(+), 1 deletion(-) diff --git a/PVE/ReplicationState.pm b/PVE/ReplicationState.pm index 952d474..ba9d0e1

[pve-devel] [PATCH pve-guest-common 1/2] Add function delete_state

This function can be used if a state will not longer needed, like if you delete a job. --- PVE/ReplicationState.pm | 22 ++ 1 file changed, 22 insertions(+) diff --git a/PVE/ReplicationState.pm b/PVE/ReplicationState.pm index 6a743a3..952d474 100644 ---

Re: [pve-devel] [PATCH container 2/3] create: open templates as real root

> On June 26, 2017 at 9:32 AM Wolfgang Bumiller wrote: > > > When creating an unprivileged container previously couldn't > open template files the unprivileged namespace did not have > access to. This fixes that. > > Note that we cannot pass the file via stdin since

[pve-devel] applied: [PATCH container 1/3] remove unused next_free_nbd_dev function

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH container 1/3] remove unused next_free_nbd_dev function

--- src/PVE/LXC/Create.pm | 11 --- 1 file changed, 11 deletions(-) diff --git a/src/PVE/LXC/Create.pm b/src/PVE/LXC/Create.pm index d93159c..5b2e5b9 100644 --- a/src/PVE/LXC/Create.pm +++ b/src/PVE/LXC/Create.pm @@ -13,17 +13,6 @@ use PVE::VZDump::ConvertOVZ; use PVE::Tools; use

[pve-devel] [PATCH container 3/3] use COMMON_TAR_FLAGS from pve-storage

--- src/PVE/LXC.pm| 6 -- src/PVE/LXC/Create.pm | 2 +- src/PVE/VZDump/LXC.pm | 2 +- 3 files changed, 2 insertions(+), 8 deletions(-) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index 32b0318..8d91b22 100644 --- a/src/PVE/LXC.pm +++ b/src/PVE/LXC.pm @@ -32,12 +32,6 @@ my $nodename

[pve-devel] [PATCH container 2/3] create: open templates as real root

When creating an unprivileged container previously couldn't open template files the unprivileged namespace did not have access to. This fixes that. Note that we cannot pass the file via stdin since tar will then refuse to extract compressed archives automatically. --- This fixes #1427 but I'd