Re: [pve-devel] [PATCH v7 pve-storage 02/10] Basic FreeNAS API interaction code

> In my book your stile is bad Perl which is more C or Java stile instead. > This is something that old Perl programmers will agree to I guess we are all C programmers, and that is why we like C style. I think it is also more easy to read for non-perl programmers.

Re: [pve-devel] [PATCH v7 pve-storage 02/10] Basic FreeNAS API interaction code

Hi Fabian, On Wed, 21 Jun 2017 15:58:13 +0200 Fabian Grünbichler wrote: > > high level question #1: how do you guarantee that inbetween pagination > requests, the underlying lists/.. on the freenas side don't change > because of concurrent actions? > > getting

[pve-devel] applied: [PATCH manager] replication: adapt help buttons reference

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH docs] replication: add chapter reference

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH docs 2/2] include pvesr.adoc in pve-admin-guide

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH docs 1/2] improve storage replication chapter

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH docs] replication: add chapter reference

Signed-off-by: Thomas Lamprecht --- pvesr.adoc | 1 + 1 file changed, 1 insertion(+) diff --git a/pvesr.adoc b/pvesr.adoc index e79839f..0d8916f 100644 --- a/pvesr.adoc +++ b/pvesr.adoc @@ -1,3 +1,4 @@ +[[chapter_pvesr]] ifdef::manvolnum[] pvesr(1) --

[pve-devel] [PATCH manager] replication: adapt help buttons reference

Signed-off-by: Thomas Lamprecht --- www/manager6/grid/Replication.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/www/manager6/grid/Replication.js b/www/manager6/grid/Replication.js index 2fd6fb75..4c696e52 100644 ---

[pve-devel] [PATCH docs 2/2] include pvesr.adoc in pve-admin-guide

Signed-off-by: Thomas Lamprecht --- pve-admin-guide.adoc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pve-admin-guide.adoc b/pve-admin-guide.adoc index 8d7dc22..0248951 100644 --- a/pve-admin-guide.adoc +++ b/pve-admin-guide.adoc @@ -39,6 +39,8 @@

[pve-devel] [PATCH docs 1/2] improve storage replication chapter

Reword sentences and address some grammar and typo errors. Also expand some sections and examples. Signed-off-by: Thomas Lamprecht --- pvesr.adoc | 291 + 1 file changed, 196 insertions(+), 95 deletions(-)

[pve-devel] applied: [PATCH manager] Add Help Button for Backup Modal Windows

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH docs] Fix vzdump information concerning backup and container mount points.

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH] Add guest type at find_local_replication_job

> We need this at migration time. I cannot see why we need this. We certainly know the vm type inside when we are inside PVE/QemuMigrate.pm and PVE/LXC/Migrate.pm. Please can you give me a hint why we need it? ___ pve-devel mailing list

[pve-devel] [PATCH manager] Add Help Button for Backup Modal Windows

Modal Windows disable the Workspace behind them, so it was not possible to get onlineHelp when starting a oneshot backup or configuring a backup job. --- www/manager6/dc/Backup.js | 1 + www/manager6/window/Backup.js | 8 +++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git

[pve-devel] [PATCH docs] Fix vzdump information concerning backup and container mount points.

--- vzdump.adoc | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/vzdump.adoc b/vzdump.adoc index 5c6804c..e56bdcb 100644 --- a/vzdump.adoc +++ b/vzdump.adoc @@ -125,9 +125,11 @@ NOTE: `snapshot` mode requires that all backed up volumes are on a storage that supports

[pve-devel] applied: [PATCH] Add guest type at find_local_replication_job

applied, but we now basically have 3 different places where we do this (one in pve-manager, two in pve-guest-common), maybe ReplicationConfig::parse_config() should just always do this? It's what they all have in common. On Wed, Jun 28, 2017 at 02:27:37PM +0200, Wolfgang Link wrote: > We need

[pve-devel] [PATCH] Add guest type at find_local_replication_job

We need this at migration time. --- PVE/ReplicationConfig.pm | 4 1 file changed, 4 insertions(+) diff --git a/PVE/ReplicationConfig.pm b/PVE/ReplicationConfig.pm index 51cfe81..670113d 100644 --- a/PVE/ReplicationConfig.pm +++ b/PVE/ReplicationConfig.pm @@ -213,9 +213,13 @@ sub

Re: [pve-devel] [PATCH container 1/2] Add disk operations to vmstatus

On Wed, Jun 28, 2017 at 10:01:59AM +0200, Wolfgang Bumiller wrote: > On Mon, Jun 19, 2017 at 12:10:10PM +0200, Tobias Böhm wrote: > > Currently, only read/write bytes are extracted from cgroups stats. > > s/bytes/operations/ > > > In order to provide IO operation stats these counters need to be

[pve-devel] applied: [PATCH guest-common] replication: add schedule_job_now helper

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH qemu-server] don't use cirrus by default for sane OS'

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH common v2] Add run_fork_with_timeout utility

This runs subroutine in a forked process and kills it after a timeout --- changes since V1: * add a second pipe to catch die() causes in the passed sub * disable pending alarms until we reaped the child * disable signals until we reaped the child ( both to avoid Zombies) * rename the

[pve-devel] [PATCH v2] Fixes: #1415 do not block pvestatd when nfsd is stopped on the server side

Wrap the -d test with run_or_get_killed sub this test can make pvestatd hang on I/O wait when a nfsd process is stopped This might help with other file based storages (GlusterFS ?) too --- PVE/Storage/Plugin.pm | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git

[pve-devel] [PATCH manager] gui: drop cirrus from the GUI

now only available from the CLI --- www/manager6/Utils.js | 1 - 1 file changed, 1 deletion(-) diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js index e9c64d1a..78683e0c 100644 --- a/www/manager6/Utils.js +++ b/www/manager6/Utils.js @@ -253,7 +253,6 @@ Ext.define('PVE.Utils', {

[pve-devel] [PATCH guest-common] replication: add schedule_job_now helper

--- PVE/ReplicationState.pm | 12 1 file changed, 12 insertions(+) diff --git a/PVE/ReplicationState.pm b/PVE/ReplicationState.pm index 74c95f9..43c8a76 100644 --- a/PVE/ReplicationState.pm +++ b/PVE/ReplicationState.pm @@ -317,4 +317,16 @@ sub get_next_job { return undef; }

[pve-devel] applied: [PATCH manager v2] replica: improve schedule format example

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH docs 2/2] Document Backup and Skip replication options for container mount points

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH docs 1/2] Fix grammar errors in QemuServer documentation

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH docs 1/2] Fix grammar errors in QemuServer documentation

--- qm.adoc | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/qm.adoc b/qm.adoc index fce34aa..02a4555 100644 --- a/qm.adoc +++ b/qm.adoc @@ -40,7 +40,7 @@ devices, and runs as it were running on real hardware. For instance you can pass an iso image as a parameter

[pve-devel] [PATCH docs 2/2] Document Backup and Skip replication options for container mount points

--- pct.adoc | 20 1 file changed, 20 insertions(+) diff --git a/pct.adoc b/pct.adoc index 4ca8d7e..ab529a9 100644 --- a/pct.adoc +++ b/pct.adoc @@ -320,6 +320,26 @@ ACLs allow you to set more detailed file ownership than the traditional user/ group/others model.

[pve-devel] [PATCH qemu-server] don't use cirrus by default for sane OS'

(It can stay for $winversion < 6 because then you probably don't have drivers for anything else.) this is long overdue --- (If you run something ancient like centos 4 or older you might have to explicitly set the display setting to something other than std now...) PVE/QemuServer.pm | 2 +- 1

[pve-devel] [PATCH manager v2] replica: improve schedule format example

Add one more to show that also weekdays + intervals are possible Further improve wording + reduce translation needs for others entries. Signed-off-by: Thomas Lamprecht --- changes v1 -> v2: * generalize 'Every XY minutes' to reduce translation need

Re: [pve-devel] [PATCH container 1/2] Add disk operations to vmstatus

On Mon, Jun 19, 2017 at 12:10:10PM +0200, Tobias Böhm wrote: > Currently, only read/write bytes are extracted from cgroups stats. s/bytes/operations/ > In order to provide IO operation stats these counters need to be > read as well. > > Signed-off-by: Tobias Böhm > --- >

[pve-devel] applied: [PATCH manager] grid/replication: show textual description of default value

applied - But I would prefer "Every {0} minutes" as gettext string ... > On June 28, 2017 at 9:19 AM Thomas Lamprecht wrote: > > > When a user sees this the first time and wants to add a job he > shouldn't be confused what the default value means, so display this >

[pve-devel] [PATCH manager] calendarevent: improve schedule format examples

Add one more to show that also weekdays + intervals are possible Further improve wording + translation needs for others Signed-off-by: Thomas Lamprecht --- www/manager6/form/CalendarEvent.js | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

Re: [pve-devel] applied: [PATCH manager] pveceph: createosd: allow to create bluestore OSDs

Hi, El 28/06/17 a las 05:58, Dietmar Maurer escribió: Digging a bit deeper, I found the following: BlueStore can use multiple block devices for storing different data, for example: Hard Disk Drive (HDD) for the data Solid-state Drive (SSD) for metadata Non-volatile Memory (NVM) or Non-volatile

[pve-devel] [PATCH manager] grid/replication: show textual description of default value

When a user sees this the first time and wants to add a job he shouldn't be confused what the default value means, so display this through the emptyText property, which does not get submitted to the backend. Signed-off-by: Thomas Lamprecht ---

[pve-devel] applied: [PATCH pve-docs] Documentation for Storage Replication.

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH guest-common] replication: sort time stamps numerically

--- PVE/ReplicationState.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/ReplicationState.pm b/PVE/ReplicationState.pm index b817f08..74c95f9 100644 --- a/PVE/ReplicationState.pm +++ b/PVE/ReplicationState.pm @@ -299,7 +299,7 @@ sub get_next_job { my $jobb =