[pve-devel] [PATCH 2/2] Fix #1125. Check for KVM support before starting VM

2017-08-16 Thread Philip Abernethy
Moved the check to the beginning of the function. VMs configured to use KVM won't start if KVM is not available. VMs not configured to use KVM will start regardless. --- PVE/QemuServer.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm

[pve-devel] [PATCH 1/2] Refactored $nokvm to $kvm

2017-08-16 Thread Philip Abernethy
Where possible I reworked the code to remove the resulting inversion. The result should be easier to read and understand. I also fixed a type in the process. --- PVE/QemuServer.pm | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/PVE/QemuServer.pm

Re: [pve-devel] proxmox install script

2017-08-16 Thread Fabian Grünbichler
On Wed, Aug 16, 2017 at 11:35:22AM +0200, Nils Privat wrote: > i got some questions about the proxmox-install-script: > https://git.proxmox.com/?p=pve-installer.git;a=blob_plain;f=proxinstall;hb=HEAD > > 1) line 21: should be 5.0 ? true, but that var is only used for testmode during development

[pve-devel] proxmox install script

2017-08-16 Thread Nils Privat
i got some questions about the proxmox-install-script: https://git.proxmox.com/?p=pve-installer.git;a=blob_plain;f=proxinstall;hb=HEAD 1) line 21: should be 5.0 ? 2) line 781: small typo 'install' 3) A question regarding function "zfs_create_rpool" (line 761): Wouldn't it be better to