On 08/24/2017 03:51 PM, Emmanuel Kasper wrote:
On 07/26/2017 03:49 PM, Thomas Lamprecht wrote:
The current size was chosen with the older, more compact, classic
theme. The Crisp theme, now in use, has a bit more spaces and bigger
font sizes to adapt to the increased pixel density of current
disp
On 08/24/2017 03:21 PM, Emmanuel Kasper wrote:
On 07/26/2017 03:49 PM, Thomas Lamprecht wrote:
Add a text area to the end of the creation wizard, to allow
adding some notes to this guest.
We can set this through the API already on creation so no big changes
needed.
not sure about this one, add
On 07/26/2017 03:49 PM, Thomas Lamprecht wrote:
> The current size was chosen with the older, more compact, classic
> theme. The Crisp theme, now in use, has a bit more spaces and bigger
> font sizes to adapt to the increased pixel density of current
> displays.
> Increase the size a bit (~13%) but
thanks for v2, looks good!
The single thing I would still change is the die-message if the ceph
version is to old. We strongly go from a specific ceph version to
another in PVE, so the "...or higher..." from the "init" API entry point:
+ die "Ceph version luminous or higher is require
On 07/26/2017 03:49 PM, Thomas Lamprecht wrote:
> Add a text area to the end of the creation wizard, to allow
> adding some notes to this guest.
> We can set this through the API already on creation so no big changes
> needed.
not sure about this one, adding options is always a trade off between
f
add version check to ceph init to require luminous or higher and
fix #1481: check existence of ceph binaries before use
Signed-off-by: Alwin Antreich
---
PVE/API2/Ceph.pm | 17 -
PVE/CephTools.pm | 34 +-
2 files changed, 45 insertions(+), 6 deleti
makes sense, looks good to me
On 07/26/2017 03:49 PM, Thomas Lamprecht wrote:
> It isn't needed as its obvious that the table below show the
> configuration. It just takes away space.
>
> Signed-off-by: Thomas Lamprecht
> ---
> www/manager6/lxc/CreateWizard.js | 1 -
> www/manager6/qemu/Create
On 08/24/2017 11:24 AM, Dominik Csapak wrote:
On 08/22/2017 11:57 AM, Thomas Lamprecht wrote:
[snip]
get_health_icon: function(state, circle) {
@@ -124,15 +132,27 @@ Ext.define('PVE.Utils', { utilities: {
return state;
},
- render_kvm_ostype: function (value) {
- if (!val
For cases when we need to set the online help block id of a modal window after
the help
button has been configured.
---
www/manager6/button/HelpButton.js | 6 ++
1 file changed, 6 insertions(+)
diff --git a/www/manager6/button/HelpButton.js
b/www/manager6/button/HelpButton.js
index 8585e4ad
This checkbox had no use, as checking/unchecking it would not be able to change
the migration type.
(see details in third patch).
I also took the opportunity to rewrite the component with a ViewController, and
this needed
a helper to set the help during the component instanciation using a config
Also group all qemu vs LXC tests in a single place.
---
www/manager6/window/Migrate.js | 217 ++---
1 file changed, 116 insertions(+), 101 deletions(-)
diff --git a/www/manager6/window/Migrate.js b/www/manager6/window/Migrate.js
index 17ef8f67..1434d40c 100644
This checkbox had not effect whatsoever:
* if the VM was online and offline was selected, the migration would fail
with the message that the --online flag is needed for running VMs
* if the the VM was offline and online was selected, the migration would
happen offline anyway
---
www/manager6/w
---
src/PVE/JSONSchema.pm | 11 +++
1 file changed, 11 insertions(+)
diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm
index 3295599..92d60b9 100644
--- a/src/PVE/JSONSchema.pm
+++ b/src/PVE/JSONSchema.pm
@@ -163,6 +163,17 @@ sub pve_verify_vmid {
return $vmid;
}
+registe
We allow uppercase characters in snapshot names.
pvesm import and export must allow uppercase characters too.
[PATCH V2 pve-storage]
Use JSON schema instead of hardcoding.
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi
---
PVE/CLI/pvesm.pm | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/PVE/CLI/pvesm.pm b/PVE/CLI/pvesm.pm
index 9455595..66ae955 100755
--- a/PVE/CLI/pvesm.pm
+++ b/PVE/CLI/pvesm.pm
@@ -183,8 +183,7 @@ __PACKAGE__->register_method ({
base => {
d
On 08/22/2017 11:57 AM, Thomas Lamprecht wrote:
move from the key => value format to one where all versions from a
base OS type can be directly used as data for a store.
We will rely on this in the next patch to allow a easy transition to
combobox UI for the OS type selector.
We also avoid havi
reviewed and tested by me
looks good to me
except one nitpick in patch 2 for which i send an extra reply
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Disables the quota checkbox for unprivileged containers in the creation wizard,
as well as when editing or adding mountpoints.
---
So it shall be done.
www/manager6/lxc/CreateWizard.js | 18 ++
www/manager6/lxc/ResourceEdit.js | 10 --
www/manager6/lxc/Resources.js| 7
On 08/24/2017 08:30 AM, Fabian Grünbichler wrote:
> On Thu, Aug 24, 2017 at 07:05:35AM +0200, Thomas Lamprecht wrote:
>> On 08/23/2017 07:15 PM, Alexandre DERUMIER wrote:
>>> for me, this patch is ok.
>>>
>>> if the job is complete, we don't need to unplug. (and that mean that vm
>>> need to sup
On 08/24/2017 08:53 AM, Dominik Csapak wrote:
i agree with all your points:
patches 1-3 require more work as to really solve the cyclic dependency -> todo
in the future
I'll try to give this (esp. the compute_api_permission) a look too.
patches 4-12 require rework to get the format from th
20 matches
Mail list logo
