If $path does not exists the '-d' check returns undef, which then
causes "Use of uninitialized value.." warning in the log.
Signed-off-by: Thomas Lamprecht
---
PVE/Storage/Plugin.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/Storage/Plugin.pm b/PVE/Storage/Plugin.pm
We allow uppercase characters in snapshot names.
pvesm import and export must allow uppercase characters too.
[PATCH V2]
Use JSON schema instead of hardcoding.
[PATCH V3 pve-storage]
Correct typo.
[PATCH V4]
Make base snapshot more specific.
___
pve-
A base snapshot can be a replication snapshot or a normal snapshot.
Normal snapshots use the format configid.
---
src/PVE/JSONSchema.pm | 14 ++
1 file changed, 14 insertions(+)
diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm
index 3295599..501f0fa 100644
--- a/src/PVE/JSON
---
PVE/CLI/pvesm.pm | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/PVE/CLI/pvesm.pm b/PVE/CLI/pvesm.pm
index 9455595..12e68fc 100755
--- a/PVE/CLI/pvesm.pm
+++ b/PVE/CLI/pvesm.pm
@@ -183,8 +183,7 @@ __PACKAGE__->register_method ({
base => {
d
On Tue, Sep 12, 2017 at 07:33:23AM +0200, Dietmar Maurer wrote:
> > 2. The VM.Clone privilege alone is not enough to clone a template.
> > Unfortunately you also need the VM.Allocate privilege, not only allowing
> > to create new VMs but also to delete VMs. This is even worse than the
> > snapsh
> 2. The VM.Clone privilege alone is not enough to clone a template.
> Unfortunately you also need the VM.Allocate privilege, not only allowing
> to create new VMs but also to delete VMs. This is even worse than the
> snapshot privileges, at least for us.
You can restrict that to a specific VMI
On 09/05/2017 11:46 AM, Alexandre Derumier wrote:
We only use it to send commands faster like resume
nitpick: could you move the v2 in the tag at the start, i.e.:
[PATCH v2]
else this stays in the commit message and thus in git history,
where it does not belongs.
git format-patch can add this
Can somebody review this patch ?
- Mail original -
De: "aderumier"
À: "pve-devel"
Cc: "aderumier"
Envoyé: Mardi 5 Septembre 2017 11:46:17
Objet: [PATCH] migration : enable mtunnel for insecure migration V2
We only use it to send commands faster like resume
Signed-off-by: Alexandr
Disables the quota checkbox for unprivileged containers in the creation
wizard, as well as when editing or adding mountpoints.
---
www/manager6/lxc/CreateWizard.js | 11 +++
www/manager6/lxc/ResourceEdit.js | 8 +++-
www/manager6/lxc/Resources.js| 5 +
3 files changed, 23 ins
---
www/manager6/lxc/CreateWizard.js | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/www/manager6/lxc/CreateWizard.js b/www/manager6/lxc/CreateWizard.js
index 8515877a..9b25db5e 100644
--- a/www/manager6/lxc/CreateWizard.js
+++ b/www/manager6/lxc/CreateWizard.js
@@ -148,7
applied whole series
On Fri, Sep 08, 2017 at 04:31:25PM +0200, Thomas Lamprecht wrote:
> Since Stretch with its newer systemd this service had a regression
> when stopping. The timeout for stop changed from infinity to 90
> seconds, meaning that if it is not finished until then it receives a
> sig
On Fri, Aug 25, 2017 at 11:50:02AM +0200, Philip Abernethy wrote:
> Disables the quota checkbox for unprivileged containers in the creation
> wizard,
> as well as when editing or adding mountpoints.
> ---
> I figured I should actually fix *all* instances accordingly.
> www/manager6/lxc/CreateWiza
Are we getting this?
On Fri, 2017-08-25 at 11:50 +0200, Philip Abernethy wrote:
> Disables the quota checkbox for unprivileged containers in the
> creation wizard,
> as well as when editing or adding mountpoints.
> ---
> I figured I should actually fix *all* instances accordingly.
> www/manager6/l
looks good to me,
there are some small things (not blockers imho) which i wrote in the
replies to the respective patches
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
On 09/06/2017 10:15 AM, Emmanuel Kasper wrote:
This will benefit the BusTypeSelector, the DiskFormatSelector, the CD
FileSelector,
and possibily other long fields like vm name, pool name.
---
www/manager6/form/ControllerSelector.js | 4 ++--
www/manager6/qemu/CDEdit.js | 3 +++
w
this is ok , but if this gets applied, please also correct the
documentation, as we mention scsi single etc. there
On 09/06/2017 10:15 AM, Emmanuel Kasper wrote:
SCSI is redundant in the VirtIO SCSI controller type.
VirtIO-blk allows to better understand the different choices in the Combobox
an
On 09/06/2017 10:15 AM, Emmanuel Kasper wrote:
---
www/manager6/form/ControllerSelector.js | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/www/manager6/form/ControllerSelector.js
b/www/manager6/form/ControllerSelector.js
index 15023a7a..5c6631b3 100644
--- a/www/man
Hello,
thank you for your comments.
On 09.09.2017 16:47, Dietmar Maurer wrote:
First, thanks for that patch!
Further comments inline:
there is only one privilege for controlling the access to snapshots,
i.e. VM.Snapshot. This makes it impossible to separate administrative
access (create, upd
preserve the old behaviour of selecting auth_supported based on the
existence of the keyring, but limit it to external clusters.
this allows switching 'auth XXX required' in the pveceph-managed
ceph.conf while still automatically copying the keyring when adding a
storage.
Signed-off-by: Fabian Gr
On 09/11/2017 09:23 AM, Wolfgang Bumiller wrote:
This function assumed df() will work or hang, but it can
also actually fail and return undef which results in
warnings - let's silence those.
Easily reproducible with a non existing path or an unsupported
one, e.g.: /proc
---
src/PVE/Tools.pm
applied whole qemu-server patch series
On Mon, Sep 11, 2017 at 08:40:27AM +0200, Thomas Lamprecht wrote:
> The size of this image is not fixed, it increased to 528k in more
> recent build of OVMF and could increase further (not likely, but
> possible).
>
> Instead of changing the hardcoded value
applied
On Mon, Sep 11, 2017 at 10:41:34AM +0200, Thomas Lamprecht wrote:
> We often need to convert between file sizes, for formatting output,
> but also code-internal. Some methods expect kilobytes, some gigabytes
> and sometimes we need bytes.
>
> While conversion from smaller to bigger units
We often need to convert between file sizes, for formatting output,
but also code-internal. Some methods expect kilobytes, some gigabytes
and sometimes we need bytes.
While conversion from smaller to bigger units can be simply done with
a left-shift, the opposite conversion may need more attention
This function assumed df() will work or hang, but it can
also actually fail and return undef which results in
warnings - let's silence those.
---
src/PVE/Tools.pm | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm
index 9ddcfda..7285c59
24 matches
Mail list logo
