Re: [pve-devel] [PATCH qemu-server v8 1/6] Force overwriting existing compressed man pages and symbolic links

2017-09-13 Thread Thomas Lamprecht
On 09/13/2017 04:10 PM, Emmanuel Kasper wrote: This allows calling the 'make install' target twice in a row. Looks OK, we overwrite everything else so why not the man pages. This can be already applied even if we would say the current iteration of this series still lacks something, IMO, no nee

[pve-devel] [PATCH qemu-server v8 4/6] Add tests for parse_ovf function

2017-09-13 Thread Emmanuel Kasper
This includes: * a test script * the manifests generated by exports from a VmWare Workstation * disk images are generated from qemu-img, with a 2KB size (it is possible to inspect the disk images with od -bc they contain a VMDK header and the rest are null characters) --- test/Makefile

[pve-devel] [PATCH qemu-server v8 2/6] Add a build dependency to libxml-libxml-perl, needed for OVF parsing

2017-09-13 Thread Emmanuel Kasper
XML::LibXML is being actively developed, and has 91 reverse depencies in Debian Stretch, so it should not go away. --- debian/control | 1 + 1 file changed, 1 insertion(+) diff --git a/debian/control b/debian/control index c2000e7..d5e4bb6 100644 --- a/debian/control +++ b/debian/control @@ -23,6

[pve-devel] [PATCH qemu-server v8 5/6] Refactor defaut bootdisk and smbios1 uuid generation in own subs

2017-09-13 Thread Emmanuel Kasper
This will allow code reuse for qm importovf --- PVE/API2/Qemu.pm | 20 PVE/QemuServer.pm | 20 2 files changed, 24 insertions(+), 16 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 1002c87..4173bdf 100644 --- a/PVE/API2/Qemu.pm +++ b/

[pve-devel] [PATCH qemu-server v8 1/6] Force overwriting existing compressed man pages and symbolic links

2017-09-13 Thread Emmanuel Kasper
This allows calling the 'make install' target twice in a row. --- Makefile | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index e9482f2..998d17a 100644 --- a/Makefile +++ b/Makefile @@ -69,12 +69,12 @@ install: ${PKGSOURCES} install -D -m 06

[pve-devel] [PATCH qemu-server v8 6/6] Add new qm command 'importovf', to create VMs from an OVF manifest

2017-09-13 Thread Emmanuel Kasper
Currently the following extracted parameters are used to create a VM: * VM name * Memory * Number of cores * Disks --- PVE/CLI/qm.pm | 99 +++ 1 file changed, 99 insertions(+) diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm index 5dce10f..0a5571b

[pve-devel] [PATCH qemu-server v8 3/6] Initial support for importing OVF virtual machines

2017-09-13 Thread Emmanuel Kasper
Following OVF parameters will be extracted: * VM name * Memory * Number of cores * disks and their associated controllers --- PVE/QemuServer/Makefile | 1 + PVE/QemuServer/OVF.pm | 236 2 files changed, 237 insertions(+) create mode 100644

[pve-devel] [PATCH qemu-server v8 0/6] Add qm importovf command

2017-09-13 Thread Emmanuel Kasper
bumping this after the topic has been brough in forum: https://forum.proxmox.com/threads/procedure-to-import-vmware-ova-to-proxmox-5-0-23-with-zfs-vm-store.36779/#post-180321 changes since V7: rebase on master Emmanuel Kasper (6): Force overwriting existing compressed man pages and symbolic lin

[pve-devel] [PATCH 4/4] Remove useless rules.

2017-09-13 Thread Wolfgang Link
--- pvepatches/remove-unneeded-rules.patch | 39 ++ pvepatches/series | 1 + 2 files changed, 40 insertions(+) create mode 100644 pvepatches/remove-unneeded-rules.patch diff --git a/pvepatches/remove-unneeded-rules.patch b/pvepatches/remove-

[pve-devel] [PATCH 2/4] Change dependency.

2017-09-13 Thread Wolfgang Link
The new Package libopenvswitch need not libssl-dev package. Libssl1.1 ok and will not install a new package. Libssl-dev is need for the libopenvswitch. --- pvepatches/remove-unneeded-from-control.patch | 17 + 1 file changed, 17 insertions(+) diff --git a/pvepatches/remove-unneed

[pve-devel] [PATCH 3/4] Remove unneeded packages.

2017-09-13 Thread Wolfgang Link
--- pvepatches/remove-unneeded-from-control.patch | 59 ++- 1 file changed, 58 insertions(+), 1 deletion(-) diff --git a/pvepatches/remove-unneeded-from-control.patch b/pvepatches/remove-unneeded-from-control.patch index 7d68ae8..ddf8ac4 100644 --- a/pvepatches/remove-unn

[pve-devel] RFC bump Version to 2.8.0 OpenvSwitch

2017-09-13 Thread Wolfgang Link
To build the package "make download" must be called first. openvswitch tarball is not included. This series bump the openvswitch version to 2.8.0. Fix an unsightly dependency in the deb package. Remove new packages wich are not supported by us. ___ pve

[pve-devel] [PATCH qemu-server] VM.Snapshot.Rollback privilege added

2017-09-13 Thread Matthias Urban
VM.Snapshot.Rollback privilege added Signed-off-by: Matthias Urban --- PVE/API2/Qemu.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index aa7c832..311295b 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -3354,7 +3354,7 @@ __

[pve-devel] [PATCH manager] VM.Snapshot.Rollback privilege added

2017-09-13 Thread Matthias Urban
VM.Snapshot.Rollback privilege added Signed-off-by: Matthias Urban --- www/manager6/lxc/Config.js | 2 +- www/manager6/qemu/Config.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/www/manager6/lxc/Config.js b/www/manager6/lxc/Config.js index fbaccefe..12a4b12d 100644 --

[pve-devel] [PATCH access-control] VM.Snapshot.Rollback privilege added

2017-09-13 Thread Matthias Urban
VM.Snapshot.Rollback privilege added Signed-off-by: Matthias Urban --- PVE/AccessControl.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/AccessControl.pm b/PVE/AccessControl.pm index 7d02cdf..2b610b7 100644 --- a/PVE/AccessControl.pm +++ b/PVE/AccessControl.pm @@ -406,6 +406,7 @@ my $

[pve-devel] [PATCH container] VM.Snapshot.Rollback privilege added

2017-09-13 Thread Matthias Urban
VM.Snapshot.Rollback privilege added Signed-off-by: Matthias Urban --- src/PVE/API2/LXC/Snapshot.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/PVE/API2/LXC/Snapshot.pm b/src/PVE/API2/LXC/Snapshot.pm index 6ba6fb3..edccbf4 100644 --- a/src/PVE/API2/LXC/Snapshot.pm

Re: [pve-devel] [PATCH manager v2 09/10] Make room in QemuWizard and Edit Window so that the larger combo boxes properly fit

2017-09-13 Thread Emmanuel Kasper
Q On 09/13/2017 07:09 AM, Thomas Lamprecht wrote: > On 09/12/2017 02:44 PM, Emmanuel Kasper wrote: >> This will benefit the BusTypeSelector, the DiskFormatSelector, the CD >> FileSelector, >> and possibily other long fields like vm name, pool name. >> --- >> www/manager6/form/ControllerSelector.

[pve-devel] [PATCH manager] vzdump/pigz: use ProcFSTools for core count, not sysconf

2017-09-13 Thread Thomas Lamprecht
A "sysconf(84)" is not really descripitve. There is no POSIX const entry for _SC_NPROCESSORS_ONLN (number of processors online) as its not standard but an adoption of glibc. Better just use our proven ProcFSTool's cpuinfo method for getting the desired information. This is kept only for backwards

[pve-devel] [PATCH guest-common] AbstractMigrate: remove unused obsolete variables

2017-09-13 Thread Thomas Lamprecht
--- PVE/AbstractMigrate.pm | 3 --- 1 file changed, 3 deletions(-) diff --git a/PVE/AbstractMigrate.pm b/PVE/AbstractMigrate.pm index 5fa17ba..17fdb5d 100644 --- a/PVE/AbstractMigrate.pm +++ b/PVE/AbstractMigrate.pm @@ -107,9 +107,6 @@ my $eval_int = sub { }; }; -my @ssh_opts = ('-o', 'Ba

[pve-devel] fix cyclic dependency between pve-manager and pve-guest-common

2017-09-13 Thread Thomas Lamprecht
We used PVE::VZDump from inside pve-guest-common for logging and a slightly wrapped PVE::Tools::run_command. Move the log helper to the base class and inline the run_command also there, which then allows to remove the cyclic dependency. In a second patch reduce code duplication and let PVE::VZDump

[pve-devel] [PATCH manager 2/2] use log method from base VZDump::Plugin

2017-09-13 Thread Thomas Lamprecht
we copied our log method over there to resolve a cyclic dependency, now use it here to reduce code duplication. As we are below pve-guest-common in the dpendency hierachy we may use it, but it does not may (or at least should) use us. Signed-off-by: Thomas Lamprecht --- PVE/VZDump.pm | 25 +++---

[pve-devel] [PATCH guest-common 1/1] VZDump/Plugin: avoid cyclic dependency

2017-09-13 Thread Thomas Lamprecht
pve-guest-common is above qemu-server, pve-container and thus also pve-manager in the package hierarchy. The latter hosts PVE::VZDump, so using it here adds a cyclic dependency between pve-manager and pve-guest-common. Move the log method to the base plugin class and inline the run_command functio