[pve-devel] [PATCH access-control 3/3] Change naming to keep command abbreviation

2017-09-22 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- PVE/CLI/pveum.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/CLI/pveum.pm b/PVE/CLI/pveum.pm index 7a4930f..d960437 100755 --- a/PVE/CLI/pveum.pm +++ b/PVE/CLI/pveum.pm @@ -50,7 +50,7 @@ our $cmddef = { useradd => [ 'PVE::API2

[pve-devel] [PATCH access-control 1/3] Add parameter userlist to pveum for listing users

2017-09-22 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- PVE/CLI/pveum.pm | 21 + 1 file changed, 21 insertions(+) diff --git a/PVE/CLI/pveum.pm b/PVE/CLI/pveum.pm index aef7089..0426cfb 100755 --- a/PVE/CLI/pveum.pm +++ b/PVE/CLI/pveum.pm @@ -18,6 +18,7 @@ use PVE::API2::ACL; use PVE::API2::Acces

[pve-devel] [PATCH access-control 2/3] Add grouplist to pveum for group listing

2017-09-22 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- PVE/CLI/pveum.pm | 12 1 file changed, 12 insertions(+) diff --git a/PVE/CLI/pveum.pm b/PVE/CLI/pveum.pm index 0426cfb..7a4930f 100755 --- a/PVE/CLI/pveum.pm +++ b/PVE/CLI/pveum.pm @@ -74,6 +74,18 @@ our $cmddef = { groupadd => [ 'PVE::API2::Gr

[pve-devel] [PATCH access-control] pveum: Allow listing of roles and their privileges

2017-09-22 Thread Philip Abernethy
Use the existing 'index' API call from PVE::API2::Role to produce a tidy list of all available roles and their associated privileges. --- Concerns #1502 but doesn't fix it completely. PVE/CLI/pveum.pm | 31 +++ 1 file changed, 31 insertions(+) diff --git a/PVE/CLI/pveu

[pve-devel] [PATCH manager v3 5/6] PVE.qemu.OSTypeEdit: declare static

2017-09-22 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- www/manager6/qemu/OSTypeEdit.js | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/www/manager6/qemu/OSTypeEdit.js b/www/manager6/qemu/OSTypeEdit.js index d7c27e99..1235ddfd 100644 --- a/www/manager6/qemu/OSTypeEdit.js +++ b/www/manage

[pve-devel] [PATCH manager v3 2/6] kvm_ostype: move to store-like format

2017-09-22 Thread Thomas Lamprecht
move from the key => value format to one where all versions from a base OS type can be directly used as data for a store. We will rely on this in the next patch to allow a easy transition to combobox UI for the OS type selector. We also avoid having the base type multiple times. Signed-off-by: T

[pve-devel] [PATCH manager v3 6/6] window.Wizard: increase default size

2017-09-22 Thread Thomas Lamprecht
The current size was choosen with the older, more compact, classic theme. The Crisp theme, now in use, has a bit more spaces and bigger font sizes to adapt to the increased pixel density of current displays. Increase the size a bit (~13%) but try to keep the aspect ratio. Signed-off-by: Thomas Lam

[pve-devel] [PATCH manager v3 4/6] wizard: merge CD/DVD and OS panels

2017-09-22 Thread Thomas Lamprecht
We had a single column for the CD/DVD panel, fill the second column with the now in size reduced OS type selector, as ISO selection and OS type selection are tied together. Reduces steps needed for creating a VM. Signed-off-by: Thomas Lamprecht --- www/manager6/qemu/CDEdit.js | 6 +-

[pve-devel] [PATCH manager v3 3/6] OSType edit: switch to combobox

2017-09-22 Thread Thomas Lamprecht
Move from the radiogroup to two comboboxes, where the base OS and then a specific Version can be choosen. Avoids multiple occurences of strings like "Microsoft Windows" and saves a lot of space - which will be used to merge this panel with the ISO selector panel in the create wizard. Signed-off-b

[pve-devel] [PATCH manager v3 0/6] Switch OSType to combobox and merge with CD/DVD panel in wizard

2017-09-22 Thread Thomas Lamprecht
Mostly a resend of v2 which was part of a bigger series. Rebased on current master. 'PVE.qemu.OSTypeEdit: declare static' patch is new. As Emmanuel showed real use for the bigger size of the wizad and I had it in this queue I resent it too. IMO, there is now drawback to this. Empty areas are alrea

[pve-devel] [PATCH manager v3 1/6] refactor OSDefaults, OSTypeEdit: add and use getDefaults

2017-09-22 Thread Thomas Lamprecht
encapuslation wise it makes sense to have a helper which assembles a os specific setting object in the OSDefaults class, where those settings are defined. Else we always need to check if the current OSType on the user side of this class, which is against encapsulation. Signed-off-by: Thomas Lampr

[pve-devel] applied: [PATCH container 1/2] doc: add dhcp/manual to netX ip description

2017-09-22 Thread Wolfgang Bumiller
applied both patches On Mon, May 15, 2017 at 09:44:18AM +0200, Fabian Grünbichler wrote: > and shorten IPv4Format to IPv4 > > Signed-off-by: Fabian Grünbichler > --- > As reported in > https://forum.proxmox.com/threads/pct-man-page-incorrect.34637/#post-169700 > > src/PVE/LXC/Config.pm | 2 +-

[pve-devel] applied: [PATCH docs] pct: add note about storage:size syntax

2017-09-22 Thread Wolfgang Bumiller
applied On Mon, May 15, 2017 at 10:48:47AM +0200, Fabian Grünbichler wrote: > Signed-off-by: Fabian Grünbichler > --- > pct.adoc | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/pct.adoc b/pct.adoc > index 4ca8d7e..297d1f8 100644 > --- a/pct.adoc > +++ b/pct.adoc > @@ -467,6 +467

[pve-devel] applied: [PATCH manager] ui: reuse ResourceStores default handling for guest description

2017-09-22 Thread Wolfgang Bumiller
applied On Thu, Sep 21, 2017 at 11:03:26AM +0200, Thomas Lamprecht wrote: > First, there was an additional space between "'" and ")" which lead > me to this. > I could never trigger the case where vmname is undefined, and saw > that we have a almost same default handling in data/ResourceStore.js >

[pve-devel] applied: [PATCH v2 qemu-server 0/5] allow explicitly configuring vmstate storage

2017-09-22 Thread Wolfgang Bumiller
applied series On Mon, May 15, 2017 at 02:11:55PM +0200, Fabian Grünbichler wrote: > changes to v1: > - add permission checks in patch #1 > - simplify storage selection loop in patch #2 (thanks Wolfang) > - add patch #5 for code hygiene ;) > > Fabian Grünbichler (5): > config: add vmstatestorag

[pve-devel] applied: [PATCH manager 2/2] use log method from base VZDump::Plugin

2017-09-22 Thread Wolfgang Bumiller
applied On Wed, Sep 13, 2017 at 10:30:15AM +0200, Thomas Lamprecht wrote: > we copied our log method over there to resolve a cyclic dependency, > now use it here to reduce code duplication. > As we are below pve-guest-common in the dpendency hierachy we may use > it, but it does not may (or at lea

[pve-devel] applied: [PATCH container] VM.Snapshot.Rollback privilege added

2017-09-22 Thread Wolfgang Bumiller
applied Also, I just noticed, you duplicated the subject line into the message body. Note that git-am already includes the subject line, so now the commits contain the first line twice. (Not a problem, just something to look out for in future contributions.) On Wed, Sep 13, 2017 at 12:30:35PM +02

[pve-devel] applied: [PATCH manager] VM.Snapshot.Rollback privilege added

2017-09-22 Thread Wolfgang Bumiller
applied On Wed, Sep 13, 2017 at 12:30:34PM +0200, Matthias Urban wrote: > VM.Snapshot.Rollback privilege added > > Signed-off-by: Matthias Urban > --- > www/manager6/lxc/Config.js | 2 +- > www/manager6/qemu/Config.js | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a

[pve-devel] applied: [PATCH qemu-server] VM.Snapshot.Rollback privilege added

2017-09-22 Thread Wolfgang Bumiller
applied On Wed, Sep 13, 2017 at 12:30:37PM +0200, Matthias Urban wrote: > VM.Snapshot.Rollback privilege added > > Signed-off-by: Matthias Urban > --- > PVE/API2/Qemu.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm > index aa7

[pve-devel] applied: [PATCH access-control] VM.Snapshot.Rollback privilege added

2017-09-22 Thread Wolfgang Bumiller
applied On Wed, Sep 13, 2017 at 12:30:36PM +0200, Matthias Urban wrote: > VM.Snapshot.Rollback privilege added > > Signed-off-by: Matthias Urban > --- > PVE/AccessControl.pm | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/PVE/AccessControl.pm b/PVE/AccessControl.pm > index 7d02cdf..2b

Re: [pve-devel] [PATCH RFC qemu-kvm 1/1] Provides a virtual package qemu-system-x86

2017-09-22 Thread Wolfgang Bumiller
On Thu, Sep 21, 2017 at 12:43:03PM +0200, Emmanuel Kasper wrote: > On 09/21/2017 10:50 AM, Wolfgang Bumiller wrote: > > On Thu, Sep 21, 2017 at 10:26:46AM +0200, Emmanuel Kasper wrote: > >> --- a/debian/control > >> +++ b/debian/control > >> @@ -45,8 +45,8 @@ Depends: ${shlibs:Depends}, ${misc:Depe