Re: [pve-devel] [PATCH access-control] pveum: Allow listing of roles and their privileges

2017-09-25 Thread Thomas Lamprecht
On 09/25/2017 07:05 AM, Dietmar Maurer wrote: + sub { + my ($res) = @_; + my $longest = 0; + foreach my $role(map($_->{roleid}, @$res)) { + my $len = length $role; + $longest = $len if $len > $longest; + } + $lo

Re: [pve-devel] [PATCH access-control] pveum: Allow listing of roles and their privileges

2017-09-25 Thread Philip Abernethy
On Mon, Sep 25, 2017 at 10:13:29AM +0200, Thomas Lamprecht wrote: > On 09/25/2017 07:05 AM, Dietmar Maurer wrote: > > > > > + sub { > > > + my ($res) = @_; > > > + my $longest = 0; > > > + foreach my $role(map($_->{roleid}, @$res)) { > > > + my $len = length $role; > > > +

[pve-devel] [PATCH manager 2/3] doc: spice-example-sh: fix ticket/csrf extraction

2017-09-25 Thread Wolfgang Bumiller
We extract them from the json data by first deleting all quotes, then deleting everything up to their entries, then everything after the next comma. If the entry is at the end there's no comma, instead there are closing braces, so we need to strip away these as well. --- it's no fun when scripts er

[pve-devel] [PATCH manager 3/3] doc: spice-example-sh: support special characters in passwords

2017-09-25 Thread Wolfgang Bumiller
--- spice-example-sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spice-example-sh b/spice-example-sh index cc7c6b7f..6fe5c1f5 100755 --- a/spice-example-sh +++ b/spice-example-sh @@ -59,7 +59,7 @@ fi NODE="${NODE%%\.*}" -DATA="$(curl -f -s -S -k -d "username=$USERNAME&

[pve-devel] [PATCH manager 1/3] doc: spice-example-sh: add quotes everywhere

2017-09-25 Thread Wolfgang Bumiller
--- avoids pain spice-example-sh | 46 +++--- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/spice-example-sh b/spice-example-sh index 62192f3e..1d8bdc49 100755 --- a/spice-example-sh +++ b/spice-example-sh @@ -22,10 +22,10 @@ USERNAME=""

Re: [pve-devel] [PATCH access-control] pveum: Allow listing of roles and their privileges

2017-09-25 Thread Wolfgang Bumiller
On Mon, Sep 25, 2017 at 07:05:03AM +0200, Dietmar Maurer wrote: > comments inline > > > Use the existing 'index' API call from PVE::API2::Role to produce a > > tidy list of all available roles and their associated privileges. > > --- > > Concerns #1502 but doesn't fix it completely. > > PVE/CLI/p

Re: [pve-devel] [PATCH access-control 1/3] Add parameter userlist to pveum for listing users

2017-09-25 Thread Thomas Lamprecht
comments inline On 09/22/2017 04:32 PM, Alwin Antreich wrote: Signed-off-by: Alwin Antreich --- PVE/CLI/pveum.pm | 21 + 1 file changed, 21 insertions(+) diff --git a/PVE/CLI/pveum.pm b/PVE/CLI/pveum.pm index aef7089..0426cfb 100755 --- a/PVE/CLI/pveum.pm +++ b/PVE/CLI/p

Re: [pve-devel] [PATCH access-control 2/3] Add grouplist to pveum for group listing

2017-09-25 Thread Thomas Lamprecht
comments inline On 09/22/2017 04:32 PM, Alwin Antreich wrote: Signed-off-by: Alwin Antreich --- PVE/CLI/pveum.pm | 12 1 file changed, 12 insertions(+) diff --git a/PVE/CLI/pveum.pm b/PVE/CLI/pveum.pm index 0426cfb..7a4930f 100755 --- a/PVE/CLI/pveum.pm +++ b/PVE/CLI/pveum.pm @

Re: [pve-devel] [PATCH access-control 1/3] Add parameter userlist to pveum for listing users

2017-09-25 Thread Wolfgang Bumiller
In addition to Thomas' reply: On Fri, Sep 22, 2017 at 04:32:29PM +0200, Alwin Antreich wrote: > Signed-off-by: Alwin Antreich > --- > PVE/CLI/pveum.pm | 21 + > 1 file changed, 21 insertions(+) > > diff --git a/PVE/CLI/pveum.pm b/PVE/CLI/pveum.pm > index aef7089..0426cfb 100

Re: [pve-devel] [PATCH access-control 3/3] Change naming to keep command abbreviation

2017-09-25 Thread Thomas Lamprecht
On 09/22/2017 04:32 PM, Alwin Antreich wrote: Signed-off-by: Alwin Antreich --- PVE/CLI/pveum.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/CLI/pveum.pm b/PVE/CLI/pveum.pm index 7a4930f..d960437 100755 --- a/PVE/CLI/pveum.pm +++ b/PVE/CLI/pveum.pm @@ -50,7 +50

[pve-devel] applied: [PATCH qemu-server v8 0/6] Add qm importovf command

2017-09-25 Thread Wolfgang Bumiller
applied series On Wed, Sep 13, 2017 at 04:10:20PM +0200, Emmanuel Kasper wrote: > bumping this after the topic has been brough in forum: > https://forum.proxmox.com/threads/procedure-to-import-vmware-ova-to-proxmox-5-0-23-with-zfs-vm-store.36779/#post-180321 > > changes since V7: > rebase on mast

[pve-devel] applied: [PATCH manager v3 0/6] Switch OSType to combobox and merge with CD/DVD panel in wizard

2017-09-25 Thread Wolfgang Bumiller
applied series On Fri, Sep 22, 2017 at 02:20:21PM +0200, Thomas Lamprecht wrote: > Mostly a resend of v2 which was part of a bigger series. > Rebased on current master. > 'PVE.qemu.OSTypeEdit: declare static' patch is new. > As Emmanuel showed real use for the bigger size of the wizad and I had >

[pve-devel] [PATCH manager] remove obsolete Posix use clause

2017-09-25 Thread Thomas Lamprecht
besides the cleanup purpose this fixes an actual problem, perls POSIX module has the following caveat: `Everything is exported by default (with a handful of exceptions). This is an unfortunate backwards compatibility feature and its use is strongly discouraged. You should either prevent the export

Re: [pve-devel] question about pve-qemu && librbd

2017-09-25 Thread Alexandre DERUMIER
>>there might be some yet undiscovered incompatibility when mixing versions like >>that (there are other ceph libraries with reverse-dependencies to >>consider as well) But proxmox 5.0 ceph-server only support luminous, right ? so, I think it shouldn't be a problem ? and from client side, librbd

[pve-devel] applied: [PATCH manager] remove obsolete Posix use clause

2017-09-25 Thread Wolfgang Bumiller
applied On Mon, Sep 25, 2017 at 02:39:43PM +0200, Thomas Lamprecht wrote: > besides the cleanup purpose this fixes an actual problem, perls POSIX > module has the following caveat: > > `Everything is exported by default (with a handful of exceptions). > This is an unfortunate backwards compatibil

[pve-devel] Adapt regex in pvesm import/export.

2017-09-25 Thread Wolfgang Link
We allow uppercase characters in snapshot names. pvesm import and export must allow uppercase characters too. [PATCH V2] Use JSON schema instead of hardcoding. [PATCH V3 pve-storage] Correct typo. [PATCH V4] Make base snapshot more specific. [PATCH V5] Merge pve-lxc-snapshot-name and pve-snapsh

[pve-devel] [PATCH V6 storage] Use a json format instead of hard code regex.

2017-09-25 Thread Wolfgang Link
--- PVE/CLI/pvesm.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/CLI/pvesm.pm b/PVE/CLI/pvesm.pm index 9455595..57d10f4 100755 --- a/PVE/CLI/pvesm.pm +++ b/PVE/CLI/pvesm.pm @@ -183,7 +183,7 @@ __PACKAGE__->register_method ({ base => { des

[pve-devel] [PATCH V6 common 1/2] merge pve-snapshot-name and pve-lxc-snapshot-name to pve-snapshot-name.

2017-09-25 Thread Wolfgang Link
This format was two time declared in PVE::LXC::Config and PVE::QemuServer. --- src/PVE/JSONSchema.pm | 17 + 1 file changed, 17 insertions(+) diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm index 3295599..5b1d59e 100644 --- a/src/PVE/JSONSchema.pm +++ b/src/PVE/JSONSche

[pve-devel] [PATCH V6 common 2/2] Extend the JSON format schema with pve_base_snapshot.

2017-09-25 Thread Wolfgang Link
A base snapshot can be a replication snapshot or a normal snapshot. Normal snapshots use the format configid. --- src/PVE/JSONSchema.pm | 13 + 1 file changed, 13 insertions(+) diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm index 5b1d59e..fdf8119 100644 --- a/src/PVE/JSONS

[pve-devel] [PATCH V6 qemu-server] Move option 'pve-snapshot-name' to PVE::JSONSchema.

2017-09-25 Thread Wolfgang Link
--- PVE/QemuServer.pm | 6 -- 1 file changed, 6 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 2b6fda9..bd4f6cd 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -62,12 +62,6 @@ PVE::JSONSchema::register_standard_option('pve-qm-stateuri', { optional => 1,

[pve-devel] [PATCH V6 container] Move option 'pve-lxc-snapshot-name' to PVE::JSONSchema.

2017-09-25 Thread Wolfgang Link
Rename pve-lxc-snapshot-name to pve-snapshot-name to have a unified name schema. --- src/PVE/API2/LXC.pm | 4 ++-- src/PVE/API2/LXC/Snapshot.pm | 12 ++-- src/PVE/LXC/Config.pm| 6 -- 3 files changed, 8 insertions(+), 14 deletions(-) diff --git a/src/PVE/API2/LXC.pm

Re: [pve-devel] question about pve-qemu && librbd

2017-09-25 Thread Fabian Grünbichler
On Mon, Sep 25, 2017 at 03:10:11PM +0200, Alexandre DERUMIER wrote: > >>there might be some yet undiscovered incompatibility when mixing versions > >>like > >>that (there are other ceph libraries with reverse-dependencies to > >>consider as well) > > But proxmox 5.0 ceph-server only support lumin

Re: [pve-devel] [PATCH ha-manager v2] fix #1347: let postfix fill in FQDN in fence mails

2017-09-25 Thread Thomas Lamprecht
On 09/14/2017 02:39 PM, Philip Abernethy wrote: Using the nodename in $mailto is not correct and can lead to mails not forwarding in restrictive mail server configurations. Also changes $mailfrom to 'root' instead of 'root@localhost', which results in postfix appending the proper FQDN there, too.

[pve-devel] applied: [PATCH ha-manager v2] fix #1347: let postfix fill in FQDN in fence mails

2017-09-25 Thread Wolfgang Bumiller
applied On Thu, Sep 14, 2017 at 02:39:33PM +0200, Philip Abernethy wrote: > Using the nodename in $mailto is not correct and can lead to mails not > forwarding in restrictive mail server configurations. > Also changes $mailfrom to 'root' instead of 'root@localhost', which > results in postfix appe

[pve-devel] applied: [PATCH pve-manager] Clean up unnecessary code.

2017-09-25 Thread Wolfgang Bumiller
applied On Tue, Sep 19, 2017 at 12:01:15PM +0200, Wolfgang Link wrote: > The jobid is already parsed by the file parser. > --- > PVE/API2/Replication.pm | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/PVE/API2/Replication.pm b/PVE/API2/Replication.pm > index 15499508..f396615d 100644 >

Re: [pve-devel] question about pve-qemu && librbd

2017-09-25 Thread Alexandre DERUMIER
>>but for other use cases, we don't (yet?) have that limitation. e.g., >>running a radosgw (which is a client from Ceph's perspective) or just >>rbd access to an external cluster is supported using Jewel as well. mmm, I don't have thinked about radosgw. >>if we move librbd1, we'd have to move

Re: [pve-devel] question about pve-qemu && librbd

2017-09-25 Thread Alexandre DERUMIER
>>Maybe it is possible to detect this at runtime ? mmm,I find some old threads and discuss about this case https://patchwork.ozlabs.org/patch/235271/ seem that qemu don't support dynamic linking, that's why it don't work with old lib if qemu is build with newer lib. so maybe maintain a pve-qem

Re: [pve-devel] [PATCH access-control] pveum: Allow listing of roles and their privileges

2017-09-25 Thread Alwin Antreich
On Mon, Sep 25, 2017 at 10:19:50AM +0200, Philip Abernethy wrote: > On Mon, Sep 25, 2017 at 10:13:29AM +0200, Thomas Lamprecht wrote: > > On 09/25/2017 07:05 AM, Dietmar Maurer wrote: > > > > > > > + sub { > > > > + my ($res) = @_; > > > > + my $longest = 0; > > > > +