[pve-devel] [PATCH docs 1/2] Typo correction

--- qm.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qm.adoc b/qm.adoc index 6cc8855..44d45f6 100644 --- a/qm.adoc +++ b/qm.adoc @@ -679,7 +679,7 @@ the VM. For Windows VMs, you need to install the Windows paravirtualized drivers by yourself. GNU/Linux and other

[pve-devel] [PATCH docs 2/2] Update the Windows import example to use the qm importovf command

Also create a new section, "Add an external disk image to a Virtual Machine" using the qm importdisk command. --- NB: qm.1-synopsis.adoc should be rebuilt, so the 'importovf' command is there too. qm.adoc | 74 - 1 file changed, 50

[pve-devel] applied: [PATCH qemu-server] importovf: explicitly returns undef

applied On Wed, Sep 27, 2017 at 02:43:11PM +0200, Emmanuel Kasper wrote: > We set the returns value to { type => 'null' } but we returned an empty > string, which was confusing the cli handler. > --- > PVE/CLI/qm.pm | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git

[pve-devel] [PATCH qemu-server] importovf: explicitly returns undef

We set the returns value to { type => 'null' } but we returned an empty string, which was confusing the cli handler. --- PVE/CLI/qm.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm index 0e17cc9..90a44ef 100755 --- a/PVE/CLI/qm.pm +++

[pve-devel] applied: [PATCH 1/3] buildsys: set SOURCE_DATE_EPOCH to allow reproducible build

whole series ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH v2 firewall 4/4] convert string based rule definitions to hashes

Am Mittwoch, den 27.09.2017, 11:51 +0200 schrieb Wolfgang Bumiller: > On Wed, Sep 27, 2017 at 11:09:29AM +0200, Tom Weber wrote: > > > > My goal are defined structures for rules, chains, macros (which i > > think > > are just arrays of "rule templates") etc and code which deals with > > these

Re: [pve-devel] [PATCH v3 container 0/5] Rebased lxc clone/move disk patches

On 09/26/2017 02:42 PM, Wolfgang Bumiller wrote: Changes: Patch 2: * Fixed unmount warnings to refer to the right $src vs $dest variable. Patch 4 is new. Patch 5 (previous 4): * Instead of refusing moves when any snapshots exist, use the new 'is_volume_in_use' variant to check whether

Re: [pve-devel] [PATCH v2 firewall 4/4] convert string based rule definitions to hashes

Am Mittwoch, den 27.09.2017, 11:53 +0200 schrieb Wolfgang Bumiller: > On Wed, Sep 27, 2017 at 12:02:33AM +0200, Tom Weber wrote: > > > > --- > > +'PVEFW-smurflog' => [ > > + { action => 'DROP', logmsg => 'DROP: ' }, > > +], > > +'PVEFW-logflags' => [ > > + { action => 'DROP',

Re: [pve-devel] [PATCH v2 firewall 4/4] convert string based rule definitions to hashes

On Wed, Sep 27, 2017 at 12:02:33AM +0200, Tom Weber wrote: > --- > +'PVEFW-smurflog' => [ > + { action => 'DROP', logmsg => 'DROP: ' }, > +], > +'PVEFW-logflags' => [ > + { action => 'DROP', logmsg => 'DROP: ' }, > ], > }; Just noticed this is missing in the ipv6 part

Re: [pve-devel] [PATCH v2 firewall 4/4] convert string based rule definitions to hashes

On Wed, Sep 27, 2017 at 11:09:29AM +0200, Tom Weber wrote: > My goal are defined structures for rules, chains, macros (which i think > are just arrays of "rule templates") etc and code which deals with > these structures instead of printing out iptables commands in various > places. That's long

Re: [pve-devel] [PATCH manager v3 8/8] Render full name of VirtIO Block controller

On 09/26/2017 02:17 PM, Emmanuel Kasper wrote: This will hopefully reduce confusion with SCSI VirtIO controller +1 and: Reviewed-by: Thomas Lamprecht --- www/manager6/form/BusTypeSelector.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [pve-devel] [PATCH manager v3 7/8] After OS type selection in Wizard, set the appropriate SCSI controller type in the Hard Disk panel

On 09/26/2017 02:17 PM, Emmanuel Kasper wrote: This was done previously without any kind of user visible feedback, so users would not know that they had a Virtio SCSI controller as default controller for Linux VMs. Same issue with line length here. Besides that: Reviewed-by: Thomas Lamprecht

Re: [pve-devel] [PATCH manager v3 6/8] When inside the wizard, actualize the scsiType display field based on iothread selection

On 09/26/2017 02:17 PM, Emmanuel Kasper wrote: We keep the same logic as before: once the iothread option is selected, the default SCSI> controller is switched to virtio-scsi-single until iothread is unselected again. Please try to keep commit message line length below 70 characters long.

Re: [pve-devel] [PATCH manager v3 5/8] Add a field to show which SCSI controller type we are currently using

On 09/26/2017 02:17 PM, Emmanuel Kasper wrote: --- www/manager6/qemu/HDEdit.js | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js index 8a415d8b..075ad667 100644 --- a/www/manager6/qemu/HDEdit.js +++

Re: [pve-devel] [PATCH manager v3 4/8] Use the noVirtIO ControllerSelector property to build the list of controllers

On 09/26/2017 02:17 PM, Emmanuel Kasper wrote: --- www/manager6/form/ControllerSelector.js | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/www/manager6/form/ControllerSelector.js b/www/manager6/form/ControllerSelector.js index 15023a7a..489b97de 100644 ---

Re: [pve-devel] [PATCH v2 firewall 4/4] convert string based rule definitions to hashes

First of all, this all is work in progress. I thought I commit for easier understanding of the way i'm heading - instead of one huge commit which turns everything inside out. and for feedback of course. My goal are defined structures for rules, chains, macros (which i think are just arrays of

Re: [pve-devel] [PATCH manager v3 3/8] Save the components we found via down() in a variable for later reuse.

Looks OK, useful even if we remove the fast path I mentioned in my other mail. Reviewed-by: Thomas Lamprecht On 09/26/2017 02:17 PM, Emmanuel Kasper wrote: --- www/manager6/form/ControllerSelector.js | 13 - 1 file changed, 8 insertions(+), 5

Re: [pve-devel] [PATCH manager v3 2/8] Remove unused noScsi parameter

On 09/26/2017 02:17 PM, Emmanuel Kasper wrote: SCSI is a valid bus for Disks and CD drives, so it should always be appear in the bus list. Reviewed-by: Thomas Lamprecht --- www/manager6/form/BusTypeSelector.js| 6 +-

Re: [pve-devel] [PATCH manager v3 1/8] Do not use 'autoselect' as a boolean when preselecting a bus

On 09/26/2017 02:17 PM, Emmanuel Kasper wrote: The bus selector is displayed when we add a Hard Disk or CD Drive. When it is displayed, we *always* preselect the next available slot on the controller of our choice. So this test is not needed. We keep the test on the string value of 'autoselect'

[pve-devel] applied: [PATCH docs] fix typos and whitespace all around

together with some further fixes for pvesr.adoc (all -> every) ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH docs] fix typos and whitespace all around

Signed-off-by: Dominik Csapak --- README.adoc | 6 +++--- getting-help.adoc | 2 +- ha-manager.adoc | 6 +++--- ha-resources-opts.adoc | 2 +- howto-improve-pve-docs.adoc | 2 +- local-zfs.adoc

Re: [pve-devel] [PATCH v2 firewall 4/4] convert string based rule definitions to hashes

On Wed, Sep 27, 2017 at 12:02:33AM +0200, Tom Weber wrote: > --- > src/PVE/Firewall.pm | 220 > > 1 file changed, 117 insertions(+), 103 deletions(-) > > diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm > index f8a9300..179617a 100644 >

Re: [pve-devel] [PATCH v2 firewall 3/4] integrate logging into ruleset_addrule

On Wed, Sep 27, 2017 at 12:02:32AM +0200, Tom Weber wrote: > --- > src/PVE/Firewall.pm | 33 ++--- > 1 file changed, 10 insertions(+), 23 deletions(-) > > diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm > index f1aecef..f8a9300 100644 > ---

Re: [pve-devel] applied: [PATCH] ProcFSTools:read_proc_mounts: increase read size

Thanks ! - Mail original - De: "Wolfgang Bumiller" À: "aderumier" Cc: "pve-devel" Envoyé: Mardi 26 Septembre 2017 10:54:53 Objet: applied: [PATCH] ProcFSTools:read_proc_mounts: increase read size Late, but here it

Re: [pve-devel] pve api offline during log rotation

Hi, Am 21.09.2017 um 15:30 schrieb Thomas Lamprecht: > On 09/20/2017 01:26 PM, Stefan Priebe - Profihost AG wrote: >> Hi, >> >> >> Am 20.09.2017 um 10:36 schrieb Thomas Lamprecht: >>> On 09/20/2017 06:40 AM, Stefan Priebe - Profihost AG wrote: Nobody? >>> >>> We register the restart