[pve-devel] [PATCH docs] Add a paragraph to explain how network models match use cases

2017-10-02 Thread Emmanuel Kasper
Also : * explain more clearly when PVE switched to persistent device naming. (5.0) * use eno1 instead of eno0 everywhere when refering to the first onboard device * use IP addresses from the range IPv4 Address Blocks for Documentation (rfc5737) instead of private IPv4 addresses when giving exam

[pve-devel] [PATCH docs 3/3] qm/cpu: split and add content

2017-10-02 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- qm.adoc | 99 +++-- 1 file changed, 91 insertions(+), 8 deletions(-) diff --git a/qm.adoc b/qm.adoc index 5b4082a..6e14033 100644 --- a/qm.adoc +++ b/qm.adoc @@ -239,6 +239,51 @@ However {pve} will pr

[pve-devel] [PATCH docs 2/3] qm: improve disk controller wording a bit

2017-10-02 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- qm.adoc | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/qm.adoc b/qm.adoc index 1cf9427..5b4082a 100644 --- a/qm.adoc +++ b/qm.adoc @@ -154,9 +154,9 @@ _VirtIO SCSI single_ which will allow you to select the *IO Thread* option.

[pve-devel] [PATCH docs 1/3] fix a/an and repeated words

2017-10-02 Thread Thomas Lamprecht
ddouble words found with /(\b\S+\b)\s+\b\1\b/ (the silver searcher `ag` can find matches even with newlines in between without extra flags) Adapt some wording when touching the lines. Signed-off-by: Thomas Lamprecht --- pve-network.adoc | 2 +- pvecm.adoc | 4 ++-- pveum.adoc | 2 +-

Re: [pve-devel] [PATCH manager] fix #1510: do not scroll back to focus when view gets refreshed

2017-10-02 Thread Emmanuel Kasper
On 10/02/2017 02:53 PM, Thomas Lamprecht wrote: > Seems to works good, the small code change you made to the > original function looks also good to me: > Reviewed-by: Thomas Lamprecht Fine for me too, I tested this with IE11 and this works as expected.

Re: [pve-devel] [PATCH manager] fix #1510: do not scroll back to focus when view gets refreshed

2017-10-02 Thread Thomas Lamprecht
Seems to works good, the small code change you made to the original function looks also good to me: Reviewed-by: Thomas Lamprecht On 09/29/2017 12:51 PM, Dominik Csapak wrote: > this adds a workaround, so that we restore the scroll position > when we restore the focus > > with the flag 'jumpToF

Re: [pve-devel] Spice Server

2017-10-02 Thread Gilberto Nunes
Yep! Your are right! I just missundertood the concept behind Spice MultipleClient. I was think that MC works like WTS that can use multiple users, independent, without interfere each other... After Lindsay explain that Spice MC act like independent console and not independent windows sessions

[pve-devel] [PATCH] dmeventd: ensure service gets stopped normally on shutdown

2017-10-02 Thread Thomas Lamprecht
The service pf dmeventd, dm-eventd.service, uses 'DefaultDependencies=no' as it wants to start up very early in the boot process. But, this also removed the implicit 'Conflicts' and 'Before' settings to the shutdown target, which is in charge of stopping all service gracefully on poweroff, reboot o

[pve-devel] [PATCH manager v4 7/8] Update VM SCSI controller type after OS selection in Wizard

2017-10-02 Thread Emmanuel Kasper
This was done previously without any kind of user visible feedback, so users would not know that they had a Virtio SCSI controller as default controller for Linux VMs. --- www/manager6/qemu/CreateWizard.js | 5 - www/manager6/qemu/OSDefaults.js | 2 +- www/manager6/qemu/OSTypeEdit.js | 1

[pve-devel] [PATCH manager v4 8/8] Render full name of VirtIO Block controller

2017-10-02 Thread Emmanuel Kasper
This will hopefully reduce confusion with SCSI VirtIO controller --- www/manager6/form/BusTypeSelector.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/form/BusTypeSelector.js b/www/manager6/form/BusTypeSelector.js index ae7c327e..8abdcf4b 100644 --- a/www/manag

[pve-devel] [PATCH manager v4 6/8] Update VM SCSI type based on iothread value when inside the wizard

2017-10-02 Thread Emmanuel Kasper
We keep the same logic as before: once the iothread option is selected, the SCSI controller is switched to virtio-scsi-single, until iothread is unselected again. --- www/manager6/qemu/HDEdit.js | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/www/manager6/

[pve-devel] [PATCH manager v4 2/8] Remove unused noScsi parameter

2017-10-02 Thread Emmanuel Kasper
SCSI is a valid bus for Disks and CD drives, so it should always be appear in the bus list. --- www/manager6/form/BusTypeSelector.js| 6 +- www/manager6/form/ControllerSelector.js | 6 +- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/www/manager6/form/BusTypeSelector.

[pve-devel] [PATCH manager v4 1/8] Do not use 'autoselect' as a boolean when preselecting a bus

2017-10-02 Thread Emmanuel Kasper
The bus selector is displayed when we add a Hard Disk or CD Drive. When it is displayed, we *always* preselect the next available slot on the controller of our choice. So this test is not needed. We keep the test on the string value of 'autoselect' to select a bus position when adding a CD Drive.

[pve-devel] [PATCH manager v4 4/8] Do not use the noVirtIO property to build the controller list

2017-10-02 Thread Emmanuel Kasper
This property is only used for CDEdit, so we can deduce this from the fact that autoselect is set to 'cdrom' --- www/manager6/form/ControllerSelector.js | 3 --- 1 file changed, 3 deletions(-) diff --git a/www/manager6/form/ControllerSelector.js b/www/manager6/form/ControllerSelector.js index 15

[pve-devel] [PATCH manager v4 3/8] Save the components we found via down() in a variable for later reuse.

2017-10-02 Thread Emmanuel Kasper
--- www/manager6/form/ControllerSelector.js | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/www/manager6/form/ControllerSelector.js b/www/manager6/form/ControllerSelector.js index 14ad574e..15023a7a 100644 --- a/www/manager6/form/ControllerSelector.js +++ b/www/m

[pve-devel] [PATCH manager v4 5/8] Add a field to show which SCSI controller type we are currently using

2017-10-02 Thread Emmanuel Kasper
--- www/manager6/qemu/HDEdit.js | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js index 8a415d8b..075ad667 100644 --- a/www/manager6/qemu/HDEdit.js +++ b/www/manager6/qemu/HDEdit.js @@ -24,11 +24,12 @@ Ext

[pve-devel] [PATCH manager v4 0/8] Display the SCSI controller type when adding a new disk

2017-10-02 Thread Emmanuel Kasper
Since we switched to the SCSI controller in the Wizard as the recommended controller for hard disks (using VirtIO scsi in the backend) it was not clear for users that they were actually using a paravirtualized driver. An example of user confusion: https://forum.proxmox.com/threads/proxmox-hypervi

Re: [pve-devel] Spice Server

2017-10-02 Thread Philip Abernethy
On Sun, Oct 01, 2017 at 06:54:03PM -0300, Gilberto Nunes wrote: > Hi guys... > > I am trying to recompile spice-server in PVE 4.4, in order to make > SPICE_DEBUG_ALLOW_MC=1 > works, but it seems I have no success. > In README file, I saw this: > > Experimental Features > - > T