[pve-devel] [PATCH v3 container 0/3] lxc@ service: fix dependencies

2017-10-09 Thread Fabian Grünbichler
the "think before you git-send-email" v3 ;) changes: - change unit in all needed places in patch#3 Fabian Grünbichler (3): install lxc@ snippets to correct location add new pve-container@ unit switch to pve-container@ unit src/Makefile | 3 ++- src/PVE/API2/LXC/Status.pm |

[pve-devel] [PATCH v3 container 2/3] add new pve-container@ unit

2017-10-09 Thread Fabian Grünbichler
to replace lxc@.service. we want our unit to only start when manually invoked (by our code), and stop on shutdown via pve-guests or pve-ha-lrm. lxc@ units are stopped by systemd on shutdown, because of transitive dependencies. Signed-off-by: Fabian Grünbichler --- src/Makefile |

[pve-devel] [PATCH v3 container 3/3] switch to pve-container@ unit

2017-10-09 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- src/PVE/API2/LXC/Status.pm | 2 +- src/PVE/VZDump/LXC.pm | 2 +- src/lxc-pve-poststop-hook | 7 --- src/lxc-pve-reboot-trigger | 3 ++- 4 files changed, 8 insertions(+), 6 deletions(-) diff --git a/src/PVE/API2/LXC/Status.pm b/src/PVE/API2/LXC/Stat

[pve-devel] [PATCH v3 container 1/3] install lxc@ snippets to correct location

2017-10-09 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- src/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Makefile b/src/Makefile index 19931e5..9c5fbc3 100644 --- a/src/Makefile +++ b/src/Makefile @@ -10,7 +10,7 @@ LXC_SCRIPT_DIR=${PREFIX}/share/lxc LXC_TMPL_DIR=${LXC_SCRIPT_DI

[pve-devel] [PATCH v2 container 1/3] install lxc@ snippets to correct location

2017-10-09 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- src/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Makefile b/src/Makefile index 19931e5..9c5fbc3 100644 --- a/src/Makefile +++ b/src/Makefile @@ -10,7 +10,7 @@ LXC_SCRIPT_DIR=${PREFIX}/share/lxc LXC_TMPL_DIR=${LXC_SCRIPT_DI

[pve-devel] [PATCH v2 container 0/3] lxc@ service: fix dependencies

2017-10-09 Thread Fabian Grünbichler
replaces <20171003081723.12872-1-f.gruenbich...@proxmox.com> Fabian Grünbichler (3): install lxc@ snippets to correct location add new pve-container@ unit lxc-pve-reboot-trigger: switch to pve-container@ src/Makefile | 3 ++- src/lxc-pve-reboot-trigger | 3 ++- src/pve-cont

[pve-devel] [PATCH v2 container 3/3] switch to new unit in reboot trigger

2017-10-09 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- src/lxc-pve-reboot-trigger | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/lxc-pve-reboot-trigger b/src/lxc-pve-reboot-trigger index 95c3ac8..6e413ea 100755 --- a/src/lxc-pve-reboot-trigger +++ b/src/lxc-pve-reboot-trigger @@ -7,4 +7

[pve-devel] [PATCH v2 container 2/3] add new pve-container@ unit

2017-10-09 Thread Fabian Grünbichler
to replace lxc@.service. we want our unit to only start when manually invoked (by our code), and stop on shutdown via pve-guests or pve-ha-lrm. lxc@ units are stopped by systemd on shutdown, because of transitive dependencies. Signed-off-by: Fabian Grünbichler --- src/Makefile |

[pve-devel] [PATCH access-control] pveum: introduce sub-commands

2017-10-09 Thread Philip Abernethy
use a sub-command structure instead of abbreviated words, where useful. Keep old commands as aliases. --- In case the sub-commands patch gets applied, here is the first use case. PVE/CLI/pveum.pm | 41 ++--- 1 file changed, 30 insertions(+), 11 deletions(-) di

Re: [pve-devel] [PATCH container] Fix restore with multiple mountpoints

2017-10-09 Thread Tom Weber
Anyone care about this? I have two cases of containers were i have to manually fix after a restore.   Tom Am Dienstag, den 26.09.2017, 15:29 +0200 schrieb Tom Weber: > If you use mountpoints inside a container, and change ownership of > these, a restore of the CT will reset them to root:root agai

[pve-devel] ceph rdma mellanox ceph 12.2.1

2017-10-09 Thread Gerhard W. Recher
Hi Fellows, Fabian suggested me to open a thread on dev-list : based on bug-report: https://bugzilla.proxmox.com/show_bug.cgi?id=1521  pveversion -v proxmox-ve: 5.0-23 (running kernel: 4.13.3-1-pve) pve-manager: 5.0-32 (running version: 5.0-32/2560e073) pve-kernel-4.13.3-1-pve: 4.13.3-2 pve-kerne

[pve-devel] [PATCH qemu-server v2] correct cpuunits range

2017-10-09 Thread Philip Abernethy
'These options take an integer value and control the "cpu.shares" control group attribute. The allowed range is 2 to 262144. Defaults to 1024.' – man 5 systemd.resource-control --- Indeed. We seem to have no way to disable fair scheduling now. PVE/QemuServer.pm | 6 +++--- 1 file changed, 3 inser

Re: [pve-devel] [PATCH qemu-server] correct cpuunits range

2017-10-09 Thread Fabian Grünbichler
On Mon, Oct 09, 2017 at 01:06:57PM +0200, Philip Abernethy wrote: > 'These options take an integer value and control the "cpu.shares" > control group attribute. The allowed range is 2 to 262144. Defaults to > 1024.' – man 5 systemd.resource-control > --- > Concerns #1321 > > PVE/QemuServer.pm | 4

[pve-devel] [PATCH qemu-server] correct cpuunits range

2017-10-09 Thread Philip Abernethy
'These options take an integer value and control the "cpu.shares" control group attribute. The allowed range is 2 to 262144. Defaults to 1024.' – man 5 systemd.resource-control --- Concerns #1321 PVE/QemuServer.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/QemuSer

[pve-devel] [PATCH v3 firewall 03/13] integrate logging into ruleset_addrule

2017-10-09 Thread Tom Weber
--- src/PVE/Firewall.pm | 33 ++--- 1 file changed, 10 insertions(+), 23 deletions(-) diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm index f1aecef..ad59267 100644 --- a/src/PVE/Firewall.pm +++ b/src/PVE/Firewall.pm @@ -2002,10 +2002,14 @@ sub ruleset_addrule_ol

[pve-devel] [PATCH v3 firewall 02/13] prepare code for more generic firewall logging

2017-10-09 Thread Tom Weber
making ruleset generation aware of a match and action part in iptable rules. code will generate the same iptables as before! (except for a few additional spaces between match and action). --- src/PVE/Firewall.pm | 166 ++- src/PVE/FirewallSimulator.

[pve-devel] [PATCH v3 firewall 04/13] convert string based rule definitions to hashes

2017-10-09 Thread Tom Weber
also extending %rule with log,logmsg,match,target --- src/PVE/Firewall.pm | 223 1 file changed, 120 insertions(+), 103 deletions(-) diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm index ad59267..634ff90 100644 --- a/src/PVE/Firewall.pm

[pve-devel] [PATCH v3 firewall 05/13] make $pve_std_chains a copy of $pve_std_chains_conf

2017-10-09 Thread Tom Weber
create a new $pve_std_chains with $pve_std_chains_conf as template on every compilation of the rules. This avoids persitant changes to the $pve_std_chains and makes it easier to read the std_chains configuration from external config files (later to implement). --- src/PVE/Firewall.pm | 9 +++--

[pve-devel] [PATCH v3 firewall 01/13] remove unused $rule_format

2017-10-09 Thread Tom Weber
--- src/PVE/Firewall.pm | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm index cc81325..5d78686 100644 --- a/src/PVE/Firewall.pm +++ b/src/PVE/Firewall.pm @@ -1648,8 +1648,6 @@ sub enable_bridge_firewall { $bridge_firewall_enabled = 1; } -my $r

[pve-devel] [PATCH v3 firewall 00/13] Firewall code cleanups

2017-10-09 Thread Tom Weber
third version. mostly converting rules into structures. reorganized ruleset_generate_rule and everything around it. please note that some of the stuff implemented in the first patches gets eliminated later. So maybe it's worth reading all patches before flaming me ;-) Tom Weber (13): remove unu

[pve-devel] [PATCH v3 firewall 06/13] eliminate unused nbdport in pve_std_chains_conf

2017-10-09 Thread Tom Weber
--- src/PVE/Firewall.pm | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm index c7ddd10..f009e58 100644 --- a/src/PVE/Firewall.pm +++ b/src/PVE/Firewall.pm @@ -586,10 +586,10 @@ $pve_std_chains_conf->{4} = {

[pve-devel] [PATCH v3 firewall 07/13] iptables address matching in own subroutine

2017-10-09 Thread Tom Weber
put generation of iptables source/destination address matching in own subroutine and use this in ruleset_generate_match --- src/PVE/Firewall.pm | 104 1 file changed, 47 insertions(+), 57 deletions(-) diff --git a/src/PVE/Firewall.pm b/src/PVE/

[pve-devel] [PATCH v3 firewall 10/13] rule_substitude_action, remove ruleset_generate_rule_old

2017-10-09 Thread Tom Weber
implement rule_substitude_action eliminate use of ruleset_genereate_rule_old and remove it --- src/PVE/Firewall.pm | 73 ++--- 1 file changed, 24 insertions(+), 49 deletions(-) diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm index 633aa7a..d9

[pve-devel] [PATCH v3 firewall 09/13] remove unused ruleset_generate_cmdstr

2017-10-09 Thread Tom Weber
--- src/PVE/Firewall.pm | 11 --- 1 file changed, 11 deletions(-) diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm index b492086..633aa7a 100644 --- a/src/PVE/Firewall.pm +++ b/src/PVE/Firewall.pm @@ -2040,17 +2040,6 @@ sub ruleset_generate_action { return scalar(@cmd) ? join('

[pve-devel] [PATCH v3 firewall 11/13] cleanup parameters to ruleset_generate_rule

2017-10-09 Thread Tom Weber
remove $actions and $goto - not used anymore --- src/PVE/Firewall.pm | 19 +++ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm index d9c2347..d249f7a 100644 --- a/src/PVE/Firewall.pm +++ b/src/PVE/Firewall.pm @@ -2050,7 +2050

[pve-devel] [PATCH v3 firewall 13/13] remove ruleset_generate_match, ruleset_generate_action

2017-10-09 Thread Tom Weber
ruleset_generate_match and ruleset_generate_action not used anymore --- src/PVE/Firewall.pm | 97 - 1 file changed, 97 deletions(-) diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm index 65ea132..9b78acb 100644 --- a/src/PVE/Firewall.pm ++

[pve-devel] [PATCH v3 firewall 08/13] implement ipt_rule_to_cmds, ruleset_add_ipt_cmd

2017-10-09 Thread Tom Weber
ipt_rule_to_cmds converts a %rule to an array of iptables commands ruleset_add_ipt_cmd adds such an iptables command to a chain ruleset_generate_rule uses these now ruleset_generate_rule_old is an interim workaround --- src/PVE/Firewall.pm | 151

[pve-devel] [PATCH v3 firewall 12/13] remove unused ruleset_generate_rule_insert

2017-10-09 Thread Tom Weber
--- src/PVE/Firewall.pm | 12 1 file changed, 12 deletions(-) diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm index d249f7a..65ea132 100644 --- a/src/PVE/Firewall.pm +++ b/src/PVE/Firewall.pm @@ -2070,18 +2070,6 @@ sub ruleset_generate_rule { } } -sub ruleset_generate_

[pve-devel] [PATCH ha-manager] lrm.service: do not timeout on stop

2017-10-09 Thread Thomas Lamprecht
we must shut all services down when stopping the LRM for a host shutdown, this can take longer than 95 seconds and should not get interrupted to ensure a gracefull poweroff. The watchdog is still active untill all services got stopped so we still are safe from a freeze or equivalent failure. Sign

[pve-devel] [PATCH docs v2] Add a paragraph to explain how network models match use cases

2017-10-09 Thread Emmanuel Kasper
Also : * explain more clearly when PVE switched to persistent device naming. (5.0) * use eno1 instead of eno0 everywhere when refering to the first onboard device * use IP addresses from the range IPv4 Address Blocks for Documentation (rfc5737) instead of private IPv4 addresses when giving exam

Re: [pve-devel] AMD EPYC

2017-10-09 Thread Martin Maurer
Hi, yes, sounds interesting. please contact me directly as soon as you can provide access for testing, Martin On 05.10.2017 09:56, Waschbüsch IT-Services GmbH wrote: Hi all, Since several times I read both on this list and on the forum that AMD based servers are rarely used for developmen

[pve-devel] applied: [PATCH storage] ISCSIPlugin: Use long options for readability

2017-10-09 Thread Fabian Grünbichler
On Mon, Oct 09, 2017 at 10:39:18AM +0200, Emmanuel Kasper wrote: > We otherwise use the long options everywhere in the plugin. > This will build the following command: > > iscsiadm --mode session --sid 1 --rescan > Rescanning session [sid: 1, target: xxx, portal: yyy] > --- > PVE/Storage/ISCSIPl

[pve-devel] [PATCH storage] ISCSIPlugin: Use long options for readability

2017-10-09 Thread Emmanuel Kasper
We otherwise use the long options everywhere in the plugin. This will build the following command: iscsiadm --mode session --sid 1 --rescan Rescanning session [sid: 1, target: xxx, portal: yyy] --- PVE/Storage/ISCSIPlugin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE

Re: [pve-devel] [PATCH ksm-control-daemon 1/1] Allow to disable ksm merge_across_nodes

2017-10-09 Thread Fabian Grünbichler
On Mon, Oct 09, 2017 at 10:08:59AM +0200, Alexandre DERUMIER wrote: > >>you can just do the same using "systemctl edit ksmtuned", and adding > >>just the following snippet (setting your desired value): > >> > >>[Service] > >>ExecStartpre=... > >> > >>as an extension to the existing unit. > >

Re: [pve-devel] [PATCH docs] Add a paragraph to explain how network models match use cases

2017-10-09 Thread Fabian Grünbichler
does not apply anymore with your previous docs series applied, please rebase ;) On Mon, Oct 02, 2017 at 05:17:26PM +0200, Emmanuel Kasper wrote: > Also : > * explain more clearly when PVE switched to persistent device naming. (5.0) > * use eno1 instead of eno0 everywhere when refering to the fir

[pve-devel] applied: [PATCH docs 1/3] fix a/an and repeated words

2017-10-09 Thread Fabian Grünbichler
all three plus some cleanup On Mon, Oct 02, 2017 at 03:55:38PM +0200, Thomas Lamprecht wrote: > ddouble words found with /(\b\S+\b)\s+\b\1\b/ > (the silver searcher `ag` can find matches even with newlines in > between without extra flags) > > Adapt some wording when touching the lines. > > Sign

Re: [pve-devel] [PATCH ksm-control-daemon 1/1] Allow to disable ksm merge_across_nodes

2017-10-09 Thread Alexandre DERUMIER
>>you can just do the same using "systemctl edit ksmtuned", and adding >>just the following snippet (setting your desired value): >> >>[Service] >>ExecStartpre=... >> >>as an extension to the existing unit. Yes, sure, I just want to add something easy for users. (Personnaly, I think we shoul

[pve-devel] applied: [PATCH docs 2/2] Update the Windows import example to use the qm importovf command

2017-10-09 Thread Fabian Grünbichler
changed "Add" to "Adding" in one of the headings for consistency On Wed, Sep 27, 2017 at 04:57:50PM +0200, Emmanuel Kasper wrote: > Also create a new section, "Add an external disk image to a Virtual Machine" > using the qm importdisk command. > --- > NB: qm.1-synopsis.adoc should be rebuilt, so t

[pve-devel] applied: [PATCH docs 1/2] Typo correction

2017-10-09 Thread Fabian Grünbichler
On Wed, Sep 27, 2017 at 04:57:49PM +0200, Emmanuel Kasper wrote: > --- > qm.adoc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qm.adoc b/qm.adoc > index 6cc8855..44d45f6 100644 > --- a/qm.adoc > +++ b/qm.adoc > @@ -679,7 +679,7 @@ the VM. For Windows VMs, you need to in

[pve-devel] skipped: [PATCH docs 3/3] Typo correction

2017-10-09 Thread Fabian Grünbichler
this one has already been fixed ;) On Mon, Jul 24, 2017 at 03:55:16PM +0200, Emmanuel Kasper wrote: > --- > pve-network.adoc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/pve-network.adoc b/pve-network.adoc > index b8eb7a0..f2f5103 100644 > --- a/pve-network.adoc > +++

[pve-devel] applied: [PATCH docs 1/3] Document that active-backup is recommended for corosync

2017-10-09 Thread Fabian Grünbichler
On Mon, Jul 24, 2017 at 03:55:14PM +0200, Emmanuel Kasper wrote: > --- > pve-network.adoc | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/pve-network.adoc b/pve-network.adoc > index 315ba63..dd86029 100644 > --- a/pve-network.adoc > +++ b/pve-network.adoc > @@ -2

[pve-devel] applied: [PATCH docs 2/3] Do not mention the name of the first NIC in the doc, as it might differ in each install

2017-10-09 Thread Fabian Grünbichler
On Mon, Jul 24, 2017 at 03:55:15PM +0200, Emmanuel Kasper wrote: > --- > pve-network.adoc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/pve-network.adoc b/pve-network.adoc > index dd86029..b8eb7a0 100644 > --- a/pve-network.adoc > +++ b/pve-network.adoc > @@ -83,8 +

Re: [pve-devel] [PATCH ksm-control-daemon 1/1] Allow to disable ksm merge_across_nodes

2017-10-09 Thread Fabian Grünbichler
On Mon, Oct 09, 2017 at 09:19:21AM +0200, Alexandre Derumier wrote: > This allow to disable /sys/kernel/mm/ksm/merge_across_nodes. > (keep defaults to 1, to not change current behaviour). > > By default, ksm can merge pages across nodes, which can impact latency. > (moving pages from node1 to node

[pve-devel] [PATCH ksm-control-daemon 1/1] Allow to disable ksm merge_across_nodes

2017-10-09 Thread Alexandre Derumier
This allow to disable /sys/kernel/mm/ksm/merge_across_nodes. (keep defaults to 1, to not change current behaviour). By default, ksm can merge pages across nodes, which can impact latency. (moving pages from node1 to node0 for example, and kvm thread still running on node1). This need to be setup

[pve-devel] [PATCH ksm-control-daemon 0/1] Allow to disable ksm merge_across_nodes

2017-10-09 Thread Alexandre Derumier
Details in commit Alexandre Derumier (1): Allow to disable ksm merge_across_nodes debian/defaults | 2 ++ debian/ksmtuned.service | 5 - 2 files changed, 6 insertions(+), 1 deletion(-) -- 2.11.0 ___ pve-devel mailing list pve-devel@pve