[pve-devel] [PATCH manager V2 1/2] Indentation cleanup.

2017-10-16 Thread Wolfgang Link
--- PVE/API2/Replication.pm | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/PVE/API2/Replication.pm b/PVE/API2/Replication.pm index f396615d..38449892 100644 --- a/PVE/API2/Replication.pm +++ b/PVE/API2/Replication.pm @@ -77,15 +77,15 @@ sub run_jobs { my $i

[pve-devel] PVE Replica email notification on failure.

2017-10-16 Thread Wolfgang Link
[PATCH manager V2] Indentation cleanup. Small clenup like W.Bumiller has suggested. ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH manager V2 2/2] Send an email when a replication job fails.

2017-10-16 Thread Wolfgang Link
A email notification will be send for each job when the job fails. This message will only send when an error occurs and the fail count is on 1. --- PVE/API2/Replication.pm | 18 -- PVE/CLI/pvesr.pm | 11 ++- bin/init.d/pvesr.service | 2 +- 3 files changed, 27 ins

[pve-devel] [PATCH guest-common V2] Remove noerr form replication.

2017-10-16 Thread Wolfgang Link
We will handle this errors in the API and decide what to do. --- PVE/Replication.pm | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/PVE/Replication.pm b/PVE/Replication.pm index e53928e..2b3df36 100644 --- a/PVE/Replication.pm +++ b/PVE/Replication.pm @@ -304

Re: [pve-devel] [PATCH manager 7/7] ui: lxc: add 'more' button with HA manage menu item to panel

2017-10-16 Thread Emmanuel Kasper
On 10/11/2017 12:09 PM, Thomas Lamprecht wrote: > Move the remove button into the more button and add a 'Manage HA' > button there, mirroring the changes from the qemu panel. > > Allows to add an unmanaged CT to HA or to edit the HA settings of a > managed one. > > Fixes: #1518 > Signed-off-by: T

[pve-devel] [PATCH common v5 1/3] cli: prepare CLIHandler for handling sub-commands

2017-10-16 Thread Philip Abernethy
instead of 5 slightly different calls to RESTHandler::usage_str this introduces a wrapper function that handles all required cases and is capable of resolving sub-commands and aliases. Adds a subroutine to print the short help for a command in case no subcommand was given. Modifies handle_cmd and p

[pve-devel] [PATCH container] implement 'edit' command for pct

2017-10-16 Thread Dominik Csapak
this opens the container config file in the editor which is specified via the "EDITOR" environment variable or set via update-alternatives (which /usr/bin/editor is a symlink to) Signed-off-by: Dominik Csapak --- src/PVE/CLI/pct.pm | 30 ++ 1 file changed, 30 insertio

[pve-devel] [PATCH qemu-server] implement 'edit' command for qm

2017-10-16 Thread Dominik Csapak
this opens the vm config file in the editor which is specified via the "EDITOR" environment variable or set via update-alternatives (which /usr/bin/editor is a symlink to) Signed-off-by: Dominik Csapak --- PVE/CLI/qm.pm | 30 ++ 1 file changed, 30 insertions(+) diff

Re: [pve-devel] [PATCH guest-common] Send email when a replication job fails.

2017-10-16 Thread Wolfgang Bumiller
This should be tagged [PATCH manager]. Some minor cleanup requests inline: On Fri, Oct 13, 2017 at 10:08:09AM +0200, Wolfgang Link wrote: > A email notification will be send for each job when the job fails. > This message will only send when an error occurs and the fail count is on 1. > --- > PV

[pve-devel] applied: Add logfunc to storage_migrate.

2017-10-16 Thread Wolfgang Bumiller
applied both patches On Tue, Oct 10, 2017 at 09:43:50AM +0200, Wolfgang Link wrote: > This redirect the output form pvesm export to the correct log instead of the > syslog. > > > ___ > pve-devel mailing list > pve-devel@pve.proxmox.com > https://pve.p

[pve-devel] applied: [PATCH manager 1/7] ui: add VM ComboSelector

2017-10-16 Thread Wolfgang Bumiller
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH manager 3/7] ui: ha: make vote warning shorter

2017-10-16 Thread Wolfgang Bumiller
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH manager 2/7] ui: ha: use vmComboSelector when adding new resource

2017-10-16 Thread Wolfgang Bumiller
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH manager] ui: GuestStatusView: simplify HA state display

2017-10-16 Thread Wolfgang Bumiller
applied On Wed, Oct 11, 2017 at 02:10:24PM +0200, Thomas Lamprecht wrote: > simplify HA Information in VM/CT Summary panel. > Use the already translated 'HA State' instead of 'Managed by HA' > (which now becomes obsolete as it was the single appearance). > Simplify PVE.Utils.format_ha respectivel

[pve-devel] applied: [PATCH manager] ui: re-align global search field to now shorter version

2017-10-16 Thread Wolfgang Bumiller
applied On Wed, Oct 11, 2017 at 09:16:23AM +0200, Thomas Lamprecht wrote: > commit 48de6c299a33fe124d7193b2565d754efdbf8cd3 removed showing the > short SHA1 commit hash in the version info field but did not > realigned the search field so that it got a asymmetric space. > > Adapt the Version info

Re: [pve-devel] [PATCH manager 0/7] WebUI: make HA management easier

2017-10-16 Thread Emmanuel Kasper
On 10/16/2017 01:48 PM, Thomas Lamprecht wrote: > On 10/16/2017 01:39 PM, Wolfgang Bumiller wrote: >> On Wed, Oct 11, 2017 at 12:09:40PM +0200, Thomas Lamprecht wrote: >>> First two patches make adding a new services over DC->HA->Add more >>> confortable by switching out the simple VMID integer s

[pve-devel] applied: [PATCH manager] ui: inline novnc: always focus console panel after render

2017-10-16 Thread Wolfgang Bumiller
applied On Thu, Oct 05, 2017 at 02:19:49PM +0200, Thomas Lamprecht wrote: > Enforce focus on the Inline CT/VM/Host Console panel backed by noVNC. > > Else, if a Console is already active on VM A and we select VM B the > console there does not gets the focus as its now in the three and > regaining

[pve-devel] applied: [PATCH qemu v2 0/5] Provides a qemu-system-x86 virtual package

2017-10-16 Thread Wolfgang Bumiller
applied with updated 4/5 v3 On Wed, Oct 11, 2017 at 11:06:04AM +0200, Emmanuel Kasper wrote: > This will allow the installation of extra packages requiring a qemu binary > Bigger use case is libguestfs0 and libguestfs-tools , this has been asked > in a few different forum threads > libguestfs-tool

Re: [pve-devel] [PATCH manager 0/7] WebUI: make HA management easier

2017-10-16 Thread Thomas Lamprecht
On 10/16/2017 01:39 PM, Wolfgang Bumiller wrote: > On Wed, Oct 11, 2017 at 12:09:40PM +0200, Thomas Lamprecht wrote: >> First two patches make adding a new services over DC->HA->Add more >> confortable by switching out the simple VMID integer spinner with a >> combobox grid showing more details for

Re: [pve-devel] [PATCH manager 0/7] WebUI: make HA management easier

2017-10-16 Thread Wolfgang Bumiller
On Wed, Oct 11, 2017 at 12:09:40PM +0200, Thomas Lamprecht wrote: > First two patches make adding a new services over DC->HA->Add more > confortable by switching out the simple VMID integer spinner with a > combobox grid showing more details for each VM/CT, addressing #1517 > Third one is a small c

[pve-devel] [PATCH qemu v3 4/5] Provides a qemu-system-x86 virtual package

2017-10-16 Thread Emmanuel Kasper
This allows adding additional debian packages on pve hosts which depends on a qemu binary being installed. The following install paths were tested: * install of proxmox-ve on debian systems with standard package set: works as expected * install of proxmox-ve on debian having the debian qemu

Re: [pve-devel] [PATCH manager] fix #1531: match nodename exactly for vmidselector

2017-10-16 Thread Thomas Lamprecht
On 10/16/2017 11:08 AM, Dominik Csapak wrote: > else we would get vms for wrong hosts if the nodename is a pre/postfix > of another nodename (e.g. 'abc' and 'abc123') > > Signed-off-by: Dominik Csapak > --- > www/manager6/form/VMSelector.js | 1 + > 1 file changed, 1 insertion(+) > > diff --git

[pve-devel] applied: [PATCH manager] fix #1531: match nodename exactly for vmidselector

2017-10-16 Thread Wolfgang Bumiller
applied On Mon, Oct 16, 2017 at 11:08:45AM +0200, Dominik Csapak wrote: > else we would get vms for wrong hosts if the nodename is a pre/postfix > of another nodename (e.g. 'abc' and 'abc123') > > Signed-off-by: Dominik Csapak > --- > www/manager6/form/VMSelector.js | 1 + > 1 file changed, 1 i

[pve-devel] [PATCH manager] fix #1531: match nodename exactly for vmidselector

2017-10-16 Thread Dominik Csapak
else we would get vms for wrong hosts if the nodename is a pre/postfix of another nodename (e.g. 'abc' and 'abc123') Signed-off-by: Dominik Csapak --- www/manager6/form/VMSelector.js | 1 + 1 file changed, 1 insertion(+) diff --git a/www/manager6/form/VMSelector.js b/www/manager6/form/VMSelecto

Re: [pve-devel] [PATCH qemu v2 0/5] Provides a qemu-system-x86 virtual package

2017-10-16 Thread Emmanuel Kasper
> In general, looks good to me. > > Upstream package provides also the following man pages[1]: > /usr/share/man/man1/qemu-system-i386.1.gz > /usr/share/man/man1/qemu-system-x86_64.1.gz > Which we do not (we have only qemu), would it make sense > to make a link to these? yes makes sense, we shoul

[pve-devel] [PATCH common v2 4/4] Remove deprecated run_cli subroutine

2017-10-16 Thread Philip Abernethy
--- v2: Corrects commit msg src/PVE/CLIHandler.pm | 11 --- 1 file changed, 11 deletions(-) diff --git a/src/PVE/CLIHandler.pm b/src/PVE/CLIHandler.pm index e61fa6a..77c71a4 100644 --- a/src/PVE/CLIHandler.pm +++ b/src/PVE/CLIHandler.pm @@ -472,17 +472,6 @@ my $handle_simple_cmd = sub {

[pve-devel] [PATCH ha-manager 2/4] Use run_cli_handler instead of deprecated run_cli

2017-10-16 Thread Philip Abernethy
--- src/pve-ha-crm | 2 +- src/pve-ha-lrm | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pve-ha-crm b/src/pve-ha-crm index 93dfc1f..6454f3d 100755 --- a/src/pve-ha-crm +++ b/src/pve-ha-crm @@ -26,4 +26,4 @@ my $prepare = sub { }; -PVE::Service::pve_ha_crm->run_cli(

[pve-devel] [PATCH common 4/4] Use run_cli_handler instead of deprecated run_cli

2017-10-16 Thread Philip Abernethy
--- src/PVE/CLIHandler.pm | 11 --- 1 file changed, 11 deletions(-) diff --git a/src/PVE/CLIHandler.pm b/src/PVE/CLIHandler.pm index e61fa6a..77c71a4 100644 --- a/src/PVE/CLIHandler.pm +++ b/src/PVE/CLIHandler.pm @@ -472,17 +472,6 @@ my $handle_simple_cmd = sub { &$outsub($res) if $o

[pve-devel] [PATCH manager 3/4] Use run_cli_handler instead of deprecated run_cli

2017-10-16 Thread Philip Abernethy
--- bin/pveam | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/pveam b/bin/pveam index 8b55adfa..43608e5f 100755 --- a/bin/pveam +++ b/bin/pveam @@ -5,4 +5,4 @@ use warnings; use PVE::CLI::pveam; -PVE::CLI::pveam->run_cli(); +PVE::CLI::pveam->run_cli_handler(); -- 2.11

[pve-devel] [PATCH firewall 1/4] Use run_cli_handler instead of deprecated run_cli

2017-10-16 Thread Philip Abernethy
--- src/pve-firewall | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pve-firewall b/src/pve-firewall index 0fbef27..601d638 100755 --- a/src/pve-firewall +++ b/src/pve-firewall @@ -22,4 +22,4 @@ my $prepare = sub { $rpcenv->set_user('root@pam'); }; -PVE::Service::pv

[pve-devel] [PATCH common 0/4] Retire deprecated run_cli subroutine

2017-10-16 Thread Philip Abernethy
Migrates the few remaining calls to the new run_cli_handler and removes the function. Philip Abernethy (1): Use run_cli_handler instead of deprecated run_cli src/pve-firewall | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.11.0 ___ pv

Re: [pve-devel] [PATCH qemu v2 0/5] Provides a qemu-system-x86 virtual package

2017-10-16 Thread Thomas Lamprecht
On 10/11/2017 11:06 AM, Emmanuel Kasper wrote: > This will allow the installation of extra packages requiring a qemu binary > Bigger use case is libguestfs0 and libguestfs-tools , this has been asked > in a few different forum threads > libguestfs-tools allow to inspect and edit disk images of offl

[pve-devel] [PATCH common v4 1/3] cli: prepare CLIHandler for handling sub-commands

2017-10-16 Thread Philip Abernethy
instead of 5 slightly different calls to RESTHandler::usage_str this introduces a wrapper function that handles all required cases and is capable of resolving sub-commands and aliases. Adds a subroutine to print the short help for a command in case no subcommand was given. Modifies handle_cmd and p

[pve-devel] [PATCH common v4 0/3] CLI: Sub-commands and aliases

2017-10-16 Thread Philip Abernethy
This patch (1/3 is the effective part) adds support for sub-commands in the form of `pveum user add `, as well as aliases, so the prior format can still be used. It correctly parses the current command format as well and, to my knowledge,generates identical help texts, man-pages and html-docs. It s

[pve-devel] [PATCH common v4 3/3] cli: whitespace cleanup

2017-10-16 Thread Philip Abernethy
--- src/PVE/CLIHandler.pm | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/PVE/CLIHandler.pm b/src/PVE/CLIHandler.pm index ac83972..0dc50e8 100644 --- a/src/PVE/CLIHandler.pm +++ b/src/PVE/CLIHandler.pm @@ -162,12 +162,12 @@ $generate_usage_str = sub { }; __PA

[pve-devel] [PATCH common v4 2/3] cli: code cleanup

2017-10-16 Thread Philip Abernethy
Removes obsolete subroutine and unused Dumper --- src/PVE/CLIHandler.pm | 24 1 file changed, 24 deletions(-) diff --git a/src/PVE/CLIHandler.pm b/src/PVE/CLIHandler.pm index 84cefa3..ac83972 100644 --- a/src/PVE/CLIHandler.pm +++ b/src/PVE/CLIHandler.pm @@ -2,7 +2,6 @@ p

Re: [pve-devel] Include dpkg-reconfigure in Makefile

2017-10-16 Thread Emmanuel Kasper
On 10/13/2017 08:13 AM, Thomas wrote: > Hello! > > How can I include /dpkg-reconfigure tzdata/ (Europe/Berlin) and > /dpkg-reconfigure/ locales (de_DE.UTF-8) in the Makefile? Hi Thomas Not sure I understand your question because server specific setup is usually not done with Make. You should eit

Re: [pve-devel] [PATCH manager v4 0/8] Display the SCSI controller type when adding a new disk

2017-10-16 Thread Thomas Lamprecht
On 10/02/2017 10:37 AM, Emmanuel Kasper wrote: > Since we switched to the SCSI controller in the Wizard as the recommended > controller > for hard disks (using VirtIO scsi in the backend) it was not clear for users > that they were actually using a paravirtualized driver. > > An example of user c

Re: [pve-devel] [PATCH container] add vm_stop helper

2017-10-16 Thread Wolfgang Bumiller
On Fri, Oct 13, 2017 at 04:12:03PM +0200, Dietmar Maurer wrote: > > +# Helper to stop a container completely and make sure it has stopped > > completely. > > +# This is necessary because we want the post-stop hook to have completed > > its > > +# unmount-all step, but post-stop happens after lxc p