[pve-devel] [PATCH docs] fix #1818: use NTP instead of Servers in timesyncd.conf

2018-06-20 Thread Wolfgang Bumiller
'Servers' should still work but it was changed to 'NTP' quite a while ago... Signed-off-by: Wolfgang Bumiller --- system-timesync.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/system-timesync.adoc b/system-timesync.adoc index e307883..c64455c 100644 --- a/system-timesy

[pve-devel] applied: [PATCH docs] fix #1818: use NTP instead of Servers in timesyncd.conf

2018-06-20 Thread Thomas Lamprecht
On 6/20/18 9:50 AM, Wolfgang Bumiller wrote: > 'Servers' should still work but it was changed to 'NTP' > quite a while ago... > > Signed-off-by: Wolfgang Bumiller > --- > system-timesync.adoc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/system-timesync.adoc b/system-

[pve-devel] applied: [PATCH librados2-perl] Make error messages in Rados.pm prettier

2018-06-20 Thread Thomas Lamprecht
On 6/18/18 6:12 PM, Alwin Antreich wrote: > Signed-off-by: Alwin Antreich > --- > PVE/RADOS.pm | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/PVE/RADOS.pm b/PVE/RADOS.pm > index d53f655..d9e2e3b 100644 > --- a/PVE/RADOS.pm > +++ b/PVE/RADOS.pm > @@ -99,7 +99,7 @@

Re: [pve-devel] [PATCH v2 pve-common 4/4] Inotify : write network config : remove allow- ovs with ifupdown2

2018-06-20 Thread Wolfgang Bumiller
On Wed, Jun 20, 2018 at 07:36:57AM +0200, Alexandre Derumier wrote: > --- > src/PVE/INotify.pm | 17 - > 1 file changed, 12 insertions(+), 5 deletions(-) > > diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm > index 94712d5..48630ae 100644 > --- a/src/PVE/INotify.pm > +++ b/src

Re: [pve-devel] [PATCH v2 pve-common 3/4] Inotify : write network config : add bridge-vids

2018-06-20 Thread Wolfgang Bumiller
On Wed, Jun 20, 2018 at 07:36:56AM +0200, Alexandre Derumier wrote: > default is 2-4094 if user don't have specified. > > mandatory for ifupdown2 and compatible with > current promox ifupdown bridgevlanport script > --- > src/PVE/INotify.pm | 5 - > 1 file changed, 4 insertions(+), 1 deletion

[pve-devel] applied: [PATCH v2 pve-common 0/4] network config improvements

2018-06-20 Thread Wolfgang Bumiller
applied with the followup fix I posted earlier On Wed, Jun 20, 2018 at 07:36:53AM +0200, Alexandre Derumier wrote: > > changelog v2 : > > - remove allow-... when ifupdown2 is used > > This patches series cleanup /etc/network/interfaces > > - replace network options _ by - > - replace slaves b

[pve-devel] [PATCH pve-client] Handle errors on tasks correctly with a die,

2018-06-20 Thread René Jochum
so we get the correct exit code on errors. Signed-off-by: René Jochum --- PVE/APIClient/Helpers.pm | 4 1 file changed, 4 insertions(+) diff --git a/PVE/APIClient/Helpers.pm b/PVE/APIClient/Helpers.pm index 7d855ec..5c2e4cb 100644 --- a/PVE/APIClient/Helpers.pm +++ b/PVE/APIClient/Helpers.

[pve-devel] [PATCH manager v2] ACMEv2 order "ready" status update

2018-06-20 Thread Dominik Csapak
since letsencrypt updates their implementation to the ACMEv2 spec [1], we should correctly parse the order status 1: https://community.letsencrypt.org/t/acmev2-order-ready-status/62866 note that we (for now) try to be compatbile to both versions, with and without ready state, this can be changed

[pve-devel] applied: [PATCH pve-client] Handle errors on tasks correctly with a die,

2018-06-20 Thread Dietmar Maurer
applied > On June 20, 2018 at 11:46 AM René Jochum wrote: > > > so we get the correct exit code on errors. > > Signed-off-by: René Jochum > --- > PVE/APIClient/Helpers.pm | 4 > 1 file changed, 4 insertions(+) > > diff --git a/PVE/APIClient/Helpers.pm b/PVE/APIClient/Helpers.pm > index

[pve-devel] cleanup and directory structure refactoring

2018-06-20 Thread Thomas Lamprecht
Removing some not really needed files. Trying to cleanup the directory structure, e.g., having the test in bin makes no sense, init.d is outated since a long time, putting all those little network if-* helper scripts in its own directory seems reasonable. I had this in mind since quite a bit and f

[pve-devel] [PATCH manager 2/6] cleanup: replace repoid.pl script by simple git commands

2018-06-20 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- Makefile | 3 ++- repoid.pl | 40 2 files changed, 2 insertions(+), 41 deletions(-) delete mode 100755 repoid.pl diff --git a/Makefile b/Makefile index 433b6069..0904db07 100644 --- a/Makefile +++ b/Makefile @@ -36,7

[pve-devel] [PATCH manager 1/6] buildsys: remove wildcard target from Makefile

2018-06-20 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- Makefile | 3 --- 1 file changed, 3 deletions(-) diff --git a/Makefile b/Makefile index 6cf32a95..433b6069 100644 --- a/Makefile +++ b/Makefile @@ -16,9 +16,6 @@ all: ${SUBDIRS} check: ${MAKE} -C bin/test check -%: - set -e && for i in ${SUBDI

[pve-devel] [PATCH manager 4/6] cleanup: add configs directory and move respective files

2018-06-20 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- Makefile | 15 ++- configs/Makefile | 19 +++ country.pl => configs/country.pl | 0 pve-apt.conf => configs/pve-apt.conf | 0 .../pve-blacklist

[pve-devel] [PATCH manager 3/6] cleanup: rename bin/init.d to services

2018-06-20 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- Makefile | 2 +- bin/Makefile | 2 +- {bin/init.d => services}/Makefile| 2 +- {bin/init.d => services}/ceph-after-pve-cluster.conf | 0 {bin/init.d => servi

[pve-devel] [PATCH manager 6/6] cleanup: move bin/test to toplevel

2018-06-20 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- Makefile | 4 ++-- bin/Makefile | 6 -- {bin/test => test}/Makefile | 6 +++--- {bin/test => test}/ReplicationTestEnv.pm | 0 {bin/test => test}/balloontest.pl| 0 {bin/test =>

[pve-devel] [PATCH manager 5/6] cleanup: add network-hooks directory and move respective files

2018-06-20 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- Makefile | 11 ++- network-hooks/Makefile | 13 + bridgevlan => network-hooks/bridgevlan | 0 bridgevlanport => network-hooks/bridgevlanport | 0 mtu => network-hooks/mt

Re: [pve-devel] [PATCH manager v4 1/2] Cephfs storage wizard

2018-06-20 Thread Thomas Lamprecht
On 6/18/18 7:49 PM, Alwin Antreich wrote: > Add internal and external storage wizard for cephfs > > Signed-off-by: Alwin Antreich > --- > www/manager6/Makefile | 1 + > www/manager6/Utils.js | 10 ++ > www/manager6/storage/CephFSEdit.js | 71 > +++

Re: [pve-devel] [PATCH storage v4 4/4] Cephfs storage plugin

2018-06-20 Thread Thomas Lamprecht
On 6/18/18 7:49 PM, Alwin Antreich wrote: > - ability to mount through kernel and fuse client > - allow mount options > - get MONs from ceph config if not in storage.cfg > - allow the use of ceph config with fuse client > > Signed-off-by: Alwin Antreich > --- > PVE/API2/Storage/Config.pm |

[pve-devel] [PATCH manager] buildsys: remove excess directory creations

2018-06-20 Thread Wolfgang Bumiller
/usr/share/$(PACKAGE) is used for country.dat, installed with -D /usr/share/man/man1 is defined as $(MAN1DIR) in defines.mk and already created in bin/Makefile where it is actually used. Signed-off-by: Wolfgang Bumiller --- Makefile | 2 -- 1 file changed, 2 deletions(-) diff --git a/Makefile b

[pve-devel] applied: cleanup and directory structure refactoring

2018-06-20 Thread Wolfgang Bumiller
applied On Wed, Jun 20, 2018 at 12:46:57PM +0200, Thomas Lamprecht wrote: > Removing some not really needed files. > Trying to cleanup the directory structure, e.g., having the test in bin > makes no sense, init.d is outated since a long time, putting all those > little network if-* helper scripts

[pve-devel] [PATCH common] CLIHandler: bugfix print_text_table

2018-06-20 Thread Stoiko Ivanov
Default to printing '', if no default is provided for a column. Signed-off-by: Stoiko Ivanov --- src/PVE/CLIHandler.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/CLIHandler.pm b/src/PVE/CLIHandler.pm index c68aae8..206fda0 100644 --- a/src/PVE/CLIHandler.pm +++ b

[pve-devel] applied: [PATCH common] CLIHandler: bugfix print_text_table

2018-06-20 Thread Thomas Lamprecht
On 6/20/18 1:28 PM, Stoiko Ivanov wrote: > Default to printing '', if no default is provided for a column. > > Signed-off-by: Stoiko Ivanov > --- > src/PVE/CLIHandler.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/PVE/CLIHandler.pm b/src/PVE/CLIHandler.pm > inde

[pve-devel] [RFC pve-client] Add configureable defaults to "lxc create"

2018-06-20 Thread René Jochum
The given patch adds configureable defaults to lxc create, I don't like how it handles defaults that are given by pveclient and I don't know ConfigParser well enough to come up with another solution. --- PVE/APIClient/Commands/lxc.pm | 16 ++-- PVE/APIClient/Config.pm | 22 ++

[pve-devel] applied: [PATCH manager] buildsys: remove excess directory creations

2018-06-20 Thread Thomas Lamprecht
On 6/20/18 1:18 PM, Wolfgang Bumiller wrote: > /usr/share/$(PACKAGE) is used for country.dat, installed > with -D > /usr/share/man/man1 is defined as $(MAN1DIR) in > defines.mk and already created in bin/Makefile where it is > actually used. > > Signed-off-by: Wolfgang Bumiller > --- > Makefile

[pve-devel] [RFC pve-client] Add configureable defaults to "lxc create"

2018-06-20 Thread René Jochum
On 2018-06-20 14:35, René Jochum wrote: > The given patch adds configureable defaults to lxc create, > I don't like how it handles defaults that are given by pveclient > and I don't know ConfigParser well enough to come up with another > solution. > --- > PVE/APIClient/Commands/lxc.pm | 16 +++

Re: [pve-devel] [PATCH v4 storage/manager] Cephfs storage plugin

2018-06-20 Thread Thomas Lamprecht
On 6/18/18 7:49 PM, Alwin Antreich wrote: > This patch series is an update and adds the Cephfs to our list of storages. > You can mount the storage through the kernel or fuse client. The plugin for > now allows all content formats, but this needs further testing. > > Config and keyfile locations a

[pve-devel] [RFC pve-manager] ui: storage: combine RBD external and hyperconverged add dialog

2018-06-20 Thread Thomas Lamprecht
We have a growing list of storages we can add. RBD and the upcoming CephFS have additionally the difference between hyperconverged PVE managed and external managed one. This makes the list quite long and not very user friendly. This proposes to combine the both dialogues in a single one, with a ch

[pve-devel] [PATCH v2 ifupdown2] remove upstreamed patches

2018-06-20 Thread Alexandre Derumier
Almost all patches have been upstreamed. we only have proxmox specific patches now 0001-config-tuning.patch 0002-don-t-remove-tap-veth-fwpr-interfaces-from-bridge-on.patch 0003-add-dummy-mtu-bridgevlanport-modules.patch --- ...ns-scripts-fix-ENV-for-interfaces-options.patch | 29 .../extra/

Re: [pve-devel] [RFC pve-client] Add configureable defaults to "lxc create"

2018-06-20 Thread Dietmar Maurer
> The given patch adds configureable defaults to lxc create, In general, different clusters (remotes) use different node and storage names. So it does not really make sense to use global defaults for that. Instead, we need defaults for each remote? ___

Re: [pve-devel] [RFC pve-client] Add configureable defaults to "lxc create"

2018-06-20 Thread René Jochum
On 2018-06-21 06:31, Dietmar Maurer wrote: >> The given patch adds configureable defaults to lxc create, > In general, different clusters (remotes) use different node > and storage names. So it does not really make sense to use > global defaults for that. Instead, we need defaults for > each remot