[pve-devel] [PATCH pve-kernel 1/3] Add 3 Patches addressing security issues

2018-11-14 Thread Stoiko Ivanov
* CVE-2018-18955 (https://launchpad.net/bugs/1801924) is addressed by 0009-userns-also-map-extents-in-the-reverse-map-to-kernel.patch * https://launchpad.net/bugs/1789161 is addressed by the other 2 patches. (see the link for a reproducer) Signed-off-by: Stoiko Ivanov --- ...extents-in-the-r

[pve-devel] [PATCH pve-kernel 2/3] update ZFS on Linux to 0.7.12

2018-11-14 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- submodules/zfsonlinux | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/submodules/zfsonlinux b/submodules/zfsonlinux index 851f368..65a9766 16 --- a/submodules/zfsonlinux +++ b/submodules/zfsonlinux @@ -1 +1 @@ -Subproject commit 851f3685395

[pve-devel] [PATCH pve-kernel 3/3] bump version to 4.15.18-30

2018-11-14 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- Makefile | 2 +- debian/changelog | 7 +++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index b8a7454..c7d17ab 100644 --- a/Makefile +++ b/Makefile @@ -6,7 +6,7 @@ KERNEL_PATCHLEVEL=18 # rebuild packages with new K

[pve-devel] [PATCH pve-kernel 0/3] add 2 security fixes and update ZFS

2018-11-14 Thread Stoiko Ivanov
Today 2 security related patchsets were sent over the Ubuntu Kernel ML, both addressing issues in user- and mountnamespaces (Thanks @Fabian for pointing them out!) Since the other commits from Ubuntu-4.15.0-40.43 onwards had no security implications I cherry-picked the 3 relevant commits. Additio

[pve-devel] [PATCH zfsonlinux 1/3] update/rebase to spl-0.7.12 with patches from ZOL

2018-11-14 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- ...fine-timestruc_t-for-Lustre-compatibility.patch | 34 + ...ackport-vnode.h-changes-from-zfs-93ce2b4c.patch | 35 + ...005-Linux-4.20-compat-current_kernel_time.patch | 40 +++ ...ldRequires-gcc-make-elfutils-libelf-devel.patc

[pve-devel] [PATCH zfsonlinux 0/3] update ZFS+SPL to 0.7.12

2018-11-14 Thread Stoiko Ivanov
This patchset pulls in the changes from 0.7.11..0.7.12 from ZOL-upstream. Additionally I reordered the zfs-patches putting the cherry-picked changes last. Stoiko Ivanov (3): update/rebase to spl-0.7.12 with patches from ZOL update/rebase to zfs-0.7.12 with patches from ZOL bump version to 0.

[pve-devel] [PATCH zfsonlinux 3/3] bump version to 0.7.12-pve1~bpo1

2018-11-14 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- Makefile | 6 +++--- spl-changelog.Debian | 6 ++ zfs-changelog.Debian | 6 ++ 3 files changed, 15 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 52a2d25..6461893 100644 --- a/Makefile +++ b/Makefile @@ -2,9 +2,9 @@ RELEA

[pve-devel] [PATCH docs] fix #1138: installation: note how one can progress with keyboard only

2018-11-14 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- pve-installation.adoc | 5 + 1 file changed, 5 insertions(+) diff --git a/pve-installation.adoc b/pve-installation.adoc index 0f2d012..f22b808 100644 --- a/pve-installation.adoc +++ b/pve-installation.adoc @@ -59,6 +59,11 @@ Install Proxmox VE:: Start n

Re: [pve-devel] [PATCH qemu-server 1/7] api2 : migrate_vm : add migration_type "external"

2018-11-14 Thread Alexandre DERUMIER
>>@Alexandre: please set the permissions to root@pam only for this new API >>path. yes, sure. >>I see the following problematic aspects otherwise: >>- potential back channel from a user/attacker-controlled target host to >>the source node via bugs in Qemu (might not even require a bug?) >>-

[pve-devel] [PATCH pve-docs] Remove SCSI exclusivity from "Discard" drive option

2018-11-14 Thread Nick Chevsky
This documents the recent move [1] to make the formerly SCSI-exclusive "Discard" option also available to IDE and SATA drives, and explains its dependency on either VirtIO SCSI or SSD emulation [2]. [1] https://git.proxmox.com/?p=pve-manager.git;a=commit;h=ee4b837692bf3d0f50b6cb8f29a5272e9a632430

[pve-devel] [PATCH storage] fix #862: do not resolve portal adress on storage add

2018-11-14 Thread Thomas Lamprecht
as described in #862: > I experienced a problem with ISCSI portal when using a hostname and > not IP. > The GUI resolves the hostname to an IP and writes it to storage.cfg. > As my setup requires hostnames, i needed to change the config > manually back to the hostname which is working fine. > > Wh

[pve-devel] applied: [RFC manager] add help button to 'My Settings' window

2018-11-14 Thread Thomas Lamprecht
On 11/13/18 1:48 PM, David Limbeck wrote: > link to 'gui_my_settings' in docs > > Signed-off-by: David Limbeck > --- > www/manager6/window/Settings.js | 19 +-- > 1 file changed, 13 insertions(+), 6 deletions(-) > > diff --git a/www/manager6/window/Settings.js b/www/manager6/win

[pve-devel] applied: [PATCH qemu-server v6 0/3] add qmeventd

2018-11-14 Thread Wolfgang Bumiller
applied series On Wed, Nov 14, 2018 at 02:59:55PM +0100, Dominik Csapak wrote: > this series adds qmeventd, a binary which listens on a socket > and waits for qemu to connect to it, and thenfor the shutdown event of qemu > > i use this to execute 'qm cleanup' when a vm exits, and can detect > if

[pve-devel] applied: [PATCH docs v5 1/1] add qmeventd manpage

2018-11-14 Thread Wolfgang Bumiller
applied On Fri, Nov 09, 2018 at 11:05:42AM +0100, Dominik Csapak wrote: > Signed-off-by: Dominik Csapak > --- > Makefile | 3 ++- > pve-doc-generator.mk.in | 2 +- > qmeventd.8-synopsis.adoc | 16 > qmeventd.adoc| 33 +++

Re: [pve-devel] [PATCH 0/2] return cluster name on successful login if available

2018-11-14 Thread Dominik Csapak
On 11/13/18 12:06 PM, Thomas Lamprecht wrote: This two patches fix #233 and #1358 which are somewhat related. The, a bit dusty, #233 requested to have the cluster name returned when getting a ticket. This is useful information for API clients and thus I followed up and return this info, for succ

[pve-devel] [PATCH qemu-server v6 2/3] add 'qm cleanup'

2018-11-14 Thread Dominik Csapak
this is intended to be used with qmeventd, to do the necessary cleanups when qemu crashes or is being shut down from within the guest this can also be the point where we could introduce shutdown/stop/reboot hooks Signed-off-by: Dominik Csapak --- PVE/CLI/qm.pm | 62 +

[pve-devel] [PATCH qemu-server v6 1/3] add qmeventd

2018-11-14 Thread Dominik Csapak
this adds a program that can listen to qemu qmp events on a given socket and if a shutdown event followed by a disconnected socket occurs, executes qm cleanup with arguments that indicate if the vm was closed gracefully and whether the guest initiated it this is useful if we want to cleanup after

[pve-devel] [PATCH qemu-server v6 3/3] use qmeventd to execute qm cleanup

2018-11-14 Thread Dominik Csapak
we reverse the direction of the event socket (this does not prevent live migration) and point it to wher qmeventd listens Signed-off-by: Dominik Csapak --- changes from v5: * fixed path to socket PVE/QemuServer.pm | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/PVE/QemuSer

[pve-devel] [PATCH qemu-server v6 0/3] add qmeventd

2018-11-14 Thread Dominik Csapak
this series adds qmeventd, a binary which listens on a socket and waits for qemu to connect to it, and thenfor the shutdown event of qemu i use this to execute 'qm cleanup' when a vm exits, and can detect if a qemu crashed/was stopped from within/etc. like i discussed this with wolfgang off-list,

[pve-devel] [PATCH storage] LVM: lock on volume_resize

2018-11-14 Thread Thomas Lamprecht
This is important for shared LVM storages. As with deletes and creates of images, as else we may have not the up-to-date metadata and extents may get reused if another node created an image during the same time, for example. Signed-off-by: Thomas Lamprecht --- PVE/Storage/LVMPlugin.pm | 5 -

[pve-devel] [PATCH ceph 1/2] build: add dsc target

2018-11-14 Thread Fabian Grünbichler
to build a source package Signed-off-by: Fabian Grünbichler --- Makefile | 31 +-- 1 file changed, 21 insertions(+), 10 deletions(-) diff --git a/Makefile b/Makefile index 94633d15c..a3a2f68e9 100644 --- a/Makefile +++ b/Makefile @@ -66,26 +66,37 @@ rbd-mirror_${VER}

[pve-devel] [PATCH ceph 2/2] patches: remove fuzz and re-format

2018-11-14 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- patches/0001-update-changelog.patch | 12 +- .../0002-cmake-disable-version-from-git.patch | 5 +--- ...03-enable-systemd-targets-by-default.patch | 5 +--- patches/0004-enable-LZ4-support.patch | 9 +++- ...sync-rdma-uninitia

[pve-devel] [PATCH common] fix #1548: replace perl use vars with our

2018-11-14 Thread Tim Marx
replace deprecated 'use vars qw($frob @mung %seen);' with the now in favor 'our $foo;' declaration see NOTE at: http://perldoc.perl.org/vars.html Signed-off-by: Tim Marx --- src/PVE/AtomicFile.pm | 3 +-- src/PVE/Exception.pm | 7 ++- src/PVE/SafeSyslog.pm | 11 +++ 3 files change

[pve-devel] [PATCH manager 0/2] MDS create/destroy & CephFS create

2018-11-14 Thread Alwin Antreich
This series adds some management of CephFS to the pveceph CLI. * Create/destroy Ceph MDS instances * Create a cephfs filesystem, including needed pools The new API endpoint 'fs' exists already, but has no functionallity. This part is not finished yet. I am sending this part already, so I can

[pve-devel] [PATCH manager 1/2] Create/destroy Ceph MDS

2018-11-14 Thread Alwin Antreich
* introduce generic ceph service create/destroy methods * add API for createmds/destroymds * add createmds/destroymds to pveceph CLI Signed-off-by: Alwin Antreich --- PVE/API2/Makefile | 1 + PVE/API2/Ceph.pm | 6 +++ PVE/API2/CephFS.pm | 131 ++

[pve-devel] [PATCH manager 2/2] Add createcephfs to pveceph

2018-11-14 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- PVE/API2/CephFS.pm | 81 ++ PVE/CLI/pveceph.pm | 1 + 2 files changed, 82 insertions(+) diff --git a/PVE/API2/CephFS.pm b/PVE/API2/CephFS.pm index b1c32b4f..fd4d7154 100644 --- a/PVE/API2/CephFS.pm +++ b/PVE/A

Re: [pve-devel] [PATCH guest-common] Bash completion helper for snapshot name

2018-11-14 Thread Thomas Lamprecht
On 11/12/18 2:58 PM, Rhonda D'Vine wrote: > This is the bash completion helper function for completing the snapshot > name. This is used both in qemu-server and pve-container. > > This patch is the base for the patches in qemu-server and pve-container. > > Signed-off-by: Rhonda D'Vine > --- >

[pve-devel] applied: [PATCH qemu-server 2/2] Add missing Build-Depends

2018-11-14 Thread Thomas Lamprecht
On 11/12/18 2:59 PM, Rhonda D'Vine wrote: > These were found while building the package within a clean chroot. > > Signed-off-by: Rhonda D'Vine > --- > debian/control | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/debian/control b/debian/control > index 45d7855..dc1a2bd 100644 >

Re: [pve-devel] [PATCH qemu-server 1/2] Fix #1924: add snapshot parameter

2018-11-14 Thread Thomas Lamprecht
On 11/12/18 2:59 PM, Rhonda D'Vine wrote: > The config and showcmd CLI commands offer the config and showcmd > functions. Both of that outputs may vary with respect to a given > snapshot. This adds a switch that shows the corresponding snapshot's > config and command line. > > This patch needs the

Re: [pve-devel] [PATCH qemu-server 1/7] api2 : migrate_vm : add migration_type "external"

2018-11-14 Thread Fabian Grünbichler
On Tue, Nov 13, 2018 at 11:22:23AM +0100, Dietmar Maurer wrote: > I would like to move forward with that, but changing an existing API makes > that difficult. > > I would suggest to add a second API entry point instead: > > __PACKAGE__->register_method({ > name => 'external_migrate_vm', >

Re: [pve-devel] [PATCH qemu-server 1/7] api2 : migrate_vm : add migration_type "external"

2018-11-14 Thread Dominik Csapak
On 11/14/18 11:15 AM, Dietmar Maurer wrote: Feel free to choose a better name ;-) We can the mark this API as unstable/experimental, and modify the parameters/types. IMHO most existing parameters does not really makes sense with external migration. I guess it is still possible to factor out mos

Re: [pve-devel] [PATCH qemu-server 1/7] api2 : migrate_vm : add migration_type "external"

2018-11-14 Thread Dietmar Maurer
> >>Feel free to choose a better name ;-) We can the mark this API as > >>unstable/experimental, and modify > >>the parameters/types. IMHO most existing parameters does not really makes > >>sense with external migration. > >>I guess it is still possible to factor out most common code to avoid c

[pve-devel] applied: [PATCH guest-common 0/6] dsc target and general cleanup

2018-11-14 Thread Thomas Lamprecht
On 10/24/18 10:19 AM, Fabian Grünbichler wrote: > Fabian Grünbichler (6): > build: add dsc target > d/control: bump standards version > d/control: wrap-and-sort > d/control|compat: bump to 10 > d/control: add misc:Depends > d/control: remove perl from build-depends > > Makefile

[pve-devel] applied: [PATCH v2 firewall 2/2] Add missing Build-Depends

2018-11-14 Thread Thomas Lamprecht
On 11/12/18 3:14 PM, Rhonda D'Vine wrote: > Found while building in a clean chroot. > > Signed-off-by: Rhonda D'Vine > --- > debian/control | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/debian/control b/debian/control > index e959ae3..a68a81c 100644 > --- a/debian/control > +++ b/d

[pve-devel] applied: [PATCH v2 firewall 1/2] Fix #1971: display firewall rule properties

2018-11-14 Thread Thomas Lamprecht
On 11/12/18 3:14 PM, Rhonda D'Vine wrote: > This is the list of the properties that should get returned in the > pretty print format, too, not just in yaml/json output. > > Signed-off-by: Rhonda D'Vine > --- > src/PVE/API2/Firewall/Rules.pm | 48 > +- > 1

[pve-devel] [PATCH qemu-server v2 4/5] implement iommu check

2018-11-14 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- new in v2 PVE/QemuServer/PCI.pm | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/PVE/QemuServer/PCI.pm b/PVE/QemuServer/PCI.pm index 4de781e..57d2f5c 100644 --- a/PVE/QemuServer/PCI.pm +++ b/PVE/QemuServer/PCI.pm @@ -184,12 +184,8 @@ su

[pve-devel] [PATCH qemu-server v2 2/5] refactor pci regex

2018-11-14 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- changes from v1: * new in v2 * correct use of regex in lspci PVE/QemuServer/PCI.pm | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/PVE/QemuServer/PCI.pm b/PVE/QemuServer/PCI.pm index 7f5a4bf..4d75028 100644 --- a/PVE/QemuServer/PCI.pm

[pve-devel] [PATCH qemu-server v2 5/5] add mediated devices support

2018-11-14 Thread Dominik Csapak
with this, we are able to create and use mediated devices, which include Intel GVT-g (aka KVMGT) and Nvidia vGPUs, and probably more types of devices in the future Signed-off-by: Dominik Csapak --- changes from v1: * improved cleanup loop * fixed error message for not available instances PVE/Qe

[pve-devel] [PATCH qemu-server v2 3/5] implement filter in lspci

2018-11-14 Thread Dominik Csapak
use the first parameter as a filter for devices, since it is used that way Signed-off-by: Dominik Csapak --- new in v2 PVE/QemuServer/PCI.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/PVE/QemuServer/PCI.pm b/PVE/QemuServer/PCI.pm index 4d75028..4de781e 100644 --- a/PVE/QemuServer/PCI.

[pve-devel] [PATCH qemu-server v2 0/5] add mediated devices/vgpu support

2018-11-14 Thread Dominik Csapak
this series adds backend support for mediated devices (aka vGPU,GVT-g) we add a new property for hostpci devices which then autocreates an instance of the specified type later, i will send patches for the gui integration, which will depend on this series also this series makes only real sense if

[pve-devel] [PATCH qemu-server v2 1/5] move pci related subs to QemuServer/PCI.pm

2018-11-14 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- changes from v1: * only code move, no refactor/optimize PVE/QemuServer.pm | 157 +++--- PVE/QemuServer/PCI.pm | 149 +++ 2 files changed, 156 insertions(+), 150 deletions

[pve-devel] applied: [PATCH changeme] Enable "Discard" option for IDE and SATA drives

2018-11-14 Thread Thomas Lamprecht
On 11/14/18 5:42 AM, Nick Chevsky wrote: > Even though QEMU supports the discard feature for both ATA [1] and > SCSI drives, the "Discard" checkbox in Proxmox VE is artificially > restricted to SCSI drives. This change expands availability of the > "Discard" checkbox to all drive types supported by