[pve-devel] pve-firewall : log conntrack sessions ?

2018-11-20 Thread Alexandre DERUMIER
Hi, I'm currently to finally use proxmox firewall in production next year, and I missing piece is session logging (create in conntrack, end in conntrack). It's currently possible with ulogd2, but ulogd2 don't start with pve fw logger is running. I have found a blog about it: https://home.reg

Re: [pve-devel] [PATCH common/qemu-server/manager v2] add mdev support and passthrough gui

2018-11-20 Thread Thomas Lamprecht
On 11/20/18 5:13 PM, Dominik Csapak wrote: > this series add support for mediated devices, such as Nvidias vGPUs and > Intels KVMgt (aka GVT-g), as well as gui support for PCI passthrough > in general > > this needs my 'cleanup and refactor mania series'[1] and supersedes my > previous 'scan clean

[pve-devel] [PATCH manager 4/6 v2] gui: add MDevSelector

2018-11-20 Thread Dominik Csapak
this is used to select a mediated device type Signed-off-by: Dominik Csapak --- www/manager6/Makefile | 1 + www/manager6/form/MDevSelector.js | 102 ++ 2 files changed, 103 insertions(+) create mode 100644 www/manager6/form/MDevSelector.js dif

[pve-devel] [PATCH qemu-server 1/2 v2] add mediated devices support

2018-11-20 Thread Dominik Csapak
with this, we are able to create and use mediated devices, which include Intel GVT-g (aka KVMGT) and Nvidia vGPUs, and probably more types of devices in the future Signed-off-by: Dominik Csapak --- changes from v1: * hardcoded sysfspath because we do not have the variable anymore PVE/QemuServer.

[pve-devel] [PATCH common/qemu-server/manager v2] add mdev support and passthrough gui

2018-11-20 Thread Dominik Csapak
this series add support for mediated devices, such as Nvidias vGPUs and Intels KVMgt (aka GVT-g), as well as gui support for PCI passthrough in general this needs my 'cleanup and refactor mania series'[1] and supersedes my previous 'scan cleanup/gui pci passthrough' series [2] and my 'add mediated

[pve-devel] [PATCH manager 5/6 v2] gui: add qemu/PCIEdit.js

2018-11-20 Thread Dominik Csapak
this patch adds the PCIEdit window and InputPanel uses PCISelector and MDevSelector when we detect an iommugroup of -1, we put a warning on top to inform the user that IOMMU is not activated (but let him add the devices regardless, so that he can use it after IOMMU is activated) also puts a warni

[pve-devel] [PATCH manager 2/6 v2] Scan.pm: add mdev scan api call

2018-11-20 Thread Dominik Csapak
this is for the gui to be able to select mediated devices Signed-off-by: Dominik Csapak --- PVE/API2/Scan.pm | 48 1 file changed, 48 insertions(+) diff --git a/PVE/API2/Scan.pm b/PVE/API2/Scan.pm index 15c8b48a..7435915d 100644 --- a/PVE/API2/Sc

[pve-devel] [PATCH manager 6/6 v2] gui: let users add PCI devices

2018-11-20 Thread Dominik Csapak
this enables the gui part to enable the user to add a pci device via the gui we disable the button after 4 devices, since that is the maximum in the backend Signed-off-by: Dominik Csapak --- www/manager6/qemu/HardwareView.js | 25 ++--- 1 file changed, 22 insertions(+), 3 de

[pve-devel] [PATCH manager 1/6 v2] Scan.pm: add pci scan api call

2018-11-20 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- changes from v1: * more api documentation * change filter-unusable to pci-class-blacklist * define filter sub here * define default class blacklist here PVE/API2/Scan.pm | 124 +++ 1 file changed, 124 insertions

[pve-devel] [PATCH manager 3/6 v2] gui: add form/PCISelector

2018-11-20 Thread Dominik Csapak
this adds a form field for selecting a pci device Signed-off-by: Dominik Csapak --- changes from v1: * updated field names www/manager6/Makefile| 1 + www/manager6/form/PCISelector.js | 89 2 files changed, 90 insertions(+) create mode 10064

[pve-devel] [PATCH common 2/2 v2] SysFSTools.pm: improve and extend lspci

2018-11-20 Thread Dominik Csapak
this implements following improvements and optimizations for lspci * removes the unecessary split between id and function since everywhere we need that information, we stitch them together anyway. to preserve ordering, simply order by id with string comparison 'cmp' (this is important for th

[pve-devel] [PATCH common 1/2 v2] SysFSTools.pm: add mediated devices subs

2018-11-20 Thread Dominik Csapak
adds helpers for listing/creating/removing mediated devices Signed-off-by: Dominik Csapak --- changes from v1: * check path in cleanup before writing src/PVE/SysFSTools.pm | 89 +++ 1 file changed, 89 insertions(+) diff --git a/src/PVE/SysFSTools.

[pve-devel] [PATCH qemu-server 2/2 v2] use improved lspci

2018-11-20 Thread Dominik Csapak
since lspci does not split between id and function anymore, there is no need to plug id + function together also we can remove the capture groups from PCIRE since parse_property_string does this check for us Signed-off-by: Dominik Csapak --- PVE/QemuServer.pm | 28 +++-

[pve-devel] applied: [PATCH zsync 1/2] fix #1587: sync: check if job state is defined

2018-11-20 Thread Wolfgang Bumiller
applied both patches ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH common] Tools.pm: do not ignore "0" in split_list

2018-11-20 Thread Dominik Csapak
giving split_list the string "0" would actually return an empty list instead of a list with the element "0" Signed-off-by: Dominik Csapak --- src/PVE/Tools.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm index 0f31fdb..accf653 100644 ---

[pve-devel] applied: [PATCH manager] ui: lxc/net: s/i.e./e.g./ and transform to emptyText

2018-11-20 Thread Dominik Csapak
applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] applied: [PATCH common 1/2] fork_worker: refactor child exit

2018-11-20 Thread Wolfgang Bumiller
On Tue, Nov 20, 2018 at 10:12:28AM +0100, Thomas Lamprecht wrote: > On 11/20/18 9:46 AM, Stoiko Ivanov wrote: > > * factor out duplicated code. > > * drop final kill(-9, $$), since the POSIX:_exit call does not return > > (see man 2 _exit). > > but followed up with re-adding this, we have it in

[pve-devel] applied: [lxc] fix typo in package description

2018-11-20 Thread Thomas Lamprecht
On 11/20/18 10:11 AM, Oguz Bektas wrote: > Signed-off-by: Oguz Bektas > --- > debian/control | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/debian/control b/debian/control > index fa3f703..d97bee1 100644 > --- a/debian/control > +++ b/debian/control > @@ -40,7 +40,7 @@

[pve-devel] applied: [PATCH common 2/2] fix #1956: return controlling terminal to parent

2018-11-20 Thread Thomas Lamprecht
On 11/20/18 9:46 AM, Stoiko Ivanov wrote: > The changes introduced in e97f807c388c10250f442b1f16c5315df2ffc2af let the > child in fork_worker take the controlling terminal of the session, without > returning it after finishing. > This breaks using/reading from the terminal after both parent and chi

[pve-devel] applied: [PATCH common 1/2] fork_worker: refactor child exit

2018-11-20 Thread Thomas Lamprecht
On 11/20/18 9:46 AM, Stoiko Ivanov wrote: > * factor out duplicated code. > * drop final kill(-9, $$), since the POSIX:_exit call does not return > (see man 2 _exit). but followed up with re-adding this, we have it in other places too in this file, and no harm. > > Signed-off-by: Stoiko Ivano

Re: [pve-devel] [PATCH common 1/2] fork_worker: refactor child exit

2018-11-20 Thread Stoiko Ivanov
On Tue, Nov 20, 2018 at 09:56:03AM +0100, Thomas Lamprecht wrote: > On 11/20/18 9:46 AM, Stoiko Ivanov wrote: > > * factor out duplicated code. > > * drop final kill(-9, $$), since the POSIX:_exit call does not return > > (see man 2 _exit). > > that's known, this is more like a safety measure to

[pve-devel] [lxc] fix typo in package description

2018-11-20 Thread Oguz Bektas
Signed-off-by: Oguz Bektas --- debian/control | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian/control b/debian/control index fa3f703..d97bee1 100644 --- a/debian/control +++ b/debian/control @@ -40,7 +40,7 @@ Replaces: liblxc1, lxc, Provides: liblxc1,

Re: [pve-devel] [PATCH common 1/2] fork_worker: refactor child exit

2018-11-20 Thread Thomas Lamprecht
On 11/20/18 9:46 AM, Stoiko Ivanov wrote: > * factor out duplicated code. > * drop final kill(-9, $$), since the POSIX:_exit call does not return > (see man 2 _exit). that's known, this is more like a safety measure to guarantee better sleep for a developer, and it does no harm... If you remove

[pve-devel] applied: [docs] minor improvements to documentation

2018-11-20 Thread Dietmar Maurer
applied. ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [docs] minor improvements to documentation

2018-11-20 Thread Thomas Lamprecht
On 11/20/18 9:35 AM, Oguz Bektas wrote: > Signed-off-by: Oguz Bektas > --- > qm.adoc | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/qm.adoc b/qm.adoc > index 0019ad1..43f250a 100644 > --- a/qm.adoc > +++ b/qm.adoc > @@ -829,7 +829,7 @@ migrate a VM to a total

[pve-devel] [PATCH common 0/2] fix #1956 return controlling terminal in fork_worker

2018-11-20 Thread Stoiko Ivanov
The problem described in https://bugzilla.proxmox.com/show_bug.cgi?id=1956 is the result of the changes introduced e97f807c388c10250f442b1f16c5315df2ffc2af: * The childprocess in fork_worker put itself in the forground by calling `tcsetpgrp`, but did not change the foreground process group when e

[pve-devel] [PATCH common 2/2] fix #1956: return controlling terminal to parent

2018-11-20 Thread Stoiko Ivanov
The changes introduced in e97f807c388c10250f442b1f16c5315df2ffc2af let the child in fork_worker take the controlling terminal of the session, without returning it after finishing. This breaks using/reading from the terminal after both parent and child exit - e.g. when the code is called from within

[pve-devel] [PATCH common 1/2] fork_worker: refactor child exit

2018-11-20 Thread Stoiko Ivanov
* factor out duplicated code. * drop final kill(-9, $$), since the POSIX:_exit call does not return (see man 2 _exit). Signed-off-by: Stoiko Ivanov --- src/PVE/RESTEnvironment.pm | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/src/PVE/RESTEnvironment.pm b/

[pve-devel] [PATCH manager] CephTools: cleanup module usage

2018-11-20 Thread Thomas Lamprecht
as done with the api ceph modules: most of this was imported by just copying without veryfing if all is actually required. Some lost it's purpose as we re-used more from our existing module code base (e.g., pve-common) but wasn't actually removed. As this file includes two perl modules you need to

[pve-devel] [docs] minor improvements to documentation

2018-11-20 Thread Oguz Bektas
Signed-off-by: Oguz Bektas --- qm.adoc | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/qm.adoc b/qm.adoc index 0019ad1..43f250a 100644 --- a/qm.adoc +++ b/qm.adoc @@ -829,7 +829,7 @@ migrate a VM to a totally different storage. You can also change the disk image *

[pve-devel] [PATCH manager 2/3] api/Ceph: cleanup module usage

2018-11-20 Thread Thomas Lamprecht
most of this was imported by just copying without veryfing if all is actually required. Some lost it's purpose as we re-used more from our existing module code base (e.g., pve-common) but wasn't actually removed. As this file includes two perl modules you need to take a bit caution when looking at

[pve-devel] [PATCH manager 1/3] api/CephOSD: cleanup module usage

2018-11-20 Thread Thomas Lamprecht
most of this was imported by just copying without veryfing if all is actually required. Some lost it's purpose as we re-used more from our existing module code base (e.g., pve-common) but wasn't actually removed. As this file includes two perl modules you need to take a bit caution when looking at

[pve-devel] [PATCH manager 3/3] api/ceph: actually use imported file_get_contents

2018-11-20 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- PVE/API2/Ceph.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Ceph.pm b/PVE/API2/Ceph.pm index cd62c040..dd7f2016 100644 --- a/PVE/API2/Ceph.pm +++ b/PVE/API2/Ceph.pm @@ -688,7 +688,7 @@ __PACKAGE__->register_method ({