Re: [pve-devel] [PATCH manager 5/6 v2] gui: add qemu/PCIEdit.js

2018-11-21 Thread Thomas Lamprecht
On 11/20/18 5:13 PM, Dominik Csapak wrote: > this patch adds the PCIEdit window and InputPanel > uses PCISelector and MDevSelector > > when we detect an iommugroup of -1, we put a warning on top > to inform the user that IOMMU is not activated (but let him add > the devices regardless, so that he

Re: [pve-devel] [PATCH manager 6/6 v2] gui: let users add PCI devices

2018-11-21 Thread Thomas Lamprecht
On 11/20/18 5:13 PM, Dominik Csapak wrote: > this enables the gui part to enable the user to add a pci device > via the gui > > we disable the button after 4 devices, since that is the maximum > in the backend > > Signed-off-by: Dominik Csapak > --- > www/manager6/qemu/HardwareView.js | 25

Re: [pve-devel] [PATCH manager 4/6 v2] gui: add MDevSelector

2018-11-21 Thread Thomas Lamprecht
On 11/20/18 5:13 PM, Dominik Csapak wrote: > this is used to select a mediated device type > pciid seems a bit of a strange name, maybe I'm just not used to it and pci_id pciID doesn't has the best ring on it either, so looks OK (besides the API path fixup from manager 2/6 which will affect this

Re: [pve-devel] [PATCH manager 3/6 v2] gui: add form/PCISelector

2018-11-21 Thread Thomas Lamprecht
On 11/20/18 5:13 PM, Dominik Csapak wrote: > this adds a form field for selecting a pci device > looks OK in general, some nits inline. > Signed-off-by: Dominik Csapak > --- > changes from v1: > * updated field names > www/manager6/Makefile| 1 + > www/manager6/form/PCISelector.js

Re: [pve-devel] [PATCH manager 2/6 v2] Scan.pm: add mdev scan api call

2018-11-21 Thread Thomas Lamprecht
On 11/20/18 5:13 PM, Dominik Csapak wrote: > this is for the gui to be able to select mediated devices why not a scan/pci/{pci-id}/mdev API path? would make more sense reading the API calls description and code. Please do so if you do not really have a strong argument against, I do not want anothe

Re: [pve-devel] pve-firewall : log conntrack sessions ?

2018-11-21 Thread Alexandre DERUMIER
>>Will look into it. Thanks ! - Mail original - De: "David Limbeck" À: "pve-devel" Envoyé: Mercredi 21 Novembre 2018 11:14:17 Objet: Re: [pve-devel] pve-firewall : log conntrack sessions ? Will look into it. On 11/21/18 7:50 AM, Alexandre DERUMIER wrote: > Hi, > > I'm currently to

[pve-devel] pve-firewall : can't have log on drop/reject rules

2018-11-21 Thread Alexandre DERUMIER
Hi, I'm not sure it was working before, but I can't get any log for a vm rule with a drop/reject. It's only works with default vm drop/reject action. I found an old patch about adding log by rules https://pve.proxmox.com/pipermail/pve-devel/2017-September/028816.html But I don't see anywhere

[pve-devel] [PATCH v2 pve-common] Network : veth pair : fix mtu

2018-11-21 Thread Alexandre Derumier
The ip link set command which create the veth pair is not setting mtu on both peers example: vm 106 is on a bridge with mtu 9000 222: tap160i1: mtu 9000 qdisc pfifo_fast master fwbr160i1 state UNKNOWN group default qlen 1000 223: fwbr160i1: mtu 1500 qdisc noqueue state UP group default qlen

[pve-devel] [manager 6/6] Add imageRemoveButton

2018-11-21 Thread Wolfgang Link
If an image has a encoded in the image name and the guest does not exist in the cluster we can delete it on the GUI. Also, if a config exists on another node and the storage is local we can delete. In all other cases, it is not allowed to delete it. For safety reason the safe remove windows ar

[pve-devel] [manager 3/6] Add function guestNode

2018-11-21 Thread Wolfgang Link
This function extracts the node where the guest resists. --- www/manager6/data/ResourceStore.js | 8 1 file changed, 8 insertions(+) diff --git a/www/manager6/data/ResourceStore.js b/www/manager6/data/ResourceStore.js index ff1dc46f..5b8690e5 100644 --- a/www/manager6/data/ResourceStore

[pve-devel] [RFC_V5] Storage: remove guest images in storage contendview

2018-11-21 Thread Wolfgang Link
[V4 -> V5] Completely implement this feature in the frontend. [V3 -> V4] Manager patch in V4 is unchanged Add check if $vmid($ownervm) is undef Use localnode instead node from the API to cover the case of localhost Split the error message into two messages to make the error more understandable f

[pve-devel] [manager 1/6] Add parameter storage shared

2018-11-21 Thread Wolfgang Link
So we know in the content call if storage is shared. This is used by removeImageButton. --- PVE/API2Tools.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/API2Tools.pm b/PVE/API2Tools.pm index 7b4c425a..7527b42b 100644 --- a/PVE/API2Tools.pm +++ b/PVE/API2Tools.pm @@ -120,6 +120,7 @@ sub

[pve-devel] [manager 2/6] Add function storageIsShared

2018-11-21 Thread Wolfgang Link
This function extracts the shared flag of the storage state. --- www/manager6/data/ResourceStore.js | 8 1 file changed, 8 insertions(+) diff --git a/www/manager6/data/ResourceStore.js b/www/manager6/data/ResourceStore.js index 0a36dee2..ff1dc46f 100644 --- a/www/manager6/data/ResourceS

[pve-devel] [manager 5/6] Move removeButton in a variable

2018-11-21 Thread Wolfgang Link
The move is necessary to hide the removeButton. --- www/manager6/storage/ContentView.js | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/www/manager6/storage/ContentView.js b/www/manager6/storage/ContentView.js index 0661065d..8716fba3 100644 --- a/

[pve-devel] [manager 4/6] Add imagedestroy to SafeDestroy

2018-11-21 Thread Wolfgang Link
--- www/manager6/window/SafeDestroy.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/www/manager6/window/SafeDestroy.js b/www/manager6/window/SafeDestroy.js index f89d0fa7..8b17093f 100644 --- a/www/manager6/window/SafeDestroy.js +++ b/www/manager6/window/SafeDestroy.js @@ -157,6 +157,8 @

[pve-devel] [PATCH pve-common] Network : veth pair : fix mtu

2018-11-21 Thread Alexandre Derumier
The ip link set command which create the veth pair is not setting mtu on both peers example: vm 106 is on a bridge with mtu 9000 222: tap160i1: mtu 9000 qdisc pfifo_fast master fwbr160i1 state UNKNOWN group default qlen 1000 223: fwbr160i1: mtu 1500 qdisc noqueue state UP group default qlen

Re: [pve-devel] [PATCH manager 6/8] ceph: add MDS create/delete/list API

2018-11-21 Thread Thomas Lamprecht
On 11/21/18 11:42 AM, Thomas Lamprecht wrote: > Allow to create, list and destroy and Ceph Metadata Server (MDS) over > the API and the CLI `pveceph` tool. > > Besides setting up the local systemd service template and the MDS > data directory we also add a reference to the MDS in the ceph.conf > W

Re: [pve-devel] [PATCH manager 6/8] ceph: add MDS create/delete/list API

2018-11-21 Thread Fabian Grünbichler
LGTM in general, small nits inlines, further testing with GUI integration expected. On Wed, Nov 21, 2018 at 11:42:41AM +0100, Thomas Lamprecht wrote: > Allow to create, list and destroy and Ceph Metadata Server (MDS) over > the API and the CLI `pveceph` tool. > > Besides setting up the local syst

Re: [pve-devel] [PATCH manager 4/8] CephTools: cleanup module usage

2018-11-21 Thread Fabian Grünbichler
On Wed, Nov 21, 2018 at 11:42:39AM +0100, Thomas Lamprecht wrote: > as done with the api ceph modules: > most of this was imported by just copying without veryfing if all is s/veryfing/verifying also for #1/#2 > actually required. Some lost it's purpose as we re-used more from our s/it's/its a

Re: [pve-devel] [PATCH manager 3/8] api/Ceph: actually use imported file_get_contents

2018-11-21 Thread Fabian Grünbichler
LGTM, but it's a bit strange that get is imported, and set is not (but also used). just in case you want to clean that up as well ;) On Wed, Nov 21, 2018 at 11:42:38AM +0100, Thomas Lamprecht wrote: > Signed-off-by: Thomas Lamprecht > --- > PVE/API2/Ceph.pm | 4 ++-- > 1 file changed, 2 insertio

Re: [pve-devel] [PATCH manager 2/8] api/Ceph: cleanup module usage

2018-11-21 Thread Fabian Grünbichler
On Wed, Nov 21, 2018 at 11:42:37AM +0100, Thomas Lamprecht wrote: > most of this was imported by just copying without veryfing if all is > actually required. Some lost it's purpose as we re-used more from our > existing module code base (e.g., pve-common) but wasn't actually > removed. > > As this

Re: [pve-devel] [PATCH manager 1/8] api/CephOSD: cleanup module usage

2018-11-21 Thread Fabian Grünbichler
On Wed, Nov 21, 2018 at 11:42:36AM +0100, Thomas Lamprecht wrote: > most of this was imported by just copying without veryfing if all is > actually required. Some lost it's purpose as we re-used more from our > existing module code base (e.g., pve-common) but wasn't actually > removed. > > As this

[pve-devel] applied: [pmg-api] fixed some typos in PMG/Config.pm

2018-11-21 Thread Dietmar Maurer
applied, thanks. BTW, we have an extra list for PMG development: https://pve.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [pmg-api] fixed some typos in PMG/Config.pm

2018-11-21 Thread Oguz Bektas
Signed-off-by: Oguz Bektas --- PMG/Config.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/PMG/Config.pm b/PMG/Config.pm index 81ab27d..b09a856 100755 --- a/PMG/Config.pm +++ b/PMG/Config.pm @@ -15,7 +15,7 @@ my $defaultData = { propertyList => { type => {

[pve-devel] [PATCH manager 6/8] ceph: add MDS create/delete/list API

2018-11-21 Thread Thomas Lamprecht
Allow to create, list and destroy and Ceph Metadata Server (MDS) over the API and the CLI `pveceph` tool. Besides setting up the local systemd service template and the MDS data directory we also add a reference to the MDS in the ceph.conf We note the backing host (node) from the respective MDS and

[pve-devel] [PATCH manager 7/8] ceph: add CephFS create and list API

2018-11-21 Thread Thomas Lamprecht
Allow to create a new CephFS instance and allow to list them. As deletion requires coordination between the active MDS and all standby MDS next in line this needs a bit more work. One could mark the MDS cluster down and stop the active, that should work but as destroying is quite a sensible operat

[pve-devel] [PATCH manager 4/8] CephTools: cleanup module usage

2018-11-21 Thread Thomas Lamprecht
as done with the api ceph modules: most of this was imported by just copying without veryfing if all is actually required. Some lost it's purpose as we re-used more from our existing module code base (e.g., pve-common) but wasn't actually removed. As this file includes two perl modules you need to

[pve-devel] [PATCH manager 1/8] api/CephOSD: cleanup module usage

2018-11-21 Thread Thomas Lamprecht
most of this was imported by just copying without veryfing if all is actually required. Some lost it's purpose as we re-used more from our existing module code base (e.g., pve-common) but wasn't actually removed. As this file includes two perl modules you need to take a bit caution when looking at

[pve-devel] [PATCH manager 0/8] CephFS/MDS server side implementation and cleanups

2018-11-21 Thread Thomas Lamprecht
First a few cleanups which may make sense in general, then the integration of MDS and CephFS management in our API/CLI and a pveceph sub command patch. Bit of an mix, but as my independent cleanup did not get any review and I want to build uppon it I include it here. Based on Aliwn's preious serie

[pve-devel] [PATCH manager 3/8] api/Ceph: actually use imported file_get_contents

2018-11-21 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- PVE/API2/Ceph.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Ceph.pm b/PVE/API2/Ceph.pm index cd62c040..dd7f2016 100644 --- a/PVE/API2/Ceph.pm +++ b/PVE/API2/Ceph.pm @@ -688,7 +688,7 @@ __PACKAGE__->register_method ({

[pve-devel] [PATCH manager 8/8] pveceph: move to sub commands

2018-11-21 Thread Thomas Lamprecht
add aliases for the existing ones, ignore the ones for MDS and CephFS, they did never hit any repo. Signed-off-by: Thomas Lamprecht --- PVE/CLI/pveceph.pm | 63 ++ 1 file changed, 42 insertions(+), 21 deletions(-) diff --git a/PVE/CLI/pveceph.pm b/PVE

[pve-devel] [PATCH manager 2/8] api/Ceph: cleanup module usage

2018-11-21 Thread Thomas Lamprecht
most of this was imported by just copying without veryfing if all is actually required. Some lost it's purpose as we re-used more from our existing module code base (e.g., pve-common) but wasn't actually removed. As this file includes two perl modules you need to take a bit caution when looking at

[pve-devel] [PATCH manager 5/8] ceph: move create/destroy pool to CephTools

2018-11-21 Thread Thomas Lamprecht
We will reuse this in the future, e.g., when creating a data and metadata pool for CephFS. Allow to pass a $rados object (to reuse it, as initializing is not that cheap) but also create it if it's undefined, fro convenience. Signed-off-by: Thomas Lamprecht --- PVE/API2/Ceph.pm | 50 ++--

Re: [pve-devel] pve-firewall : log conntrack sessions ?

2018-11-21 Thread David Limbeck
Will look into it. On 11/21/18 7:50 AM, Alexandre DERUMIER wrote: Hi, I'm currently to finally use proxmox firewall in production next year, and I missing piece is session logging (create in conntrack, end in conntrack). It's currently possible with ulogd2, but ulogd2 don't start with pve fw

[pve-devel] applied: [PATCH common] Tools.pm: do not ignore "0" in split_list

2018-11-21 Thread Wolfgang Bumiller
applied On Tue, Nov 20, 2018 at 12:45:15PM +0100, Dominik Csapak wrote: > giving split_list the string "0" would actually return > an empty list instead of a list with the element "0" > > Signed-off-by: Dominik Csapak > --- > src/PVE/Tools.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion

Re: [pve-devel] [PATCH common/qemu-server/manager v2] add mdev support and passthrough gui

2018-11-21 Thread Dominik Csapak
On 11/20/18 5:26 PM, Thomas Lamprecht wrote: On 11/20/18 5:13 PM, Dominik Csapak wrote: this series add support for mediated devices, such as Nvidias vGPUs and Intels KVMgt (aka GVT-g), as well as gui support for PCI passthrough in general this needs my 'cleanup and refactor mania series'[1] an