Hi,
I have rethinked about it, I have (again ;) a new idea for implementation.
The main problem is how to test a change at datacenter level, as we need to
test the local configuration of each node.
and it's not currently in /etc/pve , but in /etc/network/interfaces of each
node.
I think, s
On Mon, Apr 01, 2019 at 04:20:46PM +0200, Wolfgang Link wrote:
> Remove "zpool import" because there is no need for it.
>
> zpool list will import the pool if it is not imported.
this is not true? would be pretty crazy anyway ;)
> Anyway also there is no situation where Proxmox VE framework wil
Signed-off-by: Christian Ebner
---
src/PVE/API2/LXC.pm | 9 -
src/PVE/LXC/Create.pm | 9 -
2 files changed, 16 insertions(+), 2 deletions(-)
diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm
index 6de121f..3d5460c 100644
--- a/src/PVE/API2/LXC.pm
+++ b/src/PVE/API2/LXC.pm
Remove "zpool import" because there is no need for it.
zpool list will import the pool if it is not imported.
Anyway also there is no situation where Proxmox VE framework will
export a pool.
So there should no need to import a pool in the code logic.
If an error occurs, the error output will he
as alternative,
we could simply
manage multiple change in /etc/pve/network/vnet.cfg.new
apply button -> replace /etc/pve/network/vnet.cfg
The the local daemon,
do test (dry-run,) and report error in his status file. (and it's displayed
at network level in datacenter)
if ok,
it's apply chang
>>I don't really get why you want to do that? There are so many ways to damage
>>a network, and
>>I doubt that we can reliable verify that
ifupdown2 have a dry-run too, it's working not too bad (but not 100% complete)
But I would avoid some basic mistakes,
like a vlan interface already defi
On 4/1/19 2:45 PM, Christian Ebner wrote:
> Signed-off-by: Christian Ebner
> ---
> Version 2:
> * Values are retained in config while disable/enable
> * Removed disabling of the textfield and combobox when unchecking enable
> in order to get the values instead of undefined.
> * i
Signed-off-by: Christian Ebner
---
Version 2:
* Values are retained in config while disable/enable
* Removed disabling of the textfield and combobox when unchecking enable
in order to get the values instead of undefined.
* initComponent -> autoLoad: true
www/manager6/Makefile
On 4/1/19 1:31 PM, Tim Marx wrote:
> Signed-off-by: Tim Marx
> ---
> www/manager6/ceph/CephInstallWizard.js | 14 ++
> 1 file changed, 14 insertions(+)
>
> diff --git a/www/manager6/ceph/CephInstallWizard.js
> b/www/manager6/ceph/CephInstallWizard.js
> index 1c8808d1..bd50bf81 10064
On 4/1/19 1:56 PM, Christian Ebner wrote:
> Looks good! Acknowledged
thanks for looking at this, pushed it out.
>> On March 21, 2019 at 7:59 AM Thomas Lamprecht
>> wrote:
>>
>>
>> Signed-off-by: Thomas Lamprecht
>> Cc: Christian Ebner
>> ---
>>
>> just a POC, but should all be working, @chris
Looks good! Acknowledged
> On March 21, 2019 at 7:59 AM Thomas Lamprecht wrote:
>
>
> Signed-off-by: Thomas Lamprecht
> Cc: Christian Ebner
> ---
>
> just a POC, but should all be working, @christian could you take a look at
> this?
>
> src/PVE/Firewall.pm | 63
Signed-off-by: Tim Marx
---
www/manager6/ceph/CephInstallWizard.js | 14 ++
1 file changed, 14 insertions(+)
diff --git a/www/manager6/ceph/CephInstallWizard.js
b/www/manager6/ceph/CephInstallWizard.js
index 1c8808d1..bd50bf81 100644
--- a/www/manager6/ceph/CephInstallWizard.js
+++
Signed-off-by: Christian Ebner
---
www/manager6/Makefile | 1 +
www/manager6/grid/FirewallOptions.js | 8 +++
www/manager6/window/FirewallLograteEdit.js | 105 +
3 files changed, 114 insertions(+)
create mode 100644 www/manager6/window/F
> maybe better:
>
> in gui, at network,datacenter level
>
> at each change, make a
> /etc/pve/networks/vnet.cfg.
>
>
> on local node, the daemon detect the new version,make verification,
> and update /etc/pve/nodes//.networkconfigstatus
>
> version: verify:ok
I don't really get why you want t
Unconditionally add a '--bwlimit' parameter to the rsync invocation, defaulting
to an argument of '0' (= unlimited - see `man rsync).
Signed-off-by: Stoiko Ivanov
---
src/PVE/LXC.pm | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
ind
Changes from v1:
* Incorporated Thomas great feedback! - Thanks!
* Added a patch to pve-common - there the description wrote MiB/s, but the
restore-codepaths take the value as KiB/s [0]
I changed the output of PVE::QemuServer::qemu_drive_mirror to always write the
speed in KB/s, instead of using
pass bwlimit parameter to storage_migrate
Signed-off-by: Stoiko Ivanov
---
src/PVE/LXC/Migrate.pm | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/src/PVE/LXC/Migrate.pm b/src/PVE/LXC/Migrate.pm
index 1364b8d..7df3c4c 100644
--- a/src/PVE/LXC/Migrate.pm
+++ b/src/PVE/
for migrate_vm, clone_vm and move_vm_disk and extract it. The 'migrate_vm' call
passes it to PVE::QemuMigrate->migrate for handling.
Additionally the bwlimit option's description of the 'create_vm' call gets
consistent capitalization of I/O.
Signed-off-by: Stoiko Ivanov
---
PVE/API2/Qemu.pm | 3
used for online local disks via qemu_drive_mirror
Signed-off-by: Stoiko Ivanov
---
PVE/QemuMigrate.pm | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm
index 55c9a7c..4b5813c 100644
--- a/PVE/QemuMigrate.pm
+++ b/PVE/QemuMigra
for migrate_vm, clone_vm and move_volume. The 'migrate_vm' call passes it to
PVE::LXC::Migrate->migrate for handling.
Additionally the bwlimit option's description of the 'create_vm' call gets
consistent capitalization of I/O.
Signed-off-by: Stoiko Ivanov
---
src/PVE/API2/LXC.pm | 38 ++
and pass it to qemu_drive_mirror (used for online disks).
Signed-off-by: Stoiko Ivanov
---
PVE/QemuServer.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index ba14579..7d2066e 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
the description of bwlimit wrote MiB/s, the use in restore operation is KiB/s
Signed-off-by: Stoiko Ivanov
---
src/PVE/JSONSchema.pm | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm
index f0fc2aa..51ef3ab 100644
--- a/sr
The 'migrate_speed' can be set in the VM config. Additionally the 'migrate'
bwlimit from datacenter.cfg (storage-specific limits play no role for
memory+state migration) or the parameter provided to the API call can restrict
the speed. Take the lower of the two.
This patch also refactors the setti
clone_disk calls `qemu-img convert` for offline disks, which does not have a
bandwidth limit parameter.
Signed-off-by: Stoiko Ivanov
---
PVE/QemuServer.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index f9b0f58..ba14579 100644
--- a/PVE/QemuServer.
used for online drive migrations, move_disk and clone calls.
Signed-off-by: Stoiko Ivanov
---
PVE/QemuServer.pm | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index fd854c4..f9b0f58 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuS
factor out accessing $self->{opts}, since it's used twice.
Signed-off-by: Stoiko Ivanov
---
PVE/QemuMigrate.pm | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm
index c4620a5..55c9a7c 100644
--- a/PVE/QemuMigrate.pm
+++ b/PVE/QemuMig
used for offline migration of local volumes
Signed-off-by: Stoiko Ivanov
---
PVE/QemuMigrate.pm | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm
index bb65d63..c4620a5 100644
--- a/PVE/QemuMigrate.pm
+++ b/PVE/QemuMigrate.pm
@@ -46
The VM created in the 'prepare' sub never gets deleted if it fails there
already. Cleanup only happens for phases 1, 2 and 3.
On 4/1/19 7:26 AM, Alexandre DERUMIER wrote:
oh, and this all lacks a bit of cleanups on errors, e.g., the newly created
VM on the target side, etc. but it's a bit of a
>>yes, with me idea you'd still separate it, have this in the new
>>QemuMigrateExternal,
>>_but_ the base() class wouldn't be "PVE::AbstractMigrate" but
>>"PVE::QemuMigrate",
>>we won't touch PVE::QemuMigrate besides some splitting up of things (to get a
>>nicer
>>interface to overwrite in the c
29 matches
Mail list logo
