[pve-devel] applied: [PATCH manager] ui: improve datacenter summary ceph node selection

2019-04-05 Thread Thomas Lamprecht
On 4/5/19 4:08 PM, Dominik Csapak wrote: > instead of trying a single random node 3 times, try all nodes > until we either find one with ceph, or until we tried them all > > Signed-off-by: Dominik Csapak > --- > www/manager6/dc/Health.js | 39 --- > 1 file cha

[pve-devel] applied: [PATCH storage 0/2] bwlimit: ignore undef in storage_list and add tests

2019-04-05 Thread Thomas Lamprecht
On 4/5/19 4:33 PM, Stoiko Ivanov wrote: > While discussing the bug in [0], Dominik quickly came up with the patch, > ignoring undef as passed storage to storage_list, and gently hinted me to the > existance of our bwlimit tests. The first patch ignores undef as storage, > which > IMO is semantical

[pve-devel] [PATCH storage 1/2] get_bandwidt_limits: ignore 'undef' as storage

2019-04-05 Thread Stoiko Ivanov
If one of the storages passed in $storage_list was not defined get_bandwidth_limit died (see [0], of an occurence of this). This patch changes the behavior to ignore undef as storage instead. [0] https://pve.proxmox.com/pipermail/pve-devel/2019-April/036515.html Signed-off-by: Stoiko Ivanov ---

[pve-devel] [PATCH storage 0/2] bwlimit: ignore undef in storage_list and add tests

2019-04-05 Thread Stoiko Ivanov
While discussing the bug in [0], Dominik quickly came up with the patch, ignoring undef as passed storage to storage_list, and gently hinted me to the existance of our bwlimit tests. The first patch ignores undef as storage, which IMO is semantically correct, although dying on unclean/unexpected in

[pve-devel] [PATCH storage 2/2] add 3 bwlimit tests

2019-04-05 Thread Stoiko Ivanov
1) checking that the empty storage list is treated correctly (only override and datacenter config limit considered) 2) checking that the empty storage list is treated correctly (as with 1). 3) checking that undef can be passed as one element of the storage list (it is ignored) Signed-off-by: Stoik

[pve-devel] [PATCH manager] ui: improve datacenter summary ceph node selection

2019-04-05 Thread Dominik Csapak
instead of trying a single random node 3 times, try all nodes until we either find one with ceph, or until we tried them all Signed-off-by: Dominik Csapak --- www/manager6/dc/Health.js | 39 --- 1 file changed, 16 insertions(+), 23 deletions(-) diff --git a/w

[pve-devel] applied: [PATCH qemu-server] Create linked clone failed, uninitialized storage

2019-04-05 Thread Thomas Lamprecht
On 4/5/19 2:35 PM, Alwin Antreich wrote: > When creating a linked clone the storage parameter is not defined. The > get_bandwidth_limit method got a undef element for its storage_list and > therefore failed on trying to set the bandwidth limit. > applied but rewrote commit message a bit, as the i

[pve-devel] [PATCH qemu-server] Create linked clone failed, uninitialized storage

2019-04-05 Thread Alwin Antreich
When creating a linked clone the storage parameter is not defined. The get_bandwidth_limit method got a undef element for its storage_list and therefore failed on trying to set the bandwidth limit. This patch only pushes the storage parameter into the storage_list array if it is defined. Signed-o

[pve-devel] applied: [PATCH manager 2/2] ui: make Datacenter subscription info clickable when not valid

2019-04-05 Thread Thomas Lamprecht
On 4/5/19 1:02 PM, Dominik Csapak wrote: > to make it easier for the user to buy the subscriptions > > Signed-off-by: Dominik Csapak > --- > www/manager6/dc/Summary.js | 14 +- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/www/manager6/dc/Summary.js b/www/manage

[pve-devel] applied: [PATCH manager 1/2] ui: fix blinking subscription info panel

2019-04-05 Thread Thomas Lamprecht
On 4/5/19 1:02 PM, Dominik Csapak wrote: > not having a subscription trumps having mixed subscriptions, so we > check that correctly > > Signed-off-by: Dominik Csapak > --- > www/manager6/dc/Summary.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/www/manager6/dc/Summ

[pve-devel] [PATCH manager 1/2] ui: fix blinking subscription info panel

2019-04-05 Thread Dominik Csapak
not having a subscription trumps having mixed subscriptions, so we check that correctly Signed-off-by: Dominik Csapak --- www/manager6/dc/Summary.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/dc/Summary.js b/www/manager6/dc/Summary.js index 55a76bf0..6254395

[pve-devel] [PATCH manager 2/2] ui: make Datacenter subscription info clickable when not valid

2019-04-05 Thread Dominik Csapak
to make it easier for the user to buy the subscriptions Signed-off-by: Dominik Csapak --- www/manager6/dc/Summary.js | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/www/manager6/dc/Summary.js b/www/manager6/dc/Summary.js index 6254395b..091ece76 100644 --- a/ww

[pve-devel] applied: [PATCH docs] Update TFA documentation

2019-04-05 Thread Thomas Lamprecht
On 4/5/19 11:39 AM, Wolfgang Bumiller wrote: > Signed-off-by: Wolfgang Bumiller > --- > pveum.adoc | 86 > -- > 1 file changed, 84 insertions(+), 2 deletions(-) > applied, thanks! ___ pve-

[pve-devel] [PATCH docs] Update TFA documentation

2019-04-05 Thread Wolfgang Bumiller
Signed-off-by: Wolfgang Bumiller --- pveum.adoc | 86 -- 1 file changed, 84 insertions(+), 2 deletions(-) diff --git a/pveum.adoc b/pveum.adoc index b0bb72a..1447d38 100644 --- a/pveum.adoc +++ b/pveum.adoc @@ -150,8 +150,23 @@ encrypti

[pve-devel] [PATCH v3 storage] Fix #318: Delete vzdump log when deleting a backup

2019-04-05 Thread Dominic Jaeger
Vzdump log files were not deleted when a backup was deleted. Consequently, the folder continuously filled with .log files. Now they get deleted after the backup is removed. Signed-off-by: Dominic Jaeger --- Add regex guard Remove the dependency for suffix and fileparse Improve variable handling

[pve-devel] applied: [PATCH gui-tests] add create ceph install wizard screenshots

2019-04-05 Thread Thomas Lamprecht
On 4/5/19 10:40 AM, Tim Marx wrote: > Signed-off-by: Tim Marx > --- > Proxmox/GUITester.pm | 22 ++ > create_ceph_install_wizard_screenshots | 78 > ++ > 2 files changed, 100 insertions(+) > create mode 100755 create_ceph_install_wizard_

[pve-devel] [PATCH gui-tests] add create ceph install wizard screenshots

2019-04-05 Thread Tim Marx
Signed-off-by: Tim Marx --- Proxmox/GUITester.pm | 22 ++ create_ceph_install_wizard_screenshots | 78 ++ 2 files changed, 100 insertions(+) create mode 100755 create_ceph_install_wizard_screenshots diff --git a/Proxmox/GUITester.pm b/Pr

[pve-devel] applied: [PATCH manager] ui: tfa: allow apply only on valid inputs

2019-04-05 Thread Thomas Lamprecht
On 4/5/19 10:31 AM, Dominik Csapak wrote: > only when the totp form and the challenge is valid, allow pressing the > apply button, default is disabled > change allowBlank for the challenge > > Signed-off-by: Dominik Csapak > --- > www/manager6/dc/TFAEdit.js | 13 - > 1 file changed,

[pve-devel] [PATCH manager] ui: tfa: allow apply only on valid inputs

2019-04-05 Thread Dominik Csapak
only when the totp form and the challenge is valid, allow pressing the apply button, default is disabled change allowBlank for the challenge Signed-off-by: Dominik Csapak --- www/manager6/dc/TFAEdit.js | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/www/manager6

[pve-devel] applied: [PATCH manager] add a filter mask for the TFA Secret

2019-04-05 Thread Thomas Lamprecht
On 4/5/19 8:33 AM, Dominik Csapak wrote: > this way a user cannot (easily) enter wrong characters > else if an invalid Character is entered, one can still hit apply > but not all characters will be used for the secret > > Signed-off-by: Dominik Csapak > --- > www/manager6/dc/TFAEdit.js | 1 + >

Re: [pve-devel] applied: [PATCH pve-network 2/2] vnetplugin: on_delete_hook : verify if vnet exist in vm && ct

2019-04-05 Thread Alexandre DERUMIER
>>I guess this introduces a cyclic package dependency? >> >>pve-network => qemu-server/pve-contaiber => pve-network >>Currently, the package is PVE::Network::Network, so no. sorry, for a package dependencies, yes (BTW, this is the same with pve-firewall currently) - Mail original - De: