[pve-devel] [PATCH common] JSONSchema: sort keys when dumping config

2019-04-16 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- src/PVE/JSONSchema.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm index 51ef3ab..f0192c2 100644 --- a/src/PVE/JSONSchema.pm +++ b/src/PVE/JSONSchema.pm @@ -1590,7 +1590,7 @@ sub dump_config {

[pve-devel] [PATCH ifupdown2 4/4] bridge up : skip tap|veth|fwpr

2019-04-16 Thread Alexandre Derumier
to avoid error like info: vmbr5001: applying bridge port configuration: ['tap111i0'] info: vmbr5001: applying bridge configuration specific to ports error: 'NoneType' object has no attribute '__getitem__' --- .../pve/0006-bridge-up-skip-tap-veth-fwpr.patch| 30 ++ debian/p

[pve-devel] [PATCH ifupdown2 3/4] allow vlan subinterface in vlan aware bridge

2019-04-16 Thread Alexandre Derumier
(for qinq) --- ...-vlan-subinterface-in-a-vlan-aware-bridge.patch | 49 ++ debian/patches/series | 1 + 2 files changed, 50 insertions(+) create mode 100644 debian/patches/pve/0005-allow-vlan-subinterface-in-a-vlan-aware-bridge.patch diff --git

[pve-devel] [PATCH ifupdown2 1/4] ifupdown2 : bump to 1.2.5

2019-04-16 Thread Alexandre Derumier
--- Makefile | 2 +- debian/changelog | 6 ++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 91cb755..4d749be 100644 --- a/Makefile +++ b/Makefile @@ -1,5 +1,5 @@ PACKAGE=ifupdown2 -VER=1.2.2 +VER=1.2.5 PKGREL=1+pvetest1 SRCDIR=ifupdown2 di

[pve-devel] [PATCH ifupdown2 2/4] config: keep ifreload_down_changed=0

2019-04-16 Thread Alexandre Derumier
bug introduce is commit https://git.proxmox.com/?p=ifupdown2.git;a=commit;h=b58be4449b3a009ba8324e3f414f2355fcf94c06 We don't stop/start interface on config change, but only apply changes. (to avoid stop/start bridge as we don't track tap/veth) --- debian/patches/pve/0001-config-tuning.patch | 9

[pve-devel] [PATCH ifupdown2 0/4] ifupdown2 update and bugfix

2019-04-16 Thread Alexandre Derumier
please update ifupdown2 mirror to 1.2.5-1 Alexandre Derumier (4): ifupdown2 : bump to 1.2.5 config: keep ifreload_down_changed=0 allow vlan subinterface in vlan aware bridge bridge up : skip tap|veth|fwpr Makefile | 2 +- debian/changelog

[pve-devel] [PATCH kernel] fix #2008: kvm: x86: Add AMD's EX_CFG to the list of ignored MSRs

2019-04-16 Thread Thomas Lamprecht
clean backport from kernel mainline commit 0e1b869fff60c81b510c2d00602d778f8f59dd9a [0] Without this a Windows ISO doesn't even comes to the first dialog, and BSODs quite quickly (boot loops then), with this I get to the installer dialog, and everything seems to be fine.. [0]: https://git.kerne

[pve-devel] [PATCH container] fix: #1075: Correctly restore CT templates form backup

2019-04-16 Thread Christian Ebner
Restoring a backup from a CT template wrongly resulted in a CT with the template flag set in the config. This makes sure the CT template backup gets restored to a CT and only if the storage supports templates, the resulting CT is converted to a template. Otherwise the backup restores simply to a CT

Re: [pve-devel] [PATCH manager v2] Fix #482: Add timestamps to backup creation log

2019-04-16 Thread Thomas Lamprecht
On 4/16/19 11:57 AM, Dominic Jäger wrote: > Adding timestamps to the log messages facilitates troubleshooting. > > Signed-off-by: Dominic Jäger > --- > v1->v2 > Initially, I sticked to the rest of the code. > E.g. line 778 uses +1900 for the years aswell. > Now the more concise strftime is used.

Re: [pve-devel] [PATCH guest-common] increase max reading replication state file size.

2019-04-16 Thread Thomas Lamprecht
On 4/16/19 3:37 PM, Wolfgang Link wrote: > In this file, the error of a failed job will also be stored. > The default 32768 bytes are not very much. > > This file is on the local filesystem so there is no filesystem > size restrictions like in /etc/pve. looks OK, minor nit inside > --- > PVE/R

[pve-devel] [PATCH] Syscall: add setresuid syscall

2019-04-16 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- See `man 2 setresuid`. The code was tested with small UIDs (109) and one which does not fit into 16 bit (1), since I wasn't too sure about the workings of setresuid vs. setresuid32 (see NOTES of the manpage) - it worked with both. src/PVE/Syscall.pm | 1 +

[pve-devel] [PATCH guest-common] increase max reading replication state file size.

2019-04-16 Thread Wolfgang Link
In this file, the error of a failed job will also be stored. The default 32768 bytes are not very much. This file is on the local filesystem so there is no filesystem size restrictions like in /etc/pve. --- PVE/ReplicationState.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --gi

[pve-devel] [PATCH storage] fix #2154: Buggy "pvesm status" output

2019-04-16 Thread Wolfgang Link
Improve error output. --- PVE/Storage/ZFSPoolPlugin.pm | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/PVE/Storage/ZFSPoolPlugin.pm b/PVE/Storage/ZFSPoolPlugin.pm index 4f16351..9ba3999 100644 --- a/PVE/Storage/ZFSPoolPlugin.pm +++ b/PVE/Storage/ZFSPoolPlugin.pm @@ -52

[pve-devel] applied: [RFC manager] fix #263: only include node rrd stats if user has Sys.Audit

2019-04-16 Thread Thomas Lamprecht
On 4/16/19 1:49 PM, Oguz Bektas wrote: > looks good to me. > > Tested-by: Oguz Bektas applied, with your T-b tag, thanks! > > > On Mon, Apr 15, 2019 at 02:10:27PM +, Thomas Lamprecht wrote: >> It makes sense to not give users without Sys.Audit permissions to >> much information over a nod

[pve-devel] applied: [PATCH manager] fix #2177: use getValue() to get otp value

2019-04-16 Thread Thomas Lamprecht
On 4/16/19 1:37 PM, Wolfgang Bumiller wrote: > as '.value' isn't always valid > > Signed-off-by: Wolfgang Bumiller > --- > > Don't ask me why. The key events sent by the yubikey look normal: > > Event: time 1555413939.543914, -- SYN_REPORT > Event: time 1555413939.5

[pve-devel] applied: [PATCH manager] pveceph: install ceph service print sucess message

2019-04-16 Thread Thomas Lamprecht
On 4/9/19 10:44 AM, Alwin Antreich wrote: > This patch adds a success message on successful ceph.service > installation. And adds a newline to make a successful ceph package > installation more visible. > > Signed-off-by: Alwin Antreich > --- > PVE/CLI/pveceph.pm | 9 +++-- > 1 file changed,

Re: [pve-devel] [RFC manager] fix #263: only include node rrd stats if user has Sys.Audit

2019-04-16 Thread Oguz Bektas
hi, looks good to me. Tested-by: Oguz Bektas On Mon, Apr 15, 2019 at 02:10:27PM +, Thomas Lamprecht wrote: > It makes sense to not give users without Sys.Audit permissions to > much information over a node and this is relatively easy and cheap to > check and enforce at those two points. >

[pve-devel] [PATCH manager] fix #2177: use getValue() to get otp value

2019-04-16 Thread Wolfgang Bumiller
as '.value' isn't always valid Signed-off-by: Wolfgang Bumiller --- Don't ask me why. The key events sent by the yubikey look normal: Event: time 1555413939.543914, -- SYN_REPORT Event: time 1555413939.551918, type 4 (EV_MSC), code 4 (MSC_SCAN), value 70028 Event:

[pve-devel] [PATCH manager v2] Fix #482: Add timestamps to backup creation log

2019-04-16 Thread Dominic Jäger
Adding timestamps to the log messages facilitates troubleshooting. Signed-off-by: Dominic Jäger --- v1->v2 Initially, I sticked to the rest of the code. E.g. line 778 uses +1900 for the years aswell. Now the more concise strftime is used. PVE/VZDump.pm | 12 ++-- 1 file changed, 10 ins

[pve-devel] [PATCH widget-toolkit 1/2] show cidr in network view and optimize renderer

2019-04-16 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- node/NetworkView.js | 45 + 1 file changed, 25 insertions(+), 20 deletions(-) diff --git a/node/NetworkView.js b/node/NetworkView.js index b38a07e..e3f7e60 100644 --- a/node/NetworkView.js +++ b/node/NetworkView.js @@

[pve-devel] [PATCH common 2/2] INotify: map address/netmask to cidr while parsing interfaces

2019-04-16 Thread Dominik Csapak
this allows us to always show the 'address' the 'netmask' and the 'cidr' both for ipv4 and ipv6 there is a small api change involved in one scenario: if one manually changed the address to cidr format like '10.0.0.4/24' we now get from the api the parsed values addr => 10.0.0.4 netmas

[pve-devel] [PATCH common 1/2] JSONSchema: add get_netmask_bits and missing netmask

2019-04-16 Thread Dominik Csapak
so one can use the mapping from outside the module Signed-off-by: Dominik Csapak --- src/PVE/JSONSchema.pm | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm index 51ef3ab..d458ec1 100644 --- a/src/PVE/JSONSchema.pm +++ b/src/PVE/JSONSchema.pm

[pve-devel] [PATCH pmg-api 1/1] add new parameters cidr(6) to the network api

2019-04-16 Thread Dominik Csapak
to also allow to set it directly and not only via address/netmask Signed-off-by: Dominik Csapak --- PMG/API2/Network.pm | 44 +++- 1 file changed, 43 insertions(+), 1 deletion(-) diff --git a/PMG/API2/Network.pm b/PMG/API2/Network.pm index 6636553..703c05

[pve-devel] [PATCH widget-toolkit 2/2] change network input from address/netmask to cidr and change labels

2019-04-16 Thread Dominik Csapak
this makes the ui easier and is consistent with the rest of our ui (container and cloud init) Signed-off-by: Dominik Csapak --- node/NetworkEdit.js | 68 +++-- 1 file changed, 8 insertions(+), 60 deletions(-) diff --git a/node/NetworkEdit.js b/nod

[pve-devel] [PATCH manager 1/1] add new parameters cidr(6) to the network api

2019-04-16 Thread Dominik Csapak
to also allow to set it directly and not only via address/netmask Signed-off-by: Dominik Csapak --- PVE/API2/Network.pm | 44 +++- 1 file changed, 43 insertions(+), 1 deletion(-) diff --git a/PVE/API2/Network.pm b/PVE/API2/Network.pm index 0284410a..3b086

[pve-devel] [PATCH common/manager/pmg-api/widget-toolkit] implement cidr api for host network

2019-04-16 Thread Dominik Csapak
this series implements the api to set/get the host network as cidr address instead of having to set address and netmask this also parses the interfaces file now for this and returns a 'cidr', 'address', and 'netmask' field after that, it cleans up the ui to be more consistent with containers and

[pve-devel] applied: [PATCH manager 4/4] ui: tfa: set initial tab based on current tfa type

2019-04-16 Thread Thomas Lamprecht
On 4/11/19 11:32 AM, Wolfgang Bumiller wrote: > Signed-off-by: Wolfgang Bumiller > --- > www/manager6/dc/TFAEdit.js | 4 > 1 file changed, 4 insertions(+) > > diff --git a/www/manager6/dc/TFAEdit.js b/www/manager6/dc/TFAEdit.js > index 49c39b4e..021fc2a3 100644 > --- a/www/manager6/dc/TFAEd

[pve-devel] applied: [PATCH manager 3/4] ui: tfa: mask panels for not currently used types

2019-04-16 Thread Thomas Lamprecht
On 4/11/19 11:32 AM, Wolfgang Bumiller wrote: > Signed-off-by: Wolfgang Bumiller > --- applied, but with quite a big followup changing the wizard card-masking to card-disabling with a simple bind. > www/manager6/dc/TFAEdit.js | 23 --- > www/manager6/dc/UserView.js | 5 +++

[pve-devel] applied: [PATCH manager 1/4] www: parser: add parseTfaType helper

2019-04-16 Thread Thomas Lamprecht
On 4/11/19 11:31 AM, Wolfgang Bumiller wrote: > The tfa keys can now contain the type as additional > information, so let's parse it out. > > Signed-off-by: Wolfgang Bumiller > --- > www/manager6/Parser.js | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/www/manager6/Pars

[pve-devel] applied: [PATCH manager 2/4] ui: user view: show tfa type name

2019-04-16 Thread Thomas Lamprecht
On 4/11/19 11:32 AM, Wolfgang Bumiller wrote: > Signed-off-by: Wolfgang Bumiller > --- > www/manager6/dc/UserView.js | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/www/manager6/dc/UserView.js b/www/manager6/dc/UserView.js > index e412edfb..e91486ab 100644 > ---

[pve-devel] [PATCH qemu-server] fix #1829: Cloudinit ignore format parameter

2019-04-16 Thread Wolfgang Link
When a Cloudinit image is created, we allow choosing the format as parameter. So, the parameter should also be taken into account. The default for Cloudinit will stay qcow2 on directory storages. --- PVE/API2/Qemu.pm | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/P