Re: [pve-devel] [PATCH ifupdown2 2/3] fix ipforwarding

2019-05-08 Thread Thomas Lamprecht
On 5/9/19 7:56 AM, Alexandre DERUMIER wrote: >> We need to keep classic ifupdown behaviour > >>> is there any upstream issue/discussion regarding this? > > yes (I'm always trying to push upstream) perfect! sorry for being to lazy to look for myself... :-) > > https://github.com/CumulusNetwor

Re: [pve-devel] [PATCH ifupdown2 2/3] fix ipforwarding

2019-05-08 Thread Alexandre DERUMIER
> We need to keep classic ifupdown behaviour >>is there any upstream issue/discussion regarding this? yes (I'm always trying to push upstream) https://github.com/CumulusNetworks/ifupdown2/issues/98 and PR https://github.com/CumulusNetworks/ifupdown2/pull/101 - Mail original - De: "

[pve-devel] [PATCH manager] vzdump: allow plugins to set guest resume time

2019-05-08 Thread Thomas Lamprecht
This refactors things a bit to avoid having the same two lines in 3 places and allows the plugin to set the "guest was resumed" time stamp at the point it really was resumed, not only once the backup completed (see #503). Further, if a plugin prints it's own "resumed/running after X seconds" messag

[pve-devel] [PATCH qemu-server] fix #503: print correct offline time for stop mode backups

2019-05-08 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- PVE/VZDump/QemuServer.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/PVE/VZDump/QemuServer.pm b/PVE/VZDump/QemuServer.pm index 70abe99..22bb3d6 100644 --- a/PVE/VZDump/QemuServer.pm +++ b/PVE/VZDump/QemuServer.pm @@ -439,7 +439,9 @@ s

[pve-devel] fix #503 - print correct offline time for VM stop mode backups

2019-05-08 Thread Thomas Lamprecht
Encode the time a guest was stopped in the backup $task hash, also allow a plugin to set the time the guest was continued (is running again) from inside the plugin, which then allows to fix #503, i.e., stop mode backups for VM where we stopped the VM, started the VM again in backup mode and then se

Re: [pve-devel] [PATCH ifupdown2 2/3] fix ipforwarding

2019-05-08 Thread Stoiko Ivanov
On Mon, 6 May 2019 06:25:00 +0200 Alexandre Derumier wrote: > Currently ifupdown2 disable forwarding if not defined with ip-forward > on interfaces, or if bridge don't have an address (breaking inet dhcp) > > We need to keep classic ifupdown behaviour > > Signed-off-by: Alexandre Derumier > -

[pve-devel] applied: [PATCH common/manager/pmg-api/widget-toolkit v2] implement cidr api for host network

2019-05-08 Thread Thomas Lamprecht
On 5/3/19 9:28 AM, Dominik Csapak wrote: > this series implements the api to set/get the host network as cidr address > instead of having to set address and netmask > > this also parses the interfaces file now for this and returns > a 'cidr', 'address', and 'netmask' field > > after that, it clea

Re: [pve-devel] [PATCH common v2 2/2] INotify: map address/netmask to cidr while parsing interfaces

2019-05-08 Thread Thomas Lamprecht
On 5/3/19 9:28 AM, Dominik Csapak wrote: > this allows us to always show the 'address' the 'netmask' and the 'cidr' > both for ipv4 and ipv6 > > there is a small api change involved in one scenario: > if one manually changed the address to cidr format like > '10.0.0.4/24' > > we now get from

Re: [pve-devel] [PATCH common v2 2/2] INotify: map address/netmask to cidr while parsing interfaces

2019-05-08 Thread Thomas Lamprecht
On 5/3/19 9:28 AM, Dominik Csapak wrote: > this allows us to always show the 'address' the 'netmask' and the 'cidr' > both for ipv4 and ipv6 > > there is a small api change involved in one scenario: > if one manually changed the address to cidr format like > '10.0.0.4/24' > > we now get from

Re: [pve-devel] [PATCH ifupdown2 2/3] fix ipforwarding

2019-05-08 Thread Thomas Lamprecht
On 5/6/19 6:25 AM, Alexandre Derumier wrote: > Currently ifupdown2 disable forwarding if not defined with ip-forward > on interfaces, or if bridge don't have an address (breaking inet dhcp) > > We need to keep classic ifupdown behaviour is there any upstream issue/discussion regarding this? > >

[pve-devel] applied: [PATCH ifupdown2 1/3] upstream fix for error: 'NoneType' object has no attribute '__getitem__'

2019-05-08 Thread Thomas Lamprecht
On 5/6/19 6:24 AM, Alexandre Derumier wrote: > Signed-off-by: Alexandre Derumier > --- > ...ge-fix-NoneType-object-has-no-attribute-_.patch | 32 > ++ > .../pve/0006-bridge-up-skip-tap-veth-fwpr.patch| 30 > debian/patches/series

Re: [pve-devel] [PATCH container 2/2] vm_stop: add nokill-after-timeout parameter

2019-05-08 Thread Thomas Lamprecht
On 5/8/19 1:58 PM, Thomas Lamprecht wrote: > This allows to have the same semantics as qemu-server: > * immediate hard-kill > * shutdown with kill after timeout > * shutdown without kill after timeout > > And thus we finally can move the vm_shutdown API call to a correct > semantic, i.e., do not i

[pve-devel] [PATCH container 1/2] vm_stop: remove unused exit_timeout parameter

2019-05-08 Thread Thomas Lamprecht
No call-site used this parameter, and thus it was dead code, remove it not only for cleanup sake but also to make space for a new "nokill-after-timeout" parameter, comming in a future patch. Signed-off-by: Thomas Lamprecht --- src/PVE/LXC.pm | 10 ++ 1 file changed, 2 insertions(+), 8 de

[pve-devel] [PATCH container 2/2] vm_stop: add nokill-after-timeout parameter

2019-05-08 Thread Thomas Lamprecht
This allows to have the same semantics as qemu-server: * immediate hard-kill * shutdown with kill after timeout * shutdown without kill after timeout And thus we finally can move the vm_shutdown API call to a correct semantic, i.e., do not immediate hard kill if forceStop is not passed but rather

Re: [pve-devel] [PATCH cd-builder 2/2] fix #1999: create a tree view for qm listsnapshot

2019-05-08 Thread Thomas Lamprecht
On 5/3/19 11:48 AM, Rhonda D'Vine wrote: > The look of the tree is based on the GUI variant, so that we have a > consistent output when run multiple times, too. > in principle ok, comments to implementation details below, thanks! > Signed-off-by: Rhonda D'Vine > --- > PVE/CLI/qm.pm | 63 > +++

[pve-devel] [PATCH manager] ui: NodeSelector: check status field for offline nodes

2019-05-08 Thread Dominik Csapak
the memory stat is not available if the user has no audit privilges on /nodes/NODENAME but the status is always available also it makes simple more sense to check if it is online not only if the memory value is there Signed-off-by: Dominik Csapak --- www/manager6/form/NodeSelector.js | 2 +- 1

Re: [pve-devel] [PATCH cd-builder 1/2] fix #1999: sort listsnapshot output by snaptime

2019-05-08 Thread Thomas Lamprecht
On 5/3/19 11:48 AM, Rhonda D'Vine wrote: > Signed-off-by: Rhonda D'Vine > --- > PVE/CLI/qm.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm > index cea2549..fc06fa5 100755 > --- a/PVE/CLI/qm.pm > +++ b/PVE/CLI/qm.pm > @@ -922,7 +922,7 @@ o

Re: [pve-devel] [PATCH docs] document ids for status.cfg

2019-05-08 Thread Thomas Lamprecht
On 4/11/19 10:06 AM, Dominik Csapak wrote: > Signed-off-by: Dominik Csapak applied, but can you please try to start adding some short, for human (not machine) intended, tags, that would be great. E.g.: > ext. metric server: document IDs in configuration > --- > pve-external-metric-server.adoc