Re: [pve-devel] qemu : add disk option for physical/logical block (could improve windows guest performance wit ceph)

2019-05-15 Thread Dietmar Maurer
> could we add this as disk option ? (not defined by default). Sounds like a good idea. Maybe we can even set a better default (512e)? ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] qemu : add disk option for physical/logical block (could improve windows guest performance wit ceph)

2019-05-15 Thread Alexandre DERUMIER
Hi, A guy have reported on ceph mailing, a feature which is helping windows guest with ceph https://review.opendev.org/#/c/658283/ "Add support for configuring the physical_block_size and logical_block_size hints of Cinder RBD volumes using the new 'disk_geometry' configuration option. Ceph

Re: [pve-devel] pve-firewall: default loglevel behaviour change

2019-05-15 Thread Alexandre DERUMIER
Thanks ! Also, about new log ratelimit https://git.proxmox.com/?p=pve-firewall.git;a=blobdiff;f=src/PVE/Firewall.pm;h=48e630004bf424c2db578aad3e60eb61db42f8e6;hp=ba1cb5f5924af094fe647f98d40e2703eca96ff4;hb=cc37e0005d0617e405883fd12b80faf65cedb153;hpb=95ed90a9a8418173ab7cac2d0c1f6ddd04c376cc it's

[pve-devel] [PATCH container 1/2] fix #1451: add more mount options for containers

2019-05-15 Thread Oguz Bektas
added atime-related options (noatime, nodiratime, strictatime, relatime), and some other security-related mount options (noexec, nosuid, nobarrier, nodev) for container mountpoints (and rootfs). Signed-off-by: Oguz Bektas --- src/PVE/LXC.pm| 19 +-- src/PVE/LXC/Config.pm

[pve-devel] [PATCH 0/2] fix #1451: extra mount options for cts

2019-05-15 Thread Oguz Bektas
pve-container: Oguz Bektas (1): fix #1451: add more mount options for containers src/PVE/LXC.pm| 19 +-- src/PVE/LXC/Config.pm | 26 ++ 2 files changed, 43 insertions(+), 2 deletions(-) pve-manager: Oguz Bektas (1): fix #1451: add more mount

[pve-devel] [PATCH manager 2/2] fix #1451: add more mount options to containers in gui

2019-05-15 Thread Oguz Bektas
adds atime related options (noatime, nodiratime, relatime, strictatime) and other extra mount options for performance (nobarrier) and security (noexec, nosuid, nodev). Signed-off-by: Oguz Bektas --- i tried to group the options by security or performance relation. the placement is open to

[pve-devel] [PATCH storage 0/1] Fix for ZFS over iSCSI on Solaris 11

2019-05-15 Thread David Hedbor
I'm testing out ZFS over iSCSI with a Oracle Solaris 11.3 server (Sparc based specifically). It almost works - what doesn't work is when I try to act on the disk in any way (such as start KVM). Specifically it is unable to find the LUN. Looking at the source, it seems like Proxmox runs:

[pve-devel] [PATCH storage 1/1] storage: iscsi: Fix LunCmd for Comstar on Oracle Solaris 11

2019-05-15 Thread David Hedbor
Fix #2213: ZFS over iSCSI doesn't work with Solaris 11.3 Signed-off-by: David Hedbor --- PVE/Storage/LunCmd/Comstar.pm | 31 ++- 1 file changed, 26 insertions(+), 5 deletions(-) diff --git a/PVE/Storage/LunCmd/Comstar.pm b/PVE/Storage/LunCmd/Comstar.pm index

[pve-devel] [PATCH firewall] Remove redundant logging of packets passing the tap chain.

2019-05-15 Thread Christian Ebner
Incomming and outgoing packets passing the firewall bridge were unneccessarily logged, leading to double entries. The first log entry occurred when passing the bridge, the second when the packets fate was decided (ACCEPT/DROP/REJECT). Signed-off-by: Christian Ebner --- src/PVE/Firewall.pm | 4

Re: [pve-devel] pve-firewall: default loglevel behaviour change

2019-05-15 Thread Christian Ebner
Hi Alexandre, you are right, logging the packets passing the firewall bridge seems a bit overkill and redundant. Will send a patch to fix this. > On May 15, 2019 at 4:08 PM Alexandre DERUMIER wrote: > > > Hi, > > since this commit > > >

[pve-devel] applied: [PATCH qemu-server] fix ceph volume with krbd not mapped for file_size_info

2019-05-15 Thread Thomas Lamprecht
On 5/15/19 12:53 PM, Mira Limbeck wrote: > file_size_info can't find the file if it is not mapped beforehand when > using krbd and returns 0 which we interpret as the disk not existing. > vdisk_alloc is called but the disk already exists. with this patch we call > activate_volume before trying

[pve-devel] applied: [PATCH manager] fix #2185: add option to change nfs version on gui

2019-05-15 Thread Thomas Lamprecht
On 5/15/19 3:21 PM, Oguz Bektas wrote: > this enables us to specify an nfs version while editing/creating an nfs > mount. it used to default to vers=3 without the ability to change it in > gui. now it supports: 3, 4, 4.1 and 4.2 > > it should also be possible to add further options in the future

[pve-devel] pve-firewall: default loglevel behaviour change

2019-05-15 Thread Alexandre DERUMIER
Hi, since this commit https://git.proxmox.com/?p=pve-firewall.git;a=blobdiff;f=src/PVE/Firewall.pm;h=ccc5d7ffb62f1ef4c4d59e363192f512c88742c9;hp=6ac303831a62f630d437ef0e0508decd2b72f5ac;hb=3489f8a2b9597201fe8e42fa5832507f96169619;hpb=33efd363ab32d3f8f6a9c49e481cb62a8da40b5d @@ -2341,10

Re: [pve-devel] [PATCH manager] fix #2185: add option to change nfs version on gui

2019-05-15 Thread Oguz Bektas
hi, should have been v3, forgot to add changelog as well.. v2 -> v3: * only send values["delete"] when editing an existing storage i.e. if !me.isCreate * add deleteEmpty: false in column On Wed, May 15, 2019 at 03:21:56PM +0200, Oguz Bektas wrote: > this enables us to specify an nfs

[pve-devel] [PATCH manager] fix #2185: add option to change nfs version on gui

2019-05-15 Thread Oguz Bektas
this enables us to specify an nfs version while editing/creating an nfs mount. it used to default to vers=3 without the ability to change it in gui. now it supports: 3, 4, 4.1 and 4.2 it should also be possible to add further options in the future (rsize, wsize, timeo, etc.) on this screen.

[pve-devel] applied: [PATCH common] JSONSchema: sort keys when dumping config

2019-05-15 Thread Thomas Lamprecht
On 4/17/19 8:56 AM, Thomas Lamprecht wrote: > Signed-off-by: Thomas Lamprecht > --- > src/PVE/JSONSchema.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm > index 51ef3ab..f0192c2 100644 > --- a/src/PVE/JSONSchema.pm > +++

[pve-devel] applied: [PATCH manager v2 2/2] gui: node: change syslog to JournalView and journal api

2019-05-15 Thread Thomas Lamprecht
On 5/15/19 11:15 AM, Dominik Csapak wrote: > Signed-off-by: Dominik Csapak > --- > www/manager6/node/Config.js | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/www/manager6/node/Config.js b/www/manager6/node/Config.js > index 831d2e02..700ca611 100644 > ---

[pve-devel] applied: [PATCH manager v2 1/2] node: add journal api

2019-05-15 Thread Thomas Lamprecht
On 5/15/19 11:15 AM, Dominik Csapak wrote: > this uses the new journalreader instead of journalctl, which is a bit > faster and can read from/to cursor and returns a start/end cursor > > also you can give an unix epoch as time parameters > > Signed-off-by: Dominik Csapak > --- >

Re: [pve-devel] [PATCH widget-toolkit v2 1/1] add panel/JournalView

2019-05-15 Thread Thomas Lamprecht
On 5/15/19 11:15 AM, Dominik Csapak wrote: > similar to LogView, but expects the result from the /node/journal api call, > which is an array of strings, with start/endcursor instead of > an array of objects with line numbers > > the new api call also does not accept start line numbers and limit,

[pve-devel] [PATCH qemu-server] fix ceph volume with krbd not mapped for file_size_info

2019-05-15 Thread Mira Limbeck
file_size_info can't find the file if it is not mapped beforehand when using krbd and returns 0 which we interpret as the disk not existing. vdisk_alloc is called but the disk already exists. with this patch we call activate_volume before trying file_size_info. on ceph with krbd it maps the

[pve-devel] [PATCH common 1/1] Fix #545: Allow descriptive names for network bridges and bonds

2019-05-15 Thread Dominic Jäger
Allowing more descriptive names for network bridges and bonds makes their identification easier. Signed-off-by: Dominic Jäger --- src/PVE/INotify.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm index b660041..75e5010 100644 ---

[pve-devel] [PATCH docu] Fix #545: Update allowed network device names

2019-05-15 Thread Dominic Jäger
Signed-off-by: Dominic Jäger --- pve-network.adoc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pve-network.adoc b/pve-network.adoc index 9e0c439..2a78dd1 100644 --- a/pve-network.adoc +++ b/pve-network.adoc @@ -32,12 +32,12 @@ We currently use the following naming

Re: [pve-devel] [PATCH pmg-api v2 1/1] node: add journal api

2019-05-15 Thread Dominik Csapak
disregard this for now, copying was not enough ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH manager v2 1/2] node: add journal api

2019-05-15 Thread Dominik Csapak
this uses the new journalreader instead of journalctl, which is a bit faster and can read from/to cursor and returns a start/end cursor also you can give an unix epoch as time parameters Signed-off-by: Dominik Csapak --- PVE/API2/Nodes.pm | 71

[pve-devel] [PATCH manager v2 2/2] gui: node: change syslog to JournalView and journal api

2019-05-15 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- www/manager6/node/Config.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/www/manager6/node/Config.js b/www/manager6/node/Config.js index 831d2e02..700ca611 100644 --- a/www/manager6/node/Config.js +++ b/www/manager6/node/Config.js @@

[pve-devel] [PATCH widget-toolkit/manager/pmg-api v2] improve syslog tab

2019-05-15 Thread Dominik Csapak
this series aims to improve the nodes syslog tab, by changing journalctl to a slimmer, slightly faster binary called journalreader the big improvement is that it returns/accepts cursors, making it possible to get only the entries we need the name journalreader is nothing i am particularly fond

[pve-devel] [PATCH pmg-api v2 1/1] node: add journal api

2019-05-15 Thread Dominik Csapak
this uses the new journalreader instead of journalctl, which is a bit faster and can read from/to cursor and returns a start/end cursor also you can give an unix epoch as time parameters Signed-off-by: Dominik Csapak --- PMG/API2/Nodes.pm | 71

[pve-devel] [PATCH widget-toolkit v2 1/1] add panel/JournalView

2019-05-15 Thread Dominik Csapak
similar to LogView, but expects the result from the /node/journal api call, which is an array of strings, with start/endcursor instead of an array of objects with line numbers the new api call also does not accept start line numbers and limit, so it is necessary to handle it differently

[pve-devel] applied: [PATCH storage] pvesm set: handle deletion of properties

2019-05-15 Thread Thomas Lamprecht
On 5/14/19 4:24 PM, Thomas Lamprecht wrote: > the delete parameter get's injected by the SectionConfigs > updateSchem, but we need to handle it ourself in the code > This makes the following possible: > > pvesm set STORAGEID --delete property > > Also the API equivalent is now possible. Adapted

Re: [pve-devel] [PATCH storage] pvesm set: handle deletion of properties

2019-05-15 Thread Thomas Lamprecht
On 5/15/19 10:14 AM, Dominik Csapak wrote: > works like expected, there is some issue in the context though (comment > inline) > > On 5/14/19 4:24 PM, Thomas Lamprecht wrote: >> the delete parameter get's injected by the SectionConfigs >> updateSchem, but we need to handle it ourself in the code

[pve-devel] applied: [PATCH common] prevent autovivification of sectionconfig options

2019-05-15 Thread Thomas Lamprecht
On 5/15/19 10:03 AM, Dominik Csapak wrote: > If, somehow, someone passes a config to check_config with keys set > that are not in the options for that type, this fixed check > lead to autovivification, meaning that any future calls to the same > worker had an additional option for that type which

Re: [pve-devel] [PATCH storage] pvesm set: handle deletion of properties

2019-05-15 Thread Dominik Csapak
works like expected, there is some issue in the context though (comment inline) On 5/14/19 4:24 PM, Thomas Lamprecht wrote: the delete parameter get's injected by the SectionConfigs updateSchem, but we need to handle it ourself in the code This makes the following possible: pvesm set

[pve-devel] [PATCH common] prevent autovivification of sectionconfig options

2019-05-15 Thread Dominik Csapak
If, somehow, someone passes a config to check_config with keys set that are not in the options for that type, this fixed check lead to autovivification, meaning that any future calls to the same worker had an additional option for that type which is not optional this lead to a wrongfully deleting

Re: [pve-devel] Bug in Firewall for KVM

2019-05-15 Thread Detlef Bracker
Correction: The IP-Filter blocks only traffic from inside to outside and not as I have written from outside to inside! Am 15.05.2019 um 09:07 schrieb Detlef Bracker: Dear, their are 2 bugs (or thats features?) in the firewall with VM with Cloud-Init! ( a) When in VM -> Cloud-Init ->

[pve-devel] Bug in Firewall for KVM

2019-05-15 Thread Detlef Bracker
Dear, their are 2 bugs (or thats features?) in the firewall with VM with Cloud-Init! ( a) When in VM -> Cloud-Init -> Network-Interface:  firewall set on AND b) VM -> Firewall -> Options -> IP-Filter: set on ) AND c) VM -> Firewall -> Options -> Firewall: set off / set on - is equal

Re: [pve-devel] [PATCH cluster v3] add generic data broadcast interface

2019-05-15 Thread Thomas Lamprecht
On 5/14/19 11:15 AM, Dominik Csapak wrote: > similar to how we handle the cluster wide tasklist and rrd data, > have an interface that can sync data across the cluster > > this data is only transient and will not be written to disk > > we can use this for a number of things, e.g. listing ceph

Re: [pve-devel] [PATCH] cherry pick MDS fixes from stable 4.14.119

2019-05-15 Thread Thomas Lamprecht
On 5/15/19 8:24 AM, Thomas Lamprecht wrote: > On 5/15/19 7:57 AM, Thomas Lamprecht wrote: >> With some manual merging, most of it straight forward, cherry-pick >> the all but the two PowerPC and S390 patches from the 4.14.119 >> released by Greg KH[0]. It mainly comes with some mitigation for >>

Re: [pve-devel] [PATCH] cherry pick MDS fixes from stable 4.14.119

2019-05-15 Thread Thomas Lamprecht
On 5/15/19 7:57 AM, Thomas Lamprecht wrote: > With some manual merging, most of it straight forward, cherry-pick > the all but the two PowerPC and S390 patches from the 4.14.119 > released by Greg KH[0]. It mainly comes with some mitigation for > MDS[1][3][4][5], for best result a microupdate of