Re: [pve-devel] [PATCH manager 13/20] ceph: mds: adapt creation api path to the mon/mgr scheme

On 6/4/19 2:47 PM, Dominik Csapak wrote: > so no name in the path > > Signed-off-by: Dominik Csapak > --- > PVE/API2/Ceph/MDS.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/PVE/API2/Ceph/MDS.pm b/PVE/API2/Ceph/MDS.pm > index 532eb404..5aa59c0f 100644 > ---

Re: [pve-devel] [PATCH manager 11/20] ceph: osd: rework creation with ceph-volume

Hi, It could be great to have 2 others improvements: add support for multiple osd by disk (can by usefull for nvme) #ceph-volume lvm batch --osds-per-device /dev/sdX add support for encryption #ceph-volume lvm . --dmcrypt - Mail original - De: "Dominik Csapak" À: "pve-devel"

[pve-devel] applied: [PATCH manager] drop references to un-maintained sheepdog plugin

as already announced over two months ago[0], remove the unofficial SheepDog plugin now completely. Besides that it was never fully supported in Proxmox VE one of its main developer and ex-maintainer declared it as abandoned[1], and thus just let's remove it, git allows to resurrect it any time if

[pve-devel] applied: [PATCH storage] drop un-maintained sheepdog plugin

as already announced over two months ago[0], remove the unofficial SheepDog plugin now completely. Besides that it was never fully supported in Proxmox VE one of its main developer and ex-maintainer declared it as abandoned[1], and thus just let's remove it, git allows to resurrect it any time if

[pve-devel] applied: [PATCH qemu-server] drop references to un-maintained sheepdog plugin

we remove it from pve-storage as it's abandoned Signed-off-by: Thomas Lamprecht --- PVE/QemuServer.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index ff593a6..fac4dfe 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -54,7

[pve-devel] applied: [PATCH manager 09/20] ceph: add ceph-volume helper

On 6/4/19 2:47 PM, Dominik Csapak wrote: > those will be needed for creation/destruction of nautilus osds > > Signed-off-by: Dominik Csapak > --- > PVE/Ceph/Tools.pm | 33 + > 1 file changed, 33 insertions(+) > applied

[pve-devel] applied: [PATCH manager 10/20] ceph: add db/wal size helper

On 6/4/19 2:47 PM, Dominik Csapak wrote: > reads the sizes from the ceph config db first, then from the > ceph config, first from the osd section then global > > Signed-off-by: Dominik Csapak > --- > PVE/Ceph/Tools.pm | 28 > 1 file changed, 28 insertions(+)

[pve-devel] applied: [PATCH manager 08/20] ceph: mon: use ceph_service_cmd to enable/disable the systemd service

On 6/4/19 2:47 PM, Dominik Csapak wrote: > Signed-off-by: Dominik Csapak > --- > PVE/API2/Ceph/MON.pm | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > applied ___ pve-devel mailing list pve-devel@pve.proxmox.com

[pve-devel] applied: [PATCH manager 07/20] ceph: mgr: delete auth key on destruction

On 6/4/19 2:47 PM, Dominik Csapak wrote: > Signed-off-by: Dominik Csapak > --- > PVE/Ceph/Services.pm | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) applied ___ pve-devel mailing list pve-devel@pve.proxmox.com

[pve-devel] applied: [PATCH] pvecm: remove mtunnel

it was a mistake to move it here in the first place, and now we can finally drop it again, as no PVE version can exist in 6.0, or latest 5.4 which still tries to use this one. The one we will keep using is the one in qm from qemu-server, as there we have full access to all it's perl modules

[pve-devel] [PATCH qemu 1/2] fix #2190: Base64 encode SMBIOS value strings in order to allow more characters

On some occasions e.g. license checking, the manufacturer string in the SMBIOS settings edit has to allow characters such as whitespaces. https://forum.proxmox.com/threads/proxmox-and-windows-rok-license-for-dell.53236/ In principle SMBIOS allows to pass any zero terminated string to the

[pve-devel] [PATCH manager 2/2] fix #2190: Base64 encode SMBIOS value strings in order to allow more characters

On some occasions e.g. license checking, the manufacturer string in the SMBIOS settings edit has to allow characters such as whitespaces. https://forum.proxmox.com/threads/proxmox-and-windows-rok-license-for-dell.53236/ In principle SMBIOS allows to pass any zero terminated string to the

[pve-devel] [PATCH 0/2] fix #2190: Base64 encode SMBIOS value strings in order to allow more characters

On some occasions e.g. license checking, the manufacturer string in the SMBIOS settings edit has to allow characters such as whitespaces. https://forum.proxmox.com/threads/proxmox-and-windows-rok-license-for-dell.53236/ In principle SMBIOS allows to pass any zero terminated string to the

[pve-devel] applied: [PATCH manager 05/20] ceph: add an index for mgr services

On 6/4/19 2:47 PM, Dominik Csapak wrote: > Signed-off-by: Dominik Csapak > --- > PVE/API2/Ceph/MGR.pm | 64 > > 1 file changed, 64 insertions(+) applied, although not too happy with the nested hash accesses here too, but kept them for now as

[pve-devel] applied: [PATCH manager 04/20] ceph: factor out the service info generation

On 6/4/19 2:47 PM, Dominik Csapak wrote: > and include a call to $type metadata to include the version > applied, with a code cleanup for the hash accesses in get_services_info > Signed-off-by: Dominik Csapak > --- > PVE/API2/Ceph/MDS.pm | 21 +++-- > PVE/API2/Ceph/MGR.pm | 1

[pve-devel] applied: [PATCH manager 02/20] ceph: get_local_services: also check /var/lib/ceph/$type

On 6/4/19 2:47 PM, Dominik Csapak wrote: > so we do not miss disabled services > > Signed-off-by: Dominik Csapak > --- > PVE/Ceph/Services.pm | 12 +--- > 1 file changed, 9 insertions(+), 3 deletions(-) > applied ___ pve-devel mailing list

[pve-devel] applied: [PATCH manager 03/20] ceph: refactor broadcast_ceph_services and get_cluster_service

On 6/4/19 2:47 PM, Dominik Csapak wrote: > and use the broadcast when a service is added/removed > we will use 'get_cluster_service' in the future when we generate a list > of services of a specific type > > Signed-off-by: Dominik Csapak > --- applied

[pve-devel] [PATCH manager 15/20] gui: ceph: use ServiceList for MDS list

Signed-off-by: Dominik Csapak --- www/manager6/ceph/FS.js | 171 +++- 1 file changed, 9 insertions(+), 162 deletions(-) diff --git a/www/manager6/ceph/FS.js b/www/manager6/ceph/FS.js index 53261af8..d128982e 100644 --- a/www/manager6/ceph/FS.js +++

[pve-devel] [PATCH manager 16/20] gui: ceph: rework OSD Create window

to reflect the changes on the backend (no filestore, db/wal size) Signed-off-by: Dominik Csapak --- www/manager6/ceph/OSD.js | 101 ++- 1 file changed, 73 insertions(+), 28 deletions(-) diff --git a/www/manager6/ceph/OSD.js b/www/manager6/ceph/OSD.js

[pve-devel] [PATCH manager 02/20] ceph: get_local_services: also check /var/lib/ceph/$type

so we do not miss disabled services Signed-off-by: Dominik Csapak --- PVE/Ceph/Services.pm | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/PVE/Ceph/Services.pm b/PVE/Ceph/Services.pm index 08a47773..3206e323 100644 --- a/PVE/Ceph/Services.pm +++

[pve-devel] [PATCH manager 17/20] gui: ceph: reword Cleanup

since we do not only cleanup paritions anymore Signed-off-by: Dominik Csapak --- www/manager6/ceph/OSD.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/ceph/OSD.js b/www/manager6/ceph/OSD.js index 1711d7be..6c5cb498 100644 --- a/www/manager6/ceph/OSD.js +++

[pve-devel] [PATCH manager 20/20] gui: ceph: dashboard

this fixes the dashboard when one views it on a node alternatively, we can add a node specific metadata api call Signed-off-by: Dominik Csapak --- www/manager6/ceph/Status.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/ceph/Status.js

[pve-devel] [PATCH manager 11/20] ceph: osd: rework creation with ceph-volume

this completely rewrites the ceph os creation api call using ceph-volume since ceph-disk is not available anymore breaking changes: no filestore anymore, journal_dev -> db_dev it is now possible to give a specific size for db/wal, default is to read from ceph db/config and fallback is 10% of osd

[pve-devel] [PATCH manager 04/20] ceph: factor out the service info generation

and include a call to $type metadata to include the version Signed-off-by: Dominik Csapak --- PVE/API2/Ceph/MDS.pm | 21 +++-- PVE/API2/Ceph/MGR.pm | 1 + PVE/API2/Ceph/MON.pm | 20 ++-- PVE/Ceph/Services.pm | 50

[pve-devel] [PATCH manager 14/20] gui: ceph: add ServiceList component and use it

this is an abstraction for listing Ceph Services with a few improvements: * start/stop/restart buttons for all services (incl. icons) * a syslog button to view the syslog of that service * correct reloading behaviour when creating/destroying Signed-off-by: Dominik Csapak ---

[pve-devel] [PATCH manager 06/20] ceph: remove 'exclude-manager' api parameter

since we will have a seperate gui for the manager, we do not need this anymore this is a breaking api change Signed-off-by: Dominik Csapak --- PVE/API2/Ceph/MON.pm | 27 --- 1 file changed, 27 deletions(-) diff --git a/PVE/API2/Ceph/MON.pm b/PVE/API2/Ceph/MON.pm index

[pve-devel] [PATCH manager 05/20] ceph: add an index for mgr services

Signed-off-by: Dominik Csapak --- PVE/API2/Ceph/MGR.pm | 64 1 file changed, 64 insertions(+) diff --git a/PVE/API2/Ceph/MGR.pm b/PVE/API2/Ceph/MGR.pm index c1d38d7a..d8f5427d 100644 --- a/PVE/API2/Ceph/MGR.pm +++ b/PVE/API2/Ceph/MGR.pm @@

[pve-devel] [PATCH manager 19/20] gui: ceph: use taskDone functionality for reloading

instead of simply reloading when the window is closed Signed-off-by: Dominik Csapak --- www/manager6/ceph/OSD.js | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/www/manager6/ceph/OSD.js b/www/manager6/ceph/OSD.js index 708ba274..f1789df6 100644 ---

[pve-devel] [PATCH manager 03/20] ceph: refactor broadcast_ceph_services and get_cluster_service

and use the broadcast when a service is added/removed we will use 'get_cluster_service' in the future when we generate a list of services of a specific type Signed-off-by: Dominik Csapak --- PVE/API2/Ceph/MON.pm| 2 ++ PVE/API2/Cluster.pm | 8 +++- PVE/Ceph/Services.pm| 36

[pve-devel] [PATCH manager 01/20] ceph: add missing link for 'restart' in ceph api

Signed-off-by: Dominik Csapak --- PVE/API2/Ceph.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/API2/Ceph.pm b/PVE/API2/Ceph.pm index 21253276..185bbdea 100644 --- a/PVE/API2/Ceph.pm +++ b/PVE/API2/Ceph.pm @@ -89,6 +89,7 @@ __PACKAGE__->register_method ({ { name => 'mds'

[pve-devel] [PATCH manager 09/20] ceph: add ceph-volume helper

those will be needed for creation/destruction of nautilus osds Signed-off-by: Dominik Csapak --- PVE/Ceph/Tools.pm | 33 + 1 file changed, 33 insertions(+) diff --git a/PVE/Ceph/Tools.pm b/PVE/Ceph/Tools.pm index b74e2572..9610483a 100644 --- a/PVE/Ceph/Tools.pm

[pve-devel] [PATCH manager 00/20] get ceph nautilus ready

this series updates our backend to be ceph nautilus ready (especially ceph-volume) and also improves the gui quite a bit it features: * select db/wal and the size on the gui for new osds * show manager seperately of monitors * be able to start/stop/restart all services * view the syslog of

[pve-devel] [PATCH manager 07/20] ceph: mgr: delete auth key on destruction

Signed-off-by: Dominik Csapak --- PVE/Ceph/Services.pm | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/PVE/Ceph/Services.pm b/PVE/Ceph/Services.pm index 0448c7d1..ec0aef14 100644 --- a/PVE/Ceph/Services.pm +++ b/PVE/Ceph/Services.pm @@ -327,7 +327,7 @@ sub create_mgr

[pve-devel] [PATCH manager 18/20] gui: ceph: leave osd selected after reloading

Signed-off-by: Dominik Csapak --- www/manager6/ceph/OSD.js | 11 +++ 1 file changed, 11 insertions(+) diff --git a/www/manager6/ceph/OSD.js b/www/manager6/ceph/OSD.js index 6c5cb498..708ba274 100644 --- a/www/manager6/ceph/OSD.js +++ b/www/manager6/ceph/OSD.js @@ -356,9 +356,20 @@

[pve-devel] [PATCH manager 13/20] ceph: mds: adapt creation api path to the mon/mgr scheme

so no name in the path Signed-off-by: Dominik Csapak --- PVE/API2/Ceph/MDS.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/API2/Ceph/MDS.pm b/PVE/API2/Ceph/MDS.pm index 532eb404..5aa59c0f 100644 --- a/PVE/API2/Ceph/MDS.pm +++ b/PVE/API2/Ceph/MDS.pm @@ -88,7 +88,7 @@

[pve-devel] [PATCH manager 10/20] ceph: add db/wal size helper

reads the sizes from the ceph config db first, then from the ceph config, first from the osd section then global Signed-off-by: Dominik Csapak --- PVE/Ceph/Tools.pm | 28 1 file changed, 28 insertions(+) diff --git a/PVE/Ceph/Tools.pm b/PVE/Ceph/Tools.pm index

[pve-devel] [PATCH manager 08/20] ceph: mon: use ceph_service_cmd to enable/disable the systemd service

Signed-off-by: Dominik Csapak --- PVE/API2/Ceph/MON.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/PVE/API2/Ceph/MON.pm b/PVE/API2/Ceph/MON.pm index d5872b42..c7d5e915 100644 --- a/PVE/API2/Ceph/MON.pm +++ b/PVE/API2/Ceph/MON.pm @@ -249,7 +249,7 @@

[pve-devel] [PATCH manager 12/20] ceph: osd: rework osd destroy to work with ceph-volume

with this, osd destruction is left to ceph-volume if the osd was created with ceph-volume, else our old code remains mostly the same since we want to be able to destroy upgraded osds Signed-off-by: Dominik Csapak --- PVE/API2/Ceph/OSD.pm | 76 ++--

Re: [pve-devel] [PATCH qemu-server 1/3] add function to dump cloudinit config

On 6/4/19 11:31 AM, Mira Limbeck wrote: > This adds a function to dump the generated cloudinit config. Only one > can be dumped at a time, either 'user', 'network' or 'meta'. > > The logic to get user, network and metadata is copied from the other > path that also creates the ISO image to keep it

[pve-devel] applied: [PATCH storage 1/3] Diskmanage: extract nvme wearout from smartctl text

On 6/4/19 1:05 PM, Dominik Csapak wrote: > extract the info from the line: > Percentage Used: XX% > > also adapt the tests > > Signed-off-by: Dominik Csapak > --- applied all three patches, thanks! ___ pve-devel mailing list

[pve-devel] [PATCH storage 2/3] Diskmanage: fix incorrect variable usage

sysdir is a string, we wanted sysdata Signed-off-by: Dominik Csapak --- PVE/Diskmanage.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/Diskmanage.pm b/PVE/Diskmanage.pm index fbb0341..10b5737 100644 --- a/PVE/Diskmanage.pm +++ b/PVE/Diskmanage.pm @@ -511,7 +511,7 @@

[pve-devel] [PATCH storage 3/3] Diskmanage: correctly add wearout value of 0

if wearout is 0 we showed 'N/A' instead of 100% (wearout is really the 'life left' value) Signed-off-by: Dominik Csapak --- PVE/Diskmanage.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/Diskmanage.pm b/PVE/Diskmanage.pm index 10b5737..41158f4 100644 ---

[pve-devel] [PATCH storage 1/3] Diskmanage: extract nvme wearout from smartctl text

extract the info from the line: Percentage Used: XX% also adapt the tests Signed-off-by: Dominik Csapak --- PVE/Diskmanage.pm | 13 +++-- test/disk_tests/nvme_smart/disklist_expected.json | 2 +-

[pve-devel] applied: [PATCH storage v2 0/4] ceph nautilus preparation

On 6/4/19 12:35 PM, Dominik Csapak wrote: > this series adds/refactors some functionaliy we will need for ceph > nautilus > > changes from v1: > * better journal disk condition > * better handling of parameter in get_disks > * do not leave devname undef in append_partition > * use

[pve-devel] [PATCH storage v2 3/4] Diskmanage: add append_partition sub

we will use this for adding a partition to a disk when using a device for ceph osd db/wal which already has partitions on it first we search for the highest partition number, then add the partition and search for the resulting device (we cannot assume to simply append the number, e.g. from

[pve-devel] [PATCH storage v2 1/4] Disks API: allow also unused disks for db/wal

since we will create a pv/vg/lv on it with nautilus Signed-off-by: Dominik Csapak --- changes from v1: * switch test for used and lvm * pull 'not' out and reverse tests -> this makes it more understandable when a disk is a valid journal PVE/API2/Disks.pm | 2 +- 1 file changed, 1

[pve-devel] [PATCH storage v2 2/4] Diskmanage: allow get_disks to take multiple disks

we now expect the first parameter to be either a string with a single disk, or an array ref with a list of disks this way we can get the info of multiple disks simultaneously while not iterating over all disks this will be used to get the info for osd/db/wal disk Signed-off-by: Dominik Csapak

[pve-devel] [PATCH storage v2 4/4] tests: test get_disks single/multi disk filter

this executes all tests again with each disk as a single parameter and all disks again as an array ref Signed-off-by: Dominik Csapak --- new in v2 test/disklist_test.pm | 22 ++ 1 file changed, 22 insertions(+) diff --git a/test/disklist_test.pm b/test/disklist_test.pm

[pve-devel] [PATCH storage v2 0/4] ceph nautilus preparation

this series adds/refactors some functionaliy we will need for ceph nautilus changes from v1: * better journal disk condition * better handling of parameter in get_disks * do not leave devname undef in append_partition * use dir_glob_foreach regex to parse partitionid * comment second

Re: [pve-devel] [PATCH qemu-server 0/3] add cloudinit config dump

Forgot to mention, applied on both master and stable-5 (where I developed it) cleanly. On 6/4/19 11:31 AM, Mira Limbeck wrote: The ability to dump the generated cloudinit config that's written to the ISO if no snippet is specified in combination with snippets should be enough for almost every

[pve-devel] [PATCH qemu-server 1/3] add function to dump cloudinit config

This adds a function to dump the generated cloudinit config. Only one can be dumped at a time, either 'user', 'network' or 'meta'. The logic to get user, network and metadata is copied from the other path that also creates the ISO image to keep it simple and not complicate the other code path

[pve-devel] [PATCH qemu-server 0/3] add cloudinit config dump

The ability to dump the generated cloudinit config that's written to the ISO if no snippet is specified in combination with snippets should be enough for almost every cloudinit user to get started on custom cloudinit configs. The 2nd patch depends on the 1st, and the 3rd depends on the 2nd. For

[pve-devel] [PATCH qemu-server 2/3] add new API for dumping cloudinit config

Adds the path '{vmid}/cloudinit/dump' and requires the parameter 'type' that's either 'user', 'network' or 'meta'. Returns the generated config as string. Signed-off-by: Mira Limbeck --- PVE/API2/Qemu.pm | 32 1 file changed, 32 insertions(+) diff --git

[pve-devel] [PATCH qemu-server 3/3] add qm command for cloudinit config dump

Adds the command 'qm cloudinit dump ' where type is either 'user', 'network' or 'meta' as specified in the API. Signed-off-by: Mira Limbeck --- Do we want the additional '\n' after the config? The config itself already contains a newline at the end. PVE/CLI/qm.pm | 7 +++ 1 file changed,

Re: [pve-devel] [PATCH storage 3/5] Diskmanage: add append_partition sub

On 6/4/19 10:29 AM, Dominik Csapak wrote: > On 6/4/19 10:25 AM, Thomas Lamprecht wrote: >> On 6/4/19 9:21 AM, Dominik Csapak wrote: >>> [snip] >>> + >>> +    my $newpartid = 1; >>> +    dir_glob_foreach("/sys/block/$devname", qr/\Q$devname\E.+/, sub { >>> +    my ($part) = @_; >>> + >>> +    my

Re: [pve-devel] [PATCH storage 2/5] Diskmanage: allow get_disks to take multiple disks

On 6/4/19 10:25 AM, Dominik Csapak wrote: > On 6/4/19 10:08 AM, Thomas Lamprecht wrote: >> On 6/4/19 9:21 AM, Dominik Csapak wrote: >>> [snip] >>> +    if (defined($disks)) { >>> +    if (!ref($disks) || ref($disks) ne 'ARRAY') { >> >> .. || ref($disk) eq 'SCALAR' >> >> as all else doe not makes

Re: [pve-devel] [PATCH storage 3/5] Diskmanage: add append_partition sub

On 6/4/19 10:25 AM, Thomas Lamprecht wrote: On 6/4/19 9:21 AM, Dominik Csapak wrote: we will use this for adding a partition to a disk when using a device for ceph osd db/wal which already has partitions on it first we search for the highest partition number, then add the partition and search

Re: [pve-devel] [PATCH storage 1/5] Disks API: allow also unused disks for db/wal

On 6/4/19 10:20 AM, Dominik Csapak wrote: > On 6/4/19 9:54 AM, Thomas Lamprecht wrote: >> On 6/4/19 9:21 AM, Dominik Csapak wrote: >>> since we will create a pv/vg/lv on it with nautilus >>> >>> Signed-off-by: Dominik Csapak >>> --- >>>   PVE/API2/Disks.pm | 2 +- >>>   1 file changed, 1

[pve-devel] applied: [PATCH storage 5/5] tests: improve error handling of run_disk_tests

On 6/4/19 9:21 AM, Dominik Csapak wrote: > if Diskmanage.pm has a syntax error, this will now catch it > during build > > Signed-off-by: Dominik Csapak > --- > test/run_disk_tests.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/test/run_disk_tests.pl

[pve-devel] applied: [PATCH storage 4/5] LVMPlugin: factor out the lv creation

On 6/4/19 9:21 AM, Dominik Csapak wrote: > we will want to create lvs manually for ceph nautilus db/wal devices > > Signed-off-by: Dominik Csapak applied > --- > PVE/Storage/LVMPlugin.pm | 20 +--- > 1 file changed, 17 insertions(+), 3 deletions(-) > > diff --git

Re: [pve-devel] [PATCH storage 2/5] Diskmanage: allow get_disks to take multiple disks

On 6/4/19 10:08 AM, Thomas Lamprecht wrote: On 6/4/19 9:21 AM, Dominik Csapak wrote: we now expect the first parameter to be either a string with a single disk, or an array ref with a list of disks this way we can get the info of multiple disks simultaneously while not iterating over all disks

Re: [pve-devel] [PATCH storage 3/5] Diskmanage: add append_partition sub

On 6/4/19 9:21 AM, Dominik Csapak wrote: > we will use this for adding a partition to a disk when using a device > for ceph osd db/wal which already has partitions on it > > first we search for the highest partition number, then add the partition > and search for the resulting device (we cannot

Re: [pve-devel] [PATCH storage 1/5] Disks API: allow also unused disks for db/wal

On 6/4/19 9:54 AM, Thomas Lamprecht wrote: On 6/4/19 9:21 AM, Dominik Csapak wrote: since we will create a pv/vg/lv on it with nautilus Signed-off-by: Dominik Csapak --- PVE/API2/Disks.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/API2/Disks.pm

Re: [pve-devel] [PATCH storage 2/5] Diskmanage: allow get_disks to take multiple disks

On 6/4/19 9:21 AM, Dominik Csapak wrote: > we now expect the first parameter to be either a string with a single > disk, or an array ref with a list of disks > > this way we can get the info of multiple disks simultaneously while > not iterating over all disks > > this will be used to get the

Re: [pve-devel] [PATCH storage 1/5] Disks API: allow also unused disks for db/wal

On 6/4/19 9:21 AM, Dominik Csapak wrote: > since we will create a pv/vg/lv on it with nautilus > > Signed-off-by: Dominik Csapak > --- > PVE/API2/Disks.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/PVE/API2/Disks.pm b/PVE/API2/Disks.pm > index ce4acee..7433066

[pve-devel] applied: [PATCH pve-network 0/4] config generation improvments

On 6/4/19 7:03 AM, Alexandre Derumier wrote: > don't stop on error for config generation, we'll check that > with ifquery > > Alexandre Derumier (4): > vxlan: use vxlan interface name > generateconfig: use uplink$id if interface don't exist > generateconfig test: remove verify merge config

[pve-devel] [PATCH storage 3/5] Diskmanage: add append_partition sub

we will use this for adding a partition to a disk when using a device for ceph osd db/wal which already has partitions on it first we search for the highest partition number, then add the partition and search for the resulting device (we cannot assume to simply append the number, e.g. from

[pve-devel] [PATCH storage 1/5] Disks API: allow also unused disks for db/wal

since we will create a pv/vg/lv on it with nautilus Signed-off-by: Dominik Csapak --- PVE/API2/Disks.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/API2/Disks.pm b/PVE/API2/Disks.pm index ce4acee..7433066 100644 --- a/PVE/API2/Disks.pm +++ b/PVE/API2/Disks.pm @@

[pve-devel] [PATCH storage 0/5] ceph nautilus preparation

this series adds/refactors some functionaliy we will need for ceph nautilus Dominik Csapak (5): Disks API: allow also unused disks for db/wal Diskmanage: allow get_disks to take multiple disks Diskmanage: add append_partition sub LVMPlugin: factor out the lv creation tests: improve

[pve-devel] [PATCH storage 2/5] Diskmanage: allow get_disks to take multiple disks

we now expect the first parameter to be either a string with a single disk, or an array ref with a list of disks this way we can get the info of multiple disks simultaneously while not iterating over all disks this will be used to get the info for osd/db/wal disk Signed-off-by: Dominik Csapak

[pve-devel] [PATCH storage 5/5] tests: improve error handling of run_disk_tests

if Diskmanage.pm has a syntax error, this will now catch it during build Signed-off-by: Dominik Csapak --- test/run_disk_tests.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/run_disk_tests.pl b/test/run_disk_tests.pl index d955a02..c1a698e 100755 ---

[pve-devel] [PATCH storage 4/5] LVMPlugin: factor out the lv creation

we will want to create lvs manually for ceph nautilus db/wal devices Signed-off-by: Dominik Csapak --- PVE/Storage/LVMPlugin.pm | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/PVE/Storage/LVMPlugin.pm b/PVE/Storage/LVMPlugin.pm index 9ad7979..50a4f64