On Wed, Jul 03, 2019 at 03:41:54PM +0200, Thomas Lamprecht wrote:
> On 7/3/19 3:28 PM, Fabian Grünbichler wrote:
> > Signed-off-by: Fabian Grünbichler
> > ---
> > this is mainly relevant for stable-5, since master already drops them from
> > the storage.cfg
> >
> > PVE/CLI/pve5to6.pm | 4 +++-
thanks, applied all three with the following follow-up(s):
diff --git a/src/PVE/Service/pve_firewall.pm b/src/PVE/Service/pve_firewall.pm
index 39ceb39..d78bcb1 100755
--- a/src/PVE/Service/pve_firewall.pm
+++ b/src/PVE/Service/pve_firewall.pm
@@ -272,14 +272,14 @@ __PACKAGE__->register_method ({
only suggest not recommend, remove scipy,numpy and sklearn
dependencies(they are not used)
Signed-off-by: Dominik Csapak
---
...mgr-dependencies-to-more-sane-values.patch | 46 +++
patches/series| 1 +
2 files changed, 47 insertions(+)
create
we do not need it if auth is 'none'
Signed-off-by: Dominik Csapak
---
PVE/API2/Ceph/OSD.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/PVE/API2/Ceph/OSD.pm b/PVE/API2/Ceph/OSD.pm
index 42dee361..064f6b03 100644
--- a/PVE/API2/Ceph/OSD.pm
+++ b/PVE/API2/Ceph/OSD.pm
@@
we map '$type addr' to '$type_addr' anyway in the ceph.conf parser,
so this is not necessary
also use 'public_addr' if it is set
Signed-off-by: Dominik Csapak
---
PVE/Ceph/Services.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/Ceph/Services.pm
this fixes an issue where only one monitor is in mon_host, which is
offline, prevents a client connection
Signed-off-by: Dominik Csapak
---
PVE/API2/Ceph/MON.pm | 6 ++
1 file changed, 6 insertions(+)
diff --git a/PVE/API2/Ceph/MON.pm b/PVE/API2/Ceph/MON.pm
index df73450a..b59d2e59 100644
if for some reason the cluster does not have this key, generate it
Signed-off-by: Dominik Csapak
---
PVE/API2/Ceph/OSD.pm | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/PVE/API2/Ceph/OSD.pm b/PVE/API2/Ceph/OSD.pm
index 064f6b03..85197107 100644
---
On 7/3/19 3:28 PM, Fabian Grünbichler wrote:
> Signed-off-by: Fabian Grünbichler
> ---
> this is mainly relevant for stable-5, since master already drops them from
> the storage.cfg
>
> PVE/CLI/pve5to6.pm | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git
On 7/3/19 3:28 PM, Fabian Grünbichler wrote:
> Signed-off-by: Fabian Grünbichler
> ---
> PVE/CLI/pve5to6.pm | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/PVE/CLI/pve5to6.pm b/PVE/CLI/pve5to6.pm
> index e9373288..215f7430 100644
> --- a/PVE/CLI/pve5to6.pm
> +++
Signed-off-by: Stefan Reiter
---
pvecm.adoc | 5 +
1 file changed, 5 insertions(+)
diff --git a/pvecm.adoc b/pvecm.adoc
index 7525bb5..d8f2341 100644
--- a/pvecm.adoc
+++ b/pvecm.adoc
@@ -309,6 +309,11 @@ cluster again, you have to
* then join it, as explained in the previous section.
On 7/3/19 2:40 PM, Tim Marx wrote:
> Signed-off-by: Tim Marx
> ---
> PVE/API2/Ceph/MON.pm | 9 +
> 1 file changed, 9 insertions(+)
>
> diff --git a/PVE/API2/Ceph/MON.pm b/PVE/API2/Ceph/MON.pm
> index e8963264..4090612d 100644
> --- a/PVE/API2/Ceph/MON.pm
> +++ b/PVE/API2/Ceph/MON.pm
>
Signed-off-by: Fabian Grünbichler
---
this is mainly relevant for stable-5, since master already drops them from the
storage.cfg
PVE/CLI/pve5to6.pm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/PVE/CLI/pve5to6.pm b/PVE/CLI/pve5to6.pm
index c167ebca..e9373288 100644
---
mainly because it looks strange to get a warning after the upgrade is
finished and noout has been removed again
Signed-off-by: Fabian Grünbichler
---
PVE/CLI/pve5to6.pm | 22 +++---
1 file changed, 15 insertions(+), 7 deletions(-)
diff --git a/PVE/CLI/pve5to6.pm
Signed-off-by: Fabian Grünbichler
---
PVE/CLI/pve5to6.pm | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/PVE/CLI/pve5to6.pm b/PVE/CLI/pve5to6.pm
index e9373288..215f7430 100644
--- a/PVE/CLI/pve5to6.pm
+++ b/PVE/CLI/pve5to6.pm
@@ -467,12 +467,13 @@ sub check_misc {
Signed-off-by: Fabian Grünbichler
---
PVE/CLI/pve5to6.pm | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/PVE/CLI/pve5to6.pm b/PVE/CLI/pve5to6.pm
index 215f7430..23280b97 100644
--- a/PVE/CLI/pve5to6.pm
+++ b/PVE/CLI/pve5to6.pm
@@ -468,10 +468,9 @@ sub check_misc {
Signed-off-by: Tim Marx
---
PVE/API2/Ceph/MON.pm | 9 +
1 file changed, 9 insertions(+)
diff --git a/PVE/API2/Ceph/MON.pm b/PVE/API2/Ceph/MON.pm
index e8963264..4090612d 100644
--- a/PVE/API2/Ceph/MON.pm
+++ b/PVE/API2/Ceph/MON.pm
@@ -16,6 +16,7 @@ use PVE::RESTHandler;
use
If no corosync.conf exists (i.e. a standalone node), the output is left
the same.
Signed-off-by: Stefan Reiter
---
Is there a project standard regarding list output formatting?
I personally think it looks good and readable, but consistency with other
CLI tools would of course be preferrable.
Signed-off-by: Stefan Reiter
---
There were so many in this file it actually bothered me :)
src/PVE/Service/pve_firewall.pm | 42 -
1 file changed, 21 insertions(+), 21 deletions(-)
diff --git a/src/PVE/Service/pve_firewall.pm b/src/PVE/Service/pve_firewall.pm
Calling cfs_read_file with no corosync.conf (i.e. on a standalone node)
returns {} instead of undef. The previous patches assumes undef for this
scenario. To avoid confusing checks all over the place, simply leave the
config as undef if no file exists.
Signed-off-by: Stefan Reiter
---
On 7/3/19 12:06 PM, Oguz Bektas wrote:
> On Wed, Jul 03, 2019 at 11:49:00AM +0200, Thomas Lamprecht wrote:
>> On 7/3/19 11:50 AM, Oguz Bektas wrote:
I do not want to die here, if one wants to continue, why not (e.g.,
the limit is not exactly 1024 but rather somewhere beteween 850-900
On Wed, Jul 03, 2019 at 11:49:00AM +0200, Thomas Lamprecht wrote:
> On 7/3/19 11:50 AM, Oguz Bektas wrote:
> >> I do not want to die here, if one wants to continue, why not (e.g.,
> >> the limit is not exactly 1024 but rather somewhere beteween 850-900
> >> MB, and also then the error is IMO not
On 7/3/19 11:50 AM, Oguz Bektas wrote:
>> I do not want to die here, if one wants to continue, why not (e.g.,
>> the limit is not exactly 1024 but rather somewhere beteween 850-900
>> MB, and also then the error is IMO not reasonable, proxinstall +
>> gtk-webkit + base system need ~ 300 MB memory,
hi,
On Wed, Jul 03, 2019 at 10:22:06AM +0200, Thomas Lamprecht wrote:
> On 7/2/19 3:17 PM, Oguz Bektas wrote:
> > show a message on screen about memory requirement, then die and abort
> > the installation.
> >
> > Signed-off-by: Oguz Bektas
> > ---
> > proxinstall | 5 +
> > 1 file
On 7/3/19 9:45 AM, Dominik Csapak wrote:
> if auth is 'none' there is no client keyring, so do not generate it and
> do not write it into the config
>
> Signed-off-by: Dominik Csapak
> ---
> PVE/API2/Ceph.pm | 8 ++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
applied, thanks!
On 7/2/19 4:44 PM, Stoiko Ivanov wrote:
> while testing the latest changes to the installer a few low-hanging fruit were
> noticed:
>
> * sometimes installations on zfs failed to boot when the disks contained
> labels
> from old zpools (e.g. a previous installation with raidZ2 and afterwards a
On 7/2/19 3:17 PM, Oguz Bektas wrote:
> show a message on screen about memory requirement, then die and abort
> the installation.
>
> Signed-off-by: Oguz Bektas
> ---
> proxinstall | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/proxinstall b/proxinstall
> index e6a29b3..f8dd1d6
On 7/3/19 9:42 AM, Dominik Csapak wrote:
> checking '$server:$subdir' is too strict to work in all cirumcstances,
> e.g. adding/removing a monitor would mean that it is not the same
> anymore, same if one is adding/removing the ports from the config
>
> check only if the subdir is the same and if
if auth is 'none' there is no client keyring, so do not generate it and
do not write it into the config
Signed-off-by: Dominik Csapak
---
PVE/API2/Ceph.pm | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/PVE/API2/Ceph.pm b/PVE/API2/Ceph.pm
index 1ce74378..1036e24c
checking '$server:$subdir' is too strict to work in all cirumcstances,
e.g. adding/removing a monitor would mean that it is not the same
anymore, same if one is adding/removing the ports from the config
check only if the subdir is the same and if it is a cephfs
this way, it still returns true if
On 7/2/19 12:03 PM, Oguz Bektas wrote:
> Signed-off-by: Oguz Bektas
> ---
> html-common/ack_template.htm | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/html-common/ack_template.htm b/html-common/ack_template.htm
> index 2f7cf32..aefe855 100644
> ---
On 7/3/19 8:43 AM, Dominik Csapak wrote:
> 0 is falsy, we have to check for definedness
> also adapt the tests so we test for this
>
> Signed-off-by: Dominik Csapak
> ---
applied, thanks!
___
pve-devel mailing list
pve-devel@pve.proxmox.com
0 is falsy, we have to check for definedness
also adapt the tests so we test for this
Signed-off-by: Dominik Csapak
---
PVE/Diskmanage.pm | 2 +-
test/disk_tests/usages/disklist_expected.json | 2 +-
test/disk_tests/usages/lvs| 2 +-
3 files
32 matches
Mail list logo