[pve-devel] applied: [PATCH installer] prompt user if a vgrename is OK for exisiting 'pve'/'pmg' VGs

2019-07-09 Thread Thomas Lamprecht
If one has a 'pve' VG on a disks not selected as install target (e.g., on re-installation to different disk or if putting a used disk into another server where PVE was installed on) the vgcreate call errored out, as for creation the VG names must be unique. Cope with that by asking the users if a

Re: [pve-devel] [PATCH cluster] Workaround for broken corosync-qdevice SysV config

2019-07-09 Thread Thomas Lamprecht
On 7/9/19 5:31 PM, Stefan Reiter wrote: > > The author of corosync-qdevice is aware of the issue: > https://bugs.launchpad.net/ubuntu/+source/corosync-qdevice/+bug/1809682 FYI, those are not the authors of corosync-qdevice, those are some ubuntu maintainers, AFAICT from the ubuntu-ha team. The

[pve-devel] applied-series: [PATCH installer v2 0/2] create unique identifiers on install

2019-07-09 Thread Thomas Lamprecht
On 7/9/19 6:09 PM, Stoiko Ivanov wrote: > while looking into #1603 I misread and focussed on /etc/hostid, instead of > /etc/machine-id. Upon closer inspection the problem is similar for both of > them: > Our installer shipped one version of the file for both ids, while it should > create them

[pve-devel] spice new streaming option

2019-07-09 Thread Alexandre DERUMIER
Hi, I have open a bugzilla https://bugzilla.proxmox.com/show_bug.cgi?id=2272 seem that since spice 0.14.1, they are a new option to stream video from guest directly to spice client. This need a new qemu device -device

[pve-devel] [PATCH installer v2 1/2] fix #1603: create a new and unique machine-id

2019-07-09 Thread Stoiko Ivanov
see machine-id(5). The machine-id serves as a partial replacement to the hostid (gethostid(3)) used by systemd and should be unique. By generating a new one with `systemd-id128 new` (see machine-id(5), sd-id128(3)) after the installation the newly installed system gets a unique one.

[pve-devel] [PATCH installer v2 2/2] copy /etc/hostid from installer root to target

2019-07-09 Thread Stoiko Ivanov
/etc/hostid is used by ZFS (spl.ko) to determine which host last imported a pool creating and importing a pool with one hostid during install and booting with a different one (or none) leads to the system refusing to import the pool see spl-module-parameters(5) and zpool(8). by copying the

[pve-devel] [PATCH installer v2 0/2] create unique identifiers on install

2019-07-09 Thread Stoiko Ivanov
while looking into #1603 I misread and focussed on /etc/hostid, instead of /etc/machine-id. Upon closer inspection the problem is similar for both of them: Our installer shipped one version of the file for both ids, while it should create them uniquely for the system. Addionally the /etc/hostid

[pve-devel] [PATCH cluster] Workaround for broken corosync-qdevice SysV config

2019-07-09 Thread Stefan Reiter
Since we use only systemd, we can simply remove this file. Without removing, the "systemd enable" command fails, complaining about unset run-levels. Signed-off-by: Stefan Reiter --- The author of corosync-qdevice is aware of the issue:

[pve-devel] [PATCH v2 cluster] fix #2270: allow custom lxc options to be restored as root

2019-07-09 Thread Stefan Reiter
Seems to be a regression introduced with f360d7f16b094fa258cf82d2557d06f3284435e4 (related to #2028). $conf->{'lxc'} would always be defined, hence we never replaced it with the restored options. Co-developed-by: Oguz Bektas Signed-off-by: Stefan Reiter --- Nevermind v1, perl arrays and hashes

[pve-devel] [PATCH container] fix #2270: allow custom lxc options to be restored as root

2019-07-09 Thread Stefan Reiter
Seems to be a regression introduced with f360d7f16b094fa258cf82d2557d06f3284435e4 (related to #2028). $conf->{'lxc'} would always be defined, hence we never replaced it with the restored options. We now merge LXC options individually. We can't just overwrite, since that would undo the fix

[pve-devel] [PATCH installer 2/2] copy /etc/hostid from installer root to target

2019-07-09 Thread Stoiko Ivanov
/etc/hostid is used by ZFS (spl.ko) to determine which host last imported a pool creating and importing a pool with one hostid during install and booting with a different one (or none) leads to the system refusing to import the pool see spl-module-parameters(5) and zpool(8). by copying the

[pve-devel] [PATCH installer 1/2] fix #1603: create a new and unique machine-id

2019-07-09 Thread Stoiko Ivanov
see machine-id(5). The machine-id serves as a partial replacement to the hostid (gethostid(3)) used by systemd and should be unique, by not shipping one in the ISO and generating one after the installation the installer ensures the uniqueness. Signed-off-by: Stoiko Ivanov --- proxinstall | 3

[pve-devel] [PATCH installer 0/2] create unique identifiers on install

2019-07-09 Thread Stoiko Ivanov
while looking into #1603 I misread and focussed on /etc/hostid, instead of /etc/machine-id. Upon closer inspection the problem is similar for both of them: Our installer shipped one version of the file for both ids, while it should create them uniquely for the system. Addionally the /etc/hostid

[pve-devel] applied: [PATCH http-server] decode_urlencoded: cope with undefined values

2019-07-09 Thread Thomas Lamprecht
Avoids syslog/journal warning like: > Use of uninitialized value $v in substitution (s///) at > /usr/share/perl5/PVE/APIServer/AnyEvent.pm line 648. If one passes a "value-less" GET argument to a request, e.g., GET /?debug Besides the fact that this allows us to even use such arguments it also

[pve-devel] [PATCH v2 docs 1/2] Use correct xref: syntax and add pvecm prefix

2019-07-09 Thread Stefan Reiter
Signed-off-by: Stefan Reiter --- No changes for v2. As mentioned, I did not find any references to the changed names. pvecm.adoc | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/pvecm.adoc b/pvecm.adoc index 05756ca..1c0b9e7 100644 ---

[pve-devel] [PATCH v2 docs 2/2] Update pvecm documentation for corosync 3

2019-07-09 Thread Stefan Reiter
Parts about multicast and RRP have been removed entirely. Instead, a new section 'Corosync Redundancy' has been added explaining the concept of links and link priorities. Signed-off-by: Stefan Reiter --- v1 -> v2: * Spelling mistakes * Rewording to improve clarity * Fixed redundancy

Re: [pve-devel] [PATCH docs 2/2] Update pvecm documentation for corosync 3

2019-07-09 Thread Aaron Lauterer
Added a few notes, mostly regarding style and readability. On 7/8/19 6:26 PM, Stefan Reiter wrote: Parts about multicast and RRP have been removed entirely. Instead, a new section 'Corosync Redundancy' has been added explaining the concept of links and link priorities. Signed-off-by: Stefan

Re: [pve-devel] [PATCH docs 2/2] Update pvecm documentation for corosync 3

2019-07-09 Thread Stefan Reiter
Thanks for feedback! Regarding patch 1/2: I grep'd through the sources and could not find any references to the heading names I changed. A quick look through the GUI also didn't reveal any obvious references. Some of my own notes inline, I will send v2 today. On 7/9/19 9:19 AM, Thomas

Re: [pve-devel] [PATCH docs 2/2] Update pvecm documentation for corosync 3

2019-07-09 Thread Thomas Lamprecht
On 7/8/19 6:26 PM, Stefan Reiter wrote: > Parts about multicast and RRP have been removed entirely. Instead, a new > section 'Corosync Redundancy' has been added explaining the concept of > links and link priorities. > note bad at all, still some notes inline. > Signed-off-by: Stefan Reiter >