On 7/15/19 10:20 AM, Dominik Csapak wrote:
> do not warn in case there exist nautilus osds
> since the upgrade has to be done by the time a user should add new
> osds, it does not make sense to warn in that case
>
> Signed-off-by: Dominik Csapak
> ---
> PVE/CLI/pve5to6.pm | 3 ++-
> 1 file
On 7/15/19 3:34 PM, Aaron Lauterer wrote:
> Used `audio0` with the extra `0` to be able to add support for multiple
> audio devices in the future if it will ever be necessary.
>
why a format string and not a simple direct enum for the "audioX"?
Are there (potential) additional options we can
On 7/15/19 3:38 PM, Fabian Grünbichler wrote:
> to manage manually selected kernel list.
>
> Signed-off-by: Fabian Grünbichler
> ---
> v2: incorporated Aaron's feedback
>
applied series, thanks!
___
pve-devel mailing list
pve-devel@pve.proxmox.com
On 7/12/19 3:16 PM, Fabian Grünbichler wrote:
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> this series
> - adds a few helpers
> - adds the latest kernel of the second to latest kernel series to the
> list of automatically synced kernels
> -
On 7/15/19 3:51 PM, Fabian Grünbichler wrote:
On Mon, Jul 15, 2019 at 03:39:59PM +0200, Aaron Lauterer wrote:
On 7/15/19 3:07 PM, Fabian Grünbichler wrote:
On Mon, Jul 15, 2019 at 02:37:45PM +0200, Aaron Lauterer wrote:
Found a missing possible missing comma
On 7/15/19 11:35 AM, Fabian
On 7/15/19 3:10 PM, Fabian Grünbichler wrote:
> with some basic usage hints and warnings. this should be extended once
> proper support for loading of keys at boot time is merged upstream, or
> when we support it directly in pve-storage.
>
> Signed-off-by: Fabian Grünbichler
> ---
>
On Mon, Jul 15, 2019 at 03:39:59PM +0200, Aaron Lauterer wrote:
> On 7/15/19 3:07 PM, Fabian Grünbichler wrote:
> > On Mon, Jul 15, 2019 at 02:37:45PM +0200, Aaron Lauterer wrote:
> > > Found a missing possible missing comma
> > >
> > > On 7/15/19 11:35 AM, Fabian Grünbichler wrote:
> > > >
On 7/15/19 3:39 PM, Aaron Lauterer wrote:
>
>
> On 7/15/19 3:07 PM, Fabian Grünbichler wrote:
>> On Mon, Jul 15, 2019 at 02:37:45PM +0200, Aaron Lauterer wrote:
>>> Found a missing possible missing comma
>>>
>>> On 7/15/19 11:35 AM, Fabian Grünbichler wrote:
Signed-off-by: Fabian
On 7/15/19 3:07 PM, Fabian Grünbichler wrote:
On Mon, Jul 15, 2019 at 02:37:45PM +0200, Aaron Lauterer wrote:
Found a missing possible missing comma
On 7/15/19 11:35 AM, Fabian Grünbichler wrote:
Signed-off-by: Fabian Grünbichler
---
system-booting.adoc | 3 ++-
1 file changed, 2
to manage manually selected kernel list.
Signed-off-by: Fabian Grünbichler
---
v2: incorporated Aaron's feedback
system-booting.adoc | 39 +++
1 file changed, 23 insertions(+), 16 deletions(-)
diff --git a/system-booting.adoc b/system-booting.adoc
index
Signed-off-by: Fabian Grünbichler
---
v2: dropped a comma, added a 'the'
system-booting.adoc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/system-booting.adoc b/system-booting.adoc
index f40a469..82aa273 100644
--- a/system-booting.adoc
+++ b/system-booting.adoc
@@ -79,7
to match what the hook actually does in the latest version
Signed-off-by: Fabian Grünbichler
---
system-booting.adoc | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/system-booting.adoc b/system-booting.adoc
index 82aa273..2bd32a6 100644
--- a/system-booting.adoc
+++
Sorry, this is not part of the pve-manager repo but qemu-server.
Misconfiguration on my side...
On 7/15/19 3:34 PM, Aaron Lauterer wrote:
Signed-off-by: Aaron Lauterer
---
PVE/API2/Qemu.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index
Sorry, this is not part of the pve-manager repo but qemu-server.
Misconfiguration on my side...
On 7/15/19 3:34 PM, Aaron Lauterer wrote:
Signed-off-by: Aaron Lauterer
---
PVE/QemuServer/PCI.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/PVE/QemuServer/PCI.pm
Sorry, this is not part of the pve-manager repo but qemu-server.
Misconfiguration on my side...
On 7/15/19 3:34 PM, Aaron Lauterer wrote:
Used `audio0` with the extra `0` to be able to add support for multiple
audio devices in the future if it will ever be necessary.
Cleaned some old
Used `audio0` with the extra `0` to be able to add support for multiple
audio devices in the future if it will ever be necessary.
Cleaned some old commented out code regarding audio device support.
Signed-off-by: Aaron Lauterer
---
PVE/QemuServer.pm | 36 ++--
1
Signed-off-by: Aaron Lauterer
---
PVE/API2/Qemu.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index e2a63be..8be0b7b 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qemu.pm
@@ -260,6 +260,7 @@ my $hwtypeoptions = {
'tablet' => 1,
'vga' => 1,
Signed-off-by: Aaron Lauterer
---
www/css/ext6-pve.css | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/www/css/ext6-pve.css b/www/css/ext6-pve.css
index 535f8e60..bfb6fc8d 100644
--- a/www/css/ext6-pve.css
+++ b/www/css/ext6-pve.css
@@ -279,7 +279,8 @@
Signed-off-by: Aaron Lauterer
---
www/manager6/Makefile | 1 +
www/manager6/qemu/AudioEdit.js | 61 ++
2 files changed, 62 insertions(+)
create mode 100644 www/manager6/qemu/AudioEdit.js
diff --git a/www/manager6/Makefile b/www/manager6/Makefile
index
Signed-off-by: Aaron Lauterer
---
www/manager6/Utils.js | 15 +++
1 file changed, 15 insertions(+)
diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index 946b8709..3980b750 100644
--- a/www/manager6/Utils.js
+++ b/www/manager6/Utils.js
@@ -467,6 +467,21 @@
Signed-off-by: Aaron Lauterer
---
www/images/Makefile | 7 ---
www/images/icon-audio.svg | 2 ++
2 files changed, 6 insertions(+), 3 deletions(-)
create mode 100644 www/images/icon-audio.svg
diff --git a/www/images/Makefile b/www/images/Makefile
index b7e001f4..ac5ba7a4 100644
---
Including:
* permission checks
* disable button to add a new audio device if one already exists
Signed-off-by: Aaron Lauterer
---
www/manager6/qemu/HardwareView.js | 30 ++
1 file changed, 30 insertions(+)
diff --git a/www/manager6/qemu/HardwareView.js
Signed-off-by: Aaron Lauterer
---
PVE/QemuServer/PCI.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/PVE/QemuServer/PCI.pm b/PVE/QemuServer/PCI.pm
index d847146..9c72f3a 100644
--- a/PVE/QemuServer/PCI.pm
+++ b/PVE/QemuServer/PCI.pm
@@ -79,6 +79,7 @@ my $devices = {
'virtio14' => {
Add support for audio devices on the CLI and GUI.
Audio devices that can be selected are:
* ich9-intel-hda
* intel-hda (ich6)
* AC97 (for older OS versions)
Right now this supports only one audio device per VM but is written so
that adding support for multiple audio devices should be easy to add.
Signed-off-by: Dominik Csapak
---
we could also add a new 'encrypted' column, but this would currently
only show anything for osd, in the future maybe for zfs?
www/manager6/node/Disks.js | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git
On 7/15/19 3:06 PM, Fabian Grünbichler wrote:
> looks good to me. @Thomas - do you want to fix this up when
> applying or should I send a v2?
Normally both is OK for me, but today I'd prefer a v2 :)
>
> On Mon, Jul 15, 2019 at 02:36:25PM +0200, Aaron Lauterer wrote:
>> some thoughts from my
with some basic usage hints and warnings. this should be extended once
proper support for loading of keys at boot time is merged upstream, or
when we support it directly in pve-storage.
Signed-off-by: Fabian Grünbichler
---
local-zfs.adoc | 80 ++
On Mon, Jul 15, 2019 at 02:37:45PM +0200, Aaron Lauterer wrote:
> Found a missing possible missing comma
>
> On 7/15/19 11:35 AM, Fabian Grünbichler wrote:
> > Signed-off-by: Fabian Grünbichler
> > ---
> > system-booting.adoc | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
>
looks good to me. @Thomas - do you want to fix this up when
applying or should I send a v2?
On Mon, Jul 15, 2019 at 02:36:25PM +0200, Aaron Lauterer wrote:
> some thoughts from my side regarding readability:
>
> On 7/15/19 11:35 AM, Fabian Grünbichler wrote:
> > to manage manually selected
Found a missing possible missing comma
On 7/15/19 11:35 AM, Fabian Grünbichler wrote:
Signed-off-by: Fabian Grünbichler
---
system-booting.adoc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/system-booting.adoc b/system-booting.adoc
index c7f6534..fc8d896 100644
---
some thoughts from my side regarding readability:
On 7/15/19 11:35 AM, Fabian Grünbichler wrote:
to manage manually selected kernel list.
Signed-off-by: Fabian Grünbichler
---
reflecting my last, not-yet-applied series for pve-kernel-meta
system-booting.adoc | 39
Signed-off-by: Dominik Csapak
---
PVE/QemuServer.pm | 2 --
1 file changed, 2 deletions(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index b79362b..1d8e92c 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -5560,8 +5560,6 @@ sub vm_qmp_command {
sub vm_human_monitor_command {
sendkey does not return anything if it is succesful and the error otherwise
Signed-off-by: Dominik Csapak
---
PVE/QemuServer.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 9f29927..b79362b 100644
--- a/PVE/QemuServer.pm
+++
setData on an 'empty' store does not work in extjs debug mode
setting store to '{}' here does create a store on component creation
so the store is not 'empty'
Signed-off-by: Dominik Csapak
---
www/manager6/qemu/AgentIPView.js | 1 +
1 file changed, 1 insertion(+)
diff --git
The StdRemoveButton can now pass a delay parameter to the API.
It is set undefined as default so that users of the button
can set the parameter themselves.
Signed-off-by: Dominic Jäger
---
v3->v4: Make the delay undefined/optional
button/Button.js | 7 ++-
1 file changed, 6 insertions(+),
A default of 5 seems like a reasonable delay for removing backups from
the GUI.
Signed-off-by: Dominic Jäger
---
v3->v4: Move default value to users of StdRemoveButton
www/manager6/grid/BackupView.js | 1 +
www/manager6/storage/ContentView.js | 1 +
2 files changed, 2 insertions(+)
diff
Previously, the web GUI timed out when removing content (e.g. backup) took
too long. Doing the main part of the API DELETE call in a fork_worker solves
this.
Signed-off-by: Dominic Jäger
---
v3->v4: Unchanged
PVE/API2/Storage/Content.pm | 45 +
1 file
When removing content the web gui could time out when it took too long
(#582). This can be solved by starting a fork_worker.
The series adds an optional delay parameter to the API entry point. It also
adds the option to the StdRemoveButton. As #582 is about backup removal
the series makes the
to manage manually selected kernel list.
Signed-off-by: Fabian Grünbichler
---
reflecting my last, not-yet-applied series for pve-kernel-meta
system-booting.adoc | 39 +++
1 file changed, 23 insertions(+), 16 deletions(-)
diff --git a/system-booting.adoc
to match what the hook actually does in the latest version
Signed-off-by: Fabian Grünbichler
---
the hook previously only marked the series meta packages as not
autoremovable, but did not sync any of their kernels.
system-booting.adoc | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
Signed-off-by: Fabian Grünbichler
---
system-booting.adoc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/system-booting.adoc b/system-booting.adoc
index c7f6534..fc8d896 100644
--- a/system-booting.adoc
+++ b/system-booting.adoc
@@ -79,7 +79,8 @@ system boots even if the
On Mon, Jul 15, 2019 at 11:26:17AM +0200, Thomas Lamprecht wrote:
> Am 7/15/19 um 11:17 AM schrieb Dominik Csapak:
> >>
> >> and the case where some OSDs did not got yet "upgraded" to
> >> ceph-volume/nautilus
> >> but a new one was created cannot happen?
> >>
> > no it should not as the upgrade
Am 7/15/19 um 11:17 AM schrieb Dominik Csapak:
>>
>> and the case where some OSDs did not got yet "upgraded" to
>> ceph-volume/nautilus
>> but a new one was created cannot happen?
>>
> no it should not as the upgrade guide says
> -8<
> During the upgrade from Luminous to Nautilus it will
Am 7/15/19 um 11:06 AM schrieb Tim Marx:
> Signed-off-by: Tim Marx
> ---
> www/manager6/ceph/CephInstallWizard.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
applied, thanks!
___
pve-devel mailing list
pve-devel@pve.proxmox.com
and the case where some OSDs did not got yet "upgraded" to ceph-volume/nautilus
but a new one was created cannot happen?
no it should not as the upgrade guide says
-8<
During the upgrade from Luminous to Nautilus it will not be possible to
create a new OSD using a Luminous ceph-osd
Am 7/15/19 um 11:10 AM schrieb Dominik Csapak:
> On 7/15/19 10:48 AM, Thomas Lamprecht wrote:
>> Wouldn't it be simpler do, instead of all above, just do a dir_glob_foreach
>> on "/var/lib/ceph/osd/*" and read require_osd_release (not sure if that's
>> enough as heuristic, but could be) and print
On 7/15/19 10:48 AM, Thomas Lamprecht wrote:
Wouldn't it be simpler do, instead of all above, just do a dir_glob_foreach
on "/var/lib/ceph/osd/*" and read require_osd_release (not sure if that's
enough as heuristic, but could be) and print this out per OSD (so the user
actually knows_which_
Signed-off-by: Tim Marx
---
www/manager6/ceph/CephInstallWizard.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/ceph/CephInstallWizard.js
b/www/manager6/ceph/CephInstallWizard.js
index 776b2277..3c340543 100644
--- a/www/manager6/ceph/CephInstallWizard.js
+++
Am 7/15/19 um 10:20 AM schrieb Dominik Csapak:
> nautilus puts non running monitors also in the monmap, so
> only show as running when it has no quorum
>
applied with commit message fixup, thanks!
> this is also not 100% correct, but the only 'correct' alternative
> is to try and get/parse the
Am 7/15/19 um 10:20 AM schrieb Dominik Csapak:
> do not warn in case there exist nautilus osds
> since the upgrade has to be done by the time a user should add new
> osds, it does not make sense to warn in that case
>
> Signed-off-by: Dominik Csapak
> ---
> PVE/CLI/pve5to6.pm | 3 ++-
> 1 file
On 7/15/19 10:43 AM, Thomas Lamprecht wrote:
Am 7/15/19 um 10:20 AM schrieb Dominik Csapak:
nautilus puts non running monitors also in the monmap, so
only show as running when it has no quorum
s/no qurorum/quorum/ ??
oops, you are right of course ^^
this is also not 100% correct, but
Am 7/15/19 um 10:20 AM schrieb Dominik Csapak:
> nautilus puts non running monitors also in the monmap, so
> only show as running when it has no quorum
s/no qurorum/quorum/ ??
>
> this is also not 100% correct, but the only 'correct' alternative
> is to try and get/parse the systemd status of
nautilus puts non running monitors also in the monmap, so
only show as running when it has no quorum
this is also not 100% correct, but the only 'correct' alternative
is to try and get/parse the systemd status of the units and broadcast
it to the pmxcfs
Signed-off-by: Dominik Csapak
---
we can
do not warn in case there exist nautilus osds
since the upgrade has to be done by the time a user should add new
osds, it does not make sense to warn in that case
Signed-off-by: Dominik Csapak
---
PVE/CLI/pve5to6.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
54 matches
Mail list logo
