Re: [pve-devel] rbd: don't assert on writes to snapshots

2019-07-16 Thread Thomas Lamprecht
Hi, On 7/16/19 10:50 PM, Kitt wrote: > Hello. > > Would it be possible to add this patch to the bionic and dingo kernels and > fix the ceph snapshot hang issue? Yes, it would. The commit[0] from the diff you linked, looks OK. [0]: https://git.kernel.org/torvalds/c/b91a7bdca4439e286f26cdd6c15ed3

[pve-devel] rbd: don't assert on writes to snapshots

2019-07-16 Thread Kitt
Hello. Would it be possible to add this patch to the bionic and dingo kernels and fix the ceph snapshot hang issue? Diff: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/diff/drivers/block/rbd.c?id=b91a7bdca4439e286f26cdd6c15ed338e6a9fda2 diff --git a/drivers/block/rbd.c b/dri

[pve-devel] [PATCH kernel] fix #1042: inotify: increase watches, instances & queue default limits

2019-07-16 Thread Thomas Lamprecht
Some recent distributions running as a LXC container eat the relative low default limits up very fast. Thus increase all those (semi-related) limits by a factor of 512. This was chosen by using one of our bigger know CT setup (~1500 CTs per host) and the fact that I can have only a very low count (

Re: [pve-devel] [PATCH manager 4/5] Add icon for audio device

2019-07-16 Thread Aaron Lauterer
On 7/16/19 3:43 PM, Aaron Lauterer wrote: On 7/16/19 1:48 PM, Thomas Lamprecht wrote: On 7/15/19 3:34 PM, Aaron Lauterer wrote: Signed-off-by: Aaron Lauterer ---   www/images/Makefile   | 7 ---   www/images/icon-audio.svg | 2 ++   2 files changed, 6 insertions(+), 3 deletions(-)  

[pve-devel] [PATCH manager v2] gui: node disks: show if an osd is encrypted

2019-07-16 Thread Dominik Csapak
add a new 'encrypted' column, which is shows that info currently only for osds Signed-off-by: Dominik Csapak --- changes from v1: * add a seperate column for encryption info does not strictly need the pve-storage patches for detecting the osd encryption, but without them there is only a new empt

[pve-devel] [PATCH manager 1/2] ceph init: actually die on errors

2019-07-16 Thread Fabian Grünbichler
instead of silently ignoring them Signed-off-by: Fabian Grünbichler --- PVE/API2/Ceph.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/API2/Ceph.pm b/PVE/API2/Ceph.pm index 9c7b0dde..5a48e2d0 100644 --- a/PVE/API2/Ceph.pm +++ b/PVE/API2/Ceph.pm @@ -400,6 +400,7 @@ __PACKAGE__->register

[pve-devel] [PATCH manager 2/2] ceph destroymon: actually die on errors

2019-07-16 Thread Fabian Grünbichler
instead of silently ignoring them. since we are in a task worker here this is especially important - otherwise the task status/result is also wrong! Signed-off-by: Fabian Grünbichler --- PVE/API2/Ceph/MON.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/PVE/API2/Ceph/MON.pm b/PVE/API2/Ce

[pve-devel] [PATCH v2 cluster] API: correctly propagate $@ with nested locks

2019-07-16 Thread Fabian Grünbichler
PVE::Cluster::cfs_lock_file sets $@ and returns undef for all errors, including when $code dies. PVE::Tools::lock_file runs $code inside an eval as well, so just setting $@ is not enough when nesting these two types of locks. re-die with the inner error to actually propagate error messages and fai

Re: [pve-devel] [PATCH manager 4/5] Add icon for audio device

2019-07-16 Thread Aaron Lauterer
On 7/16/19 1:48 PM, Thomas Lamprecht wrote: On 7/15/19 3:34 PM, Aaron Lauterer wrote: Signed-off-by: Aaron Lauterer --- www/images/Makefile | 7 --- www/images/icon-audio.svg | 2 ++ 2 files changed, 6 insertions(+), 3 deletions(-) create mode 100644 www/images/icon-audio.svg

Re: [pve-devel] [PATCH cluster] config_change: correctly propagate $@ with nested locks

2019-07-16 Thread Thomas Lamprecht
On 7/16/19 3:30 PM, Fabian Grünbichler wrote: > On Tue, Jul 16, 2019 at 03:16:35PM +0200, Thomas Lamprecht wrote: >> On 7/16/19 2:18 PM, Fabian Grünbichler wrote: >>> + die $@ if !defined($res) && defined($@); >> >> Do you think the !defined($res) is important here? For a perl "exception" >>

Re: [pve-devel] [PATCH cluster] config_change: correctly propagate $@ with nested locks

2019-07-16 Thread Fabian Grünbichler
On Tue, Jul 16, 2019 at 03:16:35PM +0200, Thomas Lamprecht wrote: > On 7/16/19 2:18 PM, Fabian Grünbichler wrote: > > PVE::Cluster::cfs_lock_file sets $@ and returns undef for all errors, > > including when $code dies. PVE::Tools::lock_file runs $code inside an > > eval as well, so just setting $@

Re: [pve-devel] [PATCH cluster] config_change: correctly propagate $@ with nested locks

2019-07-16 Thread Thomas Lamprecht
On 7/16/19 2:18 PM, Fabian Grünbichler wrote: > PVE::Cluster::cfs_lock_file sets $@ and returns undef for all errors, > including when $code dies. PVE::Tools::lock_file runs $code inside an > eval as well, so just setting $@ is not enough when nesting these two > types of locks. > > re-die with th

Re: [pve-devel] [PATCH manager] gui: node disks: show if an osd is encrypted

2019-07-16 Thread Thomas Lamprecht
On 7/16/19 2:46 PM, Dominik Csapak wrote: > On 7/16/19 12:20 PM, Tim Marx wrote: >> I would prefer a new column, because I don't like these string extensions >> which probably aren't visible anyway if the column is to small. > > yeah makes sense, what about a general 'encryption' column where we

Re: [pve-devel] [PATCH manager] gui: node disks: show if an osd is encrypted

2019-07-16 Thread Dominik Csapak
On 7/16/19 12:20 PM, Tim Marx wrote: I would prefer a new column, because I don't like these string extensions which probably aren't visible anyway if the column is to small. yeah makes sense, what about a general 'encryption' column where we only show it (atm) for osds and leave it empty for

[pve-devel] [PATCH cluster] config_change: correctly propagate $@ with nested locks

2019-07-16 Thread Fabian Grünbichler
PVE::Cluster::cfs_lock_file sets $@ and returns undef for all errors, including when $code dies. PVE::Tools::lock_file runs $code inside an eval as well, so just setting $@ is not enough when nesting these two types of locks. re-die with the inner error to actually propagate error messages and fai

Re: [pve-devel] [PATCH manager 4/5] Add icon for audio device

2019-07-16 Thread Thomas Lamprecht
On 7/15/19 3:34 PM, Aaron Lauterer wrote: > Signed-off-by: Aaron Lauterer > --- > www/images/Makefile | 7 --- > www/images/icon-audio.svg | 2 ++ > 2 files changed, 6 insertions(+), 3 deletions(-) > create mode 100644 www/images/icon-audio.svg > > diff --git a/www/images/Makefile b/w

Re: [pve-devel] [PATCH manager 1/5] Add edit dialog for audio device

2019-07-16 Thread Thomas Lamprecht
On 7/15/19 3:34 PM, Aaron Lauterer wrote: > Signed-off-by: Aaron Lauterer > --- > www/manager6/Makefile | 1 + > www/manager6/qemu/AudioEdit.js | 61 ++ > 2 files changed, 62 insertions(+) > create mode 100644 www/manager6/qemu/AudioEdit.js > > diff --g

Re: [pve-devel] [PATCH manager 3/5] Add renderer for audio devices

2019-07-16 Thread Tim Marx
> > > Signed-off-by: Aaron Lauterer > --- > www/manager6/Utils.js | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js > index 946b8709..3980b750 100644 > --- a/www/manager6/Utils.js > +++ b/www/manager6/Utils.js > @@ -467,6

[pve-devel] Proxmox VE 6.0 released!

2019-07-16 Thread Martin Maurer
Hi all, We're excited to announce the final release of our Proxmox VE 6.0! It's based on the great Debian 10 codename "Buster" and the latest 5.0 Linux kernel, QEMU 4.0, LXC 3.1.0, ZFS 0.8.1, Ceph 14.2, Corosync 3.0, and more. This major release includes the latest Ceph Nautilus feautures and

Re: [pve-devel] [PATCH manager] gui: node disks: show if an osd is encrypted

2019-07-16 Thread Tim Marx
I would prefer a new column, because I don't like these string extensions which probably aren't visible anyway if the column is to small. Regarding the code, maybe you could use template-strings e.g. `Ceph osd.${data.osdid} ${tagtext}`? > > > Signed-off-by: Dominik Csapak > --- > we could a