Re: [pve-devel] [PATCH docs 1/2] Mention GUI for creating a cluster and adding nodes

2019-08-26 Thread Aaron Lauterer
Some things I would write differently. Mainly simpler, more precise language, avoiding clutter and reducing the amount of "you". On 8/22/19 4:53 PM, Stefan Reiter wrote: Signed-off-by: Stefan Reiter --- pvecm.adoc | 81 -- 1 file changed,

Re: [pve-devel] [PATCH manager] pve5to6: Add warning for some Gluster versions

2019-08-26 Thread Thomas Lamprecht
On 01.08.19 11:21, Dominic Jäger wrote: > Upgrading from PVE 5 to 6 works only with the Gluster packages from the > Debian repository. At least Gluster versions 5.8 to 6.4-1 have conflicts > with our packages. > > Signed-off-by: Dominic Jäger > --- > Tested on one VM with PVE 5.4 and upstream Glu

[pve-devel] applied: [PATCH qemu-server] close #2263: die on live migration with local cloudinit disk

2019-08-26 Thread Thomas Lamprecht
On 12.07.19 14:23, Mira Limbeck wrote: > Live migration with a local cloudinit disk was never intended to work. It did > however work to an extent that the migration completed but the disk on the > source node could not be deleted. Now die if a live migration is started with > a local cloudinit dis

Re: [pve-devel] Gitlab-ci

2019-08-26 Thread Kamil Trzciński
Did you think about using GitLab to at least to host all sources? I think that using Merge Requests workflow could actually be better and easier to contribute to than current mailing list. On Tue, Apr 17, 2018 at 10:53 AM Rene Jochum wrote: > On 2018-04-17 10:27, Dietmar Maurer wrote: > > I p

Re: [pve-devel] [PATCH manager] Close #2262: Add noVNC scale setting

2019-08-26 Thread Thomas Lamprecht
On 07.08.19 13:10, Dominic Jäger wrote: > Add a setting to choose the scale mode of the noVNC pop-up as well as the > embedded console in the content panel to "My Settings". Having both set to > local scaling was the most important use-case for the users. One setting for > both places is the simple

[pve-devel] [PATCH manager] api: fix nodes stats memory return type description

2019-08-26 Thread Tim Marx
Signed-off-by: Tim Marx --- PVE/API2/Nodes.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index 9921c9e1..bb232708 100644 --- a/PVE/API2/Nodes.pm +++ b/PVE/API2/Nodes.pm @@ -2125,7 +2125,7 @@ __PACKAGE__->register_method ({

[pve-devel] applied: [RFC container] mountpoints: create parent dirs with correct owner

2019-08-26 Thread Thomas Lamprecht
On 24.07.19 13:37, Fabian Grünbichler wrote: > otherwise unprivileged containers might end up with directories that > they cannot modify since they are owned by the user root in the host > namespace, instead of root inside the container. > > note: the problematic behaviour is only exhibited when a

[pve-devel] applied: [PATCH manager] api: fix nodes stats memory return type description

2019-08-26 Thread Thomas Lamprecht
On 26.08.19 13:13, Tim Marx wrote: > Signed-off-by: Tim Marx > --- > PVE/API2/Nodes.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm > index 9921c9e1..bb232708 100644 > --- a/PVE/API2/Nodes.pm > +++ b/PVE/API2/Nodes.pm > @@ -2125,7

[pve-devel] [PATCH qemu-server] Improve error output for queues

2019-08-26 Thread Aaron Lauterer
Add the name of the failed command to the error message, similar as the error messages when running a single command. --- Reason: I had a situation with a customer where we got an error but could not connect it to which command actually caused it. A similar but way hackier patch proved helpful to

[pve-devel] [PATCH firewall] fix use of uninitialized value

2019-08-26 Thread Mira Limbeck
$param->{rename} was not checked for definedness even though it is optional. This lead to a 'use of uninitialized value' when just updating the cidr. Signed-off-by: Mira Limbeck --- src/PVE/API2/Firewall/Aliases.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/PVE/API

[pve-devel] [PATCH container] don't leave fstrim lock if mount_all fails

2019-08-26 Thread Oguz Bektas
when a container has a mountpoint which can't be mounted for some reason, mount_all dies and the fstrim lock stays. prevent this by moving the call into eval, warn if any error occurs. Signed-off-by: Oguz Bektas --- src/PVE/CLI/pct.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

Re: [pve-devel] Gitlab-ci

2019-08-26 Thread Thomas Lamprecht
On 26.08.19 12:43, Kamil Trzciński wrote: > Did you think about using GitLab to at least to host all sources? For now that won't happen soon. > > I think that using Merge Requests workflow could actually be better and > easier to contribute to > than current mailing list. > IMO this depends on