[pve-devel] applied: [PATCH pve-docs] vxlan: remove "no bgp default ipv6-unicast"

On 09.09.19 17:58, Alexandre Derumier wrote: > This syntax don't exist > > Signed-off-by: Alexandre Derumier > --- > vxlan-and-evpn.adoc | 19 --- > 1 file changed, 19 deletions(-) > applied ___ pve-devel mailing list

[pve-devel] applied: [PATCH pve-network] frr: remove "no bgp default ipv6-unicast"

On 09.09.19 17:56, Alexandre Derumier wrote: > Signed-off-by: Alexandre Derumier > --- > PVE/Network/SDN/FrrPlugin.pm | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/PVE/Network/SDN/FrrPlugin.pm b/PVE/Network/SDN/FrrPlugin.pm > index 8a1f86c..79214a7 100644 > ---

[pve-devel] [PATCH pve-docs] vxlan: remove "no bgp default ipv6-unicast"

This syntax don't exist Signed-off-by: Alexandre Derumier --- vxlan-and-evpn.adoc | 19 --- 1 file changed, 19 deletions(-) diff --git a/vxlan-and-evpn.adoc b/vxlan-and-evpn.adoc index 0a05cfb..ec1bc07 100644 --- a/vxlan-and-evpn.adoc +++ b/vxlan-and-evpn.adoc @@ -367,7 +367,6

[pve-devel] [PATCH pve-network] frr: remove "no bgp default ipv6-unicast"

Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/FrrPlugin.pm | 1 - 1 file changed, 1 deletion(-) diff --git a/PVE/Network/SDN/FrrPlugin.pm b/PVE/Network/SDN/FrrPlugin.pm index 8a1f86c..79214a7 100644 --- a/PVE/Network/SDN/FrrPlugin.pm +++ b/PVE/Network/SDN/FrrPlugin.pm @@ -74,7 +74,6 @@

Re: [pve-devel] [PATCH pve-common] etc_network_interfaces : add uplink-id option

On 04.09.19 09:47, Alexandre Derumier wrote: > Signed-off-by: Alexandre Derumier > --- > src/PVE/INotify.pm | 18 +- > 1 file changed, 17 insertions(+), 1 deletion(-) > > diff --git a/src/PVE/INotify.pm b/src/PVE/INotify.pm > index 8b49f5a..fd54313 100644 > ---

[pve-devel] applied: [PATCH storage] fix vmid filter for backup listing

On 06.09.19 14:12, Dominik Csapak wrote: > $1 and $2 get set to undef from the vmid filter regex, so we have to do > the name/format regex after, else we get errors like: > > 'use of unitiialized value $1[...]' > > and the listing is empty > > Signed-off-by: Dominik Csapak > --- >

[pve-devel] applied: [PATCH v2 pve-network 0/4] vxlan-evpn: fix routing for local vms on gateway nodes

On 09.09.19 08:45, Alexandre Derumier wrote: > It was not possible to route from external to a local vm on a gateway node. > I have reworked the config hash with better ordering and sub keys > > changelog v2: > > - remove unneeded prefix-list > - move gateway-nodes option to frr plugin, and add

[pve-devel] applied-series: [PATCH pve-docs 0/4] vxlan: improve gateway doc

On 09.09.19 07:46, Alexandre Derumier wrote: > cleanup config for gateway nodes > add documentation for external bgp router > add missing ipv6 conf > applied series, thanks! > Alexandre Derumier (4): > vxlan-evpn: remove prefix-route deny > vxlan: add ipv6 missing config > vxlan: add

[pve-devel] applied-series: [PATCH novnc 1/2] update submodule to v1.1.0

On 09.09.19 12:17, Dominik Csapak wrote: > Signed-off-by: Dominik Csapak > --- > the mirror has ofc to be updated > novnc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/novnc b/novnc > index f9b6d76..9fe2fd0 16 > --- a/novnc > +++ b/novnc > @@ -1 +1 @@ >

Re: [pve-devel] proxmox5: can you bump kernel to ubuntu 4.15.0-59 ? (mellanox bug)

On 09.09.19 12:46, Alexandre DERUMIER wrote: > Hi, > > I have a bug on last pve-kernel 4.15 related to mellanox nic > > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1840854 > > seem to be fixed in 4.15.0-59. > > could you bump it to last version ? FYI:

Re: [pve-devel] [PATCH v2 qemu-server] add check to resize disk if current size could not be determined

On 09.09.19 12:39, Tim Marx wrote: > This check ensures that disks aren't unintentionally shrunken, if the > size is zero due to an underlying problem. > --- > * fix indentation > > PVE/API2/Qemu.pm | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm >

[pve-devel] applied-series: [PATCH storage 2/2] warn if filesize info couldn't be read due to error

On 09.09.19 12:56, Tim Marx wrote: > This sh abrupt CI message ending? > Signed-off-by: Tim Marx > --- > PVE/Storage/Plugin.pm | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/PVE/Storage/Plugin.pm b/PVE/Storage/Plugin.pm > index ed71fe4..6b79e7a 100644 > --- a/PVE/Storage/Plugin.pm

Re: [pve-devel] [PATCH qemu-server 3/7] Add QEMU CPU flag querying helpers

On September 9, 2019 2:56 pm, Stefan Reiter wrote: > On 9/6/19 1:42 PM, Fabian Grünbichler wrote: >>> +# this is neither the default for 'query_supported_cpu_flags' below, nor >>> for >>> +# /proc/cpuinfo. >>> +# >>> +# To compare (or array_intersect) flags, it's a good idea to convert them >>>

Re: [pve-devel] [PATCH qemu-server 3/7] Add QEMU CPU flag querying helpers

Will implement all of this for v2, just a note inline. On 9/6/19 1:42 PM, Fabian Grünbichler wrote: On September 2, 2019 4:27 pm, Stefan Reiter wrote: * query_understood_cpu_flags returns all flags that QEMU/KVM knows about * query_supported_cpu_flags returns all flags that QEMU/KVM can use on

Re: [pve-devel] [PATCH qemu-server 4/7] Add CustomCPUConfig for storing/parsing custom CPU models

Thanks again for the thorough review, I'll try to address everything mentioned in v2. Some stuff inline for this patch in particular. On 9/9/19 11:53 AM, Fabian Grünbichler wrote: On September 2, 2019 4:27 pm, Stefan Reiter wrote: Inherits from SectionConfig to provide base parsing

Re: [pve-devel] proxmox5: can you bump kernel to ubuntu 4.15.0-59 ? (mellanox bug)

Hi, On 09.09.19 12:46, Alexandre DERUMIER wrote: > Hi, > > I have a bug on last pve-kernel 4.15 related to mellanox nic > > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1840854 > > seem to be fixed in 4.15.0-59. > > could you bump it to last version ? Yes, currently in the process of

[pve-devel] [PATCH storage 1/2] whitespace cleanup

Signed-off-by: Tim Marx --- PVE/Storage/Plugin.pm | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/PVE/Storage/Plugin.pm b/PVE/Storage/Plugin.pm index 9a419f1..ed71fe4 100644 --- a/PVE/Storage/Plugin.pm +++ b/PVE/Storage/Plugin.pm @@ -651,7 +651,7 @@ sub

[pve-devel] [PATCH storage 2/2] warn if filesize info couldn't be read due to error

This sh Signed-off-by: Tim Marx --- PVE/Storage/Plugin.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/PVE/Storage/Plugin.pm b/PVE/Storage/Plugin.pm index ed71fe4..6b79e7a 100644 --- a/PVE/Storage/Plugin.pm +++ b/PVE/Storage/Plugin.pm @@ -742,6 +742,8 @@ sub file_size_info { });

[pve-devel] proxmox5: can you bump kernel to ubuntu 4.15.0-59 ? (mellanox bug)

Hi, I have a bug on last pve-kernel 4.15 related to mellanox nic https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1840854 seem to be fixed in 4.15.0-59. could you bump it to last version ? Thanks Alexandre ___ pve-devel mailing list

[pve-devel] [PATCH v2 container 2/2] add check to resize disk if current size could not be determined

This check ensures that disks aren't unintentionally shrunken, if the size is zero due to an underlying problem. --- * fix indentation src/PVE/API2/LXC.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index faec445..8006f4d 100644 ---

[pve-devel] [PATCH v2 qemu-server] add check to resize disk if current size could not be determined

This check ensures that disks aren't unintentionally shrunken, if the size is zero due to an underlying problem. --- * fix indentation PVE/API2/Qemu.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 245de80..e6f3cce 100644 --- a/PVE/API2/Qemu.pm

[pve-devel] [PATCH v2 container 1/2] whitespace cleanup

--- src/PVE/API2/LXC.pm | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index 6ddff9c..faec445 100644 --- a/src/PVE/API2/LXC.pm +++ b/src/PVE/API2/LXC.pm @@ -35,7 +35,7 @@ BEGIN { __PACKAGE__->register_method ({

[pve-devel] [PATCH novnc 2/2] rebase patches on v1.1.0

Signed-off-by: Dominik Csapak --- i tested around a bit, everything seemed to work .../0001-add-pve-specific-js-code.patch | 78 +-- ...002-add-custom-fbresize-event-on-rfb.patch | 19 ++- ...nge-scaling-when-toggling-fullscreen.patch | 15 +--

[pve-devel] [PATCH novnc 1/2] update submodule to v1.1.0

Signed-off-by: Dominik Csapak --- the mirror has ofc to be updated novnc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/novnc b/novnc index f9b6d76..9fe2fd0 16 --- a/novnc +++ b/novnc @@ -1 +1 @@ -Subproject commit f9b6d7665d01f31a6c0c675ec3f604e99f6b2341 +Subproject

[pve-devel] [PATCH container 1/2] whitespace cleanup

--- src/PVE/API2/LXC.pm | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index 6ddff9c..faec445 100644 --- a/src/PVE/API2/LXC.pm +++ b/src/PVE/API2/LXC.pm @@ -35,7 +35,7 @@ BEGIN { __PACKAGE__->register_method ({

[pve-devel] [PATCH container 2/2] add check to resize disk if current size could not be determined

This check ensures that disks aren't unintentionally shrunken, if the size is zero due to an underlying problem. --- src/PVE/API2/LXC.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index faec445..f08b6a5 100644 --- a/src/PVE/API2/LXC.pm +++

[pve-devel] [PATCH qemu-server] add check to resize disk if current size could not be determined

This check ensures that disks aren't unintentionally shrunken, if the size is zero due to an underlying problem. --- PVE/API2/Qemu.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 245de80..a0692da 100644 --- a/PVE/API2/Qemu.pm +++

Re: [pve-devel] [PATCH 0/7] Add basics for custom CPU models

On September 2, 2019 4:27 pm, Stefan Reiter wrote: > Based on the RFC and following on- and off-list discussion about custom CPU > models [0]. > > In essence, this revised patch allows a user to specify custom CPU models in > /etc/pve/cpu-models.conf (section-config style [1]), where VMs using

Re: [pve-devel] [PATCH qemu-server 7/7] Allow custom CPU types in API

On September 2, 2019 4:27 pm, Stefan Reiter wrote: > Custom CPU types can be specified via the API, but to prevent arbitrary > ones we have to manually check if the given model exists (as default or > custom). > > Signed-off-by: Stefan Reiter > --- > PVE/QemuServer.pm | 31

Re: [pve-devel] [PATCH qemu-server 6/7] Handle CPU flags defined in custom CPU type

On September 2, 2019 4:27 pm, Stefan Reiter wrote: > Special care is taken not to overwrite any special flags, or ones > manually set on the VM by the user. We warn if a flag is overruled. hmm. I am unsure whether I like that behaviour or not. it's a bit strange that VM specific flags get

Re: [pve-devel] [PATCH qemu-server 5/7] Support custom CPU types in get_cpu_options

On September 2, 2019 4:27 pm, Stefan Reiter wrote: > Supports custom basemodels (model shown to QEMU, i.e. must be a default nit: s/shown/known/ ? high-level: if we allow basing custom models on other custom models, wouldn't we need to compute an effective model first, and then use that? e.g.,

Re: [pve-devel] [PATCH qemu-server 4/7] Add CustomCPUConfig for storing/parsing custom CPU models

On September 2, 2019 4:27 pm, Stefan Reiter wrote: > Inherits from SectionConfig to provide base parsing infrastructure. > > Use with helper functions: > * config_from_file gives bless'd config > * get_model_by_name returns a "formatted" hash for a single CPU model > * config_to_file writes

[pve-devel] [PATCH pve-manager] api2 : network : use vtysh for frr reload instead systemd

avoid extra dep on frr-pythontools and parse error messages Signed-off-by: Alexandre Derumier --- PVE/API2/Network.pm | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Network.pm b/PVE/API2/Network.pm index ac5571a7..fa605ba7 100644 ---

[pve-devel] [PATCH v2 pve-network 4/4] move gateway-nodes option to frr plugin and add gateway-external-peers

It's make more sense, as We use default vrf for routing. Also add gateway-external-peers to define an external bgp peer. Signed-off-by: Alexandre Derumier --- PVE/Network/SDN.pm | 24 +-- PVE/Network/SDN/FrrPlugin.pm | 43 +-

[pve-devel] [PATCH v2 pve-network 3/4] vxlan: frr : remove unneeded prefix-list

no bgp default ipv4-unicast already deny redistribution of routes in default vrf Signed-off-by: Alexandre Derumier --- PVE/Network/SDN.pm | 1 - PVE/Network/SDN/FrrPlugin.pm | 10 ++ 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/PVE/Network/SDN.pm

[pve-devel] [PATCH v2 pve-network 0/4] vxlan-evpn: fix routing for local vms on gateway nodes

It was not possible to route from external to a local vm on a gateway node. I have reworked the config hash with better ordering and sub keys changelog v2: - remove unneeded prefix-list - move gateway-nodes option to frr plugin, and add support for bgp external router - also add missing ipv6

[pve-devel] [PATCH v2 pve-network 1/4] generate_frr_config: cleanup hash and ordering

Signed-off-by: Alexandre Derumier --- PVE/Network/SDN.pm | 99 ++ PVE/Network/SDN/FrrPlugin.pm | 13 +++-- PVE/Network/SDN/VxlanPlugin.pm | 18 ++- 3 files changed, 87 insertions(+), 43 deletions(-) diff --git a/PVE/Network/SDN.pm

[pve-devel] [PATCH v2 pve-network 2/4] vxlan: evpn: fix routing to local vms on gateway nodes

Signed-off-by: Alexandre Derumier --- PVE/Network/SDN.pm | 2 ++ PVE/Network/SDN/FrrPlugin.pm | 8 PVE/Network/SDN/VxlanPlugin.pm | 4 3 files changed, 14 insertions(+) diff --git a/PVE/Network/SDN.pm b/PVE/Network/SDN.pm index d72b94a..528437f 100644 ---