Re: [pve-devel] [PATCH qemu-server] Fix #2390: Sort @ifaces array to avoid regeneration of instance-id

2019-09-29 Thread Dominik Csapak
hi, while this patch should work (did not test it), this can be done better we could do something like: ---8<--- for (my $id = 0; $id < MAX_NETS; $id++) { my $iface = "net$id"; next if !$conf->{$iface}; --->8--- this way we do not have to grep the whole conf and sort it afterwards, but

[pve-devel] applied: [PATCH widget-toolkit] Cleanup whitespace

2019-09-29 Thread Thomas Lamprecht
On 9/18/19 5:06 PM, Aaron Lauterer wrote: > Signed-off-by: Aaron Lauterer > --- > button/Button.js | 4 ++-- > data/DiffStore.js | 4 ++-- > data/reader/JsonObject.js | 14 +++--- > mixin/CBind.js| 14 +++--- > node/TimeView.js | 14 +++-

Re: [pve-devel] scsi-hd vs scsi-generic with iSCSI

2019-09-29 Thread Daniel Berteaud
- Le 30 Sep 19, à 7:04, Thomas Lamprecht t.lampre...@proxmox.com a écrit : > But the interesting thing would be, why is there an issue with scsi-generic, > i.e., the underlying issue for the two Bugs. IIUC, Dietmar had in mind to > try to fix those - and thus help all scsi-generic users, inste

[pve-devel] applied: fix #2387: always save/restore FPU registers in ZFS SIMD helper

2019-09-29 Thread Thomas Lamprecht
On 9/27/19 12:49 PM, Thomas Lamprecht wrote: > see GitHub issue comments for some details: > https://github.com/zfsonlinux/zfs/issues/9346#issuecomment-534984486 > https://github.com/zfsonlinux/zfs/issues/9346#issuecomment-535133283 > > and the two patches for remaining ones. > > If this looks OK

Re: [pve-devel] scsi-hd vs scsi-generic with iSCSI

2019-09-29 Thread Thomas Lamprecht
On 9/29/19 5:01 PM, Daniel Berteaud wrote: > - Le 28 Sep 19, à 9:38, Dietmar Maurer diet...@proxmox.com a écrit : > >> What exactly is the problem with scsi-generic? Maybe we can fix it? > The two main issues I have are : > > * Bug #2380 : if we try to move a disk from a ZFS over iSCSI stor

Re: [pve-devel] scsi-hd vs scsi-generic with iSCSI

2019-09-29 Thread Daniel Berteaud
- Le 28 Sep 19, à 9:38, Dietmar Maurer diet...@proxmox.com a écrit : > What exactly is the problem with scsi-generic? Maybe we can fix it? The two main issues I have are : * Bug #2380 : if we try to move a disk from a ZFS over iSCSI storage of a running VM, I/O errors will be reported t