[pve-devel] ceph survey 2019

2019-11-29 Thread Alexandre DERUMIER
ceph survey 2019 is open (still with proxmox as choice inside for hypervisors and management interface) https://ceph.io/user-survey/ ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH manager] add reboot button to right-click menu for VMs

2019-11-29 Thread Oguz Bektas
Signed-off-by: Oguz Bektas --- www/manager6/qemu/CmdMenu.js | 16 1 file changed, 16 insertions(+) diff --git a/www/manager6/qemu/CmdMenu.js b/www/manager6/qemu/CmdMenu.js index b11c4545..afa794a7 100644 --- a/www/manager6/qemu/CmdMenu.js +++ b/www/manager6/qemu/CmdMenu.js @@

[pve-devel] applied: [PATCH installer 2/6] umount testdir recursively in check-* and clean

2019-11-29 Thread Thomas Lamprecht
On 11/29/19 11:53 AM, Stoiko Ivanov wrote: > recursively unmount testdir before removing it. This prevents the subsequent > call to try to remove files in potentially still bindmounted /proc, /sys, /dev > filesystems. > > Signed-off-by: Stoiko Ivanov > --- > Makefile | 4 > 1 file changed,

Re: [pve-devel] [PATCH installer 1/6] fixup 4kn install support

2019-11-29 Thread Thomas Lamprecht
On 11/29/19 11:53 AM, Stoiko Ivanov wrote: > address 2 improvments suggested by Fabian. > "fixup" sounds really like you broke something, not like small code refactoring/cleanup - please avoid too "clickbaity" subjects (they are scaring me unnecessarily if a release nears ;) ) > Signed-off-by:

[pve-devel] applied: [PATCH docs] pveum: improve tfa section

2019-11-29 Thread Thomas Lamprecht
On 11/29/19 3:17 PM, Oguz Bektas wrote: > * s/two-factor/two factor applied, fixed above to "s/two factor/two-factor" though ;) Thanks! > * add explicit mention of TOTP (Time-based One-time Password) > * wrap lines/paragraphs > * minor edits on wording or punctuation > > Signed-off-by: Oguz

[pve-devel] [PATCH docs] pveum: improve tfa section

2019-11-29 Thread Oguz Bektas
* s/two-factor/two factor * add explicit mention of TOTP (Time-based One-time Password) * wrap lines/paragraphs * minor edits on wording or punctuation Signed-off-by: Oguz Bektas --- pveum.adoc | 67 +++--- 1 file changed, 34 insertions(+), 33

[pve-devel] [PATCH manager 2/3] api: add migrate precondition checks to bulk migrate api

2019-11-29 Thread Tim Marx
Signed-off-by: Tim Marx --- PVE/API2/Nodes.pm | 19 +++ 1 file changed, 19 insertions(+) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index 6224cb71..a1f62f36 100644 --- a/PVE/API2/Nodes.pm +++ b/PVE/API2/Nodes.pm @@ -1928,6 +1928,25 @@ my $create_migrate_worker = sub {

[pve-devel] [PATCH manager 3/3] ui: add checkbox to bulk migrate window to allow migration with local disks

2019-11-29 Thread Tim Marx
Signed-off-by: Tim Marx --- www/manager6/window/BulkAction.js | 21 + 1 file changed, 21 insertions(+) diff --git a/www/manager6/window/BulkAction.js b/www/manager6/window/BulkAction.js index ba27eef1..0429d96d 100644 --- a/www/manager6/window/BulkAction.js +++

[pve-devel] [PATCH manager 1/3] api: add migrate with local disks to bulk migrate api

2019-11-29 Thread Tim Marx
Signed-off-by: Tim Marx --- PVE/API2/Nodes.pm | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index c3f64699..6224cb71 100644 --- a/PVE/API2/Nodes.pm +++ b/PVE/API2/Nodes.pm @@ -1918,7 +1918,7 @@ __PACKAGE__->register_method

[pve-devel] applied: [PATCH storage] rbd: update features of image when mapping snapshot

2019-11-29 Thread Thomas Lamprecht
On 11/29/19 1:30 PM, Fabian Grünbichler wrote: > in order to fix the features even if the image itself never gets mapped. > > Signed-off-by: Fabian Grünbichler > --- > PVE/Storage/RBDPlugin.pm | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git

[pve-devel] [PATCH storage] rbd: update features of image when mapping snapshot

2019-11-29 Thread Fabian Grünbichler
in order to fix the features even if the image itself never gets mapped. Signed-off-by: Fabian Grünbichler --- PVE/Storage/RBDPlugin.pm | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/PVE/Storage/RBDPlugin.pm b/PVE/Storage/RBDPlugin.pm index 10b54e5..538d6bb 100644

[pve-devel] [RFC storage] rbd: unprotect all snapshots on image removal

2019-11-29 Thread Fabian Grünbichler
we need to unprotect more snapshots than just the base one, since we allow linked clones of regular VM snapshots. unprotection will only work if no linked clones exist anymore. Signed-off-by: Fabian Grünbichler --- it's still rather ugly if such a linked clone exists, since unprotection and thus

[pve-devel] [PATCH installer 6/6] move vgrename check to other sanitychecks

2019-11-29 Thread Stoiko Ivanov
since the check runs at the same time as the one for existing ESPs and rpool move the code there. Signed-off-by: Stoiko Ivanov --- proxinstall | 120 ++-- 1 file changed, 60 insertions(+), 60 deletions(-) diff --git a/proxinstall b/proxinstall

[pve-devel] [PATCH installer 5/6] ask for renaming of existing pmg/pve VGs early

2019-11-29 Thread Stoiko Ivanov
instead of asking the user whether they want to rename an existing VG named 'pve' or 'pmg' after running through the installer and partitioning the disks, do so directly on the hd-selection view. Additionally refactor ask_existing_vg_rename_or_abort to reuse the dialog generation from

[pve-devel] [PATCH installer 4/6] warn on existing rpool if installing on ZFS

2019-11-29 Thread Stoiko Ivanov
Having two pools named rpool leads to an unbootable system. This can happen if reusing an old diks, which is not selected during the initial installation. Warn the user accordingly and give them the option to abort the installation. The pool is not renamed (as we do for the LVM-case with VGs

[pve-devel] [PATCH installer 1/6] fixup 4kn install support

2019-11-29 Thread Stoiko Ivanov
address 2 improvments suggested by Fabian. Signed-off-by: Stoiko Ivanov --- proxinstall | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/proxinstall b/proxinstall index 399faa4..911ee3d 100755 --- a/proxinstall +++ b/proxinstall @@ -1767,14 +1767,11 @@ _EOD

[pve-devel] [PATCH installer 0/6] small improvements for pre-used disks

2019-11-29 Thread Stoiko Ivanov
This patchset contains a few small improvements that came up during the review of the 4kn support (in order of importance): * check and warn for existing ESPs on disks, which are not used for the installation (and thus not cleared) if the system is booted in UEFI mode * check and warn if any

[pve-devel] [PATCH installer 2/6] umount testdir recursively in check-* and clean

2019-11-29 Thread Stoiko Ivanov
recursively unmount testdir before removing it. This prevents the subsequent call to try to remove files in potentially still bindmounted /proc, /sys, /dev filesystems. Signed-off-by: Stoiko Ivanov --- Makefile | 4 1 file changed, 4 insertions(+) diff --git a/Makefile b/Makefile index

[pve-devel] applied: [PATCH storage] rbd: don't attempt to update features of snapshots

2019-11-29 Thread Thomas Lamprecht
On 11/29/19 10:57 AM, Fabian Grünbichler wrote: > it does not work: > > disable RBD image features this kernel RBD drivers is not compatible with: > fast-diff,object-map,deep-flatten > clone failed: could not disable krbd-incompatible image features > 'fast-diff,object-map,deep-flatten' for rbd

[pve-devel] [PATCH qemu-server 1/4] logging vmstate into Resume/Start Task

2019-11-29 Thread Dominik Csapak
so that the user knows what got loaded as vmstate Signed-off-by: Dominik Csapak --- PVE/QemuServer.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 75e4f67..5cf04e6 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -4058,6 +4058,7 @@ sub

[pve-devel] [PATCH qemu-server 2/4] delete suspended lock when we have no vmstate

2019-11-29 Thread Dominik Csapak
if a user removed the vmstate from the config for whatever reason, a vmstart did not remove the 'suspended' lock so always delete it and delete the vmstate only if it really was there Signed-off-by: Dominik Csapak --- PVE/QemuServer.pm | 8 +--- 1 file changed, 5 insertions(+), 3

[pve-devel] [PATCH qemu-server 4/4] add special case for clearing suspended state

2019-11-29 Thread Dominik Csapak
Sometimes, a user wants to remove the 'suspended' state without resuming the vm from that state. Since the vm is locked with 'suspended', this was not possible without help from root@pam This patch allows to delete the vmstate and the suspended lock and related config entries with it. The user

[pve-devel] [PATCH qemu-server/manager] improve suspend to disk

2019-11-29 Thread Dominik Csapak
this series improves suspend to disk handling for some edge/error cases, and adds the possibility to remove the 'suspended' state without having to resume the vm qemu-server: Dominik Csapak (4): logging vmstate into Resume/Start Task delete suspended lock when we have no vmstate implement

[pve-devel] [PATCH qemu-server 3/4] implement removal of vmstate via api

2019-11-29 Thread Dominik Csapak
we did not actually delete the state if we deleted the 'vmstate' config, leaving stray vmstates on the disks actually implement the removal, requiring 'VM.Config.Disk' and 'VM.PowerMgmt' privs Signed-off-by: Dominik Csapak --- PVE/API2/Qemu.pm | 9 + 1 file changed, 9 insertions(+)

[pve-devel] [PATCH manager 1/1] gui: qemu/HardwareView: show vmstate and allow removal

2019-11-29 Thread Dominik Csapak
so that a user can remove the 'suspended' state without resuming it Signed-off-by: Dominik Csapak --- www/manager6/qemu/HardwareView.js | 5 + 1 file changed, 5 insertions(+) diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js index 937842f9..e834a3ec 100644

[pve-devel] [PATCH storage] rbd: don't attempt to update features of snapshots

2019-11-29 Thread Fabian Grünbichler
it does not work: disable RBD image features this kernel RBD drivers is not compatible with: fast-diff,object-map,deep-flatten clone failed: could not disable krbd-incompatible image features 'fast-diff,object-map,deep-flatten' for rbd image: vm-123123123-disk-0@test: rbd: snapshot name