First, thanks for the patch!
Most seems to be adapted from surrounding code, which is OK.
Some comments inline.
Also, a pve-docs patch about this would be nice, to clear up things like:
* MTU cannot be bigger than those used by the host in it's chain to the
outer network.
* All components of th
On 12/11/19 6:03 PM, Paul Shepel wrote:
> This patch adds support of QEMU host_mtu virtio-net parameter
> thats expose host MTU to guest
>
Looks OK, a nit (which I can fixup locally) and a question out of interest
inline.
> Signed-off-by: Paul Shepel
> ---
> PVE/QemuServer.pm | 8
> 1
Hi,
On 12/12/19 4:54 AM, Jin Qian wrote:
> Hi, I just want to clone some projects in https://git.proxmox.com/,
> although I've read the instruction
> https://pve.proxmox.com/wiki/Developer_Documentation,
> I could not yet find any instruction about how to register my ssh key to
> the git server so
Patch allows to specify the host MTU for the guest
with the virtio-net device
Paul Shepel (2):
Close #2443: qemu-server: add MTU option to virtio-net device
PVE/QemuServer.pm | 8
1 file changed, 8 insertions(+)
Close #2443: gui: qemu/NetworkEdit: add network mtu advanced option
Hi, I just want to clone some projects in https://git.proxmox.com/,
although I've read the instruction
https://pve.proxmox.com/wiki/Developer_Documentation,
I could not yet find any instruction about how to register my ssh key to
the git server so that I can run
git clone git://git.proxmox.com/git/
Signed-off-by: Paul Shepel
---
www/manager6/Parser.js | 5 +
www/manager6/qemu/NetworkEdit.js | 36 +---
2 files changed, 38 insertions(+), 3 deletions(-)
diff --git a/www/manager6/Parser.js b/www/manager6/Parser.js
index 0790e683..6a9cbb78 100644
--- a
This patch adds support of QEMU host_mtu virtio-net parameter
thats expose host MTU to guest
Signed-off-by: Paul Shepel
---
PVE/QemuServer.pm | 8
1 file changed, 8 insertions(+)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 865a89b..3168dde 100644
--- a/PVE/QemuServer.pm
++
On 11/29/19 11:53 AM, Stoiko Ivanov wrote:
> instead of asking the user whether they want to rename an existing VG
> named 'pve' or 'pmg' after running through the installer and partitioning
> the disks, do so directly on the hd-selection view.
Don't see real advantage there, IMO it's not a HD sel
On 11/29/19 11:53 AM, Stoiko Ivanov wrote:
> When doing the sanity-checks for the chosen harddisk setup, also check for
> existing ESPs on those disks the installer will not touch.
>
> Since they are not touched, the ESP remains on the disk, which can lead to
> unbootable systems and other surpris
On 11/29/19 11:53 AM, Stoiko Ivanov wrote:
> Having two pools named rpool leads to an unbootable system.
> This can happen if reusing an old diks, which is not selected during the
> initial installation.
>
> Warn the user accordingly and give them the option to abort the installation.
> The pool i
On 12/11/19 12:58 PM, Tim Marx wrote:
> Signed-off-by: Tim Marx
> ---
> api-viewer/PVEAPI.js | 75 +---
> 1 file changed, 71 insertions(+), 4 deletions(-)
>
applied, the search thingy could have been a separate patch from the
expand/collapse one, though.
On 12/11/19 12:58 PM, Tim Marx wrote:
> use #/ to deeplink to a specific endpoint
>
> Signed-off-by: Tim Marx
> ---
> changes v2:
> * update hash part on treenode selection
> * deepLink should work on subsequent url changes
>
applied, thanks! Did small followup, see inline:
> api-viewer/PVEAP
use #/ to deeplink to a specific endpoint
Signed-off-by: Tim Marx
---
changes v2:
* update hash part on treenode selection
* deepLink should work on subsequent url changes
api-viewer/PVEAPI.js | 15 +++
1 file changed, 15 insertions(+)
diff --git a/api-viewer/PVEAPI.js b/api-viewer
Signed-off-by: Tim Marx
---
api-viewer/PVEAPI.js | 75 +---
1 file changed, 71 insertions(+), 4 deletions(-)
diff --git a/api-viewer/PVEAPI.js b/api-viewer/PVEAPI.js
index dd36fff..9a14156 100644
--- a/api-viewer/PVEAPI.js
+++ b/api-viewer/PVEAPI.js
@@ -22
On 11/29/19 12:00 PM, Fabian Grünbichler wrote:
> we need to unprotect more snapshots than just the base one, since we
> allow linked clones of regular VM snapshots. unprotection will only work
> if no linked clones exist anymore.
>
> Signed-off-by: Fabian Grünbichler
> ---
> it's still rather ug
On 12/9/19 2:08 PM, Stefan Reiter wrote:
> Split out 'update_disksize' from the renamed 'update_disk_config' to
> allow code reuse in QemuMigrate.
>
> Remove dots after messages to keep style consistent for migration log.
>
> After updating in sync_disks (phase1) of migration, write out updated
>
We can use 'list_images' to get the desired volume IDs in
'find_free_diskname' for most plugins. For the two LVM plugins, 'list_images'
potentially skips untagged volumes, so we keep the custom version. For the
RBD plugin, 'list_images' is much more costly than the custom version, so we
keep the cu
Signed-off-by: Thomas Lamprecht
---
pve-firewall.adoc | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/pve-firewall.adoc b/pve-firewall.adoc
index 2bcdf6e..7a8fd3e 100644
--- a/pve-firewall.adoc
+++ b/pve-firewall.adoc
@@ -628,13 +628,14 @@ corresponding link lo
On 12/9/19 3:26 PM, Dominik Csapak wrote:
> this series adds additional privilege checks for the vmstate with
> hibernation, also adds docs and gui support for selecting the
> vmstate storage
>
> changes from v1:
> * add docs
> * add gui for vmstatestorage
> * improve comments
> * remove unecessar
19 matches
Mail list logo
