We clone the source VM firewall config before forking the "realcmd"
worker, but did not mind cleaning it up again if the clone failed
somewhere in the worker.
Signed-off-by: Thomas Lamprecht
---
PVE/API2/Qemu.pm | 3 +++
1 file changed, 3 insertions(+)
diff --git a/PVE/API2/Qemu.pm
This is the guarantee that this call operates on it's created config.
A VMID cannot be reused afterall. So only remove the guarantee at the
last step, just before throwing up the error message about the clone
failure.
Signed-off-by: Thomas Lamprecht
---
PVE/API2/Qemu.pm | 4 ++--
1 file
On January 14, 2020 5:36 pm, Oguz Bektas wrote:
> since we handle errors gracefully now, we don't need to write & save
> config every time we change a setting.
>
> Signed-off-by: Oguz Bektas
> ---
> v4 -> v5:
>
> changed some stuff according to the feedback from fabian and thomas,
> thanks a
* rephrase some parts.
* update old information
* add info about pending changes and other "new" features
Co-Authored-by: Aaron Lauterer
Signed-off-by: Oguz Bektas
---
v1->v2:
changed some of the writing in terms of phrasing and style, with
feedback from aaron. thanks!
pct.adoc | 442
since we handle errors gracefully now, we don't need to write & save
config every time we change a setting.
Signed-off-by: Oguz Bektas
---
v4 -> v5:
changed some stuff according to the feedback from fabian and thomas,
thanks a lot!
* remove forgotten load_config call
* some style changes (if
Signed-off-by: Tim Marx
---
changes:
* squashed patch 2 & 4
PVE/API2/Qemu.pm | 13 ++---
PVE/QemuServer.pm | 4 ++--
2 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 5bae513..2dee3f1 100644
--- a/PVE/API2/Qemu.pm
+++
Signed-off-by: Tim Marx
---
changed:
* squashed patch 1 & 3
* pass config hash
* adapated comment
PVE/QemuServer.pm | 4 ++--
PVE/QemuServer/Helpers.pm | 22 ++
2 files changed, 24 insertions(+), 2 deletions(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
On 1/14/20 12:48 PM, Kevin Greßlehner wrote:
> Kevin Greßlehner (1):
> Fix #2553: Fix for Deadlock by aligning the lockorder - Lock
> >mutex in memdb_read and refer to a new method
> "memdb_read_nolock" in memdb.c which doesn't handle locks by itself.
> This method then handles the
Signed-off-by: Tim Marx
---
PVE/QemuServer.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index a7aff07..992cc7d 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -41,7 +41,7 @@ use PVE::Tools qw(run_command lock_file
Signed-off-by: Tim Marx
---
PVE/QemuServer/Helpers.pm | 21 +
1 file changed, 21 insertions(+)
diff --git a/PVE/QemuServer/Helpers.pm b/PVE/QemuServer/Helpers.pm
index fcc9392..86bf3d9 100644
--- a/PVE/QemuServer/Helpers.pm
+++ b/PVE/QemuServer/Helpers.pm
@@ -11,6 +11,7 @@
Signed-off-by: Tim Marx
---
PVE/QemuServer.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 2b68d81..a7aff07 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -5196,7 +5196,7 @@ sub vmconfig_update_disk {
sub
Signed-off-by: Tim Marx
---
PVE/API2/Qemu.pm | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 5bae513..2dee3f1 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qemu.pm
@@ -1993,7 +1993,13 @@ __PACKAGE__->register_method({
Kevin Greßlehner (1):
Fix #2553: Fix for Deadlock by aligning the lockorder - Lock
>mutex in memdb_read and refer to a new method
"memdb_read_nolock" in memdb.c which doesn't handle locks by itself.
This method then handles the stuff which was originally in
memdb_read. Therefore
On 11/21/19 3:43 PM, Fabian Grünbichler wrote:
> pull it into helper sub, since we need this one more time for token ACL
> members.
>
> Signed-off-by: Fabian Grünbichler
> ---
>
> Notes:
> v1->v2:
> - rename helper and variable
> - also merge propagate/non-propagate loops
>
>
On 11/21/19 3:43 PM, Fabian Grünbichler wrote:
> for reusage in API token ID format/verification
>
> Signed-off-by: Fabian Grünbichler
> ---
> PVE/Auth/Plugin.pm | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/PVE/Auth/Plugin.pm b/PVE/Auth/Plugin.pm
> index
On 11/21/19 3:43 PM, Fabian Grünbichler wrote:
> it was useful for test-cases to verify the behaviour when pools where
> introduced, but it is not used anywhere else in the code base and those
> tests can also just check on permission-level.
>
> Signed-off-by: Fabian Grünbichler
> ---
>
>
On 11/21/19 3:53 PM, Stefan Reiter wrote:
> Add two overrides to avoid writing redundant information to the config
> file.
>
> get_custom_model is used to retrieve a custom model configuration by
> name.
>
> Signed-off-by: Stefan Reiter
> ---
merge this into 04/12 ?
>
On 11/21/19 3:53 PM, Stefan Reiter wrote:
> Turn CPUConfig into a SectionConfig with parsing/writing support for
> custom CPU models. IO is handled using cfs.
>
> Namespacing will be provided using "custom-" prefix for custom model
> names (in VM config only, cpu-models.conf will contain
On 11/21/19 3:53 PM, Stefan Reiter wrote:
> The package will be used for custom CPU models as a SectionConfig, hence
> the name. For now we simply move some CPU related helper functions and
> declarations over from QemuServer to reduce clutter there.
>
> Exports are to avoid changing all call
On 11/21/19 3:53 PM, Stefan Reiter wrote:
> pvestatd will check if the KVM version has changed using
> kvm_user_version (which automatically clears its cache if QEMU/KVM
> updates), and if it has, query supported CPU flags and broadcast them as
> key-value pairs to the cluster.
>
> If detection
On 11/21/19 3:53 PM, Stefan Reiter wrote:
> * query_understood_cpu_flags returns all flags that QEMU/KVM knows about
> * query_supported_cpu_flags returns all flags that QEMU/KVM can use on
> this particular host.
>
> To get supported flags, a temporary VM is started with QEMU, so we can
>
On 1/7/20 4:55 PM, Oguz Bektas wrote:
> wrap around code which can possibly fail in evals to handle them
> gracefully, and log errors.
>
> Signed-off-by: Oguz Bektas
> ---
>
> v3 -> v4:
> * use $errors parameter while calling vmconfig_apply_pending
>
applied with the commit message "note"
On 1/7/20 4:55 PM, Oguz Bektas wrote:
> since we handle errors gracefully now, we don't need to write & save
> config every time we change a setting.
>
> note: this results in a change of behavior in the API. since errors are
> handled gracefully instead of "die"ing, when there is a pending
On 1/7/20 4:55 PM, Oguz Bektas wrote:
> since we handle errors gracefully now, we don't need to write & save
> config every time we change a setting.
>
> note: this results in a change of behavior in the API. since errors are
> handled gracefully instead of "die"ing, when there is a pending
I haven't checked in detail whether patch #1 makes sense in isolation,
but this one here is not yet 100% there ;)
On January 7, 2020 4:55 pm, Oguz Bektas wrote:
> since we handle errors gracefully now, we don't need to write & save
> config every time we change a setting.
>
> note: this results
On 1/13/20 12:59 PM, Tim Marx wrote:
> Signed-off-by: Tim Marx
> ---
> backup.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/backup.txt b/backup.txt
> index 0605250..97e10fc 100644
> --- a/backup.txt
> +++ b/backup.txt
> @@ -108,7 +108,7 @@ files.
>
> We have
Allow to collapse and expand the "Notes" panel on the virtual guests
summary panel.
Further add a browser setting to control the default behavior, one
can chose from:
* expand on show (default)
* collapse on show
* collapse if there are no notes
This way users can make slightly better use of
On January 13, 2020 12:56 pm, Fabian Ebner wrote:
> Could I get some feedback for this? The same locking is done for
> 'vdisk_alloc' and 'vdisk_clone' already (among others), so I thought it
> makes sense for 'volume_import' as well.
the main user of this is storage_migrate via 'pvesm import'.
On 1/14/20 10:53 AM, Stefan Reiter wrote:
> On 1/10/20 4:12 PM, Thomas Lamprecht wrote:
>> Allow to collapse and expand the "Notes" panel on the virtual guests
>> summary panel.
>>
>> Further add a browser setting to control the default behavior, one
>> can chose from:
>> * expand on show
We need a recent version *and* our patches on top of the vanilla
ifupdown2:
0001-don-t-remove-tap-veth-fwpr-interfaces-from-bridge-on.patch
0004-don-t-remove-bridge-is-tap-veth-are-still-plugged.patch
So check for at least 1.2.8 and the pve string in the version output.
Signed-off-by: Thomas
On 1/10/20 4:12 PM, Thomas Lamprecht wrote:
Allow to collapse and expand the "Notes" panel on the virtual guests
summary panel.
Further add a browser setting to control the default behavior, one
can chose from:
* expand on show (default)
* collapse on show
* collapse if there are no notes
31 matches
Mail list logo
