On 4/23/20 12:20 PM, Fabian Grünbichler wrote:
> if our self-signed certificate expires in more than 825 days, but was
> created after July 2019 it won't be accepted by modern Apple devices. we
> fixed the issuance to generate shorter-lived certificates in November
> 2019, this cleans up the existi
opens a window with the parameters for the sync and two buttons:
'preview' and 'sync'
both open the taskviewer, but the 'preview' one sets the 'no-write'
parameter so that it does not get written out to the user.cfg
loads the realm config and prefills the selection with values from
the config
Si
Signed-off-by: Dominik Csapak
---
window/LanguageEdit.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/window/LanguageEdit.js b/window/LanguageEdit.js
index dd7393c..9176cfd 100644
--- a/window/LanguageEdit.js
+++ b/window/LanguageEdit.js
@@ -30,6 +30,7 @@ Ext.define('Proxmox.window.Languag
On April 27, 2020 1:08 pm, Fabian Ebner wrote:
> One not-patch-related observation inline.
>
> On 27.04.20 10:24, Fabian Grünbichler wrote:
>> to protect checks against concurrent modifications
>>
>> Signed-off-by: Fabian Grünbichler
>> ---
>>
>> Notes:
>> bested viewed with --patience -w
Signed-off-by: Aaron Lauterer
---
test/vzdump_guest_included_test.pl | 190 +
1 file changed, 190 insertions(+)
create mode 100755 test/vzdump_guest_included_test.pl
diff --git a/test/vzdump_guest_included_test.pl
b/test/vzdump_guest_included_test.pl
new file mode 1
As a first step to make the whole guest include logic more testable the
part from the API endpoint has been moved to its own method with as
little changes as possible.
Everything concerning `all` and `exclude` logic, and in some conditions,
node limits, is still in the PVE::VZDump->exec_backup() m
On 27.04.20 13:27, Thomas Lamprecht wrote:
On 4/27/20 11:41 AM, Fabian Ebner wrote:
This restores the behavior for sort_key as it's described in the
comment for print_text_table.
Fixes warnings, e.g.
pvesh get /nodes//network
would print "use of uninitialized"-warnings if there are inactive
net
On 4/27/20 11:41 AM, Fabian Ebner wrote:
> This restores the behavior for sort_key as it's described in the
> comment for print_text_table.
>
> Fixes warnings, e.g.
> pvesh get /nodes//network
> would print "use of uninitialized"-warnings if there are inactive
> network interfaces, because for tho
On 4/23/20 12:46 PM, Dominik Csapak wrote:
> when one of the ovmf tests fails to parse at all,
> we just get the 'die' message of the failing component, but not which
> file actually failed to parse
>
> to get better output, convert the parsing also to a test
> and ok() and fail() respectively and
One not-patch-related observation inline.
On 27.04.20 10:24, Fabian Grünbichler wrote:
to protect checks against concurrent modifications
Signed-off-by: Fabian Grünbichler
---
Notes:
bested viewed with --patience -w
PVE/AbstractConfig.pm | 45 +-
looks mostly fine, one comment though:
i would put the hint either in advancedColumnB
so that the text spans the complete width of the window
(looks weird crammed to the left)
or even at the very top? if i have iothread on but the
advanced checkbox off, i do not see the hint ...
(ok this is prob
On 4/27/20 12:29 PM, Dominik Csapak wrote:
>
>
> On 4/27/20 12:15 PM, Thomas Lamprecht wrote:
>> On 4/9/20 4:10 PM, Dominik Csapak wrote:
>>> opens a window with the parameters for the sync and two buttons:
>>> 'preview' and 'sync'
>>>
>>> both open the taskviewer, but the 'preview' one sets the
On 4/27/20 12:15 PM, Thomas Lamprecht wrote:
On 4/9/20 4:10 PM, Dominik Csapak wrote:
opens a window with the parameters for the sync and two buttons:
'preview' and 'sync'
both open the taskviewer, but the 'preview' one sets the 'no-write'
parameter so that it does not get written out to the
On 4/9/20 4:10 PM, Dominik Csapak wrote:
> this modifies AuthEditBase so that if there is a sync inputpanel specified,
> we display it in a second tab (we need to modify the bodyPadding here,
> else the whole window has too much padding)
>
> we use the same panel for both ldap/ad, since the most o
On 4/9/20 4:10 PM, Dominik Csapak wrote:
> opens a window with the parameters for the sync and two buttons:
> 'preview' and 'sync'
>
> both open the taskviewer, but the 'preview' one sets the 'no-write'
> parameter so that it does not get written out to the user.cfg
>
> Signed-off-by: Dominik Csa
This restores the behavior for sort_key as it's described in the
comment for print_text_table.
Fixes warnings, e.g.
pvesh get /nodes//network
would print "use of uninitialized"-warnings if there are inactive
network interfaces, because for those, 'active' is undef.
Signed-off-by: Fabian Ebner
--
The only warning displayed before was in the "VM Start" task log, rather
hidden. In the wizard we already auto-selected the correct controller, but
not when modifying a disk on an existing VM.
Don't break existing behaviour (to allow users to disable IO threads for
VMs that currently have it set b
and pull the actual lock_file_full handling into a helper, to make the
public interface clearer:
lock_config -> standard exclusive lock with 10s timeout
lock_config_full -> exclusive lock with configurable timeout
lock_config_shared -> shared lock with configurable timeout
the latter only has a s
and check_lock before forking as well
Signed-off-by: Fabian Grünbichler
---
Notes:
bested viewed with -w --patience
src/PVE/API2/LXC.pm | 31 ---
1 file changed, 20 insertions(+), 11 deletions(-)
diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm
index 148b
lock_file is used by PVE::QemuServer::Memory, but it does properly 'use
PVE::Tools ...' itself so we can drop them in the main module.
Signed-off-by: Fabian Grünbichler
---
PVE/QemuServer.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServe
to protect against concurrent changes
Signed-off-by: Fabian Grünbichler
---
best viewed with --patience -w
PVE/API2/Qemu.pm | 40 +++-
1 file changed, 23 insertions(+), 17 deletions(-)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index ec4c18c..f6a98f0 1
Signed-off-by: Fabian Grünbichler
---
PVE/AbstractConfig.pm | 14 ++
1 file changed, 14 insertions(+)
diff --git a/PVE/AbstractConfig.pm b/PVE/AbstractConfig.pm
index 70311df..8ec27a6 100644
--- a/PVE/AbstractConfig.pm
+++ b/PVE/AbstractConfig.pm
@@ -823,6 +823,15 @@ sub snapshot_del
Signed-off-by: Fabian Grünbichler
---
src/PVE/LXC.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index fbe736e..651ec08 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -20,8 +20,8 @@ use PVE::SafeSyslog;
use PVE::INotify;
use PVE::
and move the lock call and decision logic closer together
Signed-off-by: Fabian Grünbichler
---
Notes:
needs libpve-guest-common-perl with new lock_config_shared
possibly better to postpone since it does not fix an actual issue
but just improves the readability
PVE/API2/Qemu.pm | 1
to protect checks against concurrent modifications
Signed-off-by: Fabian Grünbichler
---
Notes:
bested viewed with --patience -w
PVE/AbstractConfig.pm | 45 +--
1 file changed, 22 insertions(+), 23 deletions(-)
diff --git a/PVE/AbstractConfig.pm b/P
this is only used for migration via 'qm mtunnel', regular users should
never need to resume a VM that does not logically belong to the node it
is running on
Signed-off-by: Fabian Grünbichler
---
PVE/API2/Qemu.pm | 2 ++
1 file changed, 2 insertions(+)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qe
26 matches
Mail list logo
