[pve-devel] [PATCH qemu-server v2] add win7 pcie quirk

ve-q35.cfg should we need it in the future. Signed-off-by: Dominik Csapak --- changes from v1: * improve comments and commit message * change 'win7' postfix to a more general 'bus0' PVE/QemuServer.pm | 8 +++- PVE/QemuServer/PCI.pm | 5 + 2 files changed, 12 inse

[pve-devel] [PATCH manager] fix #2030: use looks_like_number for number check

since numbers can also be in '1.e-10' format, we have to change how we check for a number Scalar::Util is already core and we use it in PVE::Tools, so no new dependecy. in case of "NaN" or "Infinity" we omit the key/value pair else we quote like before Signed-of

[pve-devel] [PATCH qemu-server] fix #2032: check that type is set before using

ned-off-by: Dominik Csapak --- PVE/QemuServer.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 4a6a6cc..38b511e 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -2023,7 +2023,7 @@ sub print_vga_device { my ($conf, $

Re: [pve-devel] [PATCH storage] (partially) fix #2020: do not drop the namespace part for nvme smart readings

On 12/7/18 3:56 PM, Dominik Csapak wrote: current versions of smartctl can handle this, and sometimes the mapping is reversed, e.g. smartctl /dev/nvme0 shows the info of /dev/nvme1n1 and smartctl /dev/nvme1 shows the info of /dev/nvme0n1 this patch does not fix the mismatch of nvme0 to nvme1n1

[pve-devel] [PATCH storage] (partially) fix #2020: do not drop the namespace part for nvme smart readings

correct drive Signed-off-by: Dominik Csapak --- PVE/Diskmanage.pm | 3 --- 1 file changed, 3 deletions(-) diff --git a/PVE/Diskmanage.pm b/PVE/Diskmanage.pm index def0791..5c0b6a6 100644 --- a/PVE/Diskmanage.pm +++ b/PVE/Diskmanage.pm @@ -79,9 +79,6 @@ sub get_smart_data { my $returncode = 0

[pve-devel] [RFC PATCH qemu-server] add win7 pcie quirk

ly careful with backwards compatibility here Signed-off-by: Dominik Csapak --- sending as rfc, because i am unsure about the way i do it the alternative would be to expand the parameters of print_pcie_addr to include e.g. the ostype or config and pull the information there which seems a big ch

[pve-devel] [PATCH manager] fix #2017: add help button to storage input panels

Signed-off-by: Dominik Csapak --- www/manager6/storage/CIFSEdit.js | 2 ++ www/manager6/storage/CephFSEdit.js| 2 ++ www/manager6/storage/DirEdit.js | 2 ++ www/manager6/storage/GlusterFsEdit.js | 2 ++ www/manager6/storage/IScsiEdit.js | 2 ++ www/manager6/storage/LVMEdit.js

[pve-devel] [PATCH qemu-server 1/2] fix #1267: move args to the end of qemu commandline

there is nothing that should be really affected by this, but even then, this option is only for experts and people using this should know what they are doing Signed-off-by: Dominik Csapak --- PVE/QemuServer.pm | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/PVE

[pve-devel] [PATCH qemu-server 2/2] vga: allow 'none'

ned-off-by: Dominik Csapak --- PVE/QemuServer.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 861ded8..676ab82 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -237,7 +237,7 @@ my $vga_fmt = { default => 'std'

[pve-devel] [PATCH manager] do not send 'undefined' as romfile

when adding a pcidevice, we added 'romfile=undefined' by accident Signed-off-by: Dominik Csapak --- www/manager6/qemu/PCIEdit.js | 4 1 file changed, 4 insertions(+) diff --git a/www/manager6/qemu/PCIEdit.js b/www/manager6/qemu/PCIEdit.js index 40a7d8c7..85d1f4ce 100644 --- a/ww

[pve-devel] [PATCH docs 2/2] add pcie passthrough to the wiki

and add a 'see also' chapter for the wiki with a link to the old pci passthrough documentation (which i will change to contain examples and other steps not suited for the reference documentation) Signed-off-by: Dominik Csapak --- qm-pci-passthrough.adoc | 12 1 file c

[pve-devel] [PATCH docs 1/2] fix quoting

it seems the parser cannot handle the end of the quoting with '),' after it, so `'), does not get detected as the end of the quote Signed-off-by: Dominik Csapak --- qm-pci-passthrough.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qm-pci-passthroug

Re: [pve-devel] [PATCH manager 1/2] ui: lxc/features: disable nfs and cifs for unprivileged

both patches: Reviewed-by: Dominik Csapak Tested-by: Dominik Csapak On 12/4/18 10:03 AM, Wolfgang Bumiller wrote: While we can allow them via the apparmor profile, they still won't be usable as the kernel doesn't have FS_USERNS_MOUNT set on those. Signed-off-by: Wolfgang Bumiller

[pve-devel] [PATCH firewall v2] fix #2004: do not allow backwards ranges

ranges like 10:5 are allowed by us, but iptables throws an error that is only visible in the syslog and the firewall rules do not get updated Signed-off-by: Dominik Csapak --- changes from v1: * better error message src/PVE/Firewall.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/src/PVE

Re: [pve-devel] [PATCH firewall 2/2] fix #2004: do not allow backwards ranges

On 11/30/18 11:11 AM, Alwin Antreich wrote: On Fri, Nov 30, 2018 at 09:53:50AM +0100, Dominik Csapak wrote: ranges like 10:5 are allowed by us, but iptables throws an error that is only visible in the syslog and the firewall rules do not get updated Signed-off-by: Dominik Csapak --- src/PVE

Re: [pve-devel] [PATCH qemu-server] fix #1811: allow VM.Config.HWType to add serial socket

On 11/30/18 11:07 AM, David Limbeck wrote: allow serial sockets to be added if VM.Config.HWType permission is satisfied but deny serial devices for anyone other than root (raise_perm_exc). this allows PVEVMAdmins to add serial consoles. Signed-off-by: David Limbeck --- PVE/API2/Qemu.pm | 11 +

[pve-devel] [PATCH firewall 2/2] fix #2004: do not allow backwards ranges

ranges like 10:5 are allowed by us, but iptables throws an error that is only visible in the syslog and the firewall rules do not get updated Signed-off-by: Dominik Csapak --- src/PVE/Firewall.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm index

[pve-devel] [PATCH firewall 1/2] fix #2005: only allow ascii port digits

perl accepts non-ascii digits for \d like U+09EA which do not work with iptables Signed-off-by: Dominik Csapak --- src/PVE/Firewall.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm index ef00d0c..035dc7e 100644 --- a/src/PVE

[pve-devel] [PATCH i18n v2] update german translation

Signed-off-by: Dominik Csapak --- changes from v1: * fixed typos de.po | 183 +- 1 file changed, 69 insertions(+), 114 deletions(-) diff --git a/de.po b/de.po index 91f07a5..78b0ccd 100644 --- a/de.po +++ b/de.po @@ -7,8 +7,8

[pve-devel] [PATCH firewall] macro: fix return verification failure

macros are strings not integers Signed-off-by: Dominik Csapak --- src/PVE/API2/Firewall/Rules.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/API2/Firewall/Rules.pm b/src/PVE/API2/Firewall/Rules.pm index b2a81a1..1670986 100644 --- a/src/PVE/API2/Firewall/Rules.pm

[pve-devel] [PATCH i18n] update german translation

Signed-off-by: Dominik Csapak --- one has to 'make update' before applying de.po | 183 +- 1 file changed, 69 insertions(+), 114 deletions(-) diff --git a/de.po b/de.po index 91f07a5..9a818c1 100644 --- a/de.po +++ b/de.

[pve-devel] [PATCH qemu-server 2/2] fix #2003: give 'qm terminal' a terminal over ssh

this prevents a connection loop when using novnc on a vm with vga: serialX when proxying via ssh Signed-off-by: Dominik Csapak --- PVE/API2/Qemu.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index d4085da..b55fd13 100644 --- a/PVE

[pve-devel] [PATCH qemu-server 1/2] vnc/termproxy: use ssh_info_to_command for ssh tunnel

this way we have two places less where we define a ssh cmd Signed-off-by: Dominik Csapak --- PVE/API2/Qemu.pm | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index c82e2fa..d4085da 100644 --- a/PVE/API2/Qemu.pm

[pve-devel] applied: [PATCH manager] ui: cluster: require ring0_addr if joinee's ring and node addr differ

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH widget-toolkit] form: proxmox textfield: support binding 'allowBlank'

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH manager] add pciutils as dependency

the package is not big, installed by default in the installer, makes the pci scan much prettier, and we call lspci in the pvereport Signed-off-by: Dominik Csapak --- debian/control | 1 + 1 file changed, 1 insertion(+) diff --git a/debian/control b/debian/control index 19b127ac..d6b08d64

[pve-devel] [PATCH qemu-server v3] better cleanup logging for migration

know what to clean up Signed-off-by: Dominik Csapak --- changes from v2: * use !-f config_file to check for the config * better comment PVE/CLI/qm.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm index eceb9b3..26d4217 100755 --- a/PVE/CLI/qm.pm +++ b/PVE

[pve-devel] [PATCH qemu-server v2] better cleanup logging for migration

know what to clean up Signed-off-by: Dominik Csapak --- PVE/CLI/qm.pm | 6 ++ 1 file changed, 6 insertions(+) diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm index eceb9b3..8d4fb9b 100755 --- a/PVE/CLI/qm.pm +++ b/PVE/CLI/qm.pm @@ -753,6 +753,12 @@ __PACKAGE__->register_method({ my $c

Re: [pve-devel] [PATCH manager 3/3] ui: cephfs: only allow CephFS creation if MDS is configured

Reviewed-by: Dominik Csapak Tested-by: Dominik Csapak On 11/26/18 6:22 PM, Thomas Lamprecht wrote: Introduce the mdsCount again, I know remember again why I had it in v3 of my CephFS series.. Use this to disable the CephFS create button if we have no MDS configured, as this is a requirement

Re: [pve-devel] [PATCH qemu-server 1/2] fix q35 live migration

On 11/27/18 12:05 PM, Thomas Lamprecht wrote: On 11/27/18 11:32 AM, Dominik Csapak wrote: with live migration the machine type not q35, but something like pc-q35-2.12 so we missed to include the q35 cfg in the future we probably want to have a QemuServer::Tools to refactor such methods

Re: [pve-devel] [PATCH qemu-server 2/2] better cleanup logging for migration

On 11/27/18 12:23 PM, Thomas Lamprecht wrote: On 11/27/18 12:10 PM, Thomas Lamprecht wrote: On 11/27/18 11:32 AM, Dominik Csapak wrote: if we migrate a vm we call cleanup but the logging looks like: Starting cleanup for 101 trying to acquire lock... OK Configuration file 'nodes/pve-ce

[pve-devel] [PATCH qemu-server 2/2] better cleanup logging for migration

ock... OK Configuration file 'nodes/pve-ceph-01/qemu-server/101.conf' does not exist Config for 101 not found, possibly migrated Finished cleanup for 101 it makes it more clear that the cleanup correctly does nothing, and gives a hint that it got migrated Signed-off-by: Dominik Csapak --- maybe

[pve-devel] [PATCH qemu-server 1/2] fix q35 live migration

with live migration the machine type not q35, but something like pc-q35-2.12 so we missed to include the q35 cfg in the future we probably want to have a QemuServer::Tools to refactor such methods Signed-off-by: Dominik Csapak --- PVE/QemuServer/USB.pm | 2 +- 1 file changed, 1 insertion(+), 1

Re: [pve-devel] [PATCH access-control] api/ticket: move getting cluster name into an eval

Reviewed-by: Dominik Csapak Tested-by: Dominik Csapak On 11/26/18 2:55 PM, Thomas Lamprecht wrote: to avoid a failed login if a broken corosync config is setup Signed-off-by: Thomas Lamprecht --- PVE/API2/AccessControl.pm | 13 - 1 file changed, 8 insertions(+), 5 deletions

[pve-devel] [PATCH docs 2/2] pci passthrough: add example for functions

Signed-off-by: Dominik Csapak --- qm-pci-passthrough.adoc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qm-pci-passthrough.adoc b/qm-pci-passthrough.adoc index 0a5c63f..7e00e2e 100644 --- a/qm-pci-passthrough.adoc +++ b/qm-pci-passthrough.adoc @@ -192,8 +192,8

[pve-devel] [PATCH docs 1/2] pci passthrough: add GPU passthrough notes

to make it clear how to use a GPU inside the vm Signed-off-by: Dominik Csapak --- qm-pci-passthrough.adoc | 15 +++ 1 file changed, 15 insertions(+) diff --git a/qm-pci-passthrough.adoc b/qm-pci-passthrough.adoc index 43b9ddc..0a5c63f 100644 --- a/qm-pci-passthrough.adoc +++ b/qm

[pve-devel] [PATCH common] SysFSTools: add return format comments

for lspci and get_mdev_types Signed-off-by: Dominik Csapak --- src/PVE/SysFSTools.pm | 33 + 1 file changed, 33 insertions(+) diff --git a/src/PVE/SysFSTools.pm b/src/PVE/SysFSTools.pm index 2e7d028..2da3a38 100644 --- a/src/PVE/SysFSTools.pm +++ b/src/PVE

[pve-devel] [PATCH access-control] fix #1998: correct return properties for read_role

we have each privilege as property of the return object, so we generate it from $valid_privs this has the advantage that all privileges are well documented with that api call Signed-off-by: Dominik Csapak --- PVE/API2/Role.pm | 4 +--- PVE/AccessControl.pm | 11 +++ 2 files

[pve-devel] [PATCH docs] fix clean-static find call

'-not -name' instead of '-not name' Signed-off-by: Dominik Csapak --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 81cce99..c049eda 100644 --- a/Makefile +++ b/Makefile @@ -229,7 +229,7 @@ update-static: .PHONY:

[pve-devel] applied: [PATCH manager v4] ui: add CephFS integration

applied, thanks :) ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH manager 2/3] gui: add osd restart button

Signed-off-by: Dominik Csapak --- www/manager6/ceph/OSD.js | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/www/manager6/ceph/OSD.js b/www/manager6/ceph/OSD.js index 8fe7e794..144fab7e 100644 --- a/www/manager6/ceph/OSD.js +++ b/www/manager6/ceph/OSD.js @@ -363,6

[pve-devel] [PATCH manager 1/3] ceph: add service restart api call

like start/stop but for restart, this makes maintenance a bit easier Signed-off-by: Dominik Csapak --- PVE/API2/Ceph.pm | 50 ++ 1 file changed, 50 insertions(+) diff --git a/PVE/API2/Ceph.pm b/PVE/API2/Ceph.pm index 0fc95ab0..374d83b4 100644

[pve-devel] [PATCH manager 3/3] gui: add ceph monitor restart button

Signed-off-by: Dominik Csapak --- www/manager6/ceph/Monitor.js | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/www/manager6/ceph/Monitor.js b/www/manager6/ceph/Monitor.js index 8093ed0a..a3a18a83 100644 --- a/www/manager6/ceph/Monitor.js +++ b/www/manager6/ceph

[pve-devel] [PATCH manager 0/3] ceph gui: add restart buttons

to make maintenance easier, add restart buttons for monitors and osds this series is written with thomas cephfs/mds patches applied, but i think they should apply cleanly nonetheless on master Dominik Csapak (3): ceph: add service restart api call gui: add osd restart button gui: add ceph

Re: [pve-devel] [PATCH manager v2 5/5] ui: add CephFS integration

oh one high level comment to the panel: maybe a minheight and emptytext (e.g., 'no cephfs configured') for the cephfs list would make sense, otherwise it look rather weird (zero height list with another panel directly iunder it) ___ pve-devel mailing

Re: [pve-devel] [PATCH manager v2 3/5] ceph: add CephFS create and list API

one small comment inline, looks good otherwise On 11/22/18 8:34 PM, Thomas Lamprecht wrote: Allow to create a new CephFS instance and allow to list them. As deletion requires coordination between the active MDS and all standby MDS next in line this needs a bit more work. One could mark the MDS

Re: [pve-devel] [PATCH manager v2 5/5] ui: add CephFS integration

some comments inline On 11/22/18 8:34 PM, Thomas Lamprecht wrote: create/destroy MDS and create CephFS (if none is configured yet). Can be improved, e.g., start/stop/restart for MDS this should be enough for a starter, though. Basic code and ui layout is based off my dc/Cluster view. We may wan

Re: [pve-devel] [PATCH manager v2 2/5] ceph: add MDS create/delete/list API

1 minor thing inline, rest looks good On 11/22/18 8:34 PM, Thomas Lamprecht wrote: Allow to create, list and destroy and Ceph Metadata Server (MDS) over the API and the CLI `pveceph` tool. Besides setting up the local systemd service template and the MDS data directory we also add a reference t

[pve-devel] [PATCH manager v3 5/6] gui: add qemu/PCIEdit.js

warning if he selects a device that shares an iommugroup with a different device (but not the same device with different function). that detection is not perfect, but we cannot do really better Signed-off-by: Dominik Csapak --- changes from v2: * rom-file readonly and only visible if set www

[pve-devel] [PATCH manager v3 6/6] gui: let users add PCI devices

this enables the gui part to enable the user to add a pci device via the gui we disable the button after 4 devices, since that is the maximum in the backend Signed-off-by: Dominik Csapak --- changes from v2: * correct noSysConsolePerm check www/manager6/qemu/HardwareView.js | 25

[pve-devel] [PATCH manager v3 3/6] gui: add form/PCISelector

this adds a form field for selecting a pci device Signed-off-by: Dominik Csapak --- changes from v2: * column header/size fixes www/manager6/Makefile| 1 + www/manager6/form/PCISelector.js | 90 2 files changed, 91 insertions(+) create

[pve-devel] [PATCH manager v3 1/6] Scan.pm: add pci scan api call

Signed-off-by: Dominik Csapak --- PVE/API2/Scan.pm | 124 +++ 1 file changed, 124 insertions(+) diff --git a/PVE/API2/Scan.pm b/PVE/API2/Scan.pm index b67c1041..15c8b48a 100644 --- a/PVE/API2/Scan.pm +++ b/PVE/API2/Scan.pm @@ -46,6 +46,7

[pve-devel] [PATCH manager v3 0/6] add pci passthrough gui

this is the manager part of my mdev/passthrough series changes from v2: * new mdev path -> pci/ID/mdev * column header/size fixes * rom-file is readonly * sys console check fixed Dominik Csapak (6): Scan.pm: add pci scan api call Scan.pm: add mdev scan api call gui: add form/PCISelec

[pve-devel] [PATCH manager v3 4/6] gui: add MDevSelector

this is used to select a mediated device type Signed-off-by: Dominik Csapak --- chnages from v2: * api path change * setProxy optimized -> only 1 url generation -> less code www/manager6/Makefile | 1 + www/manager6/form/MDevSelector.j

[pve-devel] [PATCH manager v3 2/6] Scan.pm: add mdev scan api call

this is for the gui to be able to select mediated devices path ist /node/NODE/scan/pci/PCIID/mdev Signed-off-by: Dominik Csapak --- changes from v2: * new path for mdev -> pci/ID/mdev * fixed pci regex '.' -> '\.

Re: [pve-devel] [PATCH common/qemu-server/manager v2] add mdev support and passthrough gui

On 11/20/18 5:26 PM, Thomas Lamprecht wrote: On 11/20/18 5:13 PM, Dominik Csapak wrote: this series add support for mediated devices, such as Nvidias vGPUs and Intels KVMgt (aka GVT-g), as well as gui support for PCI passthrough in general this needs my 'cleanup and refactor mania seri

[pve-devel] [PATCH manager 4/6 v2] gui: add MDevSelector

this is used to select a mediated device type Signed-off-by: Dominik Csapak --- www/manager6/Makefile | 1 + www/manager6/form/MDevSelector.js | 102 ++ 2 files changed, 103 insertions(+) create mode 100644 www/manager6/form/MDevSelector.js

[pve-devel] [PATCH qemu-server 1/2 v2] add mediated devices support

with this, we are able to create and use mediated devices, which include Intel GVT-g (aka KVMGT) and Nvidia vGPUs, and probably more types of devices in the future Signed-off-by: Dominik Csapak --- changes from v1: * hardcoded sysfspath because we do not have the variable anymore PVE

[pve-devel] [PATCH common/qemu-server/manager v2] add mdev support and passthrough gui

xmox.com/pipermail/pve-devel/2018-November/034525.html 3: https://pve.proxmox.com/pipermail/pve-devel/2018-November/034458.html pve-common: Dominik Csapak (2): SysFSTools.pm: add mediated devices subs SysFSTools.pm: improve and extend lspci src/PVE/SysFSTools.pm | 192 ++

[pve-devel] [PATCH manager 5/6 v2] gui: add qemu/PCIEdit.js

warning if he selects a device that shares an iommugroup with a different device (but not the same device with different function). that detection is not perfect, but we cannot do really better Signed-off-by: Dominik Csapak --- www/manager6/Makefile| 1 + www/manager6/qemu/PCIEdit.js | 227

[pve-devel] [PATCH manager 2/6 v2] Scan.pm: add mdev scan api call

this is for the gui to be able to select mediated devices Signed-off-by: Dominik Csapak --- PVE/API2/Scan.pm | 48 1 file changed, 48 insertions(+) diff --git a/PVE/API2/Scan.pm b/PVE/API2/Scan.pm index 15c8b48a..7435915d 100644 --- a/PVE/API2

[pve-devel] [PATCH manager 6/6 v2] gui: let users add PCI devices

this enables the gui part to enable the user to add a pci device via the gui we disable the button after 4 devices, since that is the maximum in the backend Signed-off-by: Dominik Csapak --- www/manager6/qemu/HardwareView.js | 25 ++--- 1 file changed, 22 insertions(+), 3

[pve-devel] [PATCH manager 1/6 v2] Scan.pm: add pci scan api call

Signed-off-by: Dominik Csapak --- changes from v1: * more api documentation * change filter-unusable to pci-class-blacklist * define filter sub here * define default class blacklist here PVE/API2/Scan.pm | 124 +++ 1 file changed, 124

[pve-devel] [PATCH manager 3/6 v2] gui: add form/PCISelector

this adds a form field for selecting a pci device Signed-off-by: Dominik Csapak --- changes from v1: * updated field names www/manager6/Makefile| 1 + www/manager6/form/PCISelector.js | 89 2 files changed, 90 insertions(+) create mode

[pve-devel] [PATCH common 2/2 v2] SysFSTools.pm: improve and extend lspci

falsy value * adds a verbose flag to include more information about the device, such as device/vendor name, iommu-group, mdev support, etc. this will be used for the pci scan api call for the gui 1: https://pci-ids.ucw.cz/read/PD/ Signed-off-by: Dominik Csapak --- changes from v1: * retur

[pve-devel] [PATCH common 1/2 v2] SysFSTools.pm: add mediated devices subs

adds helpers for listing/creating/removing mediated devices Signed-off-by: Dominik Csapak --- changes from v1: * check path in cleanup before writing src/PVE/SysFSTools.pm | 89 +++ 1 file changed, 89 insertions(+) diff --git a/src/PVE

[pve-devel] [PATCH qemu-server 2/2 v2] use improved lspci

since lspci does not split between id and function anymore, there is no need to plug id + function together also we can remove the capture groups from PCIRE since parse_property_string does this check for us Signed-off-by: Dominik Csapak --- PVE/QemuServer.pm | 28

[pve-devel] [PATCH common] Tools.pm: do not ignore "0" in split_list

giving split_list the string "0" would actually return an empty list instead of a list with the element "0" Signed-off-by: Dominik Csapak --- src/PVE/Tools.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm index 0f3

[pve-devel] applied: [PATCH manager] ui: lxc/net: s/i.e./e.g./ and transform to emptyText

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH manager] gui: refactor render_full_name

this also fixes a missing htmlEncode in UserSelector Signed-off-by: Dominik Csapak --- www/manager6/Utils.js | 6 ++ www/manager6/dc/UserView.js | 9 + www/manager6/form/UserSelector.js | 9 + 3 files changed, 8 insertions(+), 16 deletions(-) diff --git a

[pve-devel] applied: [PATCH manager 0/3] ui: storage: cleanup and allow to add CephFS storage entry

applied series, thanks :) ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH manager] fix #1224: ui: ACLAdd: allow to filter by username

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH manager v3] fix #1358: ui: show clustername besides 'Datacenter' node, if available

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH manager 5/6] gui: add qemu/PCIEdit.js

warning if he selects a device that shares an iommugroup with a different device (but not the same device with different function). that detection is not perfect, but we cannot do really better Signed-off-by: Dominik Csapak --- www/manager6/Makefile| 1 + www/manager6/qemu/PCIEdit.js | 221

[pve-devel] [PATCH manager 1/6] Scan.pm: add pci scan api call

Signed-off-by: Dominik Csapak --- PVE/API2/Scan.pm | 96 1 file changed, 96 insertions(+) diff --git a/PVE/API2/Scan.pm b/PVE/API2/Scan.pm index b67c1041..85c10d46 100644 --- a/PVE/API2/Scan.pm +++ b/PVE/API2/Scan.pm @@ -46,6 +46,7

[pve-devel] [PATCH manager 2/6] Scan.pm: add mdev scan api call

this is for the gui to be able to select mediated devices Signed-off-by: Dominik Csapak --- PVE/API2/Scan.pm | 48 1 file changed, 48 insertions(+) diff --git a/PVE/API2/Scan.pm b/PVE/API2/Scan.pm index 85c10d46..96d73b93 100644 --- a/PVE/API2

[pve-devel] [PATCH common 2/2] SysFSTools.pm: improve and extend lspci

for the pci scan api call for the gui 1: https://pci-ids.ucw.cz/read/PD/ Signed-off-by: Dominik Csapak --- src/PVE/SysFSTools.pm | 94 --- 1 file changed, 82 insertions(+), 12 deletions(-) diff --git a/src/PVE/SysFSTools.pm b/src/PVE/SysFSTools.pm in

[pve-devel] [PATCH manager 6/6] gui: let users add PCI devices

this enables the gui part to enable the user to add a pci device via the gui we disable the button after 4 devices, since that is the maximum in the backend Signed-off-by: Dominik Csapak --- www/manager6/qemu/HardwareView.js | 25 ++--- 1 file changed, 22 insertions(+), 3

[pve-devel] [PATCH manager 4/6] gui: add MDevSelector

this is used to select a mediated device type Signed-off-by: Dominik Csapak --- www/manager6/Makefile | 1 + www/manager6/form/MDevSelector.js | 102 ++ 2 files changed, 103 insertions(+) create mode 100644 www/manager6/form/MDevSelector.js

[pve-devel] [PATCH manager 3/6] gui: add form/PCISelector

this adds a form field for selecting a pci device Signed-off-by: Dominik Csapak --- www/manager6/Makefile| 1 + www/manager6/form/PCISelector.js | 89 2 files changed, 90 insertions(+) create mode 100644 www/manager6/form/PCISelector.js

[pve-devel] [PATCH common/qemu-server/manager] add mdev support and passthrough gui

ps://pve.proxmox.com/pipermail/pve-devel/2018-November/034525.html 3: https://pve.proxmox.com/pipermail/pve-devel/2018-November/034458.html pve-common: Dominik Csapak (2): SysFSTools.pm: add mediated devices subs SysFSTools.pm: improve and extend lspci

[pve-devel] [PATCH qemu-server 2/2] use improved lspci

since lspci does not split between id and function anymore, there is no need to plug id + function together also we can remove the capture groups from PCIRE since parse_property_string does this check for us Signed-off-by: Dominik Csapak --- PVE/QemuServer.pm | 28

[pve-devel] [PATCH qemu-server 1/2] add mediated devices support

with this, we are able to create and use mediated devices, which include Intel GVT-g (aka KVMGT) and Nvidia vGPUs, and probably more types of devices in the future Signed-off-by: Dominik Csapak --- PVE/QemuServer.pm | 54 +- 1 file changed, 49

[pve-devel] [PATCH common 1/2] SysFSTools.pm: add mediated devices subs

adds helpers for listing/creating/removing mediated devices Signed-off-by: Dominik Csapak --- src/PVE/SysFSTools.pm | 85 +++ 1 file changed, 85 insertions(+) diff --git a/src/PVE/SysFSTools.pm b/src/PVE/SysFSTools.pm index 4b23668..a031713

[pve-devel] [PATCH storage 2/3] remove PVE/API2/Storage/Scan.pm

since those are now defined in pve-manager Signed-off-by: Dominik Csapak --- PVE/API2/Storage/Makefile | 2 +- PVE/API2/Storage/Scan.pm | 97 --- 2 files changed, 1 insertion(+), 98 deletions(-) delete mode 100644 PVE/API2/Storage/Scan.pm diff

[pve-devel] [PATCH manager 5/5] rename PVE::API2::Storage::Scan to PVE::API2::Scan

and use it in the API Signed-off-by: Dominik Csapak --- PVE/API2/Makefile | 1 + PVE/API2/Nodes.pm | 4 ++-- PVE/API2/Scan.pm | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/PVE/API2/Makefile b/PVE/API2/Makefile index 9862e498..75b022dd 100644 --- a/PVE/API2/Makefile

[pve-devel] [PATCH manager 4/5] use scan_usb from PVE::SysFSTools rather than PVE::Storage

the code moved there Signed-off-by: Dominik Csapak --- PVE/API2/Scan.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/PVE/API2/Scan.pm b/PVE/API2/Scan.pm index f0ae10c3..87f83c9d 100644 --- a/PVE/API2/Scan.pm +++ b/PVE/API2/Scan.pm @@ -6,6 +6,7 @@ use warnings; use PVE

[pve-devel] [PATCH storage 1/3] move Scan API calls from PVE/API2/Storage/Scan.pm to pvesm.pm

since the calls for the real API are defined now in pve-managers Scan.pm Signed-off-by: Dominik Csapak --- PVE/API2/Storage/Scan.pm | 328 PVE/CLI/pvesm.pm | 343 +-- 2 files changed, 335 insertions

[pve-devel] [PATCH manager 1/5] copy Scan.pm from pve-storage

this will be used for the api endpoints in the future as PVE::API2::Scan instead of PVE::API2::Storage::Scan since it will contain endpoints to other modules (like qemu-server for pci/usb scanning) Signed-off-by: Dominik Csapak --- PVE/API2/Scan.pm | 425

[pve-devel] [PATCH qemu-server 1/1] remove PCI helpers from QemuServer.pm

and use it from PVE::SysFSTools, where they are now Signed-off-by: Dominik Csapak --- PVE/QemuServer.pm | 158 +++--- PVE/QemuServer/PCI.pm | 2 + 2 files changed, 10 insertions(+), 150 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE

[pve-devel] [PATCH manager 2/5] Scan.pm: whitespace fixes

Signed-off-by: Dominik Csapak --- PVE/API2/Scan.pm | 56 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/PVE/API2/Scan.pm b/PVE/API2/Scan.pm index 4ff023e2..de9c05c8 100644 --- a/PVE/API2/Scan.pm +++ b/PVE/API2/Scan.pm

[pve-devel] [PATCH manager 3/5] Scan.pm: remove unused HTTP::Status module

Signed-off-by: Dominik Csapak --- PVE/API2/Scan.pm | 1 - 1 file changed, 1 deletion(-) diff --git a/PVE/API2/Scan.pm b/PVE/API2/Scan.pm index de9c05c8..f0ae10c3 100644 --- a/PVE/API2/Scan.pm +++ b/PVE/API2/Scan.pm @@ -6,7 +6,6 @@ use warnings; use PVE::SafeSyslog; use PVE::Storage; use PVE

[pve-devel] [PATCH common 5/5] copy scan_usb from PVE::Storage to PVE::SysFSTools

it makes more sens to have it here rather than in pve-storage Signed-off-by: Dominik Csapak --- src/PVE/SysFSTools.pm | 57 +++ 1 file changed, 57 insertions(+) diff --git a/src/PVE/SysFSTools.pm b/src/PVE/SysFSTools.pm index e4bc328..4b23668

[pve-devel] [PATCH storage 3/3] remove usb scan code

this is now in PVE::SysFSTools Signed-off-by: Dominik Csapak --- PVE/Storage.pm | 56 1 file changed, 56 deletions(-) diff --git a/PVE/Storage.pm b/PVE/Storage.pm index a5f7fdb..d23cc3b 100755 --- a/PVE/Storage.pm +++ b/PVE/Storage.pm

[pve-devel] [PATCH common 2/5] SysFSTools.pm: refactor pci regex

Signed-off-by: Dominik Csapak --- src/PVE/SysFSTools.pm | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/PVE/SysFSTools.pm b/src/PVE/SysFSTools.pm index 8906f19..87568fb 100644 --- a/src/PVE/SysFSTools.pm +++ b/src/PVE/SysFSTools.pm @@ -8,13 +8,15 @@ use IO::File

[pve-devel] [PATCH common 3/5] SysFSTools.pm: implement filter in lspci

use the first parameter as a filter for devices, like it is used Signed-off-by: Dominik Csapak --- src/PVE/SysFSTools.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/PVE/SysFSTools.pm b/src/PVE/SysFSTools.pm index 87568fb..660f94b 100644 --- a/src/PVE/SysFSTools.pm +++ b/src/PVE

[pve-devel] [PATCH common 1/5] copy pci related subs from PVE::QemuServer

we want to have it in common, so we can maybe reuse them later, also the code is not really qemu-server related Signed-off-by: Dominik Csapak --- src/Makefile | 1 + src/PVE/SysFSTools.pm | 155 ++ 2 files changed, 156 insertions

[pve-devel] [PATCH common 4/5] SysFSTools.pm: implement iommu check

Signed-off-by: Dominik Csapak --- src/PVE/SysFSTools.pm | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/PVE/SysFSTools.pm b/src/PVE/SysFSTools.pm index 660f94b..e4bc328 100644 --- a/src/PVE/SysFSTools.pm +++ b/src/PVE/SysFSTools.pm @@ -33,12 +33,8 @@ sub lspci

[pve-devel] [PATCH common/qemu-server/manager/storage] cleanup and refactor mania

depend on the others, but breaks manager without its patches common does not depend on the others and does not break anything(tm) 1: https://pve.proxmox.com/pipermail/pve-devel/2018-November/034525.html pve-common: Dominik Csapak (5): copy pci related subs from PVE::QemuServer SysFSTools.pm

[pve-devel] [PATCH qemu-server 1/3] copy scan_usb from PVE::Storage

it makes more sense to have it here rather than in storage Signed-off-by: Dominik Csapak --- PVE/QemuServer/USB.pm | 58 +++ 1 file changed, 58 insertions(+) diff --git a/PVE/QemuServer/USB.pm b/PVE/QemuServer/USB.pm index 3d65d38..f51329b 100644

<    6   7   8   9   10   11   12   13   14   15   >