storage config is motly copied from the config2command tests
Signed-off-by: Dominik Csapak
---
test/Makefile | 5 +-
test/run_qemu_img_convert_tests.pl | 186 +
2 files changed, 190 insertions(+), 1 deletion(-)
create mode 100755 test
with commit
7d07e92edaf9c58631953ab7f300a125d63fdd95
we changed how we define isUsedDisk, which was true for efidisks before,
but not after
use the existing 'isEfi' varable to include them for the move_btn
(but not the resize_btn)
Signed-off-by: Dominik Csapak
---
www/man
On 10/10/19 1:05 PM, Thomas Lamprecht wrote:
On 10/10/19 12:31 PM, Aaron Lauterer wrote:
On 10/10/19 12:21 PM, Dominik Csapak wrote:
On 10/10/19 11:54 AM, Thomas Lamprecht wrote:
To make it more clear that PVE does not somehow magically injects a
QHA into the VM, but that this can be set if
On 10/10/19 11:54 AM, Thomas Lamprecht wrote:
To make it more clear that PVE does not somehow magically injects a
QHA into the VM, but that this can be set if one has installed the
QGA in the VM themself.
good idea to make it clearer, but i think the new text is also not
ideal, since it does n
applied series, thanks
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
otherwise qemu-img uses its default intiator id which may not have access
Signed-off-by: Dominik Csapak
---
PVE/QemuServer.pm | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 8376260..2267a3a 100644
--- a/PVE
this is useful as meta information for e.g., provisioning or config
management systems
adding the info also to the 'status' api call to make it easier to show
it in the gui
Signed-off-by: Dominik Csapak
---
PVE/API2/Qemu.pm | 1 +
PVE/QemuServer.pm | 14 +-
2 files c
this is useful as meta information for e.g., provisioning or config
management systems
adding the info also to the 'status' api call to make it easier to show
it in the gui
Signed-off-by: Dominik Csapak
---
src/PVE/LXC.pm| 6 ++
src/PVE/LXC/Config.pm | 9 +++--
2 fil
this way they are always visible when a user has selected a vm
Signed-off-by: Dominik Csapak
---
www/manager6/lxc/Config.js | 12 +---
www/manager6/qemu/Config.js | 11 +--
2 files changed, 18 insertions(+), 5 deletions(-)
diff --git a/www/manager6/lxc/Config.js b/www/manager6
the status api call of guests (for gui)
* show the tags in the gui
* make the tags editable in the gui
pve-common:
Dominik Csapak (1):
JSONSchema: add pve-tag format
src/PVE/JSONSchema.pm | 12
1 file changed, 12 insertions(+)
qemu-server:
Dominik Csapak (1):
add 'tags
so that the user can edit the tags in the gui
Signed-off-by: Dominik Csapak
---
www/manager6/lxc/Options.js | 13 +
www/manager6/qemu/Options.js | 13 +
2 files changed, 26 insertions(+)
diff --git a/www/manager6/lxc/Options.js b/www/manager6/lxc/Options.js
index
it seems that this is not needed anymore, at least i cannot
see any difference with/without it here (chromium 76)
Signed-off-by: Dominik Csapak
---
this is necessary for the TagSelector to be shown properly in
chrome/chromium, otherwise it is only a single line
if anyone tests this and sees an
api call)
Signed-off-by: Dominik Csapak
---
www/css/ext6-pve.css | 12
www/manager6/Makefile| 1 +
www/manager6/form/TagSelector.js | 117 +++
3 files changed, 130 insertions(+)
create mode 100644 www/manager6/form/TagSelector.js
diff
this will be used for vm/ct tag-lists, so that (config) management systems
or similar add additional information that does not reside in the
description
putting it here, since we want to eventually have it also for
nodes,storages,etc.
Signed-off-by: Dominik Csapak
---
src/PVE/JSONSchema.pm
helpers to
* generate a color from a string consistently
* generate a html tag for a tag
* related css classes
Signed-off-by: Dominik Csapak
---
www/css/ext6-pve.css | 13 +
www/manager6/Utils.js | 34 ++
2 files changed, 47 insertions(+)
diff --git
hi, while this patch should work (did not test it),
this can be done better
we could do something like:
---8<---
for (my $id = 0; $id < MAX_NETS; $id++) {
my $iface = "net$id";
next if !$conf->{$iface};
--->8---
this way we do not have to grep the whole conf
and sort it afterwards, but
On 9/23/19 5:34 PM, Thomas Lamprecht wrote:
On 9/10/19 2:57 PM, Dominik Csapak wrote:
this series lets users add tags to guest configs
these do not have any concrete meaning but are intended to be used
by management software such as config management systems
Looks OK, besides some comments
On 9/23/19 5:30 PM, Thomas Lamprecht wrote:
On 9/10/19 2:57 PM, Dominik Csapak wrote:
useful for vm/ct tags
a short sentence which describes the format would be appreciated..
Also, I'd like to keep format registrations here relatively minimal,
I mean they do not need to have the wide s
otherwise a user with only VM.Config.HWType cannot
delete a 'pending' usbX: spice or serial: socket option
Signed-off-by: Dominik Csapak
---
PVE/API2/Qemu.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 3355c8b..5814
lgtm, i find it understandable that the 'spice enhancments' are disabled
because spice is not selected, but maybe someone else has a comment on that?
On 9/17/19 11:35 AM, Aaron Lauterer wrote:
For a cleaner UI the SCSI Controller (pveScsiHwSelector) is moved to the
left column below the VGA sele
On 9/17/19 11:35 AM, Aaron Lauterer wrote:
Signed-off-by: Aaron Lauterer
---
www/manager6/Utils.js| 18 ++
www/manager6/qemu/Options.js | 13 +
2 files changed, 31 insertions(+)
diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index 6a489e7e..a9
On 9/17/19 11:35 AM, Aaron Lauterer wrote:
Signed-off-by: Aaron Lauterer
---
www/manager6/Makefile | 1 +
www/manager6/form/SpiceEnhancementSelector.js | 72 +++
2 files changed, 73 insertions(+)
create mode 100644 www/manager6/form/SpiceEnhancement
applied, thanks
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Signed-off-by: Dominik Csapak
---
www/manager6/qemu/Config.js | 8
1 file changed, 8 insertions(+)
diff --git a/www/manager6/qemu/Config.js b/www/manager6/qemu/Config.js
index b56f3779..65b0cbbf 100644
--- a/www/manager6/qemu/Config.js
+++ b/www/manager6/qemu/Config.js
@@ -143,6
Signed-off-by: Dominik Csapak
---
Utils.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/Utils.js b/Utils.js
index 533272d..aac877a 100644
--- a/Utils.js
+++ b/Utils.js
@@ -475,6 +475,7 @@ Ext.define('Proxmox.Utils', { utilities: {
qmstop: [ 'VM', gettext('
On 9/11/19 1:26 PM, Thomas Lamprecht wrote:
On 11.09.19 12:14, Dominik Csapak wrote:
this conflicts with our syntax of pending changes, so we have to forbid it
the check must be case-insensitive since we parse it that way from the config
this may be reverted again sometime with 7.0 if we
this creates a reboot request file (inspired by pve-container)
and relies on the 'qm cleanup' call by the qmeventd to detect
and restart the vm afterwards
Signed-off-by: Dominik Csapak
---
changes from v3:
* add note about pending changes in api description
* move storecfg into
we want to reuse most of the code in the locked context of vm_stop
for vm_reboot (since it really is just a vm_stop with a
create_reboot_request in there) so we factor that out into
_do_vm_stop
and note that it has to be called in a locked context
Signed-off-by: Dominik Csapak
---
new in v4
change
the target state
Dominik Csapak (4):
add create and remove reboot trigger subs
qm: cleanup: detect and handle reboot trigger
refactor vm_stop locked code
api: add reboot api call
PVE/API2/Qemu.pm | 59 +++
PVE/CLI/qm.pm | 14
PVE/QemuServer.pm | 187
if the reboot trigger file was set, start the vm again
also cleanup the reboot trigger on vm startup, to prevent
leftover files to trigger a reboot at the next shutdown
Signed-off-by: Dominik Csapak
---
changes from v3:
* use shorter eval and warn
PVE/CLI/qm.pm | 12
PVE
Signed-off-by: Dominik Csapak
---
changes from v3:
* use ENOENT to check for existance
PVE/QemuServer.pm | 19 +++
1 file changed, 19 insertions(+)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 7128723..367d080 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
this conflicts with our syntax of pending changes, so we have to forbid it
the check must be case-insensitive since we parse it that way from the config
this may be reverted again sometime with 7.0 if we decide to change the
name of the pending section
Signed-off-by: Dominik Csapak
---
PVE
this is useful as meta information for e.g., provisioning or config
management systems
Signed-off-by: Dominik Csapak
---
src/PVE/LXC/Config.pm | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm
index 9790345..2a67e7f 100644
this is useful as meta information for e.g., provisioning or config
management systems
Signed-off-by: Dominik Csapak
---
PVE/API2/Qemu.pm | 1 +
PVE/QemuServer.pm | 6 ++
2 files changed, 7 insertions(+)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 245de80..ea2d55d 100644
--- a
useful for vm/ct tags
Signed-off-by: Dominik Csapak
---
src/PVE/JSONSchema.pm | 11 +++
1 file changed, 11 insertions(+)
diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm
index db38d44..e221dce 100644
--- a/src/PVE/JSONSchema.pm
+++ b/src/PVE/JSONSchema.pm
@@ -499,6 +499,17
gui by tag
* add them to storages/realms/...
depending on what users need and is reasonable to implement
this series is partly a replacement for my older patchseries,
which used the tags for qemus fw_cfg (this will be its own config)
pve-common:
Dominik Csapak (1):
JSONSchema: add pve-tag format
Signed-off-by: Dominik Csapak
---
i tested around a bit, everything seemed to work
.../0001-add-pve-specific-js-code.patch | 78 +--
...002-add-custom-fbresize-event-on-rfb.patch | 19 ++-
...nge-scaling-when-toggling-fullscreen.patch | 15 +--
debian/patches/0004-add-pve
Signed-off-by: Dominik Csapak
---
the mirror has ofc to be updated
novnc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/novnc b/novnc
index f9b6d76..9fe2fd0 16
--- a/novnc
+++ b/novnc
@@ -1 +1 @@
-Subproject commit f9b6d7665d01f31a6c0c675ec3f604e99f6b2341
+Subproject
looks mostly ok, one (important) comment inline
On 9/5/19 6:13 PM, Aaron Lauterer wrote:
For non pci express passthrough additional addresses are reserved.
For pcie passthrough pcie root ports are needed (unless guest is like
windows 7).
The first 4 pcie root ports are defined by default in the
looks good to me
On 9/5/19 6:12 PM, Aaron Lauterer wrote:
Signed-off-by: Aaron Lauterer
---
www/manager6/qemu/HardwareView.js | 4 ++--
www/manager6/qemu/PCIEdit.js | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/www/manager6/qemu/HardwareView.js
b/www/manager6/
50 should be enough for all translations and we do not have
any other element there
Signed-off-by: Dominik Csapak
---
www/manager6/window/LoginWindow.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/window/LoginWindow.js
b/www/manager6/window/LoginWindow.js
i
Signed-off-by: Dominik Csapak
---
changes from v2:
* renamed to clear/create_reboot_request
PVE/QemuServer.pm | 20
1 file changed, 20 insertions(+)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index a424720..535297d 100644
--- a/PVE/QemuServer.pm
+++ b/PVE
if the reboot trigger file was set, start the vm again
also cleanup the reboot trigger on vm startup, to prevent
leftover files to trigger a reboot at the next shutdown
Signed-off-by: Dominik Csapak
---
changes from v2:
* warn on error
* add explaining comment
PVE/CLI/qm.pm | 14
arameters
of 'vm_stop'
Signed-off-by: Dominik Csapak
---
better view with '-w' as it is mostly code shift
changes from v2:
* refactored vm_stop so that the code can be reused in vm_reboot
* better function signature
* add vm running check in api, such that it cannot be cal
Signed-off-by: Dominik Csapak
---
changes from v2:
* now 1/4
* does not include reboot (this comes in the api patch)
PVE/API2/Qemu.pm | 3 +++
1 file changed, 3 insertions(+)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 245de80..9db8967 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2
shutdown
* cleanup the trigger on vm startup
* use always vm_stop even for ha vms, since we do not want to change
the target state
Dominik Csapak (4):
api: add missing index child links
add create and remove reboot trigger subs
qm: cleanup: detect and handle reboot trigger
api: add reboot api
$1 and $2 get set to undef from the vmid filter regex, so we have to do
the name/format regex after, else we get errors like:
'use of unitiialized value $1[...]'
and the listing is empty
Signed-off-by: Dominik Csapak
---
PVE/Storage/Plugin.pm | 2 +-
1 file changed, 1 insertion(+),
On 9/5/19 12:42 PM, Thomas Lamprecht wrote:
On 05.09.19 12:27, Dominik Csapak wrote:
On 9/5/19 11:47 AM, Thomas Lamprecht wrote:
On 23.08.19 10:55, Dominik Csapak wrote:
Signed-off-by: Dominik Csapak
+ open(my $fh, '>', "/run/qemu-server/$vmid.reboot")
+ o
On 9/5/19 11:47 AM, Thomas Lamprecht wrote:
On 23.08.19 10:55, Dominik Csapak wrote:
Signed-off-by: Dominik Csapak
---
new in v2
trigger is normally something which is done actively, i.e., gets triggered
like "pulling the trigger" says.
Maybe call it a flag and the file &qu
we do not support ie11 anymore due to some es6 features we use
Signed-off-by: Dominik Csapak
---
pve-system-requirements.adoc | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/pve-system-requirements.adoc b/pve-system-requirements.adoc
index 40965db..0a4ba6c 100644
--- a/pve
On 9/2/19 2:27 PM, Thomas Lamprecht wrote:
On 9/2/19 2:14 PM, Fabian Grünbichler wrote:
On August 23, 2019 2:03 pm, Dominik Csapak wrote:
this add the 'tags' property to vms, which has the format:
why 'tags'? seems rather generic for what it does ;)
Second, tags is
On 9/2/19 2:14 PM, Fabian Grünbichler wrote:
On August 23, 2019 2:03 pm, Dominik Csapak wrote:
this add the 'tags' property to vms, which has the format:
why 'tags'? seems rather generic for what it does ;)
because the request in the bugreport was a more general one
(us
this breaks live migration of vms with q35 (without passthrough)
we should be able to add those rootports on demand (if a 'hostpciX'
exists, for X >= 4) via qemu commandline
i do not really want to extend the default setup to include that many
root ports (should do no harm really, but is
nder linux the value can be read under
/sys/firmware/qemu_fw_cfg/by_name/opt/com.proxmox./$key/raw
see the file docs/specs/fw_cfg.txt in the qemu repository for more
details
maybe we can also use this in the future to show/set in the gui
e.g. some grouping/ordering etc.
Signed-off-by: Domi
this creates a reboot trigger file (inspired by pve-container)
and relies on the 'qm cleanup' call by the qmeventd to detect
and restart the vm afterwards
Signed-off-by: Dominik Csapak
---
changes from rfc:
* use PVE::QemuServer:vm_stop instead of the api call, to prevent
the ha
if the reboot trigger file was set, start the vm again
also cleanup the reboot trigger on vm startup, to prevent
leftover files to trigger a reboot at the next shutdown
Signed-off-by: Dominik Csapak
---
change from rfc:
* use remove_reboot_trigger sub
* cleanup also on vm start
PVE/CLI/qm.pm
Signed-off-by: Dominik Csapak
---
PVE/CLI/qm.pm | 2 ++
1 file changed, 2 insertions(+)
diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm
index f9b0fd7..0e8475e 100755
--- a/PVE/CLI/qm.pm
+++ b/PVE/CLI/qm.pm
@@ -999,6 +999,8 @@ our $cmddef = {
shutdown => [ "PVE::API2::Qemu",
Signed-off-by: Dominik Csapak
---
PVE/API2/Qemu.pm | 4
1 file changed, 4 insertions(+)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 5094721..6ddfca7 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qemu.pm
@@ -1916,6 +1916,10 @@ __PACKAGE__->register_method({
{ sub
Signed-off-by: Dominik Csapak
---
new in v2
PVE/QemuServer.pm | 12
1 file changed, 12 insertions(+)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 9f5bf56..d1767a9 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -7369,6 +7369,18 @@ sub nbd_stop
into their own subs
* only create reboot trigger while having the lock during shutdown
* cleanup the trigger on vm startup
* use always vm_stop even for ha vms, since we do not want to change
the target state
Dominik Csapak (5):
add create and remove reboot trigger subs
qm: cleanup: detect and
looks good, but 2 comments inline
On 8/20/19 6:02 PM, Aaron Lauterer wrote:
This adds a new config option called `spice_enhancements` with two
optional settings:
* videostreaming
* foldersharing
Signed-off-by: Aaron Lauterer
v1 -> v2:
format changes suggested by dominik:
* changed descriptio
looks ok, a bit weird, but researching showed that there are no extjs
builtin ways for this, so...
Acked-by: Dominik Csapak
On 8/22/19 1:35 PM, Stefan Reiter wrote:
By default, all file types are shown, but the user now has the option of
filtering only by supported types in the file selector
comments inline
On 8/22/19 1:35 PM, Stefan Reiter wrote:
To maintain full (backwards) compatibility, leave the type name as
'iso' - this makes this patch work without changing every consumer of
storage APIs.
Note that currently these files can only be attached as a CDROM/DVD
drive, so USB-only
ly
Signed-off-by: Dominik Csapak
---
PVE/API2/Ceph/OSD.pm | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/PVE/API2/Ceph/OSD.pm b/PVE/API2/Ceph/OSD.pm
index 78ad3734..5f70cf58 100644
--- a/PVE/API2/Ceph/OSD.pm
+++ b/PVE/API2/Ceph/OSD.pm
@@ -313,10 +313,13 @@ _
the api returns 'null' for a host that is in the crushmap, but
without actual version information, so just check for falsyness instead
of 'undefined', else we run later into javascript exceptions and no
content on the osd page
Signed-off-by: Dominik Csapak
---
i am not so su
On 8/21/19 10:39 AM, Thomas Lamprecht wrote:
On 8/20/19 2:50 PM, Dominik Csapak wrote:
we need to set the minvalue for the memoryfield when setting the
'mininum memory', otherwise it is possible in the wizard to set
a higher minimum than maximum value
Signed-off-by: Dominik Csapak
we need to set the minvalue for the memoryfield when setting the
'mininum memory', otherwise it is possible in the wizard to set
a higher minimum than maximum value
Signed-off-by: Dominik Csapak
---
www/manager6/qemu/MemoryEdit.js | 6 --
1 file changed, 4 insertions(+), 2
for some reason not setting port results in a port of '65535' which
triggers an execption in http-server anyevent, so we set the port to 0
also, we have to read the ticket from stdin even for 'unix' type secure
migration
Signed-off-by: Dominik Csapak
---
PVE/API2/Q
if the reboot trigger file was set, start the vm again
Signed-off-by: Dominik Csapak
---
PVE/CLI/qm.pm | 13 +
1 file changed, 13 insertions(+)
diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm
index 3aae23c..031aa49 100755
--- a/PVE/CLI/qm.pm
+++ b/PVE/CLI/qm.pm
@@ -763,6 +763,7
d poll the shutdown/start procedure?
Dominik Csapak (4):
qm: cleanup: detect and handle reboot trigger
api: add reboot api call
qm: add reboot command
api: add missing index child links
PVE/API2/Qemu.pm | 49
PVE/CLI/qm.pm| 15
Signed-off-by: Dominik Csapak
---
PVE/API2/Qemu.pm | 4
1 file changed, 4 insertions(+)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index d59e23c..d7accbe 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qemu.pm
@@ -1916,6 +1916,10 @@ __PACKAGE__->register_method({
{ sub
Signed-off-by: Dominik Csapak
---
PVE/CLI/qm.pm | 2 ++
1 file changed, 2 insertions(+)
diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm
index 031aa49..c759198 100755
--- a/PVE/CLI/qm.pm
+++ b/PVE/CLI/qm.pm
@@ -999,6 +999,8 @@ our $cmddef = {
shutdown => [ "PVE::API2::Qemu",
this creates a reboot trigger file (inspired by pve-container)
and relies on the 'qm cleanup' call by the qmeventd to detect
and restart the vm afterwards
Signed-off-by: Dominik Csapak
---
PVE/API2/Qemu.pm | 45 +
1 file changed, 45
no caller used that parameter, ever
Signed-off-by: Dominik Csapak
---
PVE/QemuServer.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 220af73..9f5bf56 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -7178,9 +7178,9
we now also save the mtime of the binary and cache per binary (for each
arch; this is done so we have it already when we sometime decide
that we want to split the qemu package for each arch)
so that we get the real version if only pve-qemu-kvm was updated
Signed-off-by: Dominik Csapak
---
PVE
i just benchmarked a cached stat version vs. not cached
code is the following:
8<
use strict;
use warnings;
use utf8;
use Benchmark qw(cmpthese);
use PVE::Tools qw(run_command);
my $kvm_cache;
my $kvm_timestamp;
sub get_kvm_version {
my $kvm_user_version = 'unknown';
my $code
On 8/12/19 11:43 AM, Thomas Lamprecht wrote:
Am 8/12/19 um 10:37 AM schrieb Dominik Csapak:
we want to notify the api that there is a new qemu-binary, since
the version will be cached in qemu-server and instead of
checking the version every time, just restart pveproxy/pvedaemon
whenever there
pvedaemon starts a vm with a new version but with the
defaults of an old version because of the version cache,
breaking live migration
Signed-off-by: Dominik Csapak
---
i do not know if that issue was ever triggered, but it seems
very unlikely, so this is just to be safe
the other alternative, either
this fixes the display and selection problem with countries that
have non-ascii symbols in them, like "Côte d'Ivoire"
Signed-off-by: Dominik Csapak
---
proxinstall | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/proxinstall b/proxinstall
index 963152a..d9e22
since the content of the window is encoded with 'Ext.htmlEncode'
we have to decode it with 'Ext.String.htmlDecode' (Ext.htmlDecode is
a deprecated alias for it) before downloading the file
Signed-off-by: Dominik Csapak
---
www/manager6/node/Subscription.js | 2 +-
1 file
at this point, the user may have switched the panel already and it
might seem weird to get an error 'out of nowhere'...
you could check 'me.destroyed' (see extjs docs) if the current panel
still is valid and only show the errors if it is.
also, if it is not, the 'unmask' in run_now_finished
wi
looks mostly ok (did not test it), but some comments inline
On 8/5/19 4:58 PM, Stefan Reiter wrote:
To allow masking to be correctly handled, we use a counter variable to
keep the mask visible until all tasks have been completed. Any errors
that occurred will be displayed in a consolidated messa
Looks ok overall, some comments/questions inline
On 7/29/19 10:59 AM, Aaron Lauterer wrote:
This adds a new config option called `spice_enhancements` and two
settings for it:
* videostreaming
* foldersharing
Signed-off-by: Aaron Lauterer
---
Feedback is appreciated, especially regarding:
*
s/Coniguration/Configuration/
Signed-off-by: Dominik Csapak
---
www/manager6/ceph/CephInstallWizard.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/ceph/CephInstallWizard.js
b/www/manager6/ceph/CephInstallWizard.js
index 3c340543..2613a1fa 100644
--- a/www
maybe change only the id in the config?
in the q35 config? This will not break live migration? Or do you mean
the id in QemuServer.pm?
i meant in the config, but i am not sure if this breaks live migration
(probably though, one would have to test it ;) )
alternatively for q35 the id in QemuSer
looks okay, one comment inline
On 7/15/19 12:28 PM, Dominic Jäger wrote:
The StdRemoveButton can now pass a delay parameter to the API.
It is set undefined as default so that users of the button
can set the parameter themselves.
Signed-off-by: Dominic Jäger
---
v3->v4: Make the delay undefined
On 7/24/19 12:03 PM, Aaron Lauterer wrote:
The latest changes to our audio device implemenation [0] changed the
naming of the device id to "audio" which in practice resulted in
"audio0".
This conflicts with the predefined audio device in the Q35 configs
that is also using "audio0". The result is
ons in one image for the various states
(normal, hover, active, focused, focused hover)
the icon is taken from the theme-crisp
form/tag-field-item-close.png but rearranged to fit the size
Signed-off-by: Dominik Csapak
---
css/Makefile | 2 +-
css/ext6-pmx.css | 3
r pmg-api/gui but we do not
use any combogrid with allowblank there so it would be a change
for no gain (atm)
proxmox-widget-toolkit:
Dominik Csapak (2):
add css and image directory to packaging
ComboGrid: add trigger to delete from ComboGrid
Makefile | 18 +---
add the dirs to the proxy and the css file to the index template
Signed-off-by: Dominik Csapak
---
PVE/Service/pveproxy.pm | 2 ++
www/index.html.tpl | 1 +
2 files changed, 3 insertions(+)
diff --git a/PVE/Service/pveproxy.pm b/PVE/Service/pveproxy.pm
index a07330c4..dd123dd8 100755
Signed-off-by: Dominik Csapak
---
Makefile| 18 +-
css/Makefile| 13 +
defines.mk | 15 +++
images/Makefile | 13 +
4 files changed, 46 insertions(+), 13 deletions(-)
create mode 100644 css/Makefile
create mode 100644
On 7/23/19 6:56 PM, Thomas Lamprecht wrote:
On 7/23/19 10:15 AM, Dominik Csapak wrote:
looks mostly good, some comments inline
On 7/22/19 5:16 PM, Thomas Lamprecht wrote:
We can often run into situations where a value set in the past is not
valid anymore. An example could be a deleted network
Signed-off-by: Dominik Csapak
---
de.po | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/de.po b/de.po
index c07824c..9bda767 100644
--- a/de.po
+++ b/de.po
@@ -5718,7 +5718,7 @@ msgstr "Sie sind angemeldet als {0}"
#: pve-manager/www/manager6/storage/ContentV
looks mostly good, some comments inline
On 7/22/19 5:16 PM, Thomas Lamprecht wrote:
We can often run into situations where a value set in the past is not
valid anymore. An example could be a deleted network bridge, e.g., we
set the vNIC of a VM to 'vmbr1' but then we decide to obsolete that
and
api call and
rename 'flags2' to 'flags'
Signed-off-by: Dominik Csapak
---
changes from v1:
* better comment for flagmap
* rename to 'flags2'
* use check_ceph_configured
PVE/API2/Ceph.pm | 56
1 file changed, 56 inser
this api call can set multiple flags at once, but does this in a
worker since this can take quiet some time
also we only set/unset flags that are not already set/unset (respectively)
Signed-off-by: Dominik Csapak
---
changes from v1:
* use check_ceph_configured
* better map call
* better flag
this simply shows a grid with the available flags of the backend,
with a checkbox indicating the status
Signed-off-by: Dominik Csapak
---
changes from v1:
* use flags2 instead of allflags
www/manager6/ceph/OSD.js | 78
1 file changed, 78 insertions
Signed-off-by: Dominik Csapak
---
PVE/API2/Ceph.pm | 2 --
1 file changed, 2 deletions(-)
diff --git a/PVE/API2/Ceph.pm b/PVE/API2/Ceph.pm
index 862da4a1..c146add6 100644
--- a/PVE/API2/Ceph.pm
+++ b/PVE/API2/Ceph.pm
@@ -990,7 +990,6 @@ __PACKAGE__->register_method ({
PVE::Ceph::To
by using the new CephSetFlags EditWindow
Signed-off-by: Dominik Csapak
---
www/manager6/ceph/OSD.js | 23 +++
1 file changed, 7 insertions(+), 16 deletions(-)
diff --git a/www/manager6/ceph/OSD.js b/www/manager6/ceph/OSD.js
index 4eca1303..c1463485 100644
--- a/www/manager6
* better map generation
Dominik Csapak (5):
ceph: add GET 'flags2'
ceph: add PUT 'flags' api call
ceph: set/unset flag: remove unused variable
gui: ceph: add a ceph flag EditWindow
gui: ceph: convert 'set noout' button to 'set flag
401 - 500 of 3174 matches
Mail list logo
