Re: [pve-devel] [PATCH pve-client 2/2] Fix old none ::APIClient uses.

Please also apply this one. On 2018-06-19 16:03, René Jochum wrote: > Signed-off-by: René Jochum > --- > PVE/APIClient/Commands/GuestStatus.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/PVE/APIClient/Commands/GuestStatus.pm > b/P

Re: [pve-devel] [PATCH pve-client 2/2] Fix old none ::APIClient uses.

Ups, just seen its applied. On 2018-06-20 08:49, René Jochum wrote: > Please also apply this one. > > > On 2018-06-19 16:03, René Jochum wrote: >> Signed-off-by: René Jochum >> --- >> PVE/APIClient/Commands/GuestStatus.pm | 4 ++-- >> 1 file changed, 2 inse

[pve-devel] [PATCH pve-client] Handle errors on tasks correctly with a die,

so we get the correct exit code on errors. Signed-off-by: René Jochum --- PVE/APIClient/Helpers.pm | 4 1 file changed, 4 insertions(+) diff --git a/PVE/APIClient/Helpers.pm b/PVE/APIClient/Helpers.pm index 7d855ec..5c2e4cb 100644 --- a/PVE/APIClient/Helpers.pm +++ b/PVE/APIClient

[pve-devel] [RFC pve-client] Add configureable defaults to "lxc create"

The given patch adds configureable defaults to lxc create, I don't like how it handles defaults that are given by pveclient and I don't know ConfigParser well enough to come up with another solution. --- PVE/APIClient/Commands/lxc.pm | 16 ++-- PVE/APIClient/Config.pm | 22 ++

[pve-devel] [RFC pve-client] Add configureable defaults to "lxc create"

On 2018-06-20 14:35, René Jochum wrote: > The given patch adds configureable defaults to lxc create, > I don't like how it handles defaults that are given by pveclient > and I don't know ConfigParser well enough to come up with another > solution. > --- > PVE/AP

Re: [pve-devel] [RFC pve-client] Add configureable defaults to "lxc create"

On 2018-06-21 06:31, Dietmar Maurer wrote: >> The given patch adds configureable defaults to lxc create, > In general, different clusters (remotes) use different node > and storage names. So it does not really make sense to use > global defaults for that. Instead, we need defaults for > each remot

[pve-devel] [PATCH pve-client v2] Add per remote configurable defaults

Signed-off-by: René Jochum --- v2 Makes defaults configureable per "remote". PVE/APIClient/Commands/config.pm | 26 ++ PVE/APIClient/Commands/lxc.pm| 16 ++-- PVE/APIClient/Config.pm | 29 +++-- 3 files c

[pve-devel] [PATCH pve-client v3] Add per remote configurable defaults

Signed-off-by: René Jochum --- v2: Added defaults per remote. v3: Simplified code by using "pveclient remote set" PVE/APIClient/Commands/lxc.pm | 16 ++-- PVE/APIClient/Config.pm | 29 +++-- 2 files changed, 37 insertions(+), 8 deletions(-)

[pve-devel] [PATCH pve-client v3] Add "storage status" and "storage list"

Signed-off-by: René Jochum --- PVE/APIClient/Commands/storage.pm | 155 ++ pveclient | 2 + 2 files changed, 157 insertions(+) create mode 100644 PVE/APIClient/Commands/storage.pm diff --git a/PVE/APIClient/Commands/storage.pm b

Re: [pve-devel] [PATCH pve-client v3] Add "storage status" and "storage list"

Sorry, its v1. On 2018-06-21 10:17, René Jochum wrote: > Signed-off-by: René Jochum > --- > PVE/APIClient/Commands/storage.pm | 155 > ++ > pveclient | 2 + > 2 files changed, 157 insertions(+) > create mode

Re: [pve-devel] [PATCH pve-client v3] Add per remote configurable defaults

Thanks for looking over it. On 2018-06-21 12:20, Dietmar Maurer wrote: > comments inline > >> On June 21, 2018 at 9:25 AM René Jochum wrote: >> >> >> Signed-off-by: René Jochum >> --- >> v2: Added defaults per remote. >> v3: Simplified code by us

[pve-devel] [PATCH pve-client] Use print_text_table in 'list' and 'remote list'

Signed-off-by: René Jochum --- PVE/APIClient/Commands/list.pm | 22 -- PVE/APIClient/Commands/remote.pm | 21 ++--- 2 files changed, 34 insertions(+), 9 deletions(-) diff --git a/PVE/APIClient/Commands/list.pm b/PVE/APIClient/Commands/list.pm index 2030c51

<    1   2