[pve-devel] [PATCH v3 access-control] add ui capabilities endpoint

Signed-off-by: Tim Marx --- * no changes PVE/API2/AccessControl.pm | 29 + 1 file changed, 29 insertions(+) diff --git a/PVE/API2/AccessControl.pm b/PVE/API2/AccessControl.pm index fd27786..66319cc 100644 --- a/PVE/API2/AccessControl.pm +++ b/PVE/API2

[pve-devel] [PATCH v3 widget-toolkit] utils: add api token RegExp

Signed-off-by: Tim Marx --- src/Utils.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/Utils.js b/src/Utils.js index 9a156dd..14da82e 100644 --- a/src/Utils.js +++ b/src/Utils.js @@ -867,5 +867,8 @@ utilities: { me.IP6_dotnotation_match = new RegExp("^" + I

[pve-devel] [PATCH v3 manager] ui: add api token authentication to login window

Signed-off-by: Tim Marx --- changes since v2: * let/var * removed checkbox * autodetect api token on change www/manager6/Workspace.js | 5 ++ www/manager6/window/LoginWindow.js | 106 + 2 files changed, 81 insertions(+), 30 deletions(-) diff --git a/www

[pve-devel] [PATCH guest-common] add asObject to config_with_pending

Signed-off-by: Tim Marx --- PVE/GuestHelpers.pm | 34 -- 1 file changed, 28 insertions(+), 6 deletions(-) diff --git a/PVE/GuestHelpers.pm b/PVE/GuestHelpers.pm index 1688c5c..176d903 100644 --- a/PVE/GuestHelpers.pm +++ b/PVE/GuestHelpers.pm @@ -205,19 +205,29

[pve-devel] [PATCH container] api: add option to get pending config returned as object instead of an array

Signed-off-by: Tim Marx --- src/PVE/API2/LXC.pm | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index 21899d0..7b91b6f 100644 --- a/src/PVE/API2/LXC.pm +++ b/src/PVE/API2/LXC.pm @@ -1914,10 +1914,17 @@ __PACKAGE__

[pve-devel] [PATCH qemu-server] api: add option to get pending config returned as object instead of an array

Signed-off-by: Tim Marx --- PVE/API2/Qemu.pm | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index fd51bf3..0b31f53 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -940,14 +940,20 @@ __PACKAGE__->register_met

[pve-devel] [PATCH manager] ui: migration: add maxHeight to migration window

to prevent indefinite growth in case of e.g. many local disks Signed-off-by: Tim Marx --- www/manager6/window/Migrate.js | 1 + 1 file changed, 1 insertion(+) diff --git a/www/manager6/window/Migrate.js b/www/manager6/window/Migrate.js index 61bc6a49..e022bee7 100644 --- a/www/manager6/window

[pve-devel] [PATCH manager] ui: clusterjoin: fix cluster network field visibility

Signed-off-by: Tim Marx --- www/manager6/dc/ClusterEdit.js | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/www/manager6/dc/ClusterEdit.js b/www/manager6/dc/ClusterEdit.js index 227812d3..b4603291 100644 --- a/www/manager6/dc/ClusterEdit.js +++ b/www/manager6/dc

[pve-devel] [PATCH v2 widget-toolkit] adapt auth utils for proxmox token authentication

Signed-off-by: Tim Marx --- Notes: changed since v1: * store user info as product independent object Utils.js | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/Utils.js b/Utils.js index 22eddd2..85b4a35 100644 --- a/Utils.js +++ b/Utils.js

[pve-devel] [PATCH v2 manager] ui: auth: add api token authentication to login window

Signed-off-by: Tim Marx --- Notes: changed since v1: * store token including the product prefix * add token id to username to make it more obvious that it's note the actual user www/manager6/Workspace.js | 5 ++ www/manager6/window/LoginWindow.js

[pve-devel] [PATCH widget-toolkit] adapt auth utils for pve token authentication

Signed-off-by: Tim Marx --- Utils.js | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/Utils.js b/Utils.js index 22eddd2..b190ce4 100644 --- a/Utils.js +++ b/Utils.js @@ -31,6 +31,10 @@ Ext.Ajax.on('beforerequest', function(con

[pve-devel] [PATCH access-control 1/2] whitespace cleanup

Signed-off-by: Tim Marx --- PVE/API2/AccessControl.pm | 48 +++ 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/PVE/API2/AccessControl.pm b/PVE/API2/AccessControl.pm index 5b63d2b..25230ac 100644 --- a/PVE/API2/AccessControl.pm +++ b/PVE/API2

[pve-devel] [PATCH access-control 2/2] add ui capabilities endpoint

Signed-off-by: Tim Marx --- PVE/API2/AccessControl.pm | 29 + 1 file changed, 29 insertions(+) diff --git a/PVE/API2/AccessControl.pm b/PVE/API2/AccessControl.pm index 25230ac..0a1b836 100644 --- a/PVE/API2/AccessControl.pm +++ b/PVE/API2/AccessControl.pm @@ -717,4

[pve-devel] [PATCH manager 2/3] ui: auth: add api token authentication to login window

Signed-off-by: Tim Marx --- www/manager6/Workspace.js | 5 ++ www/manager6/window/LoginWindow.js | 129 ++--- 2 files changed, 105 insertions(+), 29 deletions(-) diff --git a/www/manager6/Workspace.js b/www/manager6/Workspace.js index 12ad70e4..20d8c692 100644

[pve-devel] [PATCH manager 3/3] ui: auth: clear ui capabilities on logout

Signed-off-by: Tim Marx --- www/manager6/Workspace.js | 1 + 1 file changed, 1 insertion(+) diff --git a/www/manager6/Workspace.js b/www/manager6/Workspace.js index 20d8c692..ffc5b175 100644 --- a/www/manager6/Workspace.js +++ b/www/manager6/Workspace.js @@ -37,6 +37,7 @@ Ext.define

[pve-devel] [PATCH manager 1/3] ui: whitespace cleanup

Signed-off-by: Tim Marx --- www/manager6/Workspace.js | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/www/manager6/Workspace.js b/www/manager6/Workspace.js index 01b462c7..12ad70e4 100644 --- a/www/manager6/Workspace.js +++ b/www/manager6/Workspace.js

Re: [pve-devel] [PATCH manager 2/3] Allow setting targetstorage for offline migration

> Fabian Ebner hat am 4. Mai 2020 09:26 geschrieben: > > > On 5/2/20 11:40 AM, Alexandre DERUMIER wrote: > >>> The problem is that offline migration with target storage might not > >>> always work depending on supported export/import formats. Then users > >>> might start an offline migration,

Re: [pve-devel] applied-series: [PATCH pve-common/qemu-server 0/9] refactoring and storagemap

> Thomas Lamprecht hat am 7. April 2020 17:19 > geschrieben: > > > On 3/30/20 1:41 PM, Fabian Grünbichler wrote: > > another round of preparatory patches for remote migration. > > > > qemu-server's #1 is an unrelated follow-up fix, > > #2-4 are refactoring, > > #5+6 are new features/checks, >

[pve-devel] [PATCH pve-qemu] fix mutex lock for backup dump callback

Signed-off-by: Tim Marx --- ...-mutex-lock-for-backup-dump-callback.patch | 34 +++ debian/patches/series | 1 + 2 files changed, 35 insertions(+) create mode 100644 debian/patches/pve/0048-PVE-fix-mutex-lock-for-backup-dump-callback.patch diff --git

[pve-devel] [PATCH pve-qemu] fix hmp info backup command

Signed-off-by: Tim Marx --- ...-backup-cmd-for-not-initialized-back.patch | 31 +++ debian/patches/series | 1 + 2 files changed, 32 insertions(+) create mode 100644 debian/patches/pve/0047-PVE-fix-hmp-info-backup-cmd-for-not-initialized-back.patch

[pve-devel] [PATCH docs] move html table of content to sidebar

Signed-off-by: Tim Marx --- pve-admin-guide.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pve-admin-guide.adoc b/pve-admin-guide.adoc index 4389f73..9a14da2 100644 --- a/pve-admin-guide.adoc +++ b/pve-admin-guide.adoc @@ -8,7 +8,7 @@ Proxmox VE Administration Guide

[pve-devel] [PATCH v2 qemu-server 2/2] add timeout parameter to vm_start api endpoint

Signed-off-by: Tim Marx --- changes: * squashed patch 2 & 4 PVE/API2/Qemu.pm | 13 ++--- PVE/QemuServer.pm | 4 ++-- 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 5bae513..2dee3f1 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/

[pve-devel] [PATCH v2 qemu-server 1/2] add new helper to calculate timeout based on vm config

Signed-off-by: Tim Marx --- changed: * squashed patch 1 & 3 * pass config hash * adapated comment PVE/QemuServer.pm | 4 ++-- PVE/QemuServer/Helpers.pm | 22 ++ 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServe

[pve-devel] [PATCH qemu-server 3/4] make use of new helper config aware timeout

Signed-off-by: Tim Marx --- PVE/QemuServer.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index a7aff07..992cc7d 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -41,7 +41,7 @@ use PVE::Tools qw(run_command lock_file

[pve-devel] [PATCH qemu-server 1/4] add new helper to calculate timeout based on vm config

Signed-off-by: Tim Marx --- PVE/QemuServer/Helpers.pm | 21 + 1 file changed, 21 insertions(+) diff --git a/PVE/QemuServer/Helpers.pm b/PVE/QemuServer/Helpers.pm index fcc9392..86bf3d9 100644 --- a/PVE/QemuServer/Helpers.pm +++ b/PVE/QemuServer/Helpers.pm @@ -11,6 +11,7

[pve-devel] [PATCH qemu-server 2/4] add timeout parameter to vm start sub

Signed-off-by: Tim Marx --- PVE/QemuServer.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 2b68d81..a7aff07 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -5196,7 +5196,7 @@ sub vmconfig_update_disk { sub

[pve-devel] [PATCH qemu-server 4/4] add timeout parameter to vm_start api endpoint

Signed-off-by: Tim Marx --- PVE/API2/Qemu.pm | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 5bae513..2dee3f1 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -1993,7 +1993,13 @@ __PACKAGE__->register_met

Re: [pve-devel] [PATCH] correct link to vma spec to new repository url

repo: pve-qemu for reference... > Tim Marx hat am 13. Januar 2020 12:59 geschrieben: > > > Signed-off-by: Tim Marx > --- > backup.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/backup.txt b/backup.txt > index 0605250..97e10fc 100

[pve-devel] [PATCH] correct link to vma spec to new repository url

Signed-off-by: Tim Marx --- backup.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/backup.txt b/backup.txt index 0605250..97e10fc 100644 --- a/backup.txt +++ b/backup.txt @@ -108,7 +108,7 @@ files. We have defined a very simply format with those properties, see

[pve-devel] [PATCH v2 docs 1/2] apiviewer: add api endpoint deeplink ability

use #/ to deeplink to a specific endpoint Signed-off-by: Tim Marx --- changes v2: * update hash part on treenode selection * deepLink should work on subsequent url changes api-viewer/PVEAPI.js | 15 +++ 1 file changed, 15 insertions(+) diff --git a/api-viewer/PVEAPI.js b/api

[pve-devel] [PATCH v2 docs 2/2] apiviewer: add search and collapse/expand tools

Signed-off-by: Tim Marx --- api-viewer/PVEAPI.js | 75 +--- 1 file changed, 71 insertions(+), 4 deletions(-) diff --git a/api-viewer/PVEAPI.js b/api-viewer/PVEAPI.js index dd36fff..9a14156 100644 --- a/api-viewer/PVEAPI.js +++ b/api-viewer/PVEAPI.js

[pve-devel] [PATCH docs 3/3] apiviewer: add api endpoint deeplink ability

use #/ to deeplink to a specific endpoint Signed-off-by: Tim Marx --- api-viewer/PVEAPI.js | 10 ++ 1 file changed, 10 insertions(+) diff --git a/api-viewer/PVEAPI.js b/api-viewer/PVEAPI.js index dadc45b..bc03d88 100644 --- a/api-viewer/PVEAPI.js +++ b/api-viewer/PVEAPI.js @@ -389,4

[pve-devel] [PATCH docs 1/3] whitespace cleanup

Signed-off-by: Tim Marx --- api-viewer/PVEAPI.js | 46 ++-- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/api-viewer/PVEAPI.js b/api-viewer/PVEAPI.js index b7c0916..550f548 100644 --- a/api-viewer/PVEAPI.js +++ b/api-viewer/PVEAPI.js

[pve-devel] [PATCH docs 2/3] apiviewer: format return values as grid with optionial toggle raw

Signed-off-by: Tim Marx --- api-viewer/PVEAPI.js | 112 ++- 1 file changed, 100 insertions(+), 12 deletions(-) diff --git a/api-viewer/PVEAPI.js b/api-viewer/PVEAPI.js index 550f548..dadc45b 100644 --- a/api-viewer/PVEAPI.js +++ b/api-viewer/PVEAPI.js

[pve-devel] [PATCH storage 2/3] api: update cluster status return properties

Signed-off-by: Tim Marx --- PVE/API2/Cluster.pm | 50 - 1 file changed, 49 insertions(+), 1 deletion(-) diff --git a/PVE/API2/Cluster.pm b/PVE/API2/Cluster.pm index 4245b88c..0020d2ea 100644 --- a/PVE/API2/Cluster.pm +++ b/PVE/API2/Cluster.pm

[pve-devel] [PATCH storage 1/3] whitespace cleanup

Signed-off-by: Tim Marx --- PVE/API2/Cluster.pm | 58 ++--- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/PVE/API2/Cluster.pm b/PVE/API2/Cluster.pm index 3b62953f..4245b88c 100644 --- a/PVE/API2/Cluster.pm +++ b/PVE/API2/Cluster.pm

[pve-devel] [PATCH storage 3/3] api: prevent null as return value for property type string

Signed-off-by: Tim Marx --- PVE/API2/Cluster.pm | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Cluster.pm b/PVE/API2/Cluster.pm index 0020d2ea..ed422daa 100644 --- a/PVE/API2/Cluster.pm +++ b/PVE/API2/Cluster.pm @@ -636,13 +636,16 @@ __PACKAGE__

[pve-devel] [PATCH storage] calculate reasonable metadatasize for lvm thin pools on creation

Signed-off-by: Tim Marx --- PVE/API2/Disks/LVMThin.pm | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Disks/LVMThin.pm b/PVE/API2/Disks/LVMThin.pm index 23c0279..4d303f8 100644 --- a/PVE/API2/Disks/LVMThin.pm +++ b/PVE/API2/Disks/LVMThin.pm

[pve-devel] [PATCH manager 2/3] api: add migrate precondition checks to bulk migrate api

Signed-off-by: Tim Marx --- PVE/API2/Nodes.pm | 19 +++ 1 file changed, 19 insertions(+) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index 6224cb71..a1f62f36 100644 --- a/PVE/API2/Nodes.pm +++ b/PVE/API2/Nodes.pm @@ -1928,6 +1928,25 @@ my $create_migrate_worker = sub

[pve-devel] [PATCH manager 3/3] ui: add checkbox to bulk migrate window to allow migration with local disks

Signed-off-by: Tim Marx --- www/manager6/window/BulkAction.js | 21 + 1 file changed, 21 insertions(+) diff --git a/www/manager6/window/BulkAction.js b/www/manager6/window/BulkAction.js index ba27eef1..0429d96d 100644 --- a/www/manager6/window/BulkAction.js +++ b/www

[pve-devel] [PATCH manager 1/3] api: add migrate with local disks to bulk migrate api

Signed-off-by: Tim Marx --- PVE/API2/Nodes.pm | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index c3f64699..6224cb71 100644 --- a/PVE/API2/Nodes.pm +++ b/PVE/API2/Nodes.pm @@ -1918,7 +1918,7 @@ __PACKAGE__->register_met

[pve-devel] [PATCH v3 storage 2/3] add content type to pvesm list output

Signed-off-by: Tim Marx --- PVE/CLI/pvesm.pm | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/PVE/CLI/pvesm.pm b/PVE/CLI/pvesm.pm index 01ddd23..63b212a 100755 --- a/PVE/CLI/pvesm.pm +++ b/PVE/CLI/pvesm.pm @@ -124,21 +124,23 @@ my $print_content = sub { my

[pve-devel] [PATCH v3 storage 3/3] change var name ct to type to prevent confusion with container

Signed-off-by: Tim Marx --- PVE/Storage/Plugin.pm | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/PVE/Storage/Plugin.pm b/PVE/Storage/Plugin.pm index 2573cb7..189356a 100644 --- a/PVE/Storage/Plugin.pm +++ b/PVE/Storage/Plugin.pm @@ -938,21 +938,21

[pve-devel] [PATCH v3 storage 1/3] fix #2467 remove duplicate volumes & tag with correct content type

ted guest, if there's no guest or we don't have an owner for that volume we default to 'images'. At the volume level, there is no option to list volumes based on content types, since the volumes do not know what type they are actually used for. Signed-off-by: Tim Marx --- chang

[pve-devel] [PATCH v2 storage 1/3] fix #2467 remove duplicate volumes & tag with correct content type

guest (qemu/lxc) and we now ignore 'rootdir' if both types are enabled. At the volume level, there is no option to list volumes based on content types, since the volumes do not know what type they are actually used for. Signed-off-by: Tim Marx --- changed in v2: * duplicate filtering i

[pve-devel] [PATCH v2 storage 3/3] change var name ct to type to prevent confusion with container

Signed-off-by: Tim Marx --- PVE/Storage/Plugin.pm | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/PVE/Storage/Plugin.pm b/PVE/Storage/Plugin.pm index 2bf6f0a..c2612c1 100644 --- a/PVE/Storage/Plugin.pm +++ b/PVE/Storage/Plugin.pm @@ -938,21 +938,21

[pve-devel] [PATCH v2 storage 2/3] add content type to pvesm list output

Signed-off-by: Tim Marx --- PVE/CLI/pvesm.pm | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/PVE/CLI/pvesm.pm b/PVE/CLI/pvesm.pm index 01ddd23..63b212a 100755 --- a/PVE/CLI/pvesm.pm +++ b/PVE/CLI/pvesm.pm @@ -124,21 +124,23 @@ my $print_content = sub { my

[pve-devel] [PATCH storage] fix #2467 remove duplicate volumes & tag with correct content type

guest (qemu/lxc) and we now ignore 'rootdir' if both types are enabled. At the volume level, there is no option to list volumes based on content types, since the volumes do not know what type they are actually used for. Signed-off-by: Tim Marx --- PVE/Storage.pm| 5

[pve-devel] [PATCH storage 2/2] convert vmid to int to conform with return type declaration

Signed-off-by: Tim Marx --- PVE/API2/Storage/Content.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/API2/Storage/Content.pm b/PVE/API2/Storage/Content.pm index 76c3b67..9f6ea10 100644 --- a/PVE/API2/Storage/Content.pm +++ b/PVE/API2/Storage/Content.pm @@ -101,6 +101,7 @@ __PACKAGE__

[pve-devel] [PATCH storage 1/2] whitespace cleanup

Signed-off-by: Tim Marx --- PVE/API2/Storage/Content.pm | 56 ++--- 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/PVE/API2/Storage/Content.pm b/PVE/API2/Storage/Content.pm index 9731720..76c3b67 100644 --- a/PVE/API2/Storage/Content.pm +++ b/PVE

[pve-devel] [PATCH widget-toolkit] fix comboBox validation when forceSelection is true

Prevent the comboBox from displaying a validation error although forceSelection is true. If you change a valid selection by removing characters manually and click somewhere else, the comboBox restores the selection with the previous value. The validation logic then checked the restored value, but c

[pve-devel] [PATCH v2 manager] gui: reset cdimage selector on change

to improve UX, disabled child fields shouldn't show validation errors when the parent widget (radiofield) isn't selected anymore. Signed-off-by: Tim Marx --- changes v2: * swapped ternary for if/else * make use of new cdImageField var * adapted commit message www/manager6/qemu/CDE

[pve-devel] [PATCH manager] gui: reset cdimage selector on change

to improve UX, disabled fields shouldn't show validation errors. Signed-off-by: Tim Marx --- www/manager6/qemu/CDEdit.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/www/manager6/qemu/CDEdit.js b/www/manager6/qemu/CDEdit.js index 78d758c7..a1636aa9 100644 ---

Re: [pve-devel] [RFC 12/23] API: add API token API endpoints

Do we really want a enable/disable property? Wouldn't it be enough to delete the token? > Fabian Grünbichler hat am 17. Oktober 2019 15:14 > geschrieben: > > > and integration for user API endpoints. > > Signed-off-by: Fabian Grünbichler > --- > > Notes: > pveum integration will come i

Re: [pve-devel] [RFC 1/23] API schema: add 'notoken' property

Joining a little late into this, but I would vote for an option where we inform the client that this endpoint needs some sort of re-authentication to be accessible, similar to what Thomas already proposed. I discussed this a little bit with Thomas (off-list), but for me the only remaining differ

Re: [pve-devel] [PATCH v2 manager] fix #2364: allow offline migration with local cloudinit disk

looks ok for me too. > Thomas Lamprecht hat am 17. Oktober 2019 19:32 > geschrieben: > > > On 10/7/19 12:07 PM, Mira Limbeck wrote: > > As the cloudinit disk itself does not get copied on an offline > > migration, just the config, there's no conflict. Ignore the local > > cloudinit disk on o

[pve-devel] [PATCH v2 manager] ui: migrate: add checkbox to enable offline migration with local resources

Added to make use of [0] and because it does make sense for non HA vm's as well, in accordance with #2241. [0] pve-ha-manager: 6e8b0c225405da9472f56fe5c94c94b204259caa Signed-off-by: Tim Marx --- changes v2: * changed naming overwriteLocalResourceCheck, resetMigrationPossible, Force *

[pve-devel] [PATCH manager] ui: migrate: add checkbox to enable offline migration with local resources

Added to make use of [0] and because it does make sense for non HA vm's as well, in accordance with #2241. [0] pve-ha-manager: 6e8b0c225405da9472f56fe5c94c94b204259caa Signed-off-by: Tim Marx --- www/manager6/window/Migrate.js | 63 +++--- 1 file change

[pve-devel] [PATCH storage] change file_size_info sub to use qemu-img info json decoding

Using the json output, as suggested by Thomas, we now die if the decoding fails and, if not, all return values are set to the corresponding decoded values. That should prevent any unforeseen null size values, except if qemu-img info reports it, which we then consider as valid. Signed-off-by: Tim

[pve-devel] [PATCH v3 qemu-server] add check to resize disk if current size could not be determined

This check ensures that disks aren't unintentionally shrunken, if the size is zero due to an underlying problem. --- PVE/API2/Qemu.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 3355c8b..e09a0f7 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.p

[pve-devel] [PATCH v3 container 1/2] whitespace cleanup

--- src/PVE/API2/LXC.pm | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index 9ddaf58..faec445 100644 --- a/src/PVE/API2/LXC.pm +++ b/src/PVE/API2/LXC.pm @@ -212,7 +212,7 @@ __PACKAGE__->register_method({ if ($restore

[pve-devel] [PATCH v3 container 2/2] add check to resize disk if current size could not be determined

This check ensures that disks aren't unintentionally shrunken, if the size is zero due to an underlying problem. --- src/PVE/API2/LXC.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index faec445..fbc4659 100644 --- a/src/PVE/API2/LXC.pm +++ b/sr

[pve-devel] [PATCH storage] set filesize to undef on error during qemu-img info

Signed-off-by: Tim Marx --- PVE/Storage/Plugin.pm | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/PVE/Storage/Plugin.pm b/PVE/Storage/Plugin.pm index 39622f3..08cb260 100644 --- a/PVE/Storage/Plugin.pm +++ b/PVE/Storage/Plugin.pm @@ -738,9 +738,18 @@ sub

Re: [pve-devel] applied-series: [PATCH storage 2/2] warn if filesize info couldn't be read due to error

> Thomas Lamprecht hat am 9. September 2019 15:41 > geschrieben: > > > On 09.09.19 12:56, Tim Marx wrote: > > This sh > > abrupt CI message ending? > haha weird, sorry for that. > > Signed-off-by: Tim Marx > > --- > > PVE/Storage/Pl

Re: [pve-devel] [PATCH v2 qemu-server] add check to resize disk if current size could not be determined

ht hat am 9. September 2019 15:52 > geschrieben: > > > On 09.09.19 12:39, Tim Marx wrote: > > This check ensures that disks aren't unintentionally shrunken, if the > > size is zero due to an underlying problem. > > --- > > * fix indentation >

[pve-devel] [PATCH storage 1/2] whitespace cleanup

Signed-off-by: Tim Marx --- PVE/Storage/Plugin.pm | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/PVE/Storage/Plugin.pm b/PVE/Storage/Plugin.pm index 9a419f1..ed71fe4 100644 --- a/PVE/Storage/Plugin.pm +++ b/PVE/Storage/Plugin.pm @@ -651,7 +651,7 @@ sub

[pve-devel] [PATCH storage 2/2] warn if filesize info couldn't be read due to error

This sh Signed-off-by: Tim Marx --- PVE/Storage/Plugin.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/PVE/Storage/Plugin.pm b/PVE/Storage/Plugin.pm index ed71fe4..6b79e7a 100644 --- a/PVE/Storage/Plugin.pm +++ b/PVE/Storage/Plugin.pm @@ -742,6 +742,8 @@ sub file_size_info

[pve-devel] [PATCH v2 qemu-server] add check to resize disk if current size could not be determined

This check ensures that disks aren't unintentionally shrunken, if the size is zero due to an underlying problem. --- * fix indentation PVE/API2/Qemu.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 245de80..e6f3cce 100644 --- a/PVE/API2/Qemu.pm ++

[pve-devel] [PATCH v2 container 1/2] whitespace cleanup

--- src/PVE/API2/LXC.pm | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index 6ddff9c..faec445 100644 --- a/src/PVE/API2/LXC.pm +++ b/src/PVE/API2/LXC.pm @@ -35,7 +35,7 @@ BEGIN { __PACKAGE__->register_method ({ sub

[pve-devel] [PATCH v2 container 2/2] add check to resize disk if current size could not be determined

This check ensures that disks aren't unintentionally shrunken, if the size is zero due to an underlying problem. --- * fix indentation src/PVE/API2/LXC.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index faec445..8006f4d 100644 --- a/src/PVE/AP

[pve-devel] [PATCH container 1/2] whitespace cleanup

--- src/PVE/API2/LXC.pm | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index 6ddff9c..faec445 100644 --- a/src/PVE/API2/LXC.pm +++ b/src/PVE/API2/LXC.pm @@ -35,7 +35,7 @@ BEGIN { __PACKAGE__->register_method ({ sub

[pve-devel] [PATCH container 2/2] add check to resize disk if current size could not be determined

This check ensures that disks aren't unintentionally shrunken, if the size is zero due to an underlying problem. --- src/PVE/API2/LXC.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index faec445..f08b6a5 100644 --- a/src/PVE/API2/LXC.pm +++ b/sr

[pve-devel] [PATCH qemu-server] add check to resize disk if current size could not be determined

This check ensures that disks aren't unintentionally shrunken, if the size is zero due to an underlying problem. --- PVE/API2/Qemu.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 245de80..a0692da 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.p

Re: [pve-devel] [RFC PATCH http-server 1/1] allow ticket in auth header as fallback

me feedback as it is RFC, therefore I wrote all thoughts into the cover letter, but will move the discussion result to the commit message. I thought it would be convenient to have all things summed up in the cover letter for now. > On 8/30/19 2:12 PM, Tim Marx wrote: > > Signed-off-by: Tim

[pve-devel] [RFC PATCH http-server 0/1] allow ticket in auth header as fallback

"extract_ticket_from_auth_header" is almost identical to the old one. The only difference for now is a space instead of "=" between the type and the actual token, because this is the common way when using the Authorization header AFAIK. Tim Marx (1): allow ticket in aut

[pve-devel] [RFC PATCH http-server 1/1] allow ticket in auth header as fallback

Signed-off-by: Tim Marx --- PVE/APIServer/AnyEvent.pm | 5 + PVE/APIServer/Formatter.pm | 12 2 files changed, 17 insertions(+) diff --git a/PVE/APIServer/AnyEvent.pm b/PVE/APIServer/AnyEvent.pm index 2e8ca47..c8f7b6d 100644 --- a/PVE/APIServer/AnyEvent.pm +++ b/PVE/APIServer

[pve-devel] [RFC PATCH manager] api: allow ticket in auth header as fallback

Signed-off-by: Tim Marx --- PVE/Service/pveproxy.pm | 7 +++ 1 file changed, 7 insertions(+) diff --git a/PVE/Service/pveproxy.pm b/PVE/Service/pveproxy.pm index dd123dd8..860a05c0 100755 --- a/PVE/Service/pveproxy.pm +++ b/PVE/Service/pveproxy.pm @@ -184,6 +184,13 @@ sub get_index

[pve-devel] [PATCH manager] api: fix nodes stats memory return type description

Signed-off-by: Tim Marx --- PVE/API2/Nodes.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index 9921c9e1..bb232708 100644 --- a/PVE/API2/Nodes.pm +++ b/PVE/API2/Nodes.pm @@ -2125,7 +2125,7 @@ __PACKAGE__->register_met

Re: [pve-devel] [PATCH manager] Delete "exclude" when switching a backup job to pool

Thanks for spotting this one. IMHO this would be better fixed in the API, unless we really want to allow pool backups which exclude vms: diff --git a/PVE/API2/Backup.pm b/PVE/API2/Backup.pm index bf9a3330..6c2e16c3 100644 --- a/PVE/API2/Backup.pm +++ b/PVE/API2/Backup.pm @@ -476,6 +476,7 @@ __PACK

Re: [pve-devel] [PATCH manager 2/2] fix #1594: add "Run now" button to cluster backup page

In general it looks good and does work, some stuff inline. > Stefan Reiter hat am 31. Juli 2019 13:23 geschrieben: > > > Includes a "confirm" dialog to not accidentally run a potentially large backup > job. > > Signed-off-by: Stefan Reiter > --- > www/manager6/dc/Backup.js | 67

Re: [pve-devel] [PATCH manager 3/5] Add renderer for audio devices

> > > Signed-off-by: Aaron Lauterer > --- > www/manager6/Utils.js | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js > index 946b8709..3980b750 100644 > --- a/www/manager6/Utils.js > +++ b/www/manager6/Utils.js > @@ -467,6

Re: [pve-devel] [PATCH manager] gui: node disks: show if an osd is encrypted

I would prefer a new column, because I don't like these string extensions which probably aren't visible anyway if the column is to small. Regarding the code, maybe you could use template-strings e.g. `Ceph osd.${data.osdid} ${tagtext}`? > > > Signed-off-by: Dominik Csapak > --- > we could a

[pve-devel] [PATCH manager] gui: ceph installer: fix typo

Signed-off-by: Tim Marx --- www/manager6/ceph/CephInstallWizard.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/ceph/CephInstallWizard.js b/www/manager6/ceph/CephInstallWizard.js index 776b2277..3c340543 100644 --- a/www/manager6/ceph/CephInstallWizard.js

[pve-devel] [PATCH manager] api: ceph: automatically create manager after the first monitor

Signed-off-by: Tim Marx --- PVE/API2/Ceph/MON.pm | 9 + 1 file changed, 9 insertions(+) diff --git a/PVE/API2/Ceph/MON.pm b/PVE/API2/Ceph/MON.pm index e8963264..4090612d 100644 --- a/PVE/API2/Ceph/MON.pm +++ b/PVE/API2/Ceph/MON.pm @@ -16,6 +16,7 @@ use PVE::RESTHandler; use PVE

[pve-devel] [PATCH v2 qemu-server 2/2] migrate: add size to volume attributes

Signed-off-by: Tim Marx --- PVE/QemuServer.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 1f3234f..35e2633 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -3334,7 +3334,7 @@ sub foreach_volid { my $volhash

[pve-devel] [PATCH manager] ui: migrate: add storage and size information to preconditions

this patch depends on qemu commits: 6509ae59455c32476c683818fbf2492c60d8395e 72689d628812d75a2af44200b199b5a523760c2a Signed-off-by: Tim Marx --- www/manager6/window/Migrate.js | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/www/manager6/window/Migrate.js b/www

[pve-devel] [PATCH v2 qemu-server 1/2] migrate: handle storage not selected manually in storage config

sure that the datacenter storage config reflects the actual setup, so there is no additional check for local storages which aren't available on all nodes if they are not explicitly marked at datacenter level. Signed-off-by: Tim Marx --- PVE/API2/Qemu.pm | 22 +- PVE/Qem

[pve-devel] [PATCH qemu-server] migrate: handle local storage not selected manually in storage config

sure that the datacenter storage config reflects the actual setup, so there is no additional check for local storages which aren't available on all nodes if they are not explicitly marked at datacenter level. Signed-off-by: Tim Marx --- PVE/API2/Qemu.pm | 6 +++--- PVE/QemuServ

[pve-devel] [PATCH manager 2/3] fix #1278 api: add pool backup option

Signed-off-by: Tim Marx --- PVE/API2/Backup.pm | 7 ++- PVE/API2/VZDump.pm | 9 +++-- PVE/API2Tools.pm | 23 +++ PVE/VZDump.pm | 12 ++-- 4 files changed, 46 insertions(+), 5 deletions(-) diff --git a/PVE/API2/Backup.pm b/PVE/API2/Backup.pm index

[pve-devel] [PATCH manager 1/3] whitespace cleanup

Signed-off-by: Tim Marx --- PVE/API2/Backup.pm| 32 ++-- PVE/API2/VZDump.pm| 8 +++ PVE/API2Tools.pm | 22 +-- PVE/VZDump.pm | 54 +++ www/manager6/dc/Backup.js | 32

[pve-devel] [PATCH manager 3/3] fix #1278 gui: backup: add backup mode pool

Signed-off-by: Tim Marx --- www/manager6/dc/Backup.js | 77 +++ 1 file changed, 71 insertions(+), 6 deletions(-) diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js index c056a647..34052746 100644 --- a/www/manager6/dc/Backup.js +++ b

[pve-devel] [PATCH v2 qemu-server] add migration precondition api endpoint

Signed-off-by: Tim Marx --- changes since v1: * removed storage scan * sqashed commits * changed hash access * changed array creation PVE/API2/Qemu.pm | 121 +++ 1 file changed, 121 insertions(+) diff --git a/PVE/API2/Qemu.pm b/PVE/API2

[pve-devel] [PATCH v2 manager] ui: migrate: refactor migrate window & add migration with local disks

: Tim Marx --- changes since v1: * added error message why seleceted node is not allowed * layout change 2 columns www/manager6/window/Migrate.js | 418 ++--- 1 file changed, 309 insertions(+), 109 deletions(-) diff --git a/www/manager6/window/Migrate.js b/www

[pve-devel] [PATCH v4 widget-toolkit] add network selector widget

Signed-off-by: Tim Marx --- changes in v4: * fixed load event function signature * handle case ipv6 only Makefile| 1 + form/NetworkSelector.js | 131 2 files changed, 132 insertions(+) create mode 100644 form

[pve-devel] [PATCH v3 manager] ui: cephwizard: add networkselector widget

Signed-off-by: Tim Marx --- www/manager6/ceph/CephInstallWizard.js | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/www/manager6/ceph/CephInstallWizard.js b/www/manager6/ceph/CephInstallWizard.js index 65d71006..bb7868f2 100644 --- a/www/manager6/ceph

Re: [pve-devel] [PATCH v3 widget-toolkit] add network selector widget

> Dominik Csapak hat am 11. Juni 2019 um 16:58 > geschrieben: > > > high level looks ok, some comments inline > > On 6/11/19 2:04 PM, Tim Marx wrote: > > Signed-off-by: Tim Marx > > --- > > Makefile|

[pve-devel] [PATCH manager] gui: cephinstaller: fix create mon url

Signed-off-by: Tim Marx --- www/manager6/ceph/CephInstallWizard.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/ceph/CephInstallWizard.js b/www/manager6/ceph/CephInstallWizard.js index 65d71006..5013066c 100644 --- a/www/manager6/ceph/CephInstallWizard.js

[pve-devel] [PATCH manager] gui: ceph: fix double slash

Signed-off-by: Tim Marx --- www/manager6/ceph/Status.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/ceph/Status.js b/www/manager6/ceph/Status.js index 9364de14..48967279 100644 --- a/www/manager6/ceph/Status.js +++ b/www/manager6/ceph/Status.js @@ -306,7

[pve-devel] [PATCH v3 widget-toolkit] add network selector widget

Signed-off-by: Tim Marx --- Makefile| 1 + form/NetworkSelector.js | 121 2 files changed, 122 insertions(+) create mode 100644 form/NetworkSelector.js diff --git a/Makefile b/Makefile index b9dc8b9..d12a4da 100644 --- a

[pve-devel] [PATCH v3 manager] ui: cephwizard: add networkselector widget

Signed-off-by: Tim Marx --- www/manager6/ceph/CephInstallWizard.js | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/www/manager6/ceph/CephInstallWizard.js b/www/manager6/ceph/CephInstallWizard.js index 65d71006..bb7868f2 100644 --- a/www/manager6/ceph

  1   2   3   >