Re: [pve-devel] [PATCH] implement cpuunit with cgroups

2015-06-02 Thread Alexandre DERUMIER
; À: "aderumier" Cc: "pve-devel" Envoyé: Mardi 2 Juin 2015 16:06:24 Objet: Re: [pve-devel] [PATCH] implement cpuunit with cgroups On 06/02/2015 09:25 AM, Alexandre DERUMIER wrote: >>> So how do you specify 50% (Note: cpulimit is an integer value)? > We can

Re: [pve-devel] [PATCH] implement cpuunit with cgroups

2015-06-02 Thread Dietmar Maurer
On 06/02/2015 09:25 AM, Alexandre DERUMIER wrote: So how do you specify 50% (Note: cpulimit is an integer value)? We can't. Is the cpuunit value in vmid.conf in percent ? I never used it. I finally changed the type from integer to number, so we can now use -cpulimit 0.5 to get 50% and

Re: [pve-devel] [PATCH] implement cpuunit with cgroups

2015-06-02 Thread Dietmar Maurer
> I'm seeing in qemuserver: > cpulimit => { > optional => 1, > type => 'integer', > description => "Limit of CPU usage in per cent. Note if the computer > has 2 CPUs, it has total of 200% CPU time. Value '0' indicates no CPU > limit.\n\n.", > > > but in lxc > > cp

Re: [pve-devel] [PATCH] implement cpuunit with cgroups

2015-06-02 Thread Alexandre DERUMIER
f CPU usage. Note if the computer has 2 CPUs, it has total of '2' CPU time. Value '0' indicates no CPU limit.", minimum => 0, That's why I'm confused. ----- Mail original - De: "dietmar" À: "aderumier" Cc: "pve-devel

Re: [pve-devel] [PATCH] implement cpuunit with cgroups

2015-06-01 Thread Dietmar Maurer
> On June 2, 2015 at 8:27 AM Alexandre DERUMIER wrote: > > > >>why *100 (description states value is already in %)? > > I think that is cpuunit=1 for 1core ? (same than lxc) , so we need *100 to > get it in %. So how do you specify 50% (Note: cpulimit is an integer value)?

Re: [pve-devel] [PATCH] implement cpuunit with cgroups

2015-06-01 Thread Alexandre DERUMIER
>>why *100 (description states value is already in %)? I think that is cpuunit=1 for 1core ? (same than lxc) , so we need *100 to get it in %. - Mail original - De: "dietmar" À: "aderumier" , "pve-devel" Envoyé: Mardi 2 Juin 2015 08:18:17 Obje

Re: [pve-devel] [PATCH] implement cpuunit with cgroups

2015-06-01 Thread Dietmar Maurer
> - description => "Limit of CPU usage in per cent. Note if the computer > has 2 > CPUs, it has total of 200% CPU time. Value '0' indicates no CPU > limit.\n\nNOTE: This option is currently ignored.", > + description => "Limit of CPU usage in per cent. Note if the computer > has 2 > CPUs,

[pve-devel] [PATCH] implement cpuunit with cgroups

2015-06-01 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index f3cd41e..df30907 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -123,7 +123,7 @@ my $confdesc = { cpu