Re: [pve-devel] [PATCH 1/7] split qemu_drive_mirror_monitor from qemu_drive_mirror.

2016-10-20 Thread Alexandre DERUMIER
>>Doesn't make sense given the patch snippet: Ok, sorry, I think I have read an old git code in my sources. I'll fix that - Mail original - De: "Wolfgang Bumiller" À: "Alexandre Derumier" Cc: "pve-devel" Envoyé: Jeudi 20 Octobre 2016 12:

Re: [pve-devel] [PATCH 1/7] split qemu_drive_mirror_monitor from qemu_drive_mirror.

2016-10-20 Thread Wolfgang Bumiller
On Thu, Oct 20, 2016 at 10:57:22AM +0200, Alexandre DERUMIER wrote: > >> + vm_mon_cmd($vmid, "drive-mirror", %$opts); > > >>This is now outside an eval block which otherwise had a cancel_job() > >>error case. (Note that it looks like the error cases of vm_mon_cmd() > >>*should* not need a cance

Re: [pve-devel] [PATCH 1/7] split qemu_drive_mirror_monitor from qemu_drive_mirror.

2016-10-20 Thread Alexandre DERUMIER
#x27;t work, but I think we can have race sometime, if io occur exactly at the same time) ----- Mail original - De: "Wolfgang Bumiller" À: "aderumier" Cc: "pve-devel" Envoyé: Jeudi 20 Octobre 2016 09:43:44 Objet: Re: [pve-devel] [PATCH 1/7] split qemu_drive_mi

Re: [pve-devel] [PATCH 1/7] split qemu_drive_mirror_monitor from qemu_drive_mirror.

2016-10-20 Thread Wolfgang Bumiller
On Thu, Oct 20, 2016 at 02:35:10AM +0200, Alexandre Derumier wrote: > we can use multiple drive_mirror in parralel > > Signed-off-by: Alexandre Derumier > --- > PVE/QemuServer.pm | 98 > +-- > 1 file changed, 59 insertions(+), 39 deletions(-)

[pve-devel] [PATCH 1/7] split qemu_drive_mirror_monitor from qemu_drive_mirror.

2016-10-19 Thread Alexandre Derumier
we can use multiple drive_mirror in parralel Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 98 +-- 1 file changed, 59 insertions(+), 39 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 728110f..a5aa4c7 100644 -