Re: [pve-devel] [PATCH 2/7] use qemu_drive_mirror_monitor in live full clone

2016-10-20 Thread Alexandre DERUMIER
at the _monitor() function is a no-op if no job is >>running, it just feels like a weird API.) No objection, I'll adapt my patches. I'll try to update them for tomorrow. Thanks for the review ! - Mail original - De: "Wolfgang Bumiller" À: &q

Re: [pve-devel] [PATCH 2/7] use qemu_drive_mirror_monitor in live full clone

2016-10-20 Thread Wolfgang Bumiller
> On October 20, 2016 at 11:03 AM Alexandre DERUMIER > wrote: > > > >>I wonder if we should give the clone_disk() - which is called above in a > >>loop - a parameter telling it to do this. Not only would save us a > >>query-block-job call in the cases where we qemu_drive_mirror() isn't > >>cal

Re: [pve-devel] [PATCH 2/7] use qemu_drive_mirror_monitor in live full clone

2016-10-20 Thread Alexandre DERUMIER
I don't have checked network bandwith when multiple job are running in parallel. Not sure if we should add an option to define number of parallel job ? - Mail original - De: "Wolfgang Bumiller" À: "aderumier" Cc: "pve-devel" Envoyé: Jeudi 20 Octobre

Re: [pve-devel] [PATCH 2/7] use qemu_drive_mirror_monitor in live full clone

2016-10-20 Thread Wolfgang Bumiller
On Thu, Oct 20, 2016 at 02:35:11AM +0200, Alexandre Derumier wrote: > Signed-off-by: Alexandre Derumier > --- > PVE/API2/Qemu.pm | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm > index ad7a0c0..98865f6 100644 > --- a/PVE/API2/Qemu.pm > +++ b/PVE/API2/

[pve-devel] [PATCH 2/7] use qemu_drive_mirror_monitor in live full clone

2016-10-19 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/API2/Qemu.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index ad7a0c0..98865f6 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -2415,6 +2415,7 @@ __PACKAGE__->register_method({ P