> > Maybe you already found a better way to implement rollback within
> > drbdmanage?
> Not atomically, no.
>
> We've got an even more interesting problem - we should do atomic changes
> across the whole cluster...
Yes, I see ;-)
> We'll probably have to do the indirection trick - storing the P
Hi Dietmar,
> I just started to implement a PVE storage driver for lvmthin:
>
> https://git.proxmox.com/?p=pve-storage.git;a=blob;f=PVE/Storage/LvmThinPlugin.pm
>
> So far I just use:
>
> sub volume_snapshot_rollback {
> my ($class, $scfg, $storeid, $volname, $snap) = @_;
>
> my $vg =
Hi Philipp,
I just started to implement a PVE storage driver for lvmthin:
https://git.proxmox.com/?p=pve-storage.git;a=blob;f=PVE/Storage/LvmThinPlugin.pm
So far I just use:
sub volume_snapshot_rollback {
my ($class, $scfg, $storeid, $volname, $snap) = @_;
my $vg = $scfg->{vgname};
> So, which direction should we go?
I also think that drbdmanage should be able to do all snapshot
related functions internally, so that one can handle all aspects
of snapshots using drbdmanage. So there should be something like
# drbdmanage snapshot-rollback ...
on the command line.
__
> c) ProxMox allows us to fetch a newly generated volume name that we can
>take for the new resource, and that we can return for it to be used
>from now on
Not sure if I understand you correctly, but we store volume names inside
various configuration files. They are used to identity the vo
> > * There's no implementation for volume_snapshot_rollback() yet.
> >Is there a way to change the volume name on rollback?
> >The problem is that DRBDmanage (as of now) won't allow to _replace_
> >the current contents with the ones from the snapshot --
> >but perhaps we want to i
> First, code looks reasonable to me, but I am unable to test
> without a working rollback. Some comments inline:
> > -die "Snapshot not implemented on DRBD\n" if $snapname;
> > +return activate_volume_from_snapshot(@_) if $snapname;
>
> I would prefer to list all parameters by name (inste
First, code looks reasonable to me, but I am unable to test
without a working rollback. Some comments inline:
> On October 8, 2015 at 10:24 AM Philipp Marek wrote:
>
>
> ---
> PVE/Storage/DRBDPlugin.pm | 88
> ---
> 1 file changed, 84 insertions(+),
> * There's no implementation for volume_snapshot_rollback() yet.
>Is there a way to change the volume name on rollback?
>The problem is that DRBDmanage (as of now) won't allow to _replace_
>the current contents with the ones from the snapshot --
>but perhaps we want to implement t
Sorry, I used "git email-send" badly -- I wanted to write preface email,
as usual, but forgot the --compose commandline argument (and "compose=true"
in .git/config doesn't seem to work).
About this patch I wanted to mention a few things:
* This implementation works with the small script at
---
PVE/Storage/DRBDPlugin.pm | 88 ---
1 file changed, 84 insertions(+), 4 deletions(-)
diff --git a/PVE/Storage/DRBDPlugin.pm b/PVE/Storage/DRBDPlugin.pm
index 14f232b..3cc7f0b 100644
--- a/PVE/Storage/DRBDPlugin.pm
+++ b/PVE/Storage/DRBDPlugin.pm
@@
11 matches
Mail list logo
