Re: [pve-devel] [PATCH common v2 1/3] cli: prepare CLIHandler for handling sub-commands

2017-10-12 Thread Thomas Lamprecht
some comments inline, did not yet went over all... On 10/11/2017 06:58 PM, Philip Abernethy wrote: > instead of 5 slightly different calls to RESTHandler::usage_str this > introduces a wrapper function that handles all required cases and is > capable of resolving sub-commands and aliases. > Adds a

Re: [pve-devel] [PATCH common v2 1/3] cli: prepare CLIHandler for handling sub-commands

2017-10-12 Thread Wolfgang Bumiller
some initial comments inline On Wed, Oct 11, 2017 at 06:58:05PM +0200, Philip Abernethy wrote: > instead of 5 slightly different calls to RESTHandler::usage_str this > introduces a wrapper function that handles all required cases and is > capable of resolving sub-commands and aliases. > Adds a sub

[pve-devel] [PATCH common v2 1/3] cli: prepare CLIHandler for handling sub-commands

2017-10-11 Thread Philip Abernethy
instead of 5 slightly different calls to RESTHandler::usage_str this introduces a wrapper function that handles all required cases and is capable of resolving sub-commands and aliases. Adds a subroutine to print the short help for a command in case no subcommand was given. Modifies handle_cmd and p