Re: [pve-devel] [PATCH ha-manager] always queue service stop if node shuts down

2017-05-29 Thread Thomas Lamprecht
On 05/27/2017 08:18 AM, Dietmar Maurer wrote: Pleas can you resend the whole patch? Had already resent it at this time, fyi: https://pve.proxmox.com/pipermail/pve-devel/2017-May/026656.html Without this hunk and Fabians request do differ the log message for a node-reboot freeze or a service-re

Re: [pve-devel] [PATCH ha-manager] always queue service stop if node shuts down

2017-05-26 Thread Dietmar Maurer
Pleas can you resend the whole patch? > This hunk is not needed (but does not affects anything here, as visible > from the regression tests). > Sorry, unclean working directory on commit message re-edit. > ___ pve-devel mailing list pve-devel@pve.pro

Re: [pve-devel] [PATCH ha-manager] always queue service stop if node shuts down

2017-05-26 Thread Thomas Lamprecht
On 05/26/2017 04:49 PM, Fabian Grünbichler wrote: small comment inside On Fri, May 26, 2017 at 03:45:38PM +0200, Thomas Lamprecht wrote: [snip] +if ($shutdown && !$reboot) { + $haenv->log('info', "shutdown LRM, stop all services"); + $self->{mode} = 'shutdown'; } else

Re: [pve-devel] [PATCH ha-manager] always queue service stop if node shuts down

2017-05-26 Thread Fabian Grünbichler
small comment inside On Fri, May 26, 2017 at 03:45:38PM +0200, Thomas Lamprecht wrote: > Commit 61ae38eb6fc5ab351fb61f2323776819e20538b7 which ensured that > services get freezed on a node reboot had a side effect where running > services did not get gracefully shutdown on node reboot. > This may

Re: [pve-devel] [PATCH ha-manager] always queue service stop if node shuts down

2017-05-26 Thread Thomas Lamprecht
On 05/26/2017 03:45 PM, Thomas Lamprecht wrote: [..snip..] diff --git a/src/PVE/HA/NodeStatus.pm b/src/PVE/HA/NodeStatus.pm index b99689c..493298f 100644 --- a/src/PVE/HA/NodeStatus.pm +++ b/src/PVE/HA/NodeStatus.pm @@ -221,8 +221,12 @@ sub fence_node { if ($success) { my $msg = "f

[pve-devel] [PATCH ha-manager] always queue service stop if node shuts down

2017-05-26 Thread Thomas Lamprecht
Commit 61ae38eb6fc5ab351fb61f2323776819e20538b7 which ensured that services get freezed on a node reboot had a side effect where running services did not get gracefully shutdown on node reboot. This may lead to data loss as the services then get hard killed, or they may even prevent a node reboot b