Re: [pve-devel] [PATCH http-server 2/2] Fix #1684 WebSocket proxy behind a buffered proxy.

> On May 25, 2018 at 5:20 PM Thomas Lamprecht wrote: > > > On 5/25/18 3:20 PM, René Jochum wrote: > > The given patch fixes incoming WebSocket traffic behind buffered Proxies > > like Nginx. > > > > This fixes the "blank screen" problem users reported on the forums. >

Re: [pve-devel] [PATCH http-server 2/2] Fix #1684 WebSocket proxy behind a buffered proxy.

Hi Thomas, Thanks for having a look into it. On 05/25/2018 05:20 PM, Thomas Lamprecht wrote: > So, AFAIU, we read more than our calculated payload length and > dropped the remaining data, thus potentially corrupting the next > read. > Further we may get two or more websocket frames in one

Re: [pve-devel] [PATCH http-server 2/2] Fix #1684 WebSocket proxy behind a buffered proxy.

On 5/25/18 3:20 PM, René Jochum wrote: > The given patch fixes incoming WebSocket traffic behind buffered Proxies > like Nginx. > > This fixes the "blank screen" problem users reported on the forums. > > To have a fully working Nginx Reverse Proxy setup its important to > update nginx to 1.14

Re: [pve-devel] [PATCH http-server 2/2] Fix #1684 WebSocket proxy behind a buffered proxy.

Great that you found that bug so fast! The patch contains some white space changes - Please can you send those changes in a separate patch? > - my $payload_len = unpack 'C', substr($hdl->{rbuf}, 1, 1); > + my $payload_len = unpack 'C', substr($hdl->{rbuf}, 1, 1); >

[pve-devel] [PATCH http-server 2/2] Fix #1684 WebSocket proxy behind a buffered proxy.

The given patch fixes incoming WebSocket traffic behind buffered Proxies like Nginx. This fixes the "blank screen" problem users reported on the forums. To have a fully working Nginx Reverse Proxy setup its important to update nginx to 1.14 from the upstream repo. --- PVE/APIServer/AnyEvent.pm